dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
21,047 Commits 2 Branches 0 Tags
727d29d6b6d4324595750411647789d2fd39dbb4
Commit Graph

97 Commits

Author SHA1 Message Date
alanknight@google.com f4e9e4e0fe Add lots of debugging machinery for flaky datetime creation 
R=kustermann@google.com

Review URL: https://codereview.chromium.org//102443007

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31234 260f80e4-7a28-3924-810f-c04153c831b5
 2013-12-18 17:50:22 +00:00
alanknight@google.com e789967b46 Write a README for the Intl package 
BUG=
R=efortuna@google.com

Review URL: https://codereview.chromium.org//113223002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31090 260f80e4-7a28-3924-810f-c04153c831b5
 2013-12-11 23:30:47 +00:00
alanknight@google.com 40f9555247 Add a test for the basic operations on a test that's flaking in a very odd way 
R=floitsch@google.com

Review URL: https://codereview.chromium.org//110573002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@30999 260f80e4-7a28-3924-810f-c04153c831b5
 2013-12-09 21:07:25 +00:00
alanknight@google.com 59768e00a1 Retry date comparison to avoid a rare flake that might be associated with DST 
BUG=
R=floitsch@google.com

Review URL: https://codereview.chromium.org//92333002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@30767 260f80e4-7a28-3924-810f-c04153c831b5
 2013-11-28 19:31:32 +00:00
whesse@google.com 69205c207c Remove uses of Options from pkg, samples, tests, and third_party directories. 
BUG=
R=sgjesse@google.com

Review URL: https://codereview.chromium.org//52573002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29552 260f80e4-7a28-3924-810f-c04153c831b5
 2013-10-30 15:17:01 +00:00
alanknight@google.com 8cb396fafb Mark the intl file-reading tests slow on debug mips 
R=zra@google.com

Review URL: https://codereview.chromium.org//26491005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28529 260f80e4-7a28-3924-810f-c04153c831b5
 2013-10-11 17:10:20 +00:00
alanknight@google.com a0d7a48c5b Support "D" for ordinal date in Intl.DateFormat 
R=efortuna@google.com

Review URL: https://codereview.chromium.org//24156005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27840 260f80e4-7a28-3924-810f-c04153c831b5
 2013-09-24 19:13:26 +00:00
alanknight@google.com 81d3612c8d [ak] Allow getters to return messages 
R=efortuna@google.com

Review URL: https://codereview.chromium.org//24114005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27405 260f80e4-7a28-3924-810f-c04153c831b5
 2013-09-11 21:15:38 +00:00
alanknight@google.com 070791d923 Avoid name collision with reserved word 
R=efortuna@google.com

Review URL: https://codereview.chromium.org//23484033

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27399 260f80e4-7a28-3924-810f-c04153c831b5
 2013-09-11 20:04:05 +00:00
alanknight@google.com 47b25f4236 Fix off-by-one error in computing the quarter in date formatting 
R=efortuna@google.com

Review URL: https://codereview.chromium.org//23494030

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27202 260f80e4-7a28-3924-810f-c04153c831b5
 2013-09-05 17:41:38 +00:00
alanknight@google.com 1e6838f8f4 Re-arrange tests to allow testing generated messages code in dart2js 
R=efortuna@google.com

Review URL: https://codereview.chromium.org//23484010

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26927 260f80e4-7a28-3924-810f-c04153c831b5
 2013-08-30 17:03:39 +00:00
floitsch@google.com 74da0c7286 Remove usage of dart:json. 
R=jmesserly@google.com, lrn@google.com, nweiz@google.com, rnystrom@google.com

Review URL: https://codereview.chromium.org//23596007

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26789 260f80e4-7a28-3924-810f-c04153c831b5
 2013-08-28 14:05:11 +00:00
alanknight@google.com 5a965b5a45 Resume testing message extraction on Windows after dart:io fix 
R=efortuna@google.com

Review URL: https://codereview.chromium.org//23630002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26744 260f80e4-7a28-3924-810f-c04153c831b5
 2013-08-27 20:50:55 +00:00
alanknight@google.com 8da15c52f0 Remove hack for finding package-root in tests, now available in Platform 
R=efortuna@google.com

Review URL: https://codereview.chromium.org//23446002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26721 260f80e4-7a28-3924-810f-c04153c831b5
 2013-08-27 16:55:31 +00:00
alanknight@google.com 7602371022 Verify the locale when initializing dates over http 
BUG=dartbug.com/11093
R=efortuna@google.com

Review URL: https://codereview.chromium.org//23090005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26613 260f80e4-7a28-3924-810f-c04153c831b5
 2013-08-23 21:04:51 +00:00
alanknight@google.com d632beeaa4 Add a null check to avoid trying to load libraries that don't exist. 
R=efortuna@google.com, sigmund@google.com

Review URL: https://codereview.chromium.org//22986014

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26377 260f80e4-7a28-3924-810f-c04153c831b5
 2013-08-20 18:22:42 +00:00
efortuna@google.com 5504f5a970 Fix message_extraction test. 
BUG=

Review URL: https://codereview.chromium.org//22928010

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26103 260f80e4-7a28-3924-810f-c04153c831b5
 2013-08-14 00:45:48 +00:00
alanknight@google.com 31ab754cbf Add support for Intl.select 
Moves some of the validation logic into the appropriate objects, so we can more easily deal with Select, which takes its arguments in a Map, versus Plural/Gender which expect named arguments.

R=efortuna@google.com

Review URL: https://codereview.chromium.org//22286013

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@25965 260f80e4-7a28-3924-810f-c04153c831b5
 2013-08-09 17:08:03 +00:00
kevmoo@j832.com 18d38085ab pkg: analysis aided cleanup 
Removed a lot of warnings and hints when opening many pkg projects in the editor

R=gram@google.com

Review URL: https://codereview.chromium.org//22284003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@25831 260f80e4-7a28-3924-810f-c04153c831b5
 2013-08-06 20:42:04 +00:00
alanknight@google.com 12ee5f7c61 Improvements to warnings on message extraction. 
Add warning for message names that don't match the function name, and
a warnings-are-errors command-line option.

R=efortuna@google.com

Review URL: https://codereview.chromium.org//22392004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@25829 260f80e4-7a28-3924-810f-c04153c831b5
 2013-08-06 20:01:13 +00:00
alanknight@google.com 899a8d27a0 Allow Intl.plural/gender as the top-level, omitting the Intl.message wrapper and the first layer of interpolation. 
R=efortuna@google.com

Review URL: https://codereview.chromium.org//20072002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@25435 260f80e4-7a28-3924-810f-c04153c831b5
 2013-07-24 20:01:59 +00:00
rnystrom@google.com a9d24edd0f Rename "pathos" package to "path". 
R=ajohnsen@google.com

Review URL: https://codereview.chromium.org//18356011

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24964 260f80e4-7a28-3924-810f-c04153c831b5
 2013-07-12 17:54:48 +00:00
alanknight@google.com bea11dee93 Plurals and Genders 
R=efortuna@google.com

Review URL: https://codereview.chromium.org//18543009

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24746 260f80e4-7a28-3924-810f-c04153c831b5
 2013-07-03 20:23:27 +00:00
sgjesse@google.com 887c8e7596 Move getters from Options to Platform 
The getters for executable, script and version are now statics on
Platform. I kept them on Options for now, but updated most tests to
use Platform.

R=ajohnsen@google.com, floitsch@google.com, iposva@google.com
BUG=

Review URL: https://codereview.chromium.org//17406010

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24401 260f80e4-7a28-3924-810f-c04153c831b5
 2013-06-25 12:56:23 +00:00
kustermann@google.com 8356c667db Added async_helper and fixed broken asynchronous test. 
R=ahe@google.com, efortuna@google.com, floitsch@google.com

Review URL: https://codereview.chromium.org//16958006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24339 260f80e4-7a28-3924-810f-c04153c831b5
 2013-06-24 15:47:00 +00:00
alanknight@google.com 0ec6fe103b Allow translated messages that have no matching original message. Also clean up help text and get rid of type error for types whose name is no longer easily visible from analyzer. 
R=efortuna@google.com

Review URL: https://codereview.chromium.org//17113002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24240 260f80e4-7a28-3924-810f-c04153c831b5
 2013-06-20 17:01:13 +00:00
ajohnsen@google.com 06091dd24c Remove (unused) ProcessOptions in test. 
BUG=

Review URL: https://codereview.chromium.org//15670004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@23132 260f80e4-7a28-3924-810f-c04153c831b5
 2013-05-24 11:16:00 +00:00
alanknight@google.com f61dd39e24 Add a dateSymbols getter to DateFormat, useful to get e.g. the list of weekday names 
R=efortuna@google.com

Review URL: https://codereview.chromium.org//14604009

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@22749 260f80e4-7a28-3924-810f-c04153c831b5
 2013-05-15 17:54:43 +00:00
alanknight@google.com a6b47e0fad Fix some doc formatting problems, stop using "set" methods for NumberFormat 
R=amouravski@google.com, sethladd@google.com

Review URL: https://codereview.chromium.org//14544009

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@22148 260f80e4-7a28-3924-810f-c04153c831b5
 2013-04-29 20:32:04 +00:00
alanknight@google.com c9f0368d7d Allow suppressing message extraction warnings, providing a prefix for generated files, and format warnings better. 
Review URL: https://codereview.chromium.org//13898014

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@21959 260f80e4-7a28-3924-810f-c04153c831b5
 2013-04-24 17:03:36 +00:00
alanknight@google.com 0c2102f7e8 Explain better than the en_US locale is always available, fix other doc glitches. 
Review URL: https://codereview.chromium.org//14270009

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@21910 260f80e4-7a28-3924-810f-c04153c831b5
 2013-04-23 22:32:00 +00:00
alanknight@google.com 664fe171c6 Make use of the patterns in Intl number formatting 
This adds code to parse and use the information from the pattern
string used to create a NumberFormat. It adds tests taken
from the Closure tests and also tests comparing a simple
format to the ICU output for a large set of locales.

In addition it has changes to
 - part number_format.dart in intl.dart rather than having it as a
separate library
 - Update the algorithm to incorporate some additions in Closure
 - Allow setting a few of the internal parameters, which the
Closure tests wanted to use
 - Add named constructors for the standard formats, e.g. DECIMAL_FORMAT
 - Access _defaultLocale consistently via the getCurrentLocale() method
rather than directly, so it can never be uninitialized.
 - Regenerated the locale data

Review URL: https://codereview.chromium.org//13814018

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@21166 260f80e4-7a28-3924-810f-c04153c831b5
 2013-04-09 19:58:42 +00:00
kevmoo@j832.com 755c71f1fc pkg/intl test cleanup 
pkg/unittest has evolved a lot. Helping intl use some of the new features and
avoid some problems. I think I fixed some issues in the process

BUG=https://code.google.com/p/dart/issues/detail?id=9342

Review URL: https://codereview.chromium.org//13684003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@20993 260f80e4-7a28-3924-810f-c04153c831b5
 2013-04-05 18:24:14 +00:00
kevmoo@j832.com 1a6983771c pkg/intl: cleanup after message extraction test 
call deleteGeneratedFiles after test
update deleteGeneratedFiles to cover all generated files

Review URL: https://codereview.chromium.org//12827019

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@20391 260f80e4-7a28-3924-810f-c04153c831b5
 2013-03-22 17:13:05 +00:00
alanknight@google.com d98dc62e7d Parameterize the import directories, fix test to behave correctly on an error 
Review URL: https://codereview.chromium.org//12478010

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@20241 260f80e4-7a28-3924-810f-c04153c831b5
 2013-03-19 20:53:26 +00:00
iposva@google.com cdcb3e5b09 - Make test code fail when run from unexpected location. 
Review URL: https://codereview.chromium.org//12787011

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@20122 260f80e4-7a28-3924-810f-c04153c831b5
 2013-03-15 23:14:07 +00:00
lrn@google.com 844cd39fad Change getRange to sublist. Make getRange deprecated. 
This changes the exception behavior of getRange. It used to accept
a length of zero, no matter what start value. Now the start value
must be a valid list index.

Review URL: https://codereview.chromium.org//12817003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@20064 260f80e4-7a28-3924-810f-c04153c831b5
 2013-03-15 09:15:39 +00:00
alanknight@google.com ab0ead6b50 Intl test spawning processes must specify the encoding for stdout 
Review URL: https://codereview.chromium.org//12645010

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@20055 260f80e4-7a28-3924-810f-c04153c831b5
 2013-03-14 22:17:24 +00:00
alanknight@google.com afc98385b5 Fix windows and pub failures in intl tests 
Review URL: https://codereview.chromium.org//12448008

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@20049 260f80e4-7a28-3924-810f-c04153c831b5
 2013-03-14 21:36:18 +00:00
alanknight@google.com 0446767578 Adds facilities for extracting Intl.message calls and generating code from translations 
This adds both general libraries for extracting messages and generating translations and scripts for using them with a trivial translation format. It removes the previous mechanism in message_lookup_local that relied on mirrors and traversing libraries in favor of one with a more explicit lookup by library that's consistent with the generated code. It also changes the code in basic_example to use that.

It also includes a couple of other changes. It now uses pathos for path manipulation, and the data_directory.dart hack for running tests from multiple different places was cleaned up and made more general. In addition, Intl.message now returns a string rather than a Future, which was changed as part of the libv2 integration.

This version does not yet support the plural syntax, as it disallows any interpolations that aren't just replacing a variable name. It also doesn't support named arguments to functions containing Intl.message, and it doesn't yet have a mechanism for designating sections of a text as not being subject to translation.

Finally, it relies on analyzer-experimental, which has a different name in the repository and in pub. So this version will run in the repository but will not run if used from pub. Bug 9071 asks for the names to be made consistent.

Review URL: https://codereview.chromium.org//12733003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@20047 260f80e4-7a28-3924-810f-c04153c831b5
 2013-03-14 20:49:26 +00:00
kustermann@google.com d2c575c0b0 Create generated tests inside the build directory 
Patch Set 1 is a revert of r18295.

Review URL: https://codereview.chromium.org//12223074

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@18802 260f80e4-7a28-3924-810f-c04153c831b5
 2013-02-21 08:10:37 +00:00
lrn@google.com 9b23dff467 Reapply "Rename mappedBy to map." 
This reverts commit r17907.

TBR.

Review URL: https://codereview.chromium.org//12090093

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@17918 260f80e4-7a28-3924-810f-c04153c831b5
 2013-01-31 15:12:56 +00:00
floitsch@google.com b1a118d5ce Revert "Rename mappedBy to map." 
This reverts commit 17899.

Review URL: https://codereview.chromium.org//12087103

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@17907 260f80e4-7a28-3924-810f-c04153c831b5
 2013-01-31 14:02:27 +00:00
lrn@google.com 0dc2f4b1ba Rename mappedBy to map. 
Retain a deprecated mappedBy for now.
Change return type of mappedBy, skip and take on List to Iterable.

BUG= http://dartbug.com/8063
BUG= http://dartbug.com/8064
BUG= http://dartbug.com/6739
BUG= http://dartbug.com/7982

Review URL: https://codereview.chromium.org//12086062

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@17899 260f80e4-7a28-3924-810f-c04153c831b5
 2013-01-31 12:37:13 +00:00
alanknight@google.com 76bce685bb Remove the code that attempts to find a locale from the command line VM in Windows. 
Review URL: https://codereview.chromium.org//12038073

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@17674 260f80e4-7a28-3924-810f-c04153c831b5
 2013-01-25 23:56:02 +00:00
alanknight@google.com e17f6ef909 Make standalone (non-browser) locale detection for windows also accept short locale names 
Review URL: https://codereview.chromium.org//11953069

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@17588 260f80e4-7a28-3924-810f-c04153c831b5
 2013-01-24 18:51:50 +00:00
floitsch@google.com fb7b9e3c5c Rename Date to DateTime. 
BUG=http://dartbug.com/1424

Review URL: https://codereview.chromium.org//11770004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@17549 260f80e4-7a28-3924-810f-c04153c831b5
 2013-01-24 12:16:37 +00:00
alanknight@google.com 27541ed0fb Fix tests to accept short locale names as long as long ones, properly this time. 
Review URL: https://codereview.chromium.org//11895005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@17091 260f80e4-7a28-3924-810f-c04153c831b5
 2013-01-15 20:47:45 +00:00
alanknight@google.com 7a42378b21 [ak] Fix tests to accept short locale names as well as long ones 
BUG=

Review URL: https://codereview.chromium.org//11878030

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@17090 260f80e4-7a28-3924-810f-c04153c831b5
 2013-01-15 20:39:22 +00:00
efortuna@google.com 4622dc3e76 Make browser tests all run from a server instead of the local filesystem. 
BUG=

Review URL: https://codereview.chromium.org//11810004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@17007 260f80e4-7a28-3924-810f-c04153c831b5
 2013-01-13 01:11:07 +00:00