Commit Graph

178 Commits

Author SHA1 Message Date
alanknight@google.com f4e9e4e0fe Add lots of debugging machinery for flaky datetime creation
R=kustermann@google.com

Review URL: https://codereview.chromium.org//102443007

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31234 260f80e4-7a28-3924-810f-c04153c831b5
2013-12-18 17:50:22 +00:00
alanknight@google.com e789967b46 Write a README for the Intl package
BUG=
R=efortuna@google.com

Review URL: https://codereview.chromium.org//113223002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31090 260f80e4-7a28-3924-810f-c04153c831b5
2013-12-11 23:30:47 +00:00
scheglov@google.com 965c254725 New analyzer snapshot.
1. Fixes for converting properties for fields:
  1.1. Only if neither getter not setter are overridden. Note that we ignore the fact that it _might_ be overridden in some subclass that we don't see.
       Without this assumption almost nothing can be a field.
  2.2. Create final fields when possible.
2. Generate field formal parameters where possible.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//109853003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31043 260f80e4-7a28-3924-810f-c04153c831b5
2013-12-10 21:39:47 +00:00
nweiz@google.com 113bd79bc6 Make pkg/path 1.0.0 and upgrade dependencies appropriately.
All existing packages that use pkg/path (other than pkg/stack_trace,
which has already been updated) are compatible with both the pre-1.0
and post-1.0 path API, so I've marked their version constraints as
">=0.9.0 <2.0.0". I've also incremented their patch versions and I
intend to release new versions as soon as this CL lands.

R=alanknight@google.com, efortuna@google.com, jmesserly@google.com, rnystrom@google.com, scheglov@google.com

Review URL: https://codereview.chromium.org//110873002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31005 260f80e4-7a28-3924-810f-c04153c831b5
2013-12-10 00:24:01 +00:00
alanknight@google.com 40f9555247 Add a test for the basic operations on a test that's flaking in a very odd way
R=floitsch@google.com

Review URL: https://codereview.chromium.org//110573002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@30999 260f80e4-7a28-3924-810f-c04153c831b5
2013-12-09 21:07:25 +00:00
alanknight@google.com 59768e00a1 Retry date comparison to avoid a rare flake that might be associated with DST
BUG=
R=floitsch@google.com

Review URL: https://codereview.chromium.org//92333002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@30767 260f80e4-7a28-3924-810f-c04153c831b5
2013-11-28 19:31:32 +00:00
dgrove@google.com 18ca7d0036 Re-land r29957 (add versions and constraints for packages and samples), with
SDK constraints bumped from 1.0.0 to 0.8.10+6 .

R=ricow@google.com, sigmund@google.com

Review URL: https://codereview.chromium.org//62473002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29986 260f80e4-7a28-3924-810f-c04153c831b5
2013-11-06 18:28:22 +00:00
ajohnsen@google.com 61f6c51990 Revert "add versions and constraints for packages and samples"
This is currently blocking us from testing samples.

BUG=
R=kasperl@google.com

Review URL: https://codereview.chromium.org//59513007

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29960 260f80e4-7a28-3924-810f-c04153c831b5
2013-11-06 09:09:18 +00:00
jmesserly@google.com 02638c5760 add versions and constraints for packages and samples
- all packages at 0.9.0, except "analyzer" which had a version already
- dependencies at ">=0.9.0 <0.10.0" except analyzer is ">=0.10.0 <0.11.0"
- sdk constraint ">=1.0.0 <2.0.0"

R=sigmund@google.com

Review URL: https://codereview.chromium.org//59763006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29957 260f80e4-7a28-3924-810f-c04153c831b5
2013-11-06 03:27:58 +00:00
whesse@google.com 69205c207c Remove uses of Options from pkg, samples, tests, and third_party directories.
BUG=
R=sgjesse@google.com

Review URL: https://codereview.chromium.org//52573002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29552 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-30 15:17:01 +00:00
lrn@google.com f0a1c922a2 Reapply "Remove @deprecated features."
R=scheglov@google.com, sgjesse@google.com

Review URL: https://codereview.chromium.org//50413005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29535 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-30 12:09:15 +00:00
lrn@google.com 7a76ad7834 Add @proxy to annotations.dart.
Remove package:meta

R=bak@google.com, brianwilkerson@google.com

Review URL: https://codereview.chromium.org//46593003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29525 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-30 10:25:08 +00:00
lrn@google.com 57efa5da8c Revert "Remove @deprecated features."
There were more uses of the deprecated features.

Review URL: https://codereview.chromium.org//50313004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29443 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-29 12:54:37 +00:00
lrn@google.com 72e1d263dc Remove @deprecated features.
R=alanknight@google.com, rnystrom@google.com, sgjesse@google.com

Review URL: https://codereview.chromium.org//48293002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29438 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-29 12:00:44 +00:00
scheglov@google.com 7ac0b7d0bd Rename analyzer_experimental to analyzer.
R=jmesserly@google.com, pquitslund@google.com, danrubel@google.com
BUG=

Review URL: https://codereview.chromium.org//45573002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29302 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-25 23:59:38 +00:00
scheglov@google.com f50bafb140 Attempt to fix build.
I have to restore CompilationUnit.lineInfo, because it is used by clients.
Also added tweak to avoid using internal NodeList.elements, which was changed.

TBR

R=brianwilkerson@google.com,alanknight@google.com,iposva@google.com
BUG=

Review URL: https://codereview.chromium.org//28193004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28842 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-18 06:07:21 +00:00
lrn@google.com 8922b1065c Add EfficientLength marker interface to some iterabels.
Use that in List.from and other methods to be more efficient when possible.

R=floitsch@google.com

Review URL: https://codereview.chromium.org//26681002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28575 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-14 10:40:00 +00:00
alanknight@google.com 8cb396fafb Mark the intl file-reading tests slow on debug mips
R=zra@google.com

Review URL: https://codereview.chromium.org//26491005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28529 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-11 17:10:20 +00:00
alanknight@google.com a0d7a48c5b Support "D" for ordinal date in Intl.DateFormat
R=efortuna@google.com

Review URL: https://codereview.chromium.org//24156005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27840 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-24 19:13:26 +00:00
alanknight@google.com 43c713c022 Handle reading upper-case placeholders
R=efortuna@google.com

Review URL: https://codereview.chromium.org//23934007

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27437 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-12 17:08:52 +00:00
alanknight@google.com 81d3612c8d [ak] Allow getters to return messages
R=efortuna@google.com

Review URL: https://codereview.chromium.org//24114005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27405 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-11 21:15:38 +00:00
kevmoo@j832.com b868d8fc56 Added deprecation notice to BidiFormatter.htmlEscape
BUG= https://code.google.com/p/dart/issues/detail?id=13097
R=alanknight@google.com

Review URL: https://codereview.chromium.org//23464039

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27401 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-11 20:20:37 +00:00
alanknight@google.com 070791d923 Avoid name collision with reserved word
R=efortuna@google.com

Review URL: https://codereview.chromium.org//23484033

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27399 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-11 20:04:05 +00:00
kevmoo@j832.com 85e045313e adding HtmlEscape to dart:convert
BUG=https://code.google.com/p/dart/issues/detail?id=1657
R=blois@google.com, floitsch@google.com, rnystrom@google.com

Review URL: https://codereview.chromium.org//23492002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27211 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-05 20:30:56 +00:00
alanknight@google.com 47b25f4236 Fix off-by-one error in computing the quarter in date formatting
R=efortuna@google.com

Review URL: https://codereview.chromium.org//23494030

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27202 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-05 17:41:38 +00:00
alanknight@google.com e0234b8da6 Allow creating VariableSubstitution by name or by index
R=efortuna@google.com

Review URL: https://codereview.chromium.org//23449021

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27077 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-03 21:46:41 +00:00
alanknight@google.com 1e6838f8f4 Re-arrange tests to allow testing generated messages code in dart2js
R=efortuna@google.com

Review URL: https://codereview.chromium.org//23484010

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26927 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-30 17:03:39 +00:00
alanknight@google.com a74007e83b Documents the exception on DateFormat.parse
R=efortuna@google.com

Review URL: https://codereview.chromium.org//23623011

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26894 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-29 22:28:13 +00:00
alanknight@google.com c2d9d8cd2e Disable Intl deferred loading until it works in dart2js
R=efortuna@google.com

Review URL: https://codereview.chromium.org//23598003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26803 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-28 17:33:10 +00:00
floitsch@google.com 74da0c7286 Remove usage of dart:json.
R=jmesserly@google.com, lrn@google.com, nweiz@google.com, rnystrom@google.com

Review URL: https://codereview.chromium.org//23596007

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26789 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-28 14:05:11 +00:00
alanknight@google.com 5a965b5a45 Resume testing message extraction on Windows after dart:io fix
R=efortuna@google.com

Review URL: https://codereview.chromium.org//23630002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26744 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-27 20:50:55 +00:00
alanknight@google.com 8da15c52f0 Remove hack for finding package-root in tests, now available in Platform
R=efortuna@google.com

Review URL: https://codereview.chromium.org//23446002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26721 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-27 16:55:31 +00:00
alanknight@google.com 7602371022 Verify the locale when initializing dates over http
BUG=dartbug.com/11093
R=efortuna@google.com

Review URL: https://codereview.chromium.org//23090005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26613 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-23 21:04:51 +00:00
alanknight@google.com 551f37ed99 Put the @lazy directive on a separate line from the import to avoid confusing naive parsers (e.g. dwc)
R=sigmund@google.com

Review URL: https://codereview.chromium.org//22793016

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26559 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-22 21:46:54 +00:00
alanknight@google.com 5038d3b5e7 Make defaultLocale public
R=efortuna@google.com

Review URL: https://codereview.chromium.org//23033028

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26557 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-22 21:35:40 +00:00
alanknight@google.com f95ea62a8a Simplify the generated code for a message.
R=efortuna@google.com

Review URL: https://codereview.chromium.org//23060025

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26548 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-22 19:23:35 +00:00
alanknight@google.com d632beeaa4 Add a null check to avoid trying to load libraries that don't exist.
R=efortuna@google.com, sigmund@google.com

Review URL: https://codereview.chromium.org//22986014

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26377 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-20 18:22:42 +00:00
alanknight@google.com 3d80dba138 If you have something that recursively looks for messages in dependencies, it can end up parsing intl.dart and giving warnings that there are invalid messages in its internals. Change the calls to invoke the static messages without a prefix so that this won't complain.
R=efortuna@google.com

Review URL: https://codereview.chromium.org//23241004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26233 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-15 22:27:48 +00:00
alanknight@google.com b136efff1c Use deferred loading for message libraries.
R=efortuna@google.com

Review URL: https://codereview.chromium.org//22828006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26199 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-15 16:50:41 +00:00
alanknight@google.com e8dd115eb6 Relax verification checks. The locale doesn't have to be constant, print
the node in the error message without making assumptions about its
type, and do not require the name parameter to match the function name.

R=efortuna@google.com

Review URL: https://codereview.chromium.org//23212003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26154 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-14 21:06:54 +00:00
efortuna@google.com 5504f5a970 Fix message_extraction test.
BUG=

Review URL: https://codereview.chromium.org//22928010

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26103 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-14 00:45:48 +00:00
efortuna@google.com 6970ef4c98 Rename CompositeMessage's named parent constructor.
BUG=
R=alanknight@google.com

Review URL: https://codereview.chromium.org//23140003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26101 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-14 00:33:14 +00:00
alanknight@google.com 9f565af534 Workaround for bug 11834 with Chrome XHR
R=efortuna@google.com

Review URL: https://codereview.chromium.org//22877005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26028 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-12 20:33:04 +00:00
alanknight@google.com 31ab754cbf Add support for Intl.select
Moves some of the validation logic into the appropriate objects, so we can more easily deal with Select, which takes its arguments in a Map, versus Plural/Gender which expect named arguments.

R=efortuna@google.com

Review URL: https://codereview.chromium.org//22286013

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@25965 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-09 17:08:03 +00:00
kevmoo@j832.com 18d38085ab pkg: analysis aided cleanup
Removed a lot of warnings and hints when opening many pkg projects in the editor

R=gram@google.com

Review URL: https://codereview.chromium.org//22284003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@25831 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-06 20:42:04 +00:00
alanknight@google.com 12ee5f7c61 Improvements to warnings on message extraction.
Add warning for message names that don't match the function name, and
a warnings-are-errors command-line option.

R=efortuna@google.com

Review URL: https://codereview.chromium.org//22392004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@25829 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-06 20:01:13 +00:00
alanknight@google.com 899a8d27a0 Allow Intl.plural/gender as the top-level, omitting the Intl.message wrapper and the first layer of interpolation.
R=efortuna@google.com

Review URL: https://codereview.chromium.org//20072002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@25435 260f80e4-7a28-3924-810f-c04153c831b5
2013-07-24 20:01:59 +00:00
alanknight@google.com 816b24e8ff Make _shortLocale public
R=efortuna@google.com

Review URL: https://codereview.chromium.org//20071003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@25423 260f80e4-7a28-3924-810f-c04153c831b5
2013-07-24 17:12:54 +00:00
rnystrom@google.com a9d24edd0f Rename "pathos" package to "path".
R=ajohnsen@google.com

Review URL: https://codereview.chromium.org//18356011

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24964 260f80e4-7a28-3924-810f-c04153c831b5
2013-07-12 17:54:48 +00:00
alanknight@google.com bea11dee93 Plurals and Genders
R=efortuna@google.com

Review URL: https://codereview.chromium.org//18543009

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24746 260f80e4-7a28-3924-810f-c04153c831b5
2013-07-03 20:23:27 +00:00