dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
21,047 Commits 2 Branches 0 Tags
727d29d6b6d4324595750411647789d2fd39dbb4
Commit Graph

57 Commits

Author SHA1 Message Date
jmesserly@google.com de84d672c5 custom_element: bump pubspec version to publish fix 
Review URL: https://codereview.chromium.org//102993015

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31308 260f80e4-7a28-3924-810f-c04153c831b5
 2013-12-19 23:28:46 +00:00
jmesserly@google.com 20b120eba2 Fix for dart2js mirrors caching with custom elements 
Custom elements code is from https://github.com/dart-lang/CustomElements/pull/4

R=sigmund@google.com

Review URL: https://codereview.chromium.org//112613003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31296 260f80e4-7a28-3924-810f-c04153c831b5
 2013-12-19 19:55:57 +00:00
jmesserly@google.com a526b4ed3a update our CustomElement+Shadow DOM patch 
https://github.com/dart-lang/CustomElements/pull/3
fixes https://code.google.com/p/dart/issues/detail?id=15354

R=blois@google.com

Review URL: https://codereview.chromium.org//112433002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31078 260f80e4-7a28-3924-810f-c04153c831b5
 2013-12-11 20:31:26 +00:00
jmesserly@google.com 0e67af7d01 add LICENSE AUTHORS PATENTS so we can publish 
R=sigmund@google.com

Review URL: https://codereview.chromium.org//105693012

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31055 260f80e4-7a28-3924-810f-c04153c831b5
 2013-12-11 01:56:04 +00:00
jmesserly@google.com 66491b1f5c update pubspecs for pkg uploading 
R=sigmund@google.com

Review URL: https://codereview.chromium.org//112283002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31053 260f80e4-7a28-3924-810f-c04153c831b5
 2013-12-11 01:41:02 +00:00
jmesserly@google.com 3c7bece94a restore 30868 and 30873 
the only difference from what you already reviewed is the inclusion of:
https://github.com/dart-lang/CustomElements/pull/2

A shame your pull request from 3 months(!) ago hasn't been accepted

(reverts 30875)

R=blois@google.com

Review URL: https://codereview.chromium.org//105783003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@30967 260f80e4-7a28-3924-810f-c04153c831b5
 2013-12-06 20:51:20 +00:00
jmesserly@google.com e5b35ae519 Reverting 30868 and 30873. 
There's still a problem in document_register_type_extensions_test that isn't obvious. Need more time to investigate.

Review URL: https://codereview.chromium.org//105203006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@30875 260f80e4-7a28-3924-810f-c04153c831b5
 2013-12-04 22:51:54 +00:00
jmesserly@google.com 84c98a2902 update TemplateBinding to 119bbab376aa4a8ee96a5354e3ebe84395d1da62 
* fixes an issue where not having a sub-template results in incorrect custom element upgrade.

update custom elements to 93a27b791d4bfdddad3be17fccda3c5052bf4a16
* needed to work with the latest TemplateBinding (specifically the importNode fix)

Note that custom elements code is from: https://github.com/dart-lang/CustomElements/pull/1

R=blois@google.com

Review URL: https://codereview.chromium.org//98533004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@30868 260f80e4-7a28-3924-810f-c04153c831b5
 2013-12-04 20:59:56 +00:00
dgrove@google.com 18ca7d0036 Re-land r29957 (add versions and constraints for packages and samples), with 
SDK constraints bumped from 1.0.0 to 0.8.10+6 .

R=ricow@google.com, sigmund@google.com

Review URL: https://codereview.chromium.org//62473002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29986 260f80e4-7a28-3924-810f-c04153c831b5
 2013-11-06 18:28:22 +00:00
ajohnsen@google.com 61f6c51990 Revert "add versions and constraints for packages and samples" 
This is currently blocking us from testing samples.

BUG=
R=kasperl@google.com

Review URL: https://codereview.chromium.org//59513007

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29960 260f80e4-7a28-3924-810f-c04153c831b5
 2013-11-06 09:09:18 +00:00
jmesserly@google.com 02638c5760 add versions and constraints for packages and samples 
- all packages at 0.9.0, except "analyzer" which had a version already
- dependencies at ">=0.9.0 <0.10.0" except analyzer is ">=0.10.0 <0.11.0"
- sdk constraint ">=1.0.0 <2.0.0"

R=sigmund@google.com

Review URL: https://codereview.chromium.org//59763006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29957 260f80e4-7a28-3924-810f-c04153c831b5
 2013-11-06 03:27:58 +00:00
sigmund@google.com aaf8927792 Fixes in custom_element.dart: some of the code was broken, fixes needed for 
those using web-ui

(patch follows from issue 53293003)

R=jmesserly@google.com

Review URL: https://codereview.chromium.org//48713012

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29860 260f80e4-7a28-3924-810f-c04153c831b5
 2013-11-04 23:47:48 +00:00
lrn@google.com 7a76ad7834 Add @proxy to annotations.dart. 
Remove package:meta

R=bak@google.com, brianwilkerson@google.com

Review URL: https://codereview.chromium.org//46593003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29525 260f80e4-7a28-3924-810f-c04153c831b5
 2013-10-30 10:25:08 +00:00
kustermann@google.com 94ebff2225 Bugfix in test.dart, adding of specialized test outcomes for analyzer 
This CL will:
 - fix a bug in the legacy AnalyzerCommandOutputImpl class (in certain cases
   we did not report that the analyzer was missing a warning).
 - make the outcome of running the analyzer on a test be one of:
   * CompileTimeError
   * MissingCompileTimeError
   * StaticWarning
   * MissingStaticWarning
 - Make status file updates using the new Expectation markers
 - Remove support for '@static-clean':
     Previously running the analyer on a test could either result in
     'Pass' or in 'Fail'. The '@static-clean' annotation has been used
     as a (poor) mechanism to distinguish between errors and warnings.
     Having the 4 markers mentioned above means we can remove '@static-clean'
 - Remove 100 lines of rotted legacy code in our testing scripts.
 - Make a status file entry for every test that has analyzer errors or warnings

R=ricow@google.com

Review URL: https://codereview.chromium.org//46163002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29350 260f80e4-7a28-3924-810f-c04153c831b5
 2013-10-28 10:39:38 +00:00
jmesserly@google.com 34085ccdb5 port Node.bind to bd0a0591920da9091b326627a46a104a92c7efe7 
the first step to fix https://code.google.com/p/dart/issues/detail?id=13950

R=sigmund@google.com

Review URL: https://codereview.chromium.org//42433002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29294 260f80e4-7a28-3924-810f-c04153c831b5
 2013-10-25 21:39:06 +00:00
blois@google.com 0e97c7197a Integrating fix for IE9 custom elements upgrade 
BUG=13193
R=jmesserly@google.com

Review URL: https://codereview.chromium.org//41083002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29197 260f80e4-7a28-3924-810f-c04153c831b5
 2013-10-24 19:21:46 +00:00
jmesserly@google.com 0acc931fc4 port polymer data binding tests 
R=sigmund@google.com

Review URL: https://codereview.chromium.org//25740006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29139 260f80e4-7a28-3924-810f-c04153c831b5
 2013-10-24 00:59:31 +00:00
jmesserly@google.com 4194748695 remove old custom_element polyfill 
just some cleanup. this was the stopgap xtag polyfill for Polymer; we never used it in web_ui to my knowledge. it's obsolete with document.register

R=blois@google.com

Review URL: https://codereview.chromium.org//36373004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29116 260f80e4-7a28-3924-810f-c04153c831b5
 2013-10-23 20:21:07 +00:00
jmesserly@google.com 04c0d63166 fix build due to mdv -> template_binding rename 
BUG=

Review URL: https://codereview.chromium.org//35683006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29058 260f80e4-7a28-3924-810f-c04153c831b5
 2013-10-23 02:25:05 +00:00
sigmund@google.com 996f42cf7a Fixes needed for the deploy step. 
R=jmesserly@google.com

Review URL: https://codereview.chromium.org//34623011

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29053 260f80e4-7a28-3924-810f-c04153c831b5
 2013-10-23 01:04:09 +00:00
blois@google.com 95d32c5c6b Closing register/upgrade timing hole primarily impacting IE 
See Polymer issue https://github.com/Polymer/CustomElements/issues/76

BUG=
R=jmesserly@google.com

Review URL: https://codereview.chromium.org//36303003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29052 260f80e4-7a28-3924-810f-c04153c831b5
 2013-10-23 00:47:12 +00:00
jmesserly@google.com 821e6fec2a Several fixes here to fix bugs and get our tests into a reliable state: 
* customElementsReady future. We don't fire Polymer.onReady until custom elements are ready too

* deploy without dart.js by default. This is the expected deployment mode for real apps. Also make sure we test this on DRT and compiler==js, so Pete can change Dartium without causing build breaks :)

* stop using "package:observe" test "performMicrotaskCheckpoint" hack in Polymer. This was too blunt; it affected timing of all async operations. Instead we only trigger Observable.dirtyCheck. It's using the latest Zone API as well.

* mixin ChangeNotifier explicitly. This is mainly to fix a quirk of our test environment (test server loads "packages/polymer" in untransformed mode, causing it to pick up Observable instead of ChangeNotifier).

* fix change watchers to blacklist "attributeChanged" :)

* fix serializeValue to only use the runtime value

* fix deserializeValue to get the right Type for dart:core types

* cleanup prop_attr_reflection_test to use mutation observer

R=blois@google.com, sigmund@google.com

Review URL: https://codereview.chromium.org//29823005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28956 260f80e4-7a28-3924-810f-c04153c831b5
 2013-10-21 21:49:51 +00:00
floitsch@google.com 0f7a0bd7b1 Rename runAsync to scheduleMicrotask. 
R=lrn@google.com

Review URL: https://codereview.chromium.org//26151002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28569 260f80e4-7a28-3924-810f-c04153c831b5
 2013-10-12 15:52:17 +00:00
blois@google.com 1426a55a47 Adding platform patches to allow custom elements polyfill to work with Shadow DOM. 
The specific issue was that elements existing in the page before the tag was registered was causing issues. This is encountered with the <polymer-element> tag.
BUG=
R=jmesserly@google.com

Review URL: https://codereview.chromium.org//26558008

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28434 260f80e4-7a28-3924-810f-c04153c831b5
 2013-10-10 00:30:08 +00:00
efortuna@google.com eaa854b258 Move Rectangle and Point into dart:math. 
BUG=
R=floitsch@google.com

Review URL: https://codereview.chromium.org//25808002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28272 260f80e4-7a28-3924-810f-c04153c831b5
 2013-10-04 17:47:39 +00:00
blois@google.com 05bb03642d Implementing CustomElement's attributeChanged callback in dart2js. 
BUG=
R=jmesserly@google.com

Review URL: https://codereview.chromium.org//25325004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28168 260f80e4-7a28-3924-810f-c04153c831b5
 2013-10-02 15:57:56 +00:00
jmesserly@google.com cf3dcfba4c Port Polymer.js Core, the github.com/polymer/polymer code. 
Ports all features except where JS interop is blocking us (declaration/path.js and instance/style.js). In particular, this has:
  //   src/declaration/attributes.js
  //   src/declaration/events.js
  //   src/declaration/polymer-element.js
  //   src/declaration/properties.js
  //   src/declaration/prototype.js
  //   src/declaration/styles.js
  //   src/instance/attributes.js
  //   src/instance/base.js
  //   src/instance/events.js
  //   src/instance/mdv.js
  //   src/instance/properties.js
  //   src/instance/utils.js
  //   src/lib/deserialize.js
  //   src/lib/job.js
  //   src/lib/dom.js -- not needed in Dart
  //   src/lib/lang.js -- not needed in Dart
  //   src/lib/super.js -- not needed in Dart

There's also a big architectural change: polymer-element data is now stored in the PolymerDeclaration class, which is separate from PolymerElement. This allows us to avoid duplicate work on every constructor, and should significantly speed up instance creation.

All code is from the same revision:
https://github.com/Polymer/polymer/blob/4dc481c11505991a7c43228d3797d28f21267779

The remaining unported files are for relatively minor features. "declaration/path.js" is for asset URL resolution, and we might have a Pub-based solution instead. "instance/style.js" has an opt-in, advanced style polyfill. It needs "ShadowCSS.shimPolyfillDirectives", and probably isn't too hard to make work in a follow up change.

Other changes:
* attributeChanged lifecycle method is implemented.
* ObservableAnnotation is public so Polymer's @published can subclass it
* bindProperty renamed to onPropertyChange to avoid conflict with Polymer member of the same name.
* polymer/lib/boot.js preload's polymer-element and link[rel=stylesheet]

R=blois@google.com

Review URL: https://codereview.chromium.org//24149003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28134 260f80e4-7a28-3924-810f-c04153c831b5
 2013-10-01 23:45:37 +00:00
blois@google.com 1aa8a7be0e Adding Element.created constructor and .created constructors to all subclasses. Also ensuring generative constructor for all superclasses. 
This is for post-construction custom element creation.

Element.created is public, then the base classes of that get private ._created constructors.

BUG=
R=vsm@google.com

Review URL: https://codereview.chromium.org//24653006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28120 260f80e4-7a28-3924-810f-c04153c831b5
 2013-10-01 21:26:06 +00:00
blois@google.com b5bc0e1367 - Fixing analyzer error on legacy custom element polyfill 
- Adjsuting IE status (filed bug to investigate)
 - Fixing polymer tests on Dartium

BUG=
R=jmesserly@google.com

Review URL: https://codereview.chromium.org//24168006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27846 260f80e4-7a28-3924-810f-c04153c831b5
 2013-09-24 20:11:36 +00:00
blois@google.com 209e413a5c Retry of custom element lifecycle events. 
First patch is the original, changes were:
 - Shadow DOM upgrade landed as separate CL
 - CustomElement polyfill wasn't always firing WebComponentsLoaded event (causing timeouts on FF and IE), fixed polyfill.
 - Dartium test exclusions were not working

BUG=
R=jmesserly@google.com

Review URL: https://codereview.chromium.org//23498053

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27841 260f80e4-7a28-3924-810f-c04153c831b5
 2013-09-24 19:14:16 +00:00
blois@google.com 6def065afd Revert "Dart2js support for custom element lifecycle events" 
This reverts commit 27729. Shadow DOM polyfill appears to have regressed some tests and some issues are coming up with the browser controller.

BUG=
R=jmesserly@google.com

Review URL: https://codereview.chromium.org//24251016

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27730 260f80e4-7a28-3924-810f-c04153c831b5
 2013-09-21 00:46:48 +00:00
blois@google.com fb8f32bcc4 Dart2js support for custom element lifecycle events 
BUG=
R=jmesserly@google.com

Review URL: https://codereview.chromium.org//24096027

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27729 260f80e4-7a28-3924-810f-c04153c831b5
 2013-09-20 23:49:12 +00:00
blois@google.com 2ed732dac4 Updating custom elements polyfill to the latest github.com/dart-lang version. 
This is just updating the SVN repo to the compiled versions of: https://codereview.appspot.com/13669045/

TBR
BUG=
R=jmesserly@google.com

Review URL: https://codereview.chromium.org//23531051

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27502 260f80e4-7a28-3924-810f-c04153c831b5
 2013-09-13 20:53:53 +00:00
kathyw@google.com ef3f516570 one-liners for a few polymer-related libraries 
R=jmesserly@google.com, mcampione@google.com

Review URL: https://codereview.chromium.org//23441054

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27500 260f80e4-7a28-3924-810f-c04153c831b5
 2013-09-13 20:25:19 +00:00
blois@google.com ceb213a24d Updating custom element test to only load polyfill when needed. 
Also switching to a script element with a src, which I've found improves debuggability with some browsers.

BUG=13231
R=jmesserly@google.com

Review URL: https://codereview.chromium.org//23647014

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27456 260f80e4-7a28-3924-810f-c04153c831b5
 2013-09-12 22:24:15 +00:00
blois@google.com b904bf81ba Revert "Revert "Tag extensions"" 
Original CL is the first patch, changes follow. Includes fixes for Chrome test failures and Firefox type check issues.

BUG=
R=jmesserly@google.com

Review URL: https://codereview.chromium.org//23442011

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27313 260f80e4-7a28-3924-810f-c04153c831b5
 2013-09-09 22:03:43 +00:00
efortuna@google.com b0e059159f Adjust CustomElement as properties again. 
BUG=
R=blois@google.com

Review URL: https://codereview.chromium.org//23969002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27146 260f80e4-7a28-3924-810f-c04153c831b5
 2013-09-04 20:11:11 +00:00
blois@google.com 6570db562c Revert "Basic functionality is working with JS native support and polyfill, still some issues with dart2js typechecking." 
This reverts commit r26935. Failing in FF checked on type extension and IE9 on synchronous constructor upgrading, need to investigate.

TBR
BUG=

Review URL: https://codereview.chromium.org//23567006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26938 260f80e4-7a28-3924-810f-c04153c831b5
 2013-08-30 19:37:23 +00:00
blois@google.com 5607d75eca Basic functionality is working with JS native support and polyfill, still some issues with dart2js typechecking. 
BUG=
R=jmesserly@google.com

Review URL: https://codereview.chromium.org//23190026

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26935 260f80e4-7a28-3924-810f-c04153c831b5
 2013-08-30 19:08:19 +00:00
efortuna@google.com ea773ef953 Update CustomElement as well. 
BUG=

Review URL: https://codereview.chromium.org//23819006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26931 260f80e4-7a28-3924-810f-c04153c831b5
 2013-08-30 17:41:30 +00:00
blois@google.com 93c361dd36 This is an updated version of https://codereview.chromium.org/16374007/ 
Original submission is the first patch, fixes are the second.

There were two issues with the original-
  - Issue with URI sanitization where relative URIs on IE were being dropped.
  - Analyzer issue on missing members for CustomElement.

BUG=
R=jmesserly@google.com

Review URL: https://codereview.chromium.org//23525003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26757 260f80e4-7a28-3924-810f-c04153c831b5
 2013-08-28 01:03:01 +00:00
blois@google.com 24e9f22c90 Revert "First rev of Safe DOM" 
This reverts commit 26681.

Some IE issues with URL validation that I need to investigate further.

BUG=

Review URL: https://codereview.chromium.org//23523002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26682 260f80e4-7a28-3924-810f-c04153c831b5
 2013-08-27 02:18:48 +00:00
blois@google.com 63ecf1a3fd First rev of Safe DOM 
BUG=
R=jacobr@google.com, jmesserly@google.com

Review URL: https://codereview.chromium.org//16374007

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26681 260f80e4-7a28-3924-810f-c04153c831b5
 2013-08-27 01:48:13 +00:00
efortuna@google.com 92d2bd8c28 Fix api for dart2js tests that failed. 
BUG=

Review URL: https://codereview.chromium.org//23060041

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26606 260f80e4-7a28-3924-810f-c04153c831b5
 2013-08-23 19:15:33 +00:00
efortuna@google.com 90873051ad Making almost all dom_ methods private. Exceptions will be addressed in a later CL. 
Current ones that still remain to be made private include createElement(NS),
createRange, all the Element properties, and childNodes.

BUG=
R=blois@google.com

Review URL: https://codereview.chromium.org//23055008

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26605 260f80e4-7a28-3924-810f-c04153c831b5
 2013-08-23 18:25:40 +00:00
blois@google.com ec11e52f62 Revert "Revert "Adding polyfill support for custom elements."" 
This fixes the issues in the custom elements polyfills.

R=jmesserly@google.com

Review URL: https://codereview.chromium.org//23301012

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26412 260f80e4-7a28-3924-810f-c04153c831b5
 2013-08-21 00:08:46 +00:00
blois@google.com 508affefed Revert "Adding polyfill support for custom elements." 
Caused issues with DocumentFragment and some lingering changes from the blink roll.

BUG=

Review URL: https://codereview.chromium.org//22957010

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26410 260f80e4-7a28-3924-810f-c04153c831b5
 2013-08-20 23:28:22 +00:00
blois@google.com 72651260aa Adding polyfill support for custom elements. 
BUG=
R=jmesserly@google.com

Review URL: https://codereview.chromium.org//22967006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26405 260f80e4-7a28-3924-810f-c04153c831b5
 2013-08-20 22:56:08 +00:00
vsm@google.com 8b5e40ee78 Fixes for Element API changes 
The custom_element analyzer test started failing due to API changes on Element from the last roll.  This should fix.

TBR=jmesserly@google.com,sigmund@google.com

Review URL: https://codereview.chromium.org//22897014

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26382 260f80e4-7a28-3924-810f-c04153c831b5
 2013-08-20 19:08:55 +00:00
jwren@google.com 7a9a98445a Turn strict mode off in the dartanalyzer 
R=brianwilkerson@google.com, scheglov@google.com

Review URL: https://codereview.chromium.org//22997004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26139 260f80e4-7a28-3924-810f-c04153c831b5
 2013-08-14 19:32:54 +00:00