ec4b205d80
Fewer iterations in barback test. Was timing out.
...
BUG=
Review URL: https://codereview.chromium.org//109323007
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31119 260f80e4-7a28-3924-810f-c04153c831b5
2013-12-13 00:38:40 +00:00
cafdac012d
Don't limit transformer parallelism in barback.
...
BUG=https://code.google.com/p/dart/issues/detail?id=15615
R=nweiz@google.com
Review URL: https://codereview.chromium.org//107303004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31113 260f80e4-7a28-3924-810f-c04153c831b5
2013-12-12 22:10:46 +00:00
6538374fe3
Increase barback scheduled_test timeout for many_parallel_transformers test.
...
BUG=dartbug.com/15483
Review URL: https://codereview.chromium.org//102433007
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@30978 260f80e4-7a28-3924-810f-c04153c831b5
2013-12-09 08:43:59 +00:00
20d5b12c33
Revise several already-committed CLs.
...
R=rnystrom@google.com
BUG=
Review URL: https://codereview.chromium.org//49223004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29707 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-31 21:50:54 +00:00
5589f499fa
Don't return outputs from a removed PhaseInput.
...
Also clean up a few things in Phase.
R=alanknight@google.com
Review URL: https://codereview.chromium.org//37813002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29127 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-23 21:19:15 +00:00
7449f31f8d
Fix a synchrony bug in barback.
...
Barback was assuming that certain Future operations were synchronous when in
fact they were not (issue 14323). This caused behavioral bugs in situations with
high input churn. Specifically, barback would attempt to use the synchronous
Future operations to guarantee that no changes happened between a condition
being checked and that condition being reported to the user. Since the Future
operations were not in fact synchronous, such changes were possible.
This change works around the issue by using a manual callback-passing style in
places where synchrony is important and Futures would otherwise be used.
R=alanknight@google.com
Review URL: https://codereview.chromium.org//36463002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29103 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-23 17:54:58 +00:00
794dc9d0d9
Only run at most 10 transformers at once in barback.
...
BUG=14320
R=alanknight@google.com
Review URL: https://codereview.chromium.org//36213002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29060 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-23 04:13:41 +00:00
96e9dce1d4
Make PhaseOutput emit a new AssetNode whenever it changes outputs.
...
Previously, PhaseOutput produced a single AssetNode whose value it
would update whenever the forwarded output changed. This worked well
for a while, but once Phase started caring about the AssetNode's
origin, it became problematic. PhaseOutput would change the origin,
but Phase would have no way of knowing this, and the AssetNode would
end up sorted into the wrong place (treated as a forwarded node when
it shouldn't be, or vice versa).
This CL fixes that issue by removing the possibility of modifying an
AssetNode's origin. PhaseOutput now just creates a new AssetNode
instead. This has the additional benefit of cleaning up some
duplicated code in Phase.
R=rnystrom@google.com
BUG=
Review URL: https://codereview.chromium.org//26413003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28386 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-08 22:20:28 +00:00
0e195d3994
Add support for transformer clusters to barback.
...
A cluster encapsulates a transformation graph in a form that can be used
similarly to a plain transformer.
R=rnystrom@google.com
BUG=
Review URL: https://codereview.chromium.org//25376003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28344 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-08 00:30:50 +00:00
60605c310b
Fix a barback bug where a result could be emitted incorrectly.
...
PackageGraph was relying on its own knowledge of which AssetCascades
were dirty, based on which cascades had assets updated. However, it's
possible for a cascade to become dirty due to another cascade's asset
being updated, and that case was missed. This change addresses that.
R=rnystrom@google.com
BUG=
Review URL: https://codereview.chromium.org//24460004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27904 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-25 19:17:25 +00:00
edad0a6ed2
Fix a subtle bug in barback.
...
When a [PhaseOutput.removeListeners] was called, the output was re-added to the [Phase] but its removal event wasn't re-subscribed. This meant that if that output was later removed, the phase got into an inconsistent state where it would perform operations on a removed output.
R=rnystrom@google.com
BUG=
Review URL: https://codereview.chromium.org//23803006
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27170 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-05 00:13:36 +00:00
fb3e580c5c
Support loading transformer plugins from pub.
...
This is still missing some functionality, most notably the ability for
a transformer to import transformed code.
R=rnystrom@google.com
BUG=
Review URL: https://codereview.chromium.org//23625002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27085 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-04 00:43:24 +00:00
193dfd7481
Make Transform a little more pleasant to use:
...
- Provide the primaryInput asset synchronously (#12515 ).
- Add convenience methods for reading input assets (#12516 ).
R=nweiz@google.com , sigmund@google.com
Review URL: https://codereview.chromium.org//23543005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26822 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-28 22:37:40 +00:00
13ad318db4
Enable cross-package transforms to see new transformers in other packages.
...
R=rnystrom@google.com
BUG=
Review URL: https://codereview.chromium.org//23171020
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26556 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-22 21:04:05 +00:00
d922bc34b8
Start sketching out a buildAll() method.
...
BUG=
R=nweiz@google.com
Review URL: https://codereview.chromium.org//22824023
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26452 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-21 18:09:39 +00:00
b56d5196b8
Add the ability to dynamically modify transforms to barback.
...
R=rnystrom@google.com
BUG=
Review URL: https://codereview.chromium.org//23311006
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26403 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-20 22:31:41 +00:00
f1f368d927
pkg/barback: removed unused imports, added a missing import
...
R=rnystrom@google.com
Review URL: https://codereview.chromium.org//23201013
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26330 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-19 23:29:50 +00:00
97d87db6ed
Fix a pass-through bug in barback.
...
R=rnystrom@google.com
Review URL: https://codereview.chromium.org//22852007
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26289 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-16 19:07:35 +00:00
ab406948be
Support passing barback assets through phases in which they're unused.
...
R=rnystrom@google.com
Review URL: https://codereview.chromium.org//23199004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26220 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-15 21:06:22 +00:00
6812f7c10a
Add more metadata to non-programmatic barback exceptions.
...
This also adds a BarbackException superclass for errors that come from the
package graph or from transformers.
R=rnystrom@google.com
Review URL: https://codereview.chromium.org//22961002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26133 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-14 18:12:17 +00:00
f3b74cb621
Better handling of asset collisions in barback.
...
R=rnystrom@google.com
Review URL: https://codereview.chromium.org//22685006
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26042 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-12 22:25:03 +00:00
5395c1e611
Consistently schedule operations in the barback tests.
...
R=rnystrom@google.com
Review URL: https://codereview.chromium.org//22371005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@25978 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-09 20:35:59 +00:00
12207b384d
Support cross-package transforms in barback.
...
R=rnystrom@google.com
Review URL: https://codereview.chromium.org//22265002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@25937 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-08 18:27:44 +00:00
54a2295fd7
Support an additional edge case in barback.
...
This adds support for the case where a transform loads an input, then that input
is changed before that transform completes. Previously the change would be
ignored; now the transform will be re-run.
R=rnystrom@google.com
Review URL: https://codereview.chromium.org//20625005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@25695 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-01 00:14:41 +00:00
f22e9532a6
Move barback to a more event-based model.
...
The goal of this change is to make it easy to synchronously propagate the dirty
state of an asset node to all of the nodes and transforms that depend on it,
while still asynchronously processing those transforms.
In addition, this refactor ends up addressing two TODOs and one bug:
* If a node has been compiled previously and an unrelated part of its cascade is
dirtied, it will now be returned immediately rather than waiting for the
entire cascade to finish processing.
* If a node is consumed as the input of a transform, it will no longer be
returned by [getAssetById].
* If the contents of a transform's primary input changes such that it's no
longer a valid primary input for that transform, the transform will be
removed.
R=rnystrom@google.com
Review URL: https://codereview.chromium.org//21275003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@25693 260f80e4-7a28-3924-810f-c04153c831b5
2013-07-31 23:51:24 +00:00
c12a5cad3a
Refactor the barback tests somewhat.
...
This makes each transformer capable of relatively fine-grained pausing
and resuming of processing. They no longer use MockAsset, instead
using [Asset.fromString] to better simulate real-world transformers.
This also adds several new utility functions to
barback/test/utils.dart.
R=rnystrom@google.com
Review URL: https://codereview.chromium.org//21226004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@25652 260f80e4-7a28-3924-810f-c04153c831b5
2013-07-30 23:57:16 +00:00
b31ce6c8cf
Fix a barback bug that triggered when an asset was removed.
...
If a transform had that asset as its primary input, it would go into an error
state.
R=rnystrom@google.com
Review URL: https://codereview.chromium.org//19473002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@25116 260f80e4-7a28-3924-810f-c04153c831b5
2013-07-17 18:32:11 +00:00
962d3fddb6
Rename several classes in barback.
...
AssetProvider -> PackageProvider
AssetGraphManager -> PackageGraph
AssetGraph -> AssetCascade
R=rnystrom@google.com
Review URL: https://codereview.chromium.org//19402003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@25080 260f80e4-7a28-3924-810f-c04153c831b5
2013-07-17 00:34:33 +00:00
rnystrom@google.com