Commit Graph

106 Commits

Author SHA1 Message Date
nweiz@google.com 76779d96d4 Remove version bump comment from pkg/barback/pubspec.yaml.
R=rnystrom@google.com
BUG=

Review URL: https://codereview.chromium.org//112933008

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31148 260f80e4-7a28-3924-810f-c04153c831b5
2013-12-13 23:02:48 +00:00
whesse@google.com fb2aeee1c5 Add missing import of stack_trace to barback implementation.
BUG=
R=sgjesse@google.com

Review URL: https://codereview.chromium.org//110533005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31124 260f80e4-7a28-3924-810f-c04153c831b5
2013-12-13 11:41:38 +00:00
rnystrom@google.com ec4b205d80 Fewer iterations in barback test. Was timing out.
BUG=

Review URL: https://codereview.chromium.org//109323007

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31119 260f80e4-7a28-3924-810f-c04153c831b5
2013-12-13 00:38:40 +00:00
rnystrom@google.com cafdac012d Don't limit transformer parallelism in barback.
BUG=https://code.google.com/p/dart/issues/detail?id=15615
R=nweiz@google.com

Review URL: https://codereview.chromium.org//107303004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31113 260f80e4-7a28-3924-810f-c04153c831b5
2013-12-12 22:10:46 +00:00
nweiz@google.com 113bd79bc6 Make pkg/path 1.0.0 and upgrade dependencies appropriately.
All existing packages that use pkg/path (other than pkg/stack_trace,
which has already been updated) are compatible with both the pre-1.0
and post-1.0 path API, so I've marked their version constraints as
">=0.9.0 <2.0.0". I've also incremented their patch versions and I
intend to release new versions as soon as this CL lands.

R=alanknight@google.com, efortuna@google.com, jmesserly@google.com, rnystrom@google.com, scheglov@google.com

Review URL: https://codereview.chromium.org//110873002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31005 260f80e4-7a28-3924-810f-c04153c831b5
2013-12-10 00:24:01 +00:00
nweiz@google.com 568613fb93 Bump the barback minor version.
This will ensure that next week's dev channel release will force
everyone to use compatible pub and barback versions.

R=rnystrom@google.com
BUG=

Review URL: https://codereview.chromium.org//99303005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31001 260f80e4-7a28-3924-810f-c04153c831b5
2013-12-09 21:22:43 +00:00
nweiz@google.com 6611756318 Increment package versions for stack trace changes.
R=rnystrom@google.com
BUG=

Review URL: https://codereview.chromium.org//110613003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@30997 260f80e4-7a28-3924-810f-c04153c831b5
2013-12-09 20:44:05 +00:00
whesse@google.com 6538374fe3 Increase barback scheduled_test timeout for many_parallel_transformers test.
BUG=dartbug.com/15483

Review URL: https://codereview.chromium.org//102433007

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@30978 260f80e4-7a28-3924-810f-c04153c831b5
2013-12-09 08:43:59 +00:00
rnystrom@google.com fe1c97ddf4 Pass logs through transformer groups.
BUG=https://code.google.com/p/dart/issues/detail?id=15189
R=nweiz@google.com

Review URL: https://codereview.chromium.org//108853003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@30963 260f80e4-7a28-3924-810f-c04153c831b5
2013-12-06 20:23:03 +00:00
rnystrom@google.com f4fb64f797 Implicitly constrain barback to versions pub supports.
BUG=https://code.google.com/p/dart/issues/detail?id=15345
R=nweiz@google.com

Review URL: https://codereview.chromium.org//105473002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@30923 260f80e4-7a28-3924-810f-c04153c831b5
2013-12-05 23:39:02 +00:00
nweiz@google.com 6955df5203 Add chain support to barback.
This also adds support to pub where necessary to maintain consistency with
barback.

R=rnystrom@google.com
BUG=

Review URL: https://codereview.chromium.org//101523003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@30880 260f80e4-7a28-3924-810f-c04153c831b5
2013-12-04 23:58:56 +00:00
nweiz@google.com 2e14e7ae71 Use a pool to restrict access to file descriptors in pub.
This is like r30830, but it doesn't check out resources for process invocations
in an attempt to narrow down the cause of the Windows buildbot failure.

This also adds additional logging for the same purpose.

R=rnystrom@google.com
TBR

Review URL: https://codereview.chromium.org//100393010

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@30839 260f80e4-7a28-3924-810f-c04153c831b5
2013-12-04 00:49:50 +00:00
nweiz@google.com 14d4e1f263 Revert "Use a pool to restrict access to file descriptors in pub."
This reverts r30830. This revert is just a test to see whether this CL caused
the windows bots to start failing or if it was a coincidence.

R=rnystrom@google.com
TBR

Review URL: https://codereview.chromium.org//102693007

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@30837 260f80e4-7a28-3924-810f-c04153c831b5
2013-12-04 00:33:41 +00:00
nweiz@google.com b97f099b2e Use a pool to restrict access to file descriptors in pub.
R=rnystrom@google.com
BUG=15358

Review URL: https://codereview.chromium.org//93013002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@30830 260f80e4-7a28-3924-810f-c04153c831b5
2013-12-03 22:30:59 +00:00
lrn@google.com 8744794212 Change other futures to also have timeout take a named parameter.
Review URL: https://codereview.chromium.org//98683002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@30792 260f80e4-7a28-3924-810f-c04153c831b5
2013-12-02 09:13:49 +00:00
lrn@google.com e0314a6117 Add Future.timeout.
R=floitsch@google.com, nweiz@google.com

Review URL: https://codereview.chromium.org//91213002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@30745 260f80e4-7a28-3924-810f-c04153c831b5
2013-11-28 08:16:01 +00:00
nweiz@google.com 20a6b4a97c Fix an incorrect method invocation in barback.
BUG=15358
R=sigmund@google.com

Review URL: https://codereview.chromium.org//92883002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@30736 260f80e4-7a28-3924-810f-c04153c831b5
2013-11-27 22:12:09 +00:00
rnystrom@google.com 2785beb7a7 Fix publish_barback.py script.
R=dgrove@google.com

Review URL: https://codereview.chromium.org//88943002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@30674 260f80e4-7a28-3924-810f-c04153c831b5
2013-11-26 18:46:12 +00:00
nweiz@google.com 9552f94822 Ensure that errors have stack traces attached.
This adds a stack trace argument to all [completeError] and [addError]
calls in pub and associated libraries.

R=rnystrom@google.com
BUG=

Review URL: https://codereview.chromium.org//68493003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@30332 260f80e4-7a28-3924-810f-c04153c831b5
2013-11-16 01:19:39 +00:00
nweiz@google.com 557d1d5062 Fix an analyzer error in http and barback.
R=rnystrom@google.com
BUG=

Review URL: https://codereview.chromium.org//62443006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@30331 260f80e4-7a28-3924-810f-c04153c831b5
2013-11-16 01:13:04 +00:00
nweiz@google.com d018e7308e Serialize binary barback assets using typed arrays.
R=rnystrom@google.com

Review URL: https://codereview.chromium.org//68103027

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@30324 260f80e4-7a28-3924-810f-c04153c831b5
2013-11-16 00:09:30 +00:00
rnystrom@google.com c528bf9f9d SDK constraint and README for barback.
BUG=https://code.google.com/p/dart/issues/detail?id=14862
R=jmesserly@google.com, nweiz@google.com

Review URL: https://codereview.chromium.org//63363002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@30200 260f80e4-7a28-3924-810f-c04153c831b5
2013-11-12 18:57:17 +00:00
nweiz@google.com ea9d92f3f4 Fix a synchronous event bug in futureStream.
R=rnystrom@google.com
TBR

Review URL: https://codereview.chromium.org//68713004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@30182 260f80e4-7a28-3924-810f-c04153c831b5
2013-11-12 01:56:18 +00:00
nweiz@google.com 0a4fb91145 Properly close watcher streams during tests.
This also makes [futureStream] pass cancellations through to the underlying
stream, and adds the ability for it to return broadcast streams.

R=rnystrom@google.com
BUG=14943

Review URL: https://codereview.chromium.org//66293008

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@30180 260f80e4-7a28-3924-810f-c04153c831b5
2013-11-12 01:42:00 +00:00
nweiz@google.com 0a22d14296 Work around issue 14971 in barback.
R=rnystrom@google.com
BUG=

Review URL: https://codereview.chromium.org//63243003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@30131 260f80e4-7a28-3924-810f-c04153c831b5
2013-11-08 23:34:53 +00:00
nweiz@google.com 88124b3f81 Serialize barback assets more efficiently.
This adds an [InternalAsset] class to barback that supports serialization
operations, and specializes those operations for each asset type (for example,
FileAssets will just send the file path across isolates). This class isn't
exposed publicly, but pub imports it and uses it to handle asset serialization.

BUG=14430
R=rnystrom@google.com

Review URL: https://codereview.chromium.org//55983005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@30126 260f80e4-7a28-3924-810f-c04153c831b5
2013-11-08 22:14:03 +00:00
dgrove@google.com 18ca7d0036 Re-land r29957 (add versions and constraints for packages and samples), with
SDK constraints bumped from 1.0.0 to 0.8.10+6 .

R=ricow@google.com, sigmund@google.com

Review URL: https://codereview.chromium.org//62473002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29986 260f80e4-7a28-3924-810f-c04153c831b5
2013-11-06 18:28:22 +00:00
ajohnsen@google.com 61f6c51990 Revert "add versions and constraints for packages and samples"
This is currently blocking us from testing samples.

BUG=
R=kasperl@google.com

Review URL: https://codereview.chromium.org//59513007

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29960 260f80e4-7a28-3924-810f-c04153c831b5
2013-11-06 09:09:18 +00:00
jmesserly@google.com 02638c5760 add versions and constraints for packages and samples
- all packages at 0.9.0, except "analyzer" which had a version already
- dependencies at ">=0.9.0 <0.10.0" except analyzer is ">=0.10.0 <0.11.0"
- sdk constraint ">=1.0.0 <2.0.0"

R=sigmund@google.com

Review URL: https://codereview.chromium.org//59763006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29957 260f80e4-7a28-3924-810f-c04153c831b5
2013-11-06 03:27:58 +00:00
nweiz@google.com 20d5b12c33 Revise several already-committed CLs.
R=rnystrom@google.com
BUG=

Review URL: https://codereview.chromium.org//49223004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29707 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-31 21:50:54 +00:00
rnystrom@google.com af0326f92c Fix barback test.
R=nweiz@google.com

Review URL: https://codereview.chromium.org//54723004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29693 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-31 20:25:34 +00:00
rnystrom@google.com 810915f01a Pass in "mode" to transformer plugins.
BUG=https://code.google.com/p/dart/issues/detail?id=14538
R=nweiz@google.com, sigmund@google.com

Review URL: https://codereview.chromium.org//52853004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29690 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-31 20:04:27 +00:00
jmesserly@google.com 489f51a41b fix barback and polymer build warnings
R=nweiz@google.com, sigmund@google.com

Review URL: https://codereview.chromium.org//50073007

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29631 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-31 02:41:01 +00:00
floitsch@google.com 7006de6f23 Remove deprecated parts of dart:async.
Attempt to fix most uses of the deprecated features.

R=floitsch@google.com, nweiz@google.com, rnystrom@google.com

Review URL: https://codereview.chromium.org//48483002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29628 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-31 02:24:29 +00:00
rnystrom@google.com c638273b84 Revise barback logging patch.
R=nweiz@google.com

Review URL: https://codereview.chromium.org//48993007

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29483 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-29 20:01:12 +00:00
nweiz@google.com c2790caa6a Avoid sending needless data between isolates in "pub serve" and "pub build"
Previously when passing barback assets between isolates, pub would eagerly send
the entire contents of the asset. Now it waits to do so until some code actually
subscribes to the asset's data stream.

BUG=14430
R=rnystrom@google.com

Review URL: https://codereview.chromium.org//43143002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29408 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-29 00:18:19 +00:00
nweiz@google.com 5589f499fa Don't return outputs from a removed PhaseInput.
Also clean up a few things in Phase.

R=alanknight@google.com

Review URL: https://codereview.chromium.org//37813002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29127 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-23 21:19:15 +00:00
nweiz@google.com 7449f31f8d Fix a synchrony bug in barback.
Barback was assuming that certain Future operations were synchronous when in
fact they were not (issue 14323). This caused behavioral bugs in situations with
high input churn. Specifically, barback would attempt to use the synchronous
Future operations to guarantee that no changes happened between a condition
being checked and that condition being reported to the user. Since the Future
operations were not in fact synchronous, such changes were possible.

This change works around the issue by using a manual callback-passing style in
places where synchrony is important and Futures would otherwise be used.

R=alanknight@google.com

Review URL: https://codereview.chromium.org//36463002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29103 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-23 17:54:58 +00:00
nweiz@google.com 794dc9d0d9 Only run at most 10 transformers at once in barback.
BUG=14320
R=alanknight@google.com

Review URL: https://codereview.chromium.org//36213002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29060 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-23 04:13:41 +00:00
sigmund@google.com 7c2e6295aa Fix type errors detected with --error-on-bad-type.
R=nweiz@google.com, regis@google.com

Review URL: https://codereview.chromium.org//35543006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29047 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-22 23:41:05 +00:00
nweiz@google.com 0fb1f14635 Cap the number of FDs used by barback at 32.
BUG=13752
R=alanknight@google.com

Review URL: https://codereview.chromium.org//35923002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29034 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-22 20:29:46 +00:00
nweiz@google.com 7ff3b89aba Make sure barback's FilePool doesn't take up *all* the available FDs.
BUG=13752
R=alanknight@google.com

Review URL: https://codereview.chromium.org//28733009

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29021 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-22 18:36:57 +00:00
nweiz@google.com 2f53ba7b48 Make barback propagate logs synchronously.
R=alanknight@google.com

Review URL: https://codereview.chromium.org//29763003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28893 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-18 22:58:08 +00:00
kevmoo@j832.com 7802e835ae fix for Set.add tweak in r28863
R=blois@google.com

Review URL: https://codereview.chromium.org//29463002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28866 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-18 17:54:21 +00:00
rnystrom@google.com bd4f848856 Use file pool to handle running out of file descriptors.
BUG=https://code.google.com/p/dart/issues/detail?id=13752

Review URL: https://codereview.chromium.org//27242002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28702 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-16 00:59:47 +00:00
nweiz@google.com 999840c105 Track the original assets more efficiently in Phase.
R=rnystrom@google.com
BUG=

Review URL: https://codereview.chromium.org//26598002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28685 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-15 21:40:59 +00:00
floitsch@google.com 0f7a0bd7b1 Rename runAsync to scheduleMicrotask.
R=lrn@google.com

Review URL: https://codereview.chromium.org//26151002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28569 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-12 15:52:17 +00:00
floitsch@google.com dc9c5f42ed Redo StreamTransformers so they work with Stack traces.
Since this involved a breaking change I cleaned up more of the
StreamTransformer API.

This CL also deprecates the getAttachedStackTrace method.

R=ajohnsen@google.com, lrn@google.com, nweiz@google.com, rnystrom@google.com

Review URL: https://codereview.chromium.org//25354003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28562 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-12 12:34:34 +00:00
rnystrom@google.com 2c095c78d9 Make pub build use barback.
BUG=https://code.google.com/p/dart/issues/detail?id=13880
R=alanknight@google.com

Review URL: https://codereview.chromium.org//26933003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28524 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-11 16:17:06 +00:00
floitsch@google.com 4be547c705 Adapt streams for additional stackTrace argument.
R=lrn@google.com

Review URL: https://codereview.chromium.org//25094002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28511 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-11 12:02:20 +00:00