bda0d5f25c
Test fix in quest for build greenness [TBR].
...
Review URL: https://codereview.chromium.org//99583011
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31284 260f80e4-7a28-3924-810f-c04153c831b5
2013-12-19 17:21:28 +00:00
21730c7eb8
Test jig for data-driving dartfmt tests.
...
R=brianwilkerson@google.com
Review URL: https://codereview.chromium.org//98693013
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31283 260f80e4-7a28-3924-810f-c04153c831b5
2013-12-19 17:02:50 +00:00
db0d15dbe2
dartfmt gets opinionated about 'gratuitous' linebreaks.
...
IOW: we now collapse lines that are broken.
NOTE: EOL comments are sure to break this; CL to address to follow.
R=brianwilkerson@google.com
Review URL: https://codereview.chromium.org//113693003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31243 260f80e4-7a28-3924-810f-c04153c831b5
2013-12-18 22:57:53 +00:00
5353a7771a
Formatter line continuation awareness hooks.
...
DO indent continued lines with at least four spaces.
https://www.dartlang.org/articles/style-guide/#do-indent-continued-lines-with-at-least-four-spaces
NOTE: these are just the hooks. As per our conversations, we need to encode opinions about what continuations should be allowed before we support them. The tests are left, commented out, to serve as tracer bullets when we get there.
R=brianwilkerson@google.com
Review URL: https://codereview.chromium.org//109423004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31210 260f80e4-7a28-3924-810f-c04153c831b5
2013-12-17 22:38:35 +00:00
59b87d2dc3
Implement hashCode for classes with equals().
...
These problems were reported by dart2js.
R=brianwilkerson@google.com , devoncarew@google.com
BUG=
Review URL: https://codereview.chromium.org//93433007
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31068 260f80e4-7a28-3924-810f-c04153c831b5
2013-12-11 16:32:56 +00:00
965c254725
New analyzer snapshot.
...
1. Fixes for converting properties for fields:
1.1. Only if neither getter not setter are overridden. Note that we ignore the fact that it _might_ be overridden in some subclass that we don't see.
Without this assumption almost nothing can be a field.
2.2. Create final fields when possible.
2. Generate field formal parameters where possible.
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//109853003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31043 260f80e4-7a28-3924-810f-c04153c831b5
2013-12-10 21:39:47 +00:00
113bd79bc6
Make pkg/path 1.0.0 and upgrade dependencies appropriately.
...
All existing packages that use pkg/path (other than pkg/stack_trace,
which has already been updated) are compatible with both the pre-1.0
and post-1.0 path API, so I've marked their version constraints as
">=0.9.0 <2.0.0". I've also incremented their patch versions and I
intend to release new versions as soon as this CL lands.
R=alanknight@google.com , efortuna@google.com , jmesserly@google.com , rnystrom@google.com , scheglov@google.com
Review URL: https://codereview.chromium.org//110873002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31005 260f80e4-7a28-3924-810f-c04153c831b5
2013-12-10 00:24:01 +00:00
fb66f5d516
New analyzer snapshot.
...
Mainly to add support for the new options.
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//107833002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@30960 260f80e4-7a28-3924-810f-c04153c831b5
2013-12-06 19:43:15 +00:00
6d652fbf4e
Fix for extra space preceding the 'on' keyword in a catch clause (dartbug.com/15454).
...
R=brianwilkerson@google.com
Review URL: https://codereview.chromium.org//100553004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@30900 260f80e4-7a28-3924-810f-c04153c831b5
2013-12-05 17:18:53 +00:00
e689a786b5
Fix for map and list literal indentation (dartbug.com/15453).
...
R=brianwilkerson@google.com
Review URL: https://codereview.chromium.org//105613003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@30876 260f80e4-7a28-3924-810f-c04153c831b5
2013-12-04 23:35:55 +00:00
4c02f461e9
Formatter improvements (comments and empty bodies).
...
With these fixes we can now safely format the analyzer source itself (w/ sanity checking). Next stop the SDK! :)
R=brianwilkerson@google.com
Review URL: https://codereview.chromium.org//104993003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@30869 260f80e4-7a28-3924-810f-c04153c831b5
2013-12-04 21:12:51 +00:00
0cd8cd4006
New analyzer snapshot.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//103233003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@30862 260f80e4-7a28-3924-810f-c04153c831b5
2013-12-04 17:57:44 +00:00
7a2e3d53e3
Source kind arg support for dartftmt.
...
The API is far from firm but enough to enable a steel-thread through the editor where we want to support formatting source selections.
A follow-up CL will introduce more CodeKinds.
R=brianwilkerson@google.com
Review URL: https://codereview.chromium.org//82043002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@30584 260f80e4-7a28-3924-810f-c04153c831b5
2013-11-22 18:50:48 +00:00
9d8ce37bfe
New analyzer snapshot.
...
Also insert empty lines between class and unit members.
Remove some more extra parentheses.
R=brianwilkerson@google.com , devoncarew@google.com
BUG=
Review URL: https://codereview.chromium.org//68233003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@30203 260f80e4-7a28-3924-810f-c04153c831b5
2013-11-12 19:33:57 +00:00
18ca7d0036
Re-land r29957 (add versions and constraints for packages and samples), with
...
SDK constraints bumped from 1.0.0 to 0.8.10+6 .
R=ricow@google.com , sigmund@google.com
Review URL: https://codereview.chromium.org//62473002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29986 260f80e4-7a28-3924-810f-c04153c831b5
2013-11-06 18:28:22 +00:00
61f6c51990
Revert "add versions and constraints for packages and samples"
...
This is currently blocking us from testing samples.
BUG=
R=kasperl@google.com
Review URL: https://codereview.chromium.org//59513007
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29960 260f80e4-7a28-3924-810f-c04153c831b5
2013-11-06 09:09:18 +00:00
02638c5760
add versions and constraints for packages and samples
...
- all packages at 0.9.0, except "analyzer" which had a version already
- dependencies at ">=0.9.0 <0.10.0" except analyzer is ">=0.10.0 <0.11.0"
- sdk constraint ">=1.0.0 <2.0.0"
R=sigmund@google.com
Review URL: https://codereview.chromium.org//59763006
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29957 260f80e4-7a28-3924-810f-c04153c831b5
2013-11-06 03:27:58 +00:00
3651d4879a
Issue 14685. Don't analyzer parts.
...
https://code.google.com/p/dart/issues/detail?id=14685
R=brianwilkerson@google.com , jwren@google.com
BUG=
Review URL: https://codereview.chromium.org//54903009
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29781 260f80e4-7a28-3924-810f-c04153c831b5
2013-11-01 23:46:12 +00:00
d4359631f7
New analyzer snapshot.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//51043010
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29765 260f80e4-7a28-3924-810f-c04153c831b5
2013-11-01 19:24:33 +00:00
c38de04d0c
Change dart:io Platform.script to return a Uri.
...
BUG=
R=sgjesse@google.com
Review URL: https://codereview.chromium.org//46063010
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29651 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-31 07:29:01 +00:00
4f08151090
Revert "Change dart:io Platform.script to return a Uri."
...
This reverts r29619 and r29624. The changes look fine on the buildbot,
but need review before adding to the repository.
BUG=
TBR=sgjesse@google.com
Review URL: https://codereview.chromium.org//52723007
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29627 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-31 02:17:37 +00:00
cb0110350a
Change dart:io Platform.script to return a URI. Change all uses of Platform.script to work with the new value.
...
R=floitsch@google.com
Review URL: https://codereview.chromium.org//53313007
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29619 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-31 01:08:11 +00:00
69205c207c
Remove uses of Options from pkg, samples, tests, and third_party directories.
...
BUG=
R=sgjesse@google.com
Review URL: https://codereview.chromium.org//52573002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29552 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-30 15:17:01 +00:00
f0a1c922a2
Reapply "Remove @deprecated features."
...
R=scheglov@google.com , sgjesse@google.com
Review URL: https://codereview.chromium.org//50413005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29535 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-30 12:09:15 +00:00
7a76ad7834
Add @proxy to annotations.dart.
...
Remove package:meta
R=bak@google.com , brianwilkerson@google.com
Review URL: https://codereview.chromium.org//46593003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29525 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-30 10:25:08 +00:00
9039835b60
New analyzer snapshot.
...
R=brianwilkerson@google.com , jwren@google.com
BUG=
Review URL: https://codereview.chromium.org//49383002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29384 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-28 19:46:48 +00:00
509d0afd74
Remove all_test from analyzer package.
...
We use it only locally.
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//46633002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29308 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-26 02:00:12 +00:00
00d017bc9e
Comment out resolver tests.
...
They always should be commented, because we cannot get SDK path on bot.
TBR
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//46513002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29304 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-26 01:00:03 +00:00
7ac0b7d0bd
Rename analyzer_experimental to analyzer.
...
R=jmesserly@google.com , pquitslund@google.com , danrubel@google.com
BUG=
Review URL: https://codereview.chromium.org//45573002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29302 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-25 23:59:38 +00:00
pquitslund@google.com