36c0788137
add package:_macros (SDK vendored) and package:macros (pub published)
...
add sdk_packages.yaml file (describes SDK vendored package locations)
delete old macro code in _fe_analyzer_shared, move tests/benchmarks
adds a top level `pkg` directory to the Dart SDK, which is where vendored packages live
BUG: https://github.com/dart-lang/sdk/issues/54976
Change-Id: Ib3503a27fb5644fa8a39ab5a3e5b568df330cfd6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/359040
Auto-Submit: Jake Macdonald <jakemac@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Jonas Termansen <sortie@google.com >
Reviewed-by: Johnni Winther <johnniwinther@google.com >
Reviewed-by: Bob Nystrom <rnystrom@google.com >
Commit-Queue: Jake Macdonald <jakemac@google.com >
Reviewed-by: Devon Carew <devoncarew@google.com >
2024-03-26 18:40:00 +00:00
e680eb4c4f
[macros] Tweak diagnostic for unexpected macro implementation exception.
...
The only expected exceptions at this point are DiagnosticException and MacroException subtypes; everything else is a bug in the implementation.
Tweak the diagnostic to explain that it's due to a bug in the macro. Add the exception message and stack trace as a context message, and a fix hint to contact the author.
Add a language test.
Retry landing with updates to `pkg/analyzer/test/summary/macro_test`.
R=jensj@google.com , scheglov@google.com , sigmund@google.com
Change-Id: Iebc3df784922dcb6ef112ba8d023d5388516373b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/352361
Reviewed-by: Jake Macdonald <jakemac@google.com >
Auto-Submit: Morgan :) <davidmorgan@google.com >
Commit-Queue: Morgan :) <davidmorgan@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Johnni Winther <johnniwinther@google.com >
2024-02-22 13:53:20 +00:00
dc586994da
[macros] Add language tests for nested macros and disallowed macro use.
...
Nested macros: check that macro impls can themselves use macros.
Disallowed use: check that macros can't be used in the library in which they are declared, or in the same library cycle.
R=jakemac@google.com
Change-Id: I3b12afc27e5784edc217508b7763a9b448229877
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/352522
Reviewed-by: Jake Macdonald <jakemac@google.com >
Commit-Queue: Morgan :) <davidmorgan@google.com >
Auto-Submit: Morgan :) <davidmorgan@google.com >
2024-02-15 09:42:41 +00:00
6d57fe5a1c
Revert "[macros] Tweak diagnostic for unexpected macro implementation exception."
...
This reverts commit 093271880aR=jakemac@google.com
>
> Change-Id: Ieaa6bedb3bc1646e4be61b384619152cc173b7e0
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/351040
> Auto-Submit: Morgan :) <davidmorgan@google.com >
> Reviewed-by: Jens Johansen <jensj@google.com >
> Commit-Queue: Morgan :) <davidmorgan@google.com >
> Reviewed-by: Jake Macdonald <jakemac@google.com >
Change-Id: Ia64c112aad79fdcdd1f6e1a4b800616632107fc2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/352260
Auto-Submit: Morgan :) <davidmorgan@google.com >
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com >
Commit-Queue: Erik Ernst <eernst@google.com >
Reviewed-by: Erik Ernst <eernst@google.com >
Reviewed-by: Jens Johansen <jensj@google.com >
2024-02-13 12:38:14 +00:00
093271880a
[macros] Tweak diagnostic for unexpected macro implementation exception.
...
The only expected exceptions at this point are DiagnosticException and MacroException subtypes; everything else is a bug in the implementation.
Tweak the diagnostic to explain that it's due to a bug in the macro. Add the exception message and stack trace as a context message, and a fix hint to contact the author.
Add a language test.
R=jakemac@google.com
Change-Id: Ieaa6bedb3bc1646e4be61b384619152cc173b7e0
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/351040
Auto-Submit: Morgan :) <davidmorgan@google.com >
Reviewed-by: Jens Johansen <jensj@google.com >
Commit-Queue: Morgan :) <davidmorgan@google.com >
Reviewed-by: Jake Macdonald <jakemac@google.com >
2024-02-13 10:31:11 +00:00
94fb9c9f2c
support custom JSON keys for fields
...
Change-Id: I72c2a4f09b012c4100fe9286967d182831507160
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/350740
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Auto-Submit: Jake Macdonald <jakemac@google.com >
Reviewed-by: Morgan :) <davidmorgan@google.com >
Commit-Queue: Jake Macdonald <jakemac@google.com >
2024-02-07 16:48:38 +00:00
f367d1e107
[macros] Add DiagnosticException that macro implementations can throw to report a diagnostic.
...
R=jakemac@google.com
Change-Id: I7546aa84f3e0b8423465dcb49d90a89df9231b84
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/350302
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Auto-Submit: Morgan :) <davidmorgan@google.com >
Reviewed-by: Jake Macdonald <jakemac@google.com >
Commit-Queue: Morgan :) <davidmorgan@google.com >
2024-02-06 17:32:14 +00:00
Konstantin Shcheglov