 Konstantin Shcheglov
|
14c155d2db
|
Coding style. Add the reason for using 'var' and not 'final'.
Change-Id: Id30cad3b8c5e45d290d6f1cf5bdc79320e6ff0b7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/362900
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
|
2024-04-16 17:50:31 +00:00 |
|
|
Sam Rawlins
|
c2a9026ef2
|
analyzer: add Effective Dart to our style guide
I tidy up a few other bits.
In particular, I wasn't sure about the word "adjective" to describe the word "file" in the variable name `filePath`. I looked it up and found "noun adjunct." https://en.wikipedia.org/wiki/Noun_adjunct#:~:text=Noun%20adjuncts%20can%20also%20be,and%20%22chicken%20soup%22%20modifies%20%22. Never heard of it! It looks like "qualifying noun" is also a common term, and I think it's not too hard to figure out what that means. But, open to suggestions as always.
Change-Id: If204c67078532fb5130fda08f6777761c87ba8eb
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/355891
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
|
2024-03-06 19:29:58 +00:00 |
|
|
Sam Rawlins
|
b19141a202
|
analyzer: Rename some extensions
And add a bit to our style doc about naming of extensions.
Change-Id: I22dd05dfe08b46ae38cc200456eb008e02eb002f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/347782
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Auto-Submit: Samuel Rawlins <srawlins@google.com>
|
2024-01-23 16:26:39 +00:00 |
|
|
Brian Wilkerson
|
4532e20ec4
|
Update the coding_style doc
After lengthy consideration, I believe that this is the best policy for
the team overall. It also corresponds to what I thought we had already
agreed to in the past.
Change-Id: I952297bf966ace0bdb105a5e4539420c3c6b8983
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/345748
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Phil Quitslund <pquitslund@google.com>
Reviewed-by: Samuel Rawlins <srawlins@google.com>
|
2024-01-12 05:27:28 +00:00 |
|
|
pq
|
3b5f985aa5
|
document use of flutter_style_todos
We agreed to adopt this style (and I enabled the lint) but forgot to update the doc.
This fixes that!
Change-Id: I68c29471506b8621ee8e6069540f7ca7dc23138e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/337286
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
|
2023-11-21 00:06:59 +00:00 |
|
|
Konstantin Shcheglov
|
42e5cc2377
|
Specify using unnecessary_breaks in the coding style.
Change-Id: Ibedb2fcd0ad5fdb6bfc3dcc4b88a02c9a9d78152
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/337282
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
|
2023-11-20 21:36:17 +00:00 |
|
|
Sam Rawlins
|
283dad4ddc
|
analysis_server: Enforce single quotes preference
Change-Id: I553befc2c45e66bfc569004d810b4e0a958d4baa
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/325544
Commit-Queue: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
|
2023-09-13 17:48:22 +00:00 |
|
|
Sam Rawlins
|
05f2b3222a
|
[analyzer] Add extension-naming to our style doc
Change-Id: I454df164b2cede7c4ae7d6fdf541e67fdf7090da
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/316525
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Kallen Tu <kallentu@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
|
2023-07-26 20:32:59 +00:00 |
|
|
Brian Wilkerson
|
06be97c607
|
Capture the agreed on style for import prefix names
Change-Id: I6eba4a7e37a72677c58d219892cd2e4c74560356
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/314220
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
|
2023-07-18 04:09:58 +00:00 |
|
|
Brian Wilkerson
|
a2dbcf7a56
|
Initial coding style documentation
Change-Id: I1f29d10a0eff99a98e8e79500288f9766fcc9a64
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/308700
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Phil Quitslund <pquitslund@google.com>
|
2023-06-13 01:11:56 +00:00 |
|