dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
74,108 Commits 2 Branches 0 Tags
71d6b669a3676f01bf040c00528fa2138ff7987f
Commit Graph

773 Commits

Author SHA1 Message Date
Brian Wilkerson 082a6e03bd Use element kind to boost the relevance of available declarations 
This doesn't significantly improve the overall scores, but it does cause
the element kind to be used for available declarations, which means that
constructors are suggested before classes.

Change-Id: I75e7bb13bd867b9209a43c4d737c5079c42eb25a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/154080
Reviewed-by: Jaime Wren <jwren@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2020-07-10 20:08:36 +00:00
Konstantin Shcheglov 90ce990409 Simplify Flutter support to a single instance. 
Change-Id: I90813c4e01694510971c4ce9cf96a4a3380a2923
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/153952
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-07-10 17:21:24 +00:00
Konstantin Shcheglov d49a98b866 Simplify FeatureComputer and improve for location before named arguments and with spaces. 
Change-Id: Ie2b383078ab79ecc6ac9634f9f38534f0c22c707
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/152989
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-06-30 23:17:37 +00:00
Konstantin Shcheglov 99cc566afc Clean up ArgumentList tests for FeatureComputer. 
R=brianwilkerson@google.com

Change-Id: I50c880ba5e60b8a5ba4b80f0fe0da7097eb2cb9c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/152733
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2020-06-30 21:26:22 +00:00
Brian Wilkerson 3fe9867ae2 Add a fix for prefer_final_in_for_each (issue 42510) 
Change-Id: Iebac9c2854eaf40dd7c177d5357172dfcafa6806
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/152618
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2020-06-29 19:20:23 +00:00
Danny Tuppeny e8e366714c Rename "Sort Directives" as "Organize Imports" in the quick-fix 
Fixes https://github.com/Dart-Code/Dart-Code/issues/2552.

Change-Id: I5591b3fa7b0e2c03e104b16f878689cf2e8caa4c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/151514
Commit-Queue: Danny Tuppeny <danny@tuppeny.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Jaime Wren <jwren@google.com>
 2020-06-29 16:38:13 +00:00
Konstantin Shcheglov 13aae92ae9 Fix for crash when computing the context type and unresolved named argument. 
StateError: Bad state: No element
at Iterable.first	(dart:core)
at _ContextTypeVisitor.visitArgumentList	(feature_computer.dart:400)

R=brianwilkerson@google.com

Change-Id: I578a17d5f0451785a0ed9ff5953705f91676c4ca
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/152731
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-06-28 17:49:02 +00:00
Paul Berry 8ed0541439 Fix typo causing a test not to be run 
Change-Id: I6455621fd59603adf980dddcedb2ee4f1d455664
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/152430
Auto-Submit: Paul Berry <paulberry@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2020-06-25 17:59:32 +00:00
Danny Tuppeny 87d431e8de Improve flutter wrap assists when caret is at the offset of an argument list 
Bug: https://github.com/Dart-Code/Dart-Code/issues/2492
Change-Id: I296f9396b3eedcbd1a63f272ed34c65f9d95d83b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/152521
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Danny Tuppeny <danny@tuppeny.com>
 2020-06-25 17:17:12 +00:00
Konstantin Shcheglov 52d16dfbba Resolve only relevant portion of the file for Cider completion. 
R=brianwilkerson@google.com, keertip@google.com

Change-Id: Icf23a79f25baf309f88b737ac061a10a655d2f7f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/152407
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2020-06-25 01:02:41 +00:00
Brian Wilkerson d0e78f8a77 Fix the edit groups created by create_missing_overrides (issue 42468) 
Change-Id: I53e5f44af3583549f277f1d7acbe1f725f7a6ef5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/152400
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2020-06-24 22:39:18 +00:00
Konstantin Shcheglov 7f824bb02d Check for null in VariableDeclaration context type. 
R=brianwilkerson@google.com

Change-Id: Iabf7b76812cdd9480a71b3a396c9895b33e3c998
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/152181
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-06-23 19:16:23 +00:00
Brian Wilkerson ab73158758 Fix the windows bot and update MockSdk 
Fixing the test that's causing the Windows bot to fail required updating
the MockSdk, which cause a lot of other changes. I would have done this
in two separate CLs if I'd known how big this was going to get, but I'm
hoping it isn't too big.

Change-Id: Idee56bab5e73a78ab7857e81177090493aa08b40
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/151874
Reviewed-by: Paul Berry <paulberry@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2020-06-22 14:34:25 +00:00
Brian Wilkerson 32d403b472 Add a fix to insert the keyword late 
Change-Id: I40612fd2710a1189137d8ba676c1b66b4943d677
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/151037
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2020-06-21 17:33:10 +00:00
Brian Wilkerson 52dd48651b Convert the remaining quick assists to use CorrectionProducer 
Change-Id: I0accafaf3f076d99bb265d2e6d8815cf2720a7a2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/151871
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2020-06-21 15:43:42 +00:00
Konstantin Shcheglov 8fd04408f0 Add CiderCompletionComputer.warmUp() 
R=brianwilkerson@google.com, keertip@google.com

Change-Id: I4fce7250d7f7b85ea47bf119ddfd6ef25fb28efe
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/151888
Reviewed-by: Keerti Parthasarathy <keertip@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-06-19 22:59:17 +00:00
Brian Wilkerson 9fcac032b6 Convert more quick assists to be correction producers 
Change-Id: I6cc0343cc9af390923a7d4a66a95e1c15aeb47f8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/151887
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2020-06-19 22:23:47 +00:00
Jaime Wren e12a515be0 Use the new analysis we now have with implied types to included types at locations such as 'var i = ^' for purposes of code completion. 
Change-Id: Ie78a51a5c3c65818bec66496e51716f9406899c0
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/151807
Commit-Queue: Jaime Wren <jwren@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2020-06-19 20:38:28 +00:00
Konstantin Shcheglov 69843a8f04 Record performance with CiderOperationPerformance hierarchy. 
This does not include breakdown for resolution yet.

I wonder if this more general information could replace specialized
CiderCompletionPerformance fields 'resolution', 'suggestions', etc.
WDYT?

R=brianwilkerson@google.com, keertip@google.com

Change-Id: I4685dc2a8de8028ce84cc2640943f45c8cf047e3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/151811
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Keerti Parthasarathy <keertip@google.com>
 2020-06-19 17:33:03 +00:00
Konstantin Shcheglov 71ddad82e4 Disable UriContributor for Cider. 
There are two reasons to disable it.

1. This contributor talks to the file system, and for Cider this
   operation is too slow.

2. It just does not work. We need `SourceFactory` for it, and the
   way we get it is not compatible with the Cider's `AnalysisSession`
   mock.


R=brianwilkerson@google.com, keertip@google.com

Change-Id: I652c4f438dbab2a9fa220878ff09d47c14434cd5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/151806
Reviewed-by: Keerti Parthasarathy <keertip@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-06-18 23:29:03 +00:00
Jaime Wren 5944ff823f Context type improvement for code completion, fill in missing functionality and add tests for FieldDeclarations, VariableDeclarations, VariableDeclarationList, and TopLevelVariableDeclarations. 
Change-Id: I7267712f68990b5f55ab64bca2345409e41738b3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/151622
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Jaime Wren <jwren@google.com>
 2020-06-17 20:42:41 +00:00
Danny Tuppeny f36151e2d2 Add ChangeTo/CreateClass fixes for implements/mixin of missing identifiers 
Change-Id: Iac0c512e87aaf5ba183d155e7bffe2a74936d7a1
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/151509
Commit-Queue: Danny Tuppeny <danny@tuppeny.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2020-06-17 15:44:36 +00:00
Danny Tuppeny 728df5d9ab Fix placement of "final" for late fields with types 
Fixes https://github.com/Dart-Code/Dart-Code/issues/2553.

Change-Id: Ief79c8d5e095c17afc39d83eb231604bcf224ee8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/151511
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Danny Tuppeny <danny@tuppeny.com>
 2020-06-17 14:56:04 +00:00
Jaime Wren 651464c909 Implement the rest of the ArgumentList ASTNode logic in the context type visitor in feature_computer.dart, tests added in feature_computer_test.dart 
Change-Id: I35afea21912a785af427afb317cbff532c29d717
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/151364
Commit-Queue: Jaime Wren <jwren@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2020-06-16 20:51:21 +00:00
Jaime Wren 920ddae937 Re-write of the computation of the context type for code completion.  Instead of passing a parent and child node, a parent node with an offset is passed.  The primary purpose of this change was to fix a bug with argument lists which is close to being fixed. 
I will follow up with some additional fixes and tests for map and list literals.

Change-Id: I1a26e8f900dcf13402385a49e8f3538c5d1b39df
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/151030
Commit-Queue: Jaime Wren <jwren@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2020-06-15 18:19:42 +00:00
Brian Wilkerson 8d08bbf40a Add a fix for default_list_constructor 
Change-Id: Ia7b9c88cfe9528ddddd68935009736c494e57130
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/151098
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2020-06-13 16:29:35 +00:00
Danny Tuppeny 7b12c8e06d Add fixes for extends_non_class 
Bug: https://github.com/Dart-Code/Dart-Code/issues/2536
Change-Id: I5e4fa5a3625016045d86462b941cee3c73a36a04
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/150932
Commit-Queue: Danny Tuppeny <danny@tuppeny.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2020-06-12 14:12:34 +00:00
Konstantin Shcheglov 67da8cf7f5 Fix for NPE when the assigned expression is synthetic at the end of the unit. 
R=brianwilkerson@google.com

Change-Id: I6c221481fa0b8338847f6fb0d605c45c17a55fe3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/150841
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-06-11 16:50:51 +00:00
Konstantin Shcheglov 42fd487b08 Fix type cast exception in AddExplicitCast. 
Change-Id: If4b3b2d680bf36b77aa60a96ec70d3bc721d1d8b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/150163
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-06-04 22:25:19 +00:00
Konstantin Shcheglov e36f8a6645 Fix NPE in RemoveConst when implicit 'const'. 
Change-Id: I563ce8bc9283ef8e393b68be7fd2dca0a653fb0f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/149890
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-06-04 17:14:17 +00:00
Konstantin Shcheglov 4b9c8db412 Fix cast exception in RemoveUnusedParameter. 
Change-Id: I2905933f3f2aee68505ee7dba1335a87bc8c84a0
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/149888
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-06-04 17:13:57 +00:00
Konstantin Shcheglov e5b2cb0b02 Fix for filtering name argument suggestions for Cider. 
R=brianwilkerson@google.com, keertip@google.com

Bug: https://buganizer.corp.google.com/issues/157673517
Change-Id: If7b39b9986963f5936a77556d5ac528b71d365e6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/149884
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Keerti Parthasarathy <keertip@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-06-04 01:26:10 +00:00
Konstantin Shcheglov 5c0c41cc68 Add CiderCompletionResult.performance 
Change-Id: I5df913afc99fc253282611472dc3ff48b9abb8c8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/149785
Reviewed-by: Keerti Parthasarathy <keertip@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-06-03 04:20:04 +00:00
Brian Wilkerson 76d736e27b Convert more quick fixes to use the producer pattern 
Change-Id: I049b2a79b57c96fe016d6046b6d905f7f71c9efd
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/149600
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2020-06-01 14:32:54 +00:00
Konstantin Shcheglov 89782c96d9 Implement changes to return type verification. 
https://github.com/dart-lang/sdk/issues/41803
https://dart-review.googlesource.com/c/sdk/+/149163
https://github.com/dart-lang/language/pull/989

Change-Id: I13caf53a3e96c7b266dd3b3bf511002addcf83b6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/149373
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2020-05-29 23:09:37 +00:00
Danny Tuppeny 65671edd30 Support publishing errors (diagnostics) for plugins in LSP 
This splits Notification manager into an abstract base (which handles merging plugins notifications) and two concrete subclasses that can broadcast the notifications in the correct format for LSP vs DAS protocols.

Change-Id: I5fa2b643adc7bb46db0f06ddd2c997d8a736cbaa
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/149162
Commit-Queue: Danny Tuppeny <danny@tuppeny.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2020-05-29 17:39:06 +00:00
Brian Wilkerson 1892a00fe5 Fix the RemoveType quick fix to work with final and const (issue 42099) 
Change-Id: I4e933682a821bbe943aacc936a471ed72f9b1d89
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/149361
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2020-05-28 20:49:27 +00:00
Konstantin Shcheglov 571f564eda Rewrite TypeName to ConstructorName in one place, consolidate error reporting. 
Change-Id: I5ea1369d65c5eb47e920f68806d28f34931d372e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/148983
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-05-26 21:32:22 +00:00
Brian Wilkerson 3329b312c5 Convert another set of quick fixes to the producer model 
Change-Id: Ib77901994a186484ec9cbd3496bfa173367304d5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/148982
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2020-05-26 04:28:09 +00:00
Brian Wilkerson 350dd576b1 Add a fix for avoid_unused_constructor_parameters 
Change-Id: I6e7e8c8b93a2e37655689a1bf0193061acc00d67
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/148951
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2020-05-24 16:46:52 +00:00
Brian Wilkerson 3fb5f27d05 Extract and enhance the CREATE_CLASS fix 
The enhancement is that we can now create a const constructor if the
class to be created is being used as an annotation. We could also do
this if the class were being created from a constructor invocation, but
I didn't do that. This also doesn't handle creating a named constructor,
but I don't think it's any worse than before. If you disagree let me
know.

Change-Id: Idcff7bd0ac8def416b141b49b801f6798548405d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/148885
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2020-05-22 18:50:06 +00:00
Konstantin Shcheglov d307e6df88 Fix RemoveTypeAnnotation when used as an assist. 
Change-Id: Ic989ca18634783cf59400423bddb331e88a73400
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/148793
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-05-21 16:40:00 +00:00
Brian Wilkerson 94022c4d76 More improvements to computing context type 
Change-Id: Iefd3802a87d4de8f84d6f5fcf8d380047773a746
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/148513
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2020-05-19 19:52:48 +00:00
Paul Berry c38742cdbc Migration: remove references from analysis_server to nnbd_migration. 
Change-Id: I90b562b8b3e82b770f197d7ef2c4e10ac9f99100
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/148160
Reviewed-by: Janice Collins <jcollins@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
 2020-05-15 16:49:32 +00:00
Konstantin Shcheglov 092ed38a87 Don't use _createFileResolver() where not necessary. 
R=brianwilkerson@google.com, keertip@google.com

Change-Id: I4265e1f32f940c5b83b0c4fe03ff095c68afdbec
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/147363
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-05-09 18:19:29 +00:00
Konstantin Shcheglov 83ce658c6d Remove old compute, rename compute2(). 
R=brianwilkerson@google.com, keertip@google.com

Change-Id: I0ceddd83ae7ca6eac7bd4ddd0034aabb14e703a3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/147381
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Keerti Parthasarathy <keertip@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-05-08 19:02:46 +00:00
Keerti Parthasarathy 485ad3ba4c Add prefix start information for completions 
Change-Id: Ia03503937c50695067e088114e2ed9aa3599eb4d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/147280
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Keerti Parthasarathy <keertip@google.com>
 2020-05-08 15:16:19 +00:00
Brian Wilkerson 9eff98594f Cleanup unnecessary references to experiments that are enabled by default 
There's a good chance that I missed some references, but this should
clean up a significant number of them.

Change-Id: Ib0c93d2505d850903315c93979eca40244ab1585
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/147048
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2020-05-07 18:42:48 +00:00
Paul Berry 8061d2d6cc Migration: add support for a machine-readable summary of migration results. 
Change-Id: Id41bc9869448dd4ed63286cab814bf7687baaaad
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/146620
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
 2020-05-05 17:35:22 +00:00
Brian Wilkerson 5528d8daac Add a fix to add the required keyword 
Change-Id: I2602ab5b4d3b47d3d8e302aa60847b791768481a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/145200
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2020-04-28 20:04:22 +00:00