Srujan Gaddam
b5470ae013
[dart:html] Modify scripts to always use NNBD
...
Since the sdk has been unforked, scripts should be updated to
generate files by always using NNBD. As such, nnbd_src has been
moved to src and the old src has been deleted. This does not address
the nnbd tokens e.g. $NULLABLE. That will be done in a future CL.
Change-Id: I00bead16a9d19569b07ad0601f581fc14400fdce
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/151864
Reviewed-by: Sigmund Cherem <sigmund@google.com >
Commit-Queue: Srujan Gaddam <srujzs@google.com >
2020-06-23 23:17:35 +00:00
Srujan Gaddam
a39a3cd141
[dart:html] Add rename/metadata for some attributes
...
Some fields that were changed to native getters/setters should include
renaming/metadata whenever possible to account for name differences.
While this is already the case with most fields, this CL adds it to
some places that missed it. Annotations for
AnimationEffectTiming.duration are changed to be accurate as well.
Change-Id: Idb8b94a9b916086d127753f868e97f1a1b9db53f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/148464
Reviewed-by: Stephen Adams <sra@google.com >
Commit-Queue: Srujan Gaddam <srujzs@google.com >
2020-06-12 00:52:46 +00:00
Srujan Gaddam
c10b8dc5b2
[dart:html] Use JS name for promise call
...
Generated code uses the html_name, which could be a Dart rename,
in the JS call instead of the JS name associated with it.
Change-Id: I7362abf0e089705be5e532b5281f326305c96246
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/148180
Reviewed-by: Stephen Adams <sra@google.com >
Commit-Queue: Srujan Gaddam <srujzs@google.com >
2020-05-19 19:47:38 +00:00
Srujan Gaddam
aa018d90f3
[dart:html] Add back static attributes to getters/setters
...
Closes https://github.com/dart-lang/sdk/issues/41911
Fields were translated to native getters/setters, but static attributes
did not maintain their static modifier. This fixes that.
Change-Id: I52b75ecbf40c4f39d301c6aaedd2492ce7deae5a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/148239
Reviewed-by: Sigmund Cherem <sigmund@google.com >
Commit-Queue: Srujan Gaddam <srujzs@google.com >
2020-05-16 01:00:32 +00:00
Srujan Gaddam
2bd4858d40
[dart:html] Use TreatNullAs attribute in nullability
...
Closes https://github.com/dart-lang/sdk/issues/41419
Uses the external attribute TreatNullAs to allow nullable setters
and parameters.
Change-Id: I5182ac6dcfdcf78e84f204079a782aebbf128a78
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/143185
Reviewed-by: Sigmund Cherem <sigmund@google.com >
2020-04-14 00:37:41 +00:00
Srujan Gaddam
80f84e1942
Change all fields to native getters/setters
...
Bug: https://github.com/dart-lang/sdk/issues/40772
Attributes are translated to native getters and setters regardless of
NNBD. Some logic was removed for fields that no longer apply due to this
change.
Change-Id: Ia1a05778ff8c6f082506a1c95a3057a7c5f7f896
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/136880
Reviewed-by: Stephen Adams <sra@google.com >
2020-02-29 01:29:35 +00:00
Srujan Gaddam
3ec6ec2a2d
Change getters/setters to native for nnbd
...
NNBD fields that were non-nullable or final were transformed to getters
so that they were compilable. They need to be transformed to natives now
for performance.
Change-Id: Ice0082f9468c542098a6d12083a826438d15eba4
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/135860
Reviewed-by: Stephen Adams <sra@google.com >
2020-02-29 01:29:35 +00:00
Srujan Gaddam
e7ee11a95b
Fix input and output for conversions
...
Fixes tests lib_2/html/event_customerevent_test
co19_2/LibtTest/html/Document/window_A01_t01
JS inline incorrectly uses the converted html name for attributes for
getters. Similarly, dynamics do not need to be marked as nullable as
they are already nullable. This also fixes some of the nullability logic
for conversion input and output.
Change-Id: I77efde95a4e5d52461b3412f8650578e967ca5cd
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/135201
Reviewed-by: Sigmund Cherem <sigmund@google.com >
Commit-Queue: Srujan Gaddam <srujzs@google.com >
2020-02-11 00:27:05 +00:00
Srujan Gaddam
9af1ffc558
Don't generate getters/setters for read only promises
...
Bug: https://github.com/dart-lang/sdk/issues/40530
For attributes that return promises and are read only, we
use promiseToFuture casts that should be maintained.
Change-Id: I02e23fc9c47321ced64a152c245cbdccd7337033
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/134902
Reviewed-by: Sigmund Cherem <sigmund@google.com >
Commit-Queue: Srujan Gaddam <srujzs@google.com >
2020-02-10 18:55:35 +00:00
Srujan Gaddam
dae60008ab
DOM script changes to handle nnbd
...
-Adds field for type nullability for IDL operations
-Adds field for conversions to reflect input and output type nullability
--based on implementation
-Corrects generic object types to include nullability
-Changes 'any' types to dynamics
-Adds nullability to types in various operations
-Converts finals and non-initialized non-nullable fields to getters and
setters
--TODO: convert these to native instead of JS inline
-Modifies nullability for annotations and removes annotations from
setters
Change-Id: Iab19830fd1d7f37b170a4da8672f922c3f9b0863
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/132967
Commit-Queue: Srujan Gaddam <srujzs@google.com >
Reviewed-by: Sigmund Cherem <sigmund@google.com >
2020-02-07 01:05:14 +00:00
Srujan Gaddam
3776313e65
Change dart:html templates to generate null-safe code
...
Introduces NULLASSERT token and NNBD condition to allow code to
conditionally compile with NNBD.
Change-Id: Ib71e439f32c793e69b66c328cd7c9900358d886e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/134045
Commit-Queue: Srujan Gaddam <srujzs@google.com >
Reviewed-by: Sigmund Cherem <sigmund@google.com >
2020-02-06 23:18:24 +00:00
Srujan Gaddam
151dc015c0
Add $#NAME syntax to emitter to allow subtemplates
...
NNBD will require explicit casts in various locations in the dart:html
libraries. To avoid taking on this overhead in the pre-nnbd dart:html
library, syntax is introduced in the emitter to allow tokens with
arguments.
Test: emitter_test.py
Change-Id: Ie6de714f491e0cda654f33ee389a91b765cacc9b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/133333
Reviewed-by: Stephen Adams <sra@google.com >
2020-01-29 22:22:50 +00:00
Srujan Gaddam
7db61c6b01
Changing the dart:html generator scripts to generate null-safe/nnbd code
...
Change-Id: I4a8b097b126864366076b1e73cf3e0296600380e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/128376
Reviewed-by: Sigmund Cherem <sigmund@google.com >
Commit-Queue: Srujan Gaddam <srujzs@google.com >
2020-01-29 00:20:42 +00:00
Srujan Gaddam
a865b9c379
Change Future lists to use dynamic
...
Bug: https://github.com/dart-lang/sdk/issues/39627
Lists in a future should be typed with dynamic since they come from JS
interop.
Change-Id: I93d4da16eb27c3af23820a170cfad7cc5c3b4472
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/128368
Reviewed-by: Sigmund Cherem <sigmund@google.com >
Commit-Queue: Srujan Gaddam <srujzs@google.com >
2019-12-14 00:23:54 +00:00
Srujan Gaddam
b84d6ba0f8
Change type MediaDeviceInfo to dynamic in Future
...
Bug: https://github.com/dart-lang/sdk/issues/39627
Lists in a future should be typed with dynamic since they come from JS
interop.
Results from running tools/dom/scripts/go.sh
Change-Id: I4ed37d6f5fa570beef71652dcad17c3bcf7560ab
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/128300
Reviewed-by: Sigmund Cherem <sigmund@google.com >
Commit-Queue: Srujan Gaddam <srujzs@google.com >
2019-12-13 22:17:11 +00:00
Sigmund Cherem
16bc1806ea
(html) remove type parameter from callback argument
...
This was a case missed when fixing #33891 , and fixes #36798
Change-Id: I96e177a7d8020635e191d829afdec45f888658a9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/127500
Reviewed-by: Alan Knight <alanknight@google.com >
Reviewed-by: Sigmund Cherem <sigmund@google.com >
Commit-Queue: Sigmund Cherem <sigmund@google.com >
2019-12-06 19:02:02 +00:00
Nate Bosch
55f81f2210
Mass format python with yapf
...
- Add `.style.yapf` with configuration to use Google style.
- Run `yapf` on all `.py` files in this repo.
- Manually fix one trailing space in a doc string.
- Run `git cl format runtime` to satisfy presubmit.
Change-Id: I7e6bd11e91f07926b9188362599af398551eed79
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/111600
Commit-Queue: Nate Bosch <nbosch@google.com >
Reviewed-by: Alexander Thomas <athom@google.com >
2019-08-05 20:34:31 +00:00
Terry Lucas
490421d166
Fixed Service Workers and any Promise/Future API with a Dictionary parameter.
...
APIs in dart:html (that take a Dictionary) will receive a Dart Map parameter. The Map parameter
must be converted to a Dictionary before passing to the browser's API. Before this change,
any Promise/Future API with a Map/Dictionary parameter never called the Promise and didn't
return a Dart Future - now it does.
This caused a number of breaks especially in Service Workers (register, etc.). Here is a
complete list of the fixed APIs:
BackgroundFetchManager
Future<BackgroundFetchRegistration> fetch(String id, Object requests, [Map options])
CacheStorage
Future match(/*RequestInfo*/ request, [Map options])
CanMakePayment
Future<List<Client>> matchAll([Map options])
CookieStore
Future getAll([Map options])
Future set(String name, String value, [Map options])
CredentialsContainer
Future get([Map options])
Future create([Map options])
DirectoryEntry
Future<Entry> _getDirectory(String path, {Map options})
Future<Entry> _getFile(String path, {Map options})
ImageCapture
Future setOptions(Map photoSettings)
MediaCapabilities
Future<MediaCapabilitiesInfo> decodingInfo(Map configuration)
Future<MediaCapabilitiesInfo> encodingInfo(Map configuration)
MediaStreamTrack
Future applyConstraints([Map constraints])
Navigator
Future requestKeyboardLock([List<String> keyCodes])
Future requestMidiAccess([Map options])
Future share([Map data])
OffscreenCanvas
Future<Blob> convertToBlob([Map options])
PaymentInstruments
Future set(String instrumentKey, Map details)
Permissions
Future<PermissionStatus> query(Map permission)
Future<PermissionStatus> request(Map permissions)
Future<PermissionStatus> revoke(Map permission)
PushManager
Future permissionState([Map options])
Future<PushSubscription> subscribe([Map options])
RtcPeerConnection
REMOVED: Future createAnswer([options_OR_successCallback,
RtcPeerConnectionErrorCallback failureCallback,
Map mediaConstraints])
REMOVED: Future createOffer([options_OR_successCallback,
RtcPeerConnectionErrorCallback failureCallback,
Map rtcOfferOptions])
REMOVED: Future setLocalDescription(Map description, VoidCallback successCallback,
[RtcPeerConnectionErrorCallback failureCallback])
REMOVED: Future setLocalDescription(Map description, VoidCallback successCallback,
[RtcPeerConnectionErrorCallback failureCallback])
Future<RtcSessionDescription> createAnswer([Map options])
Future<RtcSessionDescription> createOffer([Map options])
Future setLocalDescription(Map description)
Future setRemoteDescription(Map description)
ServiceWorkerContainer
Future<ServiceWorkerRegistration> register(String url, [Map options])
ServiceWorkerRegistration
Future<List<Notification>> getNotifications([Map filter])
Future showNotification(String title, [Map options])
VRDevice
Future requestSession([Map options])
Future supportsSession([Map options])
VRSession
Future requestFrameOfReference(String type, [Map options])
Window
Future fetch(/*RequestInfo*/ input, [Map init])
WorkerGlobalScope
Future fetch(/*RequestInfo*/ input, [Map init])
In addition, exposed Service Worker "self" as a static getter named "instance". The
instance is exposed on four different Service Worker classes and can throw a InstanceTypeError
if the instance isn't of the class expected (WorkerGlobalScope.instance will always work
and not throw):
* SharedWorkerGlobalScope.instance
* DedicatedWorkerGlobalScope.instance
* ServiceWorkerGlobalScope.instance
* WorkerGlobalScope.instance
R=vsm@google.com
Bug: #34202
Change-Id: I641ccbff7cc771465dd32c73db20eba5d6667939
Reviewed-on: https://dart-review.googlesource.com/c/74482
Commit-Queue: Terry Lucas <terry@google.com >
Reviewed-by: Vijay Menon <vsm@google.com >
Reviewed-by: Jenny Messerly <jmesserly@google.com >
2018-10-14 22:48:33 +00:00
Terry Lucas
7b77fa217b
Fixed callbacks typedef to be List instead of a generic typed List.
...
Fixed getLegacyStats - shouldn't have a JSName annotation.
Fixes #33891
R=sigmund@google.com
Change-Id: Ie9761ad4f3c69fc875cdb1f0d096f48d1528671b
Reviewed-on: https://dart-review.googlesource.com/66400
Reviewed-by: Sigmund Cherem <sigmund@google.com >
Commit-Queue: Terry Lucas <terry@google.com >
2018-07-24 19:14:08 +00:00
Terry Lucas
6d25212302
getStats Future should be strongly typed.
...
TBR=kevmoo@google.com
Change-Id: I4c4a6376f84b346e676245e5984136adfe3074aa
Reviewed-on: https://dart-review.googlesource.com/62128
Commit-Queue: Terry Lucas <terry@google.com >
Reviewed-by: Terry Lucas <terry@google.com >
2018-06-25 19:25:04 +00:00
Terry Lucas
dd8988c9b2
- Moved all WebGL rendering/drawing constants to synthesized class WebGL.
...
- Removed obsolete Dartium/_blink code.
R=kevmoo@google.com
Change-Id: I81a6f0d5bfe33592ff8ae9c85db9266e898c2861
Reviewed-on: https://dart-review.googlesource.com/60380
Commit-Queue: Terry Lucas <terry@google.com >
Reviewed-by: Kevin Moore <kevmoo@google.com >
2018-06-15 17:08:54 +00:00
Terry Lucas
f479435bca
- Removed custom handling of fill - it was wrong the method is now overloaded.
...
- Associate the JS class SpeechSyntesisVoice with the correct Dart class (DDC).
- Top-level querySelectorAll wasn't generic.
- Handle "static" for attributes in the IDLs.
Fixes #33147
Fixes #33178
Fixes #31886
Fixes #20585
R=vsm@google.com
Change-Id: Ic75a2bfc66670b72342269be259408b610547dab
Reviewed-on: https://dart-review.googlesource.com/59240
Commit-Queue: Terry Lucas <terry@google.com >
Reviewed-by: Vijay Menon <vsm@google.com >
2018-06-15 02:25:13 +00:00
Terry Lucas
eea2dff20d
Added support for members of type Promise.
...
Fixes #31046
R=sra@google.com
Change-Id: Id1e8d415b91a842bd8e2f50c6064c24aaaed9d98
Reviewed-on: https://dart-review.googlesource.com/59460
Reviewed-by: Stephen Adams <sra@google.com >
Commit-Queue: Terry Lucas <terry@google.com >
2018-06-13 18:20:53 +00:00
Terry Lucas
5ec940a2e0
Updated to expose APIs promiseToFuture calls for users.
...
Fixes #33226
R=kevmoo@google.com , sra@google.com
Change-Id: I04995b33e9445d0fcef8d874315f14fd272018d1
Reviewed-on: https://dart-review.googlesource.com/57482
Commit-Queue: Terry Lucas <terry@google.com >
Reviewed-by: Stephen Adams <sra@google.com >
2018-06-07 01:40:22 +00:00
Terry Lucas
cf87b84f7d
Support Promise to Future for both DDC and dart2js.
...
APIs in the newer Chrome IDLs support more JS style promises. The Dart web libraries now hookup those promises and return a Dart Future.
Additionally, a new type maplike is exposed in the IDL this is exposed too.
Change-Id: I44175877eb95f4d910586d42c0139fb182483f82
Reviewed-on: https://dart-review.googlesource.com/49800
Commit-Queue: Terry Lucas <terry@google.com >
Reviewed-by: Stephen Adams <sra@google.com >
2018-05-23 04:08:14 +00:00
Terry Lucas
ef6273cba0
Dart Web Libraries re-generated based on Chrome 63 WebIDLs.
...
This is a migration of 13 Chrome release about 1.5 years of Chrome releases.
Update PYTHON scripts for cleaner and easier rolling.
Here's a doc on the changes that might affect Dart users:
https://docs.google.com/document/d/1Kj0nk3SueO3JKub8im7z3znu9j5oiI7vf49ejZrMxuE/edit#
Change-Id: I768fbd09b04fe6884af36ac102d5813f67bae426
Reviewed-on: https://dart-review.googlesource.com/24501
Commit-Queue: Terry Lucas <terry@google.com >
Reviewed-by: Terry Lucas <terry@google.com >
2018-03-18 09:41:04 +00:00
Terry Lucas
d7a8aa155f
Fixed a number of File API methods in DDC.
...
R=vsm@google.com
Change-Id: I77881201f1e89f731476655476eb865e10d581a1
Reviewed-on: https://dart-review.googlesource.com/38164
Commit-Queue: Terry Lucas <terry@google.com >
Reviewed-by: Vijay Menon <vsm@google.com >
2018-02-05 22:29:00 +00:00
Stephen Adams
f3734a9fc5
dom: Recognize __getter__ indexers
...
BUG=
R=alanknight@google.com
Review-Url: https://codereview.chromium.org/2879663002 .
2017-05-11 13:59:41 -07:00
Terry Lucas
f27144d7b5
Roll 50: Updated for push to origin/master.
...
TBR=jacobr@google.com
Review-Url: https://codereview.chromium.org/2875773003 .
2017-05-10 18:16:51 -07:00
Stephen Adams
ea2c9cba39
dart2js_html: Fix for issue 29538 - some returned lists may be null
...
Annotate querySelectorAll as not-null to recover code quality.
R=sigmund@google.com
Review-Url: https://codereview.chromium.org/2857143003 .
2017-05-03 14:26:38 -07:00
Stephen Adams
14c7c3c556
Redo "Refined types for most HtmlElement factory constructors"
...
Fix: ShadowElement is not always present.
Original:
Committed: https://github.com/dart-lang/sdk/commit/b7b12b564a3e1811ccfca3e28fe30dde685f6633
Reverted: https://github.com/dart-lang/sdk/commit/963df1e3e1a3bac0013d191d2b02898bbebefa9d
BUG=
Review-Url: https://codereview.chromium.org/2718713003 .
2017-02-24 14:28:58 -08:00
Stephen Adams
963df1e3e1
Revert "Refined types for most HtmlElement factory constructors"
...
Need to fix ShadowElement
TBR=alanknight@google.com
Review-Url: https://codereview.chromium.org/2710323004 .
2017-02-24 14:15:37 -08:00
Stephen Adams
b7b12b564a
Refined types for most HtmlElement factory constructors
...
The body of new DivElement() is marked as returning a DivElement, instead of inferred to return Element.
The more precise receiver type allows svg polyfills to be excluded, allowsing the HtmlElement methods to be identified as the single target and inlined.
This tends to improve the code generated for idioms like
new DivElement()..classes.add('foo')
var e1 = new DivElement();
e1.children.add(e2);
BUG=
R=alanknight@google.com
Review-Url: https://codereview.chromium.org/2705213003 .
2017-02-24 11:23:06 -08:00
Alan Knight
de05077537
Revert "Add Selection.toString() calling the native method"
...
This reverts commit 01e6e00499 .
BUG=
Review URL: https://codereview.chromium.org/2678593002 .
2017-02-03 17:02:06 -08:00
Alan Knight
01e6e00499
Add Selection.toString() calling the native method
...
BUG=
R=terry@google.com
Review URL: https://codereview.chromium.org/2669103003 .
2017-02-03 10:24:18 -08:00
Harry Terkelsen
1d749a2fec
record that Gamepad.buttons creates GamepadButtons
...
This also extends the html generator to be able to generate List implementations with nullable element types
Fixes https://github.com/dart-lang/sdk/issues/27073
R=sra@google.com , terry@google.com
Review URL: https://codereview.chromium.org/2242203002 .
2016-08-16 13:56:32 -07:00
Jacob Richman
f26e522f84
Strip unused functionality from dart:html and fix strong mode errors. Switch from blacklisting pure interfaces to determining pure interfaces from the idl and whitelisting impure interfaces we need for dart2js.
...
BUG=
R=alanknight@google.com
Review URL: https://codereview.chromium.org/1987073002 .
2016-05-18 12:49:09 -07:00
Jacob Richman
819ed4bb60
Fix strong mode errors in SVG
...
BUG=
R=alanknight@google.com
Review URL: https://codereview.chromium.org/1903893003 .
2016-04-21 12:45:08 -07:00
Jacob Richman
864b64fd5e
Strong html
...
BUG=
R=alanknight@google.com
Review URL: https://codereview.chromium.org/1894713002 .
2016-04-19 15:08:45 -07:00
Alan Knight
a718c8dac9
Fix a few strong mode errors in dart:html
...
BUG=
R=jacobr@google.com
Committed: https://github.com/dart-lang/sdk/commit/65fe0a5383c7d09efb1dd958a7a30ec5c4d1c847
Review URL: https://codereview.chromium.org/1876363006 .
2016-04-13 15:13:31 -07:00
Alan Knight
3fd7e32b65
Revert "Fix a few strong mode errors in dart:html"
...
This reverts commit 65fe0a5383 .
BUG=
Review URL: https://codereview.chromium.org/1879253004 .
2016-04-13 14:56:42 -07:00
Alan Knight
65fe0a5383
Fix a few strong mode errors in dart:html
...
BUG=
R=jacobr@google.com
Review URL: https://codereview.chromium.org/1876363006 .
2016-04-13 14:41:10 -07:00
Jacob Richman
c65854d2e4
Optimize dartium dart:html bindings so real world application performance is acceptable. Improves dart:html performance by 2X-30X for microbenchmarks. Real world improvement is typically 2X-3X.
...
BUG=
Review URL: https://codereview.chromium.org/1832713002 .
2016-03-29 18:32:52 -07:00
Alan Knight
051451d7e6
Trying to fix SQLResultSetRowList's subscript operator to do type conversion
...
BUG=
Review URL: https://codereview.chromium.org/1779023002 .
2016-03-09 14:02:30 -08:00
Terry Lucas
e1a33e9981
Moved ChromiumSubscribeUniform to web_gl
...
Fixed to return null if dictionary returned form blink is null
Cleanup up logging/error reporting
TBR=alanknight@google.com ,jacobr@google.com
Committed: https://github.com/dart-lang/sdk/commit/01f6e4ed0f8882001e5a308cc8e36dcb62e9b5bc
Review URL: https://codereview.chromium.org/1752983003 .
2016-03-02 08:15:45 -08:00
Terry Lucas
a3350d9b06
Generation of sdk/lib files from 45 roll
...
TBR=alanknight@google.com ,jacobr@google.com
Review URL: https://codereview.chromium.org/1720743005 .
2016-02-22 10:59:12 -08:00
Jacob Richman
cf7ae2e0cb
Support JS$ prefix for dart and fix bug where _operator_getter and the [] operator were used inconsistently. Would only impact future use cases where js APIs returned types not auto-proxied with dart:html.
...
Support typed JS interop classes that extend the behavior of dart:html types in Dartium.
This theoretically enables supporting package:dom at the same time as dart:html as well as helping with
JavaScript libraries that monkey patch the dom.
Also support JS$ name prefix to resolve name conflicts with dart reserved words and with
dart:html libraries.
Cleanup addEventListener and friends so they are consistent with typed JS Interop and fix
bugs in the unlikely case where multiple functions have the same identity hash.
Add checks to make it easier to catch when allowInterop is accidentally omitted
when using the new typed JavaScript interop. You will now get an exception
any time you pass a Function to JS via the new typed interop without first
calling allowInterop.
BUG=
R=alanknight@google.com
Review URL: https://codereview.chromium.org/1583773003 .
2016-01-15 10:40:32 -08:00
Kevin Moore
156bc53866
Hide implementation members in dart:html, dart:js and related libraries
...
Closes https://github.com/dart-lang/sdk/issues/24602
R=alanknight@google.com , jacobr@google.com , terry@google.com
Review URL: https://codereview.chromium.org/1416043008 .
2015-11-02 13:23:22 -05:00
Alan Knight
8831fb876e
Deprecate new internal Dartium/JsInterop APIs that are public
...
BUG=
Review URL: https://codereview.chromium.org/1428593002 .
2015-10-27 10:55:12 -07:00
Alan Knight
c92a2450b4
Switch dart:html objects not to be NativeFieldWrapper subclasses with JsInterop
...
BUG=
Review URL: https://codereview.chromium.org/1392723003 .
2015-10-07 17:42:39 -07:00