dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 3 Packages Projects Releases Wiki Activity
73,765 Commits 2 Branches 0 Tags
718df630eaec0099cd8d9c8f2fb8477fd851d343
Commit Graph

3989 Commits

Author SHA1 Message Date
Konstantin Shcheglov 616ed353a2 Rename / deprecate FileResolver methods. 
R=keertip@google.com

Change-Id: I684465db327f5f448a95f57a18cf65e172c09b01
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/152603
Reviewed-by: Keerti Parthasarathy <keertip@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-06-25 20:59:32 +00:00
Danny Tuppeny 87d431e8de Improve flutter wrap assists when caret is at the offset of an argument list 
Bug: https://github.com/Dart-Code/Dart-Code/issues/2492
Change-Id: I296f9396b3eedcbd1a63f272ed34c65f9d95d83b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/152521
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Danny Tuppeny <danny@tuppeny.com>
 2020-06-25 17:17:12 +00:00
Danny Tuppeny d619edf7ae Avoid using a visitor to find the identifier of a completion target 
Change-Id: I94a3515912b373cd201a7d110382d126420bc67e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/152520
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Danny Tuppeny <danny@tuppeny.com>
 2020-06-25 17:02:02 +00:00
Konstantin Shcheglov 52d16dfbba Resolve only relevant portion of the file for Cider completion. 
R=brianwilkerson@google.com, keertip@google.com

Change-Id: Icf23a79f25baf309f88b737ac061a10a655d2f7f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/152407
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2020-06-25 01:02:41 +00:00
Konstantin Shcheglov 2ec47ad273 Use ElementKind.ENUM for enums. 
There was a crash internally, caused by the fact that when we have
duplicate name for class and enum, during linking we put them into
different Reference bucket - @class and @enum, and also inside
the class, the reference to its name is the class.

But when we resolve, we check equality of elements using not
references, but locations. So, we need to make sure that their
kinds are also different, so go into different bucket, and so
not equal.

When they are InterfaceType and equal, we would try to match
type arguments against the wrong number of type parameters and crash.

Change-Id: Iee3f8691adac65d4b0395ceec7fc7250f96afa88
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/152404
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-06-25 00:20:31 +00:00
Konstantin Shcheglov 7f824bb02d Check for null in VariableDeclaration context type. 
R=brianwilkerson@google.com

Change-Id: Iabf7b76812cdd9480a71b3a396c9895b33e3c998
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/152181
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-06-23 19:16:23 +00:00
Brian Wilkerson b95538cff1 Generate tables of keyword relevance 
Change-Id: Ic0f07561bd4b4cd81a3b511bac31b0f7b4906319
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/151881
Reviewed-by: Jaime Wren <jwren@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2020-06-23 18:57:03 +00:00
Danny Tuppeny 2d73cb53a1 Filter LSP completion requests when offset is mid-symbol 
Change-Id: I28bf5ddda1d7d6f1177a602d9f2dd3091f35966d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/151847
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Danny Tuppeny <danny@tuppeny.com>
 2020-06-23 11:38:20 +00:00
Brian Wilkerson 32d403b472 Add a fix to insert the keyword late 
Change-Id: I40612fd2710a1189137d8ba676c1b66b4943d677
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/151037
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2020-06-21 17:33:10 +00:00
Brian Wilkerson 52dd48651b Convert the remaining quick assists to use CorrectionProducer 
Change-Id: I0accafaf3f076d99bb265d2e6d8815cf2720a7a2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/151871
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2020-06-21 15:43:42 +00:00
Konstantin Shcheglov 8fd04408f0 Add CiderCompletionComputer.warmUp() 
R=brianwilkerson@google.com, keertip@google.com

Change-Id: I4fce7250d7f7b85ea47bf119ddfd6ef25fb28efe
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/151888
Reviewed-by: Keerti Parthasarathy <keertip@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-06-19 22:59:17 +00:00
Brian Wilkerson 9fcac032b6 Convert more quick assists to be correction producers 
Change-Id: I6cc0343cc9af390923a7d4a66a95e1c15aeb47f8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/151887
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2020-06-19 22:23:47 +00:00
Jaime Wren e12a515be0 Use the new analysis we now have with implied types to included types at locations such as 'var i = ^' for purposes of code completion. 
Change-Id: Ie78a51a5c3c65818bec66496e51716f9406899c0
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/151807
Commit-Queue: Jaime Wren <jwren@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2020-06-19 20:38:28 +00:00
Konstantin Shcheglov 67173ade40 Record performance for analysis operations. 
R=brianwilkerson@google.com, keertip@google.com

Change-Id: Ib85680d37f36c9a34f61b8d215a68ed2bd71f8d2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/151884
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Keerti Parthasarathy <keertip@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-06-19 20:15:35 +00:00
Konstantin Shcheglov 69843a8f04 Record performance with CiderOperationPerformance hierarchy. 
This does not include breakdown for resolution yet.

I wonder if this more general information could replace specialized
CiderCompletionPerformance fields 'resolution', 'suggestions', etc.
WDYT?

R=brianwilkerson@google.com, keertip@google.com

Change-Id: I4685dc2a8de8028ce84cc2640943f45c8cf047e3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/151811
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Keerti Parthasarathy <keertip@google.com>
 2020-06-19 17:33:03 +00:00
Konstantin Shcheglov 71ddad82e4 Disable UriContributor for Cider. 
There are two reasons to disable it.

1. This contributor talks to the file system, and for Cider this
   operation is too slow.

2. It just does not work. We need `SourceFactory` for it, and the
   way we get it is not compatible with the Cider's `AnalysisSession`
   mock.


R=brianwilkerson@google.com, keertip@google.com

Change-Id: I652c4f438dbab2a9fa220878ff09d47c14434cd5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/151806
Reviewed-by: Keerti Parthasarathy <keertip@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-06-18 23:29:03 +00:00
Konstantin Shcheglov 60bb0d3a41 Separate current and to restrict FeatureSet(s) in scanner. 
Bug: https://buganizer.corp.google.com/issues/159207726
Change-Id: I41b4c79590dccd05d8b0fa42d296f00a3c3ee229
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/151620
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2020-06-17 23:32:31 +00:00
Jaime Wren 5944ff823f Context type improvement for code completion, fill in missing functionality and add tests for FieldDeclarations, VariableDeclarations, VariableDeclarationList, and TopLevelVariableDeclarations. 
Change-Id: I7267712f68990b5f55ab64bca2345409e41738b3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/151622
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Jaime Wren <jwren@google.com>
 2020-06-17 20:42:41 +00:00
Danny Tuppeny 7951b21c91 Add folding regions for do/while loop blocks 
Change-Id: I92c5c9392ca6e19e8ca0378beb23100fe0ccd1db
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/151524
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2020-06-17 19:32:50 +00:00
Danny Tuppeny f0e1f32c87 Add support for folding if/else/elseif blocks 
Change-Id: I3cbf1f282ee59c577c6ba912e957f838e827fd3e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/151520
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2020-06-17 19:32:50 +00:00
Danny Tuppeny f36151e2d2 Add ChangeTo/CreateClass fixes for implements/mixin of missing identifiers 
Change-Id: Iac0c512e87aaf5ba183d155e7bffe2a74936d7a1
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/151509
Commit-Queue: Danny Tuppeny <danny@tuppeny.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2020-06-17 15:44:36 +00:00
Brian Wilkerson 094d98a812 Use the context type for available declarations 
Change-Id: I698becd01145dde94505608f99171789a7f39c62
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/151428
Reviewed-by: Jaime Wren <jwren@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2020-06-17 15:43:36 +00:00
Danny Tuppeny 728df5d9ab Fix placement of "final" for late fields with types 
Fixes https://github.com/Dart-Code/Dart-Code/issues/2553.

Change-Id: Ief79c8d5e095c17afc39d83eb231604bcf224ee8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/151511
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Danny Tuppeny <danny@tuppeny.com>
 2020-06-17 14:56:04 +00:00
Mike Fairhurst aa3f7dc4e9 [analysis_server] Fix crash reporting bug, casting exception to a string 
Brian noticed this running unit tests. Who knows how many bug reports we
have missed from this -- we can only hope it is very few.

```
type '_TypeError' is not a subtype of type 'String'

package:analysis_server/src/server/error_notifier.dart 26:7        ErrorNotifier.logException
package:analysis_server/src/analysis_server.dart 266:54            AnalysisServer.handleRequest.<fn>
dart:async/zone.dart 1222:13                                       _rootRunBinary
dart:async/zone.dart 1107:19                                       _CustomZone.runBinary
dart:async/zone.dart 1601:18                                       runZonedGuarded.<fn>
dart:async/zone.dart 751:19                                        _ZoneDelegate.handleUncaughtError
...
```
Change-Id: Ib83dc99a88a1566ead5d59a9f71afc80416eb341
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/151464
Auto-Submit: Mike Fairhurst <mfairhurst@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2020-06-17 07:11:30 +00:00
Jaime Wren 651464c909 Implement the rest of the ArgumentList ASTNode logic in the context type visitor in feature_computer.dart, tests added in feature_computer_test.dart 
Change-Id: I35afea21912a785af427afb317cbff532c29d717
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/151364
Commit-Queue: Jaime Wren <jwren@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2020-06-16 20:51:21 +00:00
Brian Wilkerson c7d9fa996b Clean up some unnecessary code in completion manager 
Change-Id: Ifdbe46f12b82a521aa079db87fd8c1aba9dd165b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/151424
Reviewed-by: Jaime Wren <jwren@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2020-06-16 20:41:01 +00:00
Brian Wilkerson 6d4e7d6830 Fix an exception thrown when a method cannot be resolved because the target type is dynamic 
Change-Id: I0479305057a2f763f68aa61c860ab9785d2ca1b9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/151420
Reviewed-by: Jaime Wren <jwren@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2020-06-16 17:38:30 +00:00
Danny Tuppeny 25f2f7796a Send LSP outlines for all open files 
Change-Id: Icd785376c54965c53bd4ea0cf89ede74a4287981
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/151390
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Danny Tuppeny <danny@tuppeny.com>
 2020-06-16 16:21:50 +00:00
Brian Wilkerson 0d3e77d28e Start converting assists to CorrectionProducer 
Change-Id: Ie2d12ce8c15a75e8db71434d790c32a76a06b13e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/151324
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2020-06-16 00:11:28 +00:00
Jaime Wren 920ddae937 Re-write of the computation of the context type for code completion.  Instead of passing a parent and child node, a parent node with an offset is passed.  The primary purpose of this change was to fix a bug with argument lists which is close to being fixed. 
I will follow up with some additional fixes and tests for map and list literals.

Change-Id: I1a26e8f900dcf13402385a49e8f3538c5d1b39df
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/151030
Commit-Queue: Jaime Wren <jwren@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2020-06-15 18:19:42 +00:00
Danny Tuppeny 25cf204dd2 Prevent duplicate code actions for lines with multiple similar errors 
Change-Id: If1a50f3c651efec9ba68fc7be5e50700cfcdb20b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/151234
Commit-Queue: Danny Tuppeny <danny@tuppeny.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2020-06-15 18:09:02 +00:00
Danny Tuppeny 16ef3ee562 Fix LSP equality checks for lists/maps within unions 
Change-Id: I7ec8b591375dfb4d75f802839b89c1288cd4cfef
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/151236
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2020-06-15 18:09:02 +00:00
Danny Tuppeny 3b243a0c30 Recurse through lists/maps when generating hash codes in LSP types 
Change-Id: I06117fe33c7bfb8553e9930afbf7e3bdc86c6032
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/151230
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2020-06-15 18:09:02 +00:00
Konstantin Shcheglov 48f2d10d3e Deprecate ClassElement.hasReferenceToSuper 
Change-Id: Ie94d8e2b0be6ccb30c7ca59c80da2832cfed3689
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/151168
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-06-15 17:45:06 +00:00
Brian Wilkerson 8d08bbf40a Add a fix for default_list_constructor 
Change-Id: Ia7b9c88cfe9528ddddd68935009736c494e57130
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/151098
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2020-06-13 16:29:35 +00:00
Brian Wilkerson c22dc20a93 Use the const-ness of an element when completing in a const context using available declarations 
Change-Id: Ia950ad81ed571cbcf1f0060da0cba26406206ad1
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/151031
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2020-06-12 22:15:55 +00:00
Brian Wilkerson 9be1160700 Do not suggest the keyword const when completing in a constant context 
While it isn't an error to use `const` in those contexts, it also isn't
necessary and we already omit `new` because it's never required. This
makes `const` more consistent with `new`.

Change-Id: Ia577065d53ab57543b86161f5e62e3947ff9a2a7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/151029
Reviewed-by: Jaime Wren <jwren@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2020-06-12 16:32:40 +00:00
Danny Tuppeny 2f2efeb07a Filter LSP definitions to not include variable names 
Fixes https://github.com/Dart-Code/Dart-Code/issues/2535.

Change-Id: I2e64d0cd53abcde4ac3ecae1682b6b054b16407a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/150980
Commit-Queue: Danny Tuppeny <danny@tuppeny.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2020-06-12 14:38:44 +00:00
Danny Tuppeny 7b12c8e06d Add fixes for extends_non_class 
Bug: https://github.com/Dart-Code/Dart-Code/issues/2536
Change-Id: I5e4fa5a3625016045d86462b941cee3c73a36a04
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/150932
Commit-Queue: Danny Tuppeny <danny@tuppeny.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2020-06-12 14:12:34 +00:00
Danny Tuppeny 44f869d3a6 Cap the amount of time spent waiting for plugin completions in LSP 
Change-Id: Ic60d9936a252a1322becc233d696dfed41af834a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/150927
Commit-Queue: Danny Tuppeny <danny@tuppeny.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2020-06-12 14:11:24 +00:00
Konstantin Shcheglov 67da8cf7f5 Fix for NPE when the assigned expression is synthetic at the end of the unit. 
R=brianwilkerson@google.com

Change-Id: I6c221481fa0b8338847f6fb0d605c45c17a55fe3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/150841
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-06-11 16:50:51 +00:00
Danny Tuppeny 5c3f9217cb Filter LSP completions (fuzzily) by prefix to reduce payload size 
Bug: https://github.com/dart-lang/sdk/issues/42152.
Bug: https://github.com/dart-lang/sdk/issues/40026.
Change-Id: I4c921ddff3224d736c4236861d0ff156f58be595
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/150628
Commit-Queue: Danny Tuppeny <danny@tuppeny.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2020-06-11 14:11:12 +00:00
Brian Wilkerson 01f284c661 Clean up the return type of the contributors compute method 
All of the contributors now contribute through the builder so the return
value was always an empty list.

Change-Id: I9e5746a7c7e2dc256a00c6091f6bf9d46331b617
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/150803
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2020-06-10 19:37:12 +00:00
Jaime Wren 5900da5418 Refactoring and follow-up on the recent change to local_reference_contributor.dart. 
Change-Id: I40dccf84293d09b85879d75ed84a30e141c8dbda
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/150764
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Jaime Wren <jwren@google.com>
 2020-06-10 17:26:17 +00:00
Danny Tuppeny 5f3c799084 Don't return LSP errors when failing to organize imports due to parse errors 
Change-Id: Ia0a6fab160da0a04b4fe81c0968d0f8ad3141c3e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/150631
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Danny Tuppeny <danny@tuppeny.com>
 2020-06-10 16:07:27 +00:00
Danny Tuppeny 2b917f5b6a Separate server/plugin completion results to make it easier to fuzzy-filter server results 
Change-Id: I249d74627a1eb38ed73a61ea4719aa865c645139
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/150627
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Danny Tuppeny <danny@tuppeny.com>
 2020-06-10 15:46:47 +00:00
Jaime Wren abde894da6 Merge the inherited_reference_contributor.dart into the local_reference_contributor.dart contributor. This fixes an outstanding bug in completion inwhich local and inherited methods were recommended in completions instead of local declarations. 
Change-Id: Ie9d2b51b2b25d5537a59f73f23e3f6224190eedf
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/150620
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Jaime Wren <jwren@google.com>
 2020-06-10 14:59:27 +00:00
Keerti Parthasarathy 85eeee228a Expose some more completion timings. 
Change-Id: Id9cb40fd07c350e7de817025e65d0537e19821e1
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/150467
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Keerti Parthasarathy <keertip@google.com>
 2020-06-08 22:02:59 +00:00
Jaime Wren 0c54bb7563 Finish implementing the shouldSuggest(..) logic in the local_reference_contributor.dart contributor, adding tests for each case. 
The next step is to merge the inherited_reference_contributor.dart into this contributor (local_reference_contributor.dart) to prevent getters, setters and methods from being suggested when they are, in fact, shadowed.

Change-Id: I406cc916d69ee87eaa1b516e6f85996464d62cab
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/150460
Commit-Queue: Jaime Wren <jwren@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2020-06-08 21:42:22 +00:00
Brian Wilkerson 87300e9081 Rename getClassDeclaration to getClassOrMixingDeclaration 
Change-Id: Ide9ca130a5141d4a970652c0b9893d389a6a7a6f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/150380
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2020-06-08 16:25:46 +00:00