d1c8aae6d8
[ VM ] Update lib_2/isolate tests to no longer use package:unittest
...
Fixes https://github.com/dart-lang/sdk/issues/40799
Change-Id: Ia65221c2a14b9d8e923e394ebc1c35ea5dad4c6f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/139953
Commit-Queue: Ben Konyi <bkonyi@google.com >
Reviewed-by: Siva Annamalai <asiva@google.com >
2020-03-19 00:57:26 +00:00
5aa86eb123
[vm/concurrency] Run all isolate related tests with/without enabling isolate groups
...
Issue https://github.com/dart-lang/sdk/issues/36097
Change-Id: I0b7eca744bc49ab5ba09da3ce2a9286b1ed3c70f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/126340
Commit-Queue: Martin Kustermann <kustermann@google.com >
Reviewed-by: Alexander Aprelev <aam@google.com >
2019-11-27 17:23:31 +00:00
bdec682558
[Test] Fixes flakiness in spawn_function_test caused by racing.
...
Previously the test would create and run an isolate, then checking the debugName of the isolate.
However, if the isolate ran to completion and got collected before the check happened, the debugName would be null, causing the test to fail.
The test was running at about 1.5% flakiness when run locally before.
With the change no flakiness was observed across several couple hundred runs.
Tested:
tools/test.py -n dartk-optcounter-linux-release-x64 \
lib_2/isolate/spawn_function_test --repeat=1000
Change-Id: I0aea6bbae08fbe321e1bea7301655ad06ec3dcd2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/108410
Reviewed-by: Ben Konyi <bkonyi@google.com >
Reviewed-by: Martin Kustermann <kustermann@google.com >
Commit-Queue: Clement Skau <cskau@google.com >
2019-07-29 10:24:58 +00:00
ac2c934563
Reland "[ VM / dart:isolate ] Added ability to set names for spawned isolates."
...
This reverts commit 638f13ff3dhttps://dart-review.googlesource.com/c/sdk/+/97845
Commit-Queue: Ben Konyi <bkonyi@google.com >
Auto-Submit: Ben Konyi <bkonyi@google.com >
Reviewed-by: Siva Annamalai <asiva@google.com >
2019-03-28 16:39:50 +00:00
638f13ff3d
Revert "[ VM / dart:isolate ] Added ability to set names for spawned isolates."
...
This reverts commit 59525264e8https://github.com/dart-lang/sdk/issues/36232
Original change's description:
> [ VM / dart:isolate ] Added ability to set names for spawned isolates.
>
> Fixes issue #34059
>
> Change-Id: I315498b02edc184e9e408c93eddb78aa1a5a8a1d
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/90341
> Commit-Queue: Ben Konyi <bkonyi@google.com >
> Reviewed-by: Sigmund Cherem <sigmund@google.com >
> Reviewed-by: Ryan Macnak <rmacnak@google.com >
TBR=bkonyi@google.com ,rmacnak@google.com ,asiva@google.com ,sigmund@google.com
Change-Id: I5f2115a2ac394a8d4c7c175bc97f2b88b65fcb49
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/97107
Reviewed-by: Daco Harkes <dacoharkes@google.com >
Commit-Queue: Daco Harkes <dacoharkes@google.com >
2019-03-15 14:40:37 +00:00
59525264e8
[ VM / dart:isolate ] Added ability to set names for spawned isolates.
...
Fixes issue #34059
Change-Id: I315498b02edc184e9e408c93eddb78aa1a5a8a1d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/90341
Commit-Queue: Ben Konyi <bkonyi@google.com >
Reviewed-by: Sigmund Cherem <sigmund@google.com >
Reviewed-by: Ryan Macnak <rmacnak@google.com >
2019-03-14 22:23:09 +00:00
e2f92be5ae
Migrated test block 34 to Dart 2.0.
...
Bug:
Change-Id: Ib2e0effabc354b5864f59b0de6611381d7dfd0df
Reviewed-on: https://dart-review.googlesource.com/11250
Commit-Queue: Ben Konyi <bkonyi@google.com >
Reviewed-by: Bob Nystrom <rnystrom@google.com >
Reviewed-by: Phil Quitslund <pquitslund@google.com >
2017-10-06 22:52:56 +00:00
Ben Konyi