Commit Graph

678 Commits

Author SHA1 Message Date
scheglov@google.com 6fffdf490a Issue 5148. Error on abstract method in concrete class needs to be a warning
http://code.google.com/p/dart/issues/detail?id=5148

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//10914318

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12445 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-17 17:09:27 +00:00
scheglov@google.com d6802247b5 Issue 5082. It is an error if argument to '?' is not a formal parameter
http://code.google.com/p/dart/issues/detail?id=5082

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//10928230

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12438 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-17 15:09:52 +00:00
scheglov@google.com 14cb03ace9 Issue 5044. Keep FieldElement as Element for field access
http://code.google.com/p/dart/issues/detail?id=5044

Move inGetterContext() and inSetterContext() from Elements to ASTNodes.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//10918260

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12434 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-17 13:14:51 +00:00
scheglov@google.com 8184329d8b Issue 5075. Remove support for 'negate' and 'equals' operators
http://code.google.com/p/dart/issues/detail?id=5075

R=messick@google.com
BUG=

Review URL: https://codereview.chromium.org//10910279

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12393 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-14 17:38:40 +00:00
scheglov@google.com a2395ed946 Issue 5084. Report error if a type name appears multiple times in an implements clause
http://code.google.com/p/dart/issues/detail?id=5084

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//10918247

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12391 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-14 15:55:31 +00:00
scheglov@google.com b388161d1f Issue 3476. Final variables don't have to have constant initializers
http://code.google.com/p/dart/issues/detail?id=3476

R=jwren@google.com
BUG=

Review URL: https://codereview.chromium.org//10919290

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12382 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-14 13:04:19 +00:00
scheglov@google.com ea65bbb961 Issue 3553. Stop treating static final variables as constants
http://code.google.com/p/dart/issues/detail?id=3553
http://code.google.com/p/dart/issues/detail?id=3476

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//10907215

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12336 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-13 15:49:07 +00:00
brianwilkerson@google.com cd57835f8f Add built-in identifiers 'library', 'import', 'export' and 'part' (issue 5120)
Review URL: https://codereview.chromium.org//10919266

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12335 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-13 15:27:51 +00:00
scheglov@google.com fba2c23084 New 'Clean Up' to convert old optional parameters to the new optional named where possible.
R=brianwilkerson@google.com
BUG=

Review URL: https://chromiumcodereview.appspot.com//10916268

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12282 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-12 20:57:10 +00:00
pquitslund@google.com 63476bc781 Merge of DartAstUtilities into DartNodes (and push into compiler.js).
Review URL: https://codereview.chromium.org//10905241

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12277 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-12 18:44:35 +00:00
keertip@google.com a8e4699571 show category information for sdk libs
Review URL: https://chromiumcodereview.appspot.com//10911221

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12267 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-12 15:45:51 +00:00
scheglov@google.com c317d33753 Issue 5049. Consistently resolve instance/static/top-level property access
print(x) = getter
x += 1   = getter
x++      = getter
++x      = getter
x = 1    = setter

R=brianwilkerson@google.com
BUG=

Review URL: https://chromiumcodereview.appspot.com//10914215

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12231 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-12 00:48:06 +00:00
brianwilkerson@google.com 911a8f9e6f Missing file from previous CL
Review URL: https://chromiumcodereview.appspot.com//10919220

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12213 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-11 18:26:09 +00:00
brianwilkerson@google.com 2d80d699b1 Convert throw from a statement to an expression (issue 4872)
Review URL: https://chromiumcodereview.appspot.com//10913197

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12212 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-11 18:21:24 +00:00
brianwilkerson@google.com 6700e32533 Accept raw strings prefixed by 'r' (issue 4815)
Review URL: https://chromiumcodereview.appspot.com//10933024

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12209 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-11 16:39:33 +00:00
scheglov@google.com 753903b60a Issue 5042. Fix for resolving [], []= and [] op=
http://code.google.com/p/dart/issues/detail?id=5042

R=brianwilkerson@google.com
BUG=

Review URL: https://chromiumcodereview.appspot.com//10913187

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12205 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-11 15:17:53 +00:00
scheglov@google.com ed3c755f0d Issue 5044. Make all abstract fields resolve to setter or getter methods.
http://code.google.com/p/dart/issues/detail?id=5044

Also tweaks for be able to navigate (F3) in Editor to corresponding method/function.

R=brianwilkerson@google.com
BUG=

Review URL: https://chromiumcodereview.appspot.com//10919203

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12204 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-11 15:12:01 +00:00
bak@google.com d3b5cfba18 First partial step at removing interfaces in libraries.
- Changes interfaces without default implmenetations to abstract class.
  - Changed final fields in interfaces to getters.
  - Changed dart_analyzer to allow methods with empty bodies in abstract class.
  - Updated the co19 status file since two tests now are passing.
Review URL: https://chromiumcodereview.appspot.com//10917187

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12201 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-11 14:57:09 +00:00
scheglov@google.com 4b35780112 Issue 5055. Visit field getter/setter only once.
http://code.google.com/p/dart/issues/detail?id=5055

R=brianwilkerson@google.com
BUG=

Review URL: https://chromiumcodereview.appspot.com//10910176

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12152 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-11 00:02:29 +00:00
scheglov@google.com b537a1c26e Issue 4752. When convert to getter, remove also ()
I've forgot to do this initially.
Mostly Parser and Core changes.

R=brianwilkerson@google.com
BUG=

Review URL: https://chromiumcodereview.appspot.com//10916211

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12140 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-10 18:27:56 +00:00
scheglov@google.com 06469daca1 Issue 5004. Type inference with 'is!' and 'continue'.
http://code.google.com/p/dart/issues/detail?id=5004

R=brianwilkerson@google.com
BUG=

Review URL: https://chromiumcodereview.appspot.com//10913168

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12123 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-10 15:54:20 +00:00
scheglov@google.com 2cb90be0d9 Don't report 'no such method' if class defines 'noSuchMethod'
R=brianwilkerson@google.com
BUG=

Review URL: https://chromiumcodereview.appspot.com//10915171

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12121 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-10 15:41:16 +00:00
danrubel@google.com 088eb5d136 fix library manager to handle nested dart: libraries
Review URL: https://chromiumcodereview.appspot.com//10907135

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12091 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-09 02:59:30 +00:00
scheglov@google.com 03ccc4df50 Issue 4988. Fixe for 'assert' statement vs function resolving
http://code.google.com/p/dart/issues/detail?id=4988

R=brianwilkerson@google.com
BUG=

Review URL: https://chromiumcodereview.appspot.com//10910142

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12071 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-07 22:09:49 +00:00
danrubel@google.com b950e57ed3 Fix PackageLibraryManager set package directory
Review URL: https://chromiumcodereview.appspot.com//10919160

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12067 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-07 21:16:52 +00:00
keertip@google.com c8950c5fba modify files view to use declared sdk libraries
Review URL: http://codereview.chromium.org//10907096

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12042 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-07 15:34:55 +00:00
scheglov@google.com 93f4f29df1 Support for new 'export' directive in resolver
R=brianwilkerson@google.com
BUG=

Review URL: https://chromiumcodereview.appspot.com//10919133

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@11984 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-06 20:28:44 +00:00
scheglov@google.com 886064fd2b Fix internal exception when assignment happens in initializer
R=brianwilkerson@google.com
BUG=

Review URL: https://chromiumcodereview.appspot.com//10928033

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@11967 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-06 16:57:58 +00:00
brianwilkerson@google.com 35dc358c56 Parser changes to support new export directive
Review URL: https://chromiumcodereview.appspot.com//10916145

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@11963 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-06 16:16:26 +00:00
scheglov@google.com b8bc1a8ffc Clean ups for trailing whitespace and block style
Also M1 migration for 'operator negate()'.

R=messick@google.com
BUG=

Review URL: https://chromiumcodereview.appspot.com//10913112

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@11957 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-06 15:37:00 +00:00
brianwilkerson@google.com c58f6cb7a3 Use of undefined class in const constructor should be an error (issue 4882)
Review URL: https://chromiumcodereview.appspot.com//10908103

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@11907 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-05 21:40:02 +00:00
brianwilkerson@google.com ba8b6cdb1c Enable use of new metadata in analysis
Review URL: https://chromiumcodereview.appspot.com//10920100

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@11906 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-05 21:31:05 +00:00
scheglov@google.com bd121a0b1d Generate different ErrorCodes for inferred and explicit type problems
R=brianwilkerson@google.com
BUG=

Review URL: https://chromiumcodereview.appspot.com//10907079

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@11903 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-05 21:09:31 +00:00
scheglov@google.com d7e8b5f7c6 Fixing DartC build
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@11899 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-05 19:46:00 +00:00
scheglov@google.com fe31d54e87 Issue 4881. Resolve new == and []+ operators
http://code.google.com/p/dart/issues/detail?id=4881

R=brianwilkerson@google.com
BUG=

Review URL: https://chromiumcodereview.appspot.com//10918073

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@11880 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-05 16:04:26 +00:00
scheglov@google.com 6f8893f9b8 Invocation C.unknownMethod() should produce warning, not error
R=brianwilkerson@google.com
BUG=

Review URL: https://chromiumcodereview.appspot.com//10914099

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@11878 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-05 15:58:18 +00:00
scheglov@google.com 80d0b4e31d Change type of variable using assignment only if it was explicitly not declared
R=brianwilkerson@google.com
BUG=

Review URL: https://chromiumcodereview.appspot.com//10919087

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@11861 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-05 04:23:45 +00:00
scheglov@google.com 32ead8d136 Issue 4903. Better error message when static method attempts to use type variable
http://code.google.com/p/dart/issues/detail?id=4903

R=brianwilkerson@google.com
BUG=

Review URL: https://chromiumcodereview.appspot.com//10911087

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@11860 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-05 03:36:50 +00:00
scheglov@google.com b46094104a Issue 4901. Tweak for dart:core check
http://code.google.com/p/dart/issues/detail?id=4901

R=brianwilkerson@google.com
BUG=

Review URL: https://chromiumcodereview.appspot.com//10909076

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@11859 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-05 03:35:51 +00:00
scheglov@google.com 5a2e60732c Issue 4900. Fix for for-in cycle and field as identifier
http://code.google.com/p/dart/issues/detail?id=4900

R=brianwilkerson@google.com
BUG=

Review URL: https://chromiumcodereview.appspot.com//10910081

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@11857 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-05 01:44:37 +00:00
brianwilkerson@google.com c8d748d65a Fix for issue 4835
Review URL: https://chromiumcodereview.appspot.com//10915071

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@11847 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-04 22:19:05 +00:00
keertip@google.com fd8de0e51c load sdk libraries defined in libraries.dart
Review URL: http://codereview.chromium.org//10916099

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@11838 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-04 19:38:12 +00:00
brianwilkerson@google.com efaa2a1d4b Old catch syntax is now an error (issue 4905)
Review URL: https://chromiumcodereview.appspot.com//10913068

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@11834 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-04 18:11:19 +00:00
scheglov@google.com eefab68628 Issue 4849. Disabling using inferred types for warnings should also disable invocation argument types checks
http://code.google.com/p/dart/issues/detail?id=4849

R=brianwilkerson@google.com
BUG=

Review URL: https://chromiumcodereview.appspot.com//10913033

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@11707 260f80e4-7a28-3924-810f-c04153c831b5
2012-08-31 18:04:37 +00:00
scheglov@google.com d1413bb2f1 Issue 4796. Support for renaming named parameters in invocations
http://code.google.com/p/dart/issues/detail?id=4796

R=brianwilkerson@google.com
BUG=

Review URL: https://chromiumcodereview.appspot.com//10915031

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@11689 260f80e4-7a28-3924-810f-c04153c831b5
2012-08-31 15:25:00 +00:00
pquitslund@google.com 61a86f50cb Typo fix in resolver error code (asbstract -> abstract).
Review URL: https://chromiumcodereview.appspot.com//10905037

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@11686 260f80e4-7a28-3924-810f-c04153c831b5
2012-08-31 14:51:57 +00:00
brianwilkerson@google.com 3c3badd039 Accept types rather than identifiers in catch clauses (Issue 4840)
Review URL: https://chromiumcodereview.appspot.com//10913016

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@11660 260f80e4-7a28-3924-810f-c04153c831b5
2012-08-30 21:30:05 +00:00
brianwilkerson@google.com 43c52ef328 Enable warning for old catch syntax
Review URL: https://chromiumcodereview.appspot.com//10911013

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@11640 260f80e4-7a28-3924-810f-c04153c831b5
2012-08-30 18:40:25 +00:00
scheglov@google.com 21edadf633 Issue 4791. Ignore Dynamic (e.g. null) during types intersection
http://code.google.com/p/dart/issues/detail?id=4791

R=brianwilkerson@google.com
BUG=

Review URL: https://chromiumcodereview.appspot.com//10909011

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@11632 260f80e4-7a28-3924-810f-c04153c831b5
2012-08-30 17:35:53 +00:00
brianwilkerson@google.com 65090f7e98 Stop creating a synthetic node so that parent links will be preserved (issue 4833)
Review URL: https://chromiumcodereview.appspot.com//10911009

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@11625 260f80e4-7a28-3924-810f-c04153c831b5
2012-08-30 16:19:27 +00:00