dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
16,802 Commits 2 Branches 0 Tags
6ffa627fd758c73f9d9bee2c2fee84d2db74cec7
Commit Graph

21 Commits

Author SHA1 Message Date
zra@google.com 42add423d2 Fixes javascript integer overflow check. 
R=asiva@google.com

Review URL: https://codereview.chromium.org//21301003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@25675 260f80e4-7a28-3924-810f-c04153c831b5
 2013-07-31 17:51:23 +00:00
asiva@google.com dcb6850f87 Fix for issue 11680 
- implicitly store a full stack trace in Error objects when they are thrown.
- the shlFromInt on Mints and Bigints was trying to allocate a new OutOfMemory
  exception objects instead of using the pre-allocated exception object.
  Made the implementation of these methods native so that they can use the
  pre-allocated object.
- Ensure that it is not possible to allocate new OutOfMemory or StackOverflow
  exception objects.

R=ahe@google.com, srdjan@google.com

Review URL: https://codereview.chromium.org//19106008

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@25492 260f80e4-7a28-3924-810f-c04153c831b5
 2013-07-25 19:28:53 +00:00
rmacnak@google.com 1a0b3c7871 Make reflective invocations raise NoSuchMethodErrors in the cases where non-reflective invocations do so. Resolves issues 11187 and 11957. 
R=asiva@google.com

Review URL: https://codereview.chromium.org//19819003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@25387 260f80e4-7a28-3924-810f-c04153c831b5
 2013-07-24 00:29:17 +00:00
floitsch@google.com 06493c3460 Revert "Introduce StackTraceOnThrowMixin." 
This reverts commit r24951.

R=lrn@google.com

Review URL: https://codereview.chromium.org//19579002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@25142 260f80e4-7a28-3924-810f-c04153c831b5
 2013-07-18 10:39:56 +00:00
floitsch@google.com e5cade9e88 Introduce StackTraceOnThrowMixin. 
R=ahe@google.com, lrn@google.com

Review URL: https://codereview.chromium.org//18259021

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24951 260f80e4-7a28-3924-810f-c04153c831b5
 2013-07-12 15:30:53 +00:00
floitsch@google.com 438767ca3a Add stackTrace to Error object. 
BUG=
R=lrn@google.com

Review URL: https://codereview.chromium.org//18529003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24726 260f80e4-7a28-3924-810f-c04153c831b5
 2013-07-03 14:51:30 +00:00
lrn@google.com 64553c2774 Fix expectation for 53-bit-overflow. 
Make variable in error private.

R=floitsch@google.com

Review URL: https://codereview.chromium.org//17527003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24274 260f80e4-7a28-3924-810f-c04153c831b5
 2013-06-21 09:11:14 +00:00
lrn@google.com 0c90061029 Move FiftythreeBitOverflowError to VM-only patch file. 
The class is not meaningful in the core library, and should go away once
dart2js has integers.

R=floitsch@google.com, srdjan@google.com

Review URL: https://codereview.chromium.org//17361004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24265 260f80e4-7a28-3924-810f-c04153c831b5
 2013-06-21 07:31:48 +00:00
srdjan@google.com 706e79d074 Fix error reporting when calling static methods and closures withh mismatched arguments. 
Closures BEFORE:
----
Unhandled exception:
Class '(dynamic, dynamic, dynamic) => dynamic' has no instance method 'call'.

NoSuchMethodError : method not found: 'call'
Receiver: Closure: (dynamic, dynamic, dynamic, dynamic) => dynamic from Function 'foo':.
Arguments: [2]

Closures NOW:
----
Closure call with mismatched arguments: function 'A.foo'

NoSuchMethodError: incorrect number of arguments passed to method named 'A.foo'
Receiver: Closure: (dynamic, dynamic, dynamic, dynamic) => dynamic from Function 'foo':.
Tried calling: A.foo(2)
Found: A.foo(a, b, c)


Statics BEFORE:
----
Unhandled exception:
No top-level method 'foo' declared.

NoSuchMethodError : method not found: 'foo'
Receiver: Type: class '::'
Arguments: []

Statics NOW:
----
Unhandled exception:
No top-level method 'foo' with matching arguments declared.

NoSuchMethodError: incorrect number of arguments passed to method named 'foo'
Receiver: top-level
Tried calling: foo(...)
Found: foo(a, b, c)

R=regis@google.com

Review URL: https://codereview.chromium.org//14652008

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@22209 260f80e4-7a28-3924-810f-c04153c831b5
 2013-04-30 22:05:14 +00:00
iposva@google.com 2fb7cf7220 - Print "top-level" instead of "class '::'" in 
NoSuchMethodErrors.

Review URL: https://codereview.chromium.org//13982018

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@22005 260f80e4-7a28-3924-810f-c04153c831b5
 2013-04-25 07:29:06 +00:00
lrn@google.com 844cd39fad Change getRange to sublist. Make getRange deprecated. 
This changes the exception behavior of getRange. It used to accept
a length of zero, no matter what start value. Now the start value
must be a valid list index.

Review URL: https://codereview.chromium.org//12817003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@20064 260f80e4-7a28-3924-810f-c04153c831b5
 2013-03-15 09:15:39 +00:00
floitsch@google.com dd48256fe5 Remove deprecated StringBuffer.add, addAll and addCharCode. 
Review URL: https://codereview.chromium.org//12473003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19690 260f80e4-7a28-3924-810f-c04153c831b5
 2013-03-08 13:07:18 +00:00
iposva@google.com c900112af7 - Improve the message for NoSuchMethodErrors that are 
determined statically at compile time.
Review URL: https://codereview.chromium.org//12328019

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@18848 260f80e4-7a28-3924-810f-c04153c831b5
 2013-02-21 18:53:27 +00:00
iposva@google.com f6c5bcec42 - Split the implementation of NoSuchMethodError in preparation for 
better error messages from the VM.
Review URL: https://codereview.chromium.org//12297010

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@18614 260f80e4-7a28-3924-810f-c04153c831b5
 2013-02-18 07:00:53 +00:00
regis@google.com cb27634842 Remove NoSuchMethodErrorImplementation class and use NoSuchMethodError from core 
lib instead.
Review URL: https://codereview.chromium.org//11712002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@16583 260f80e4-7a28-3924-810f-c04153c831b5
 2013-01-02 18:52:28 +00:00
lrn@google.com 3450798a1d Make Exception a class, not an interface, and remove the const constructor. 
We should consider removing the constructor entirely, there is never a good excuse for throwing a non-descript Exception. If you do, it should likely be an Error instead.

Review URL: https://codereview.chromium.org//11369243

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@15077 260f80e4-7a28-3924-810f-c04153c831b5
 2012-11-19 13:23:23 +00:00
regis@google.com ec09038e82 Remove references to ObjectNotClosureException and ClosureArgumentMismatchException 
from the VM (issue 6124).
These are replaced with NoSuchMethodError for now (work in progress).
Review URL: https://codereview.chromium.org//11312019

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@14362 260f80e4-7a28-3924-810f-c04153c831b5
 2012-10-31 18:13:12 +00:00
lrn@google.com bc7f07ae86 Move ObjectNotClosureException and ClosureArgumentMismatchException to patch file. 
They are no longer available in the core library, and are only used by the VM.

Review URL: https://codereview.chromium.org//11233063

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13992 260f80e4-7a28-3924-810f-c04153c831b5
 2012-10-24 06:17:21 +00:00
ahe@google.com 3f1932a563 Handle backslashes and newlines when escaping strings. 
Review URL: https://codereview.chromium.org//10943027

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12568 260f80e4-7a28-3924-810f-c04153c831b5
 2012-09-19 15:43:41 +00:00
ahe@google.com d0f3e48063 Work around for bug 4995 to unbreak VM build. 
Review URL: https://codereview.chromium.org//10947026

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12541 260f80e4-7a28-3924-810f-c04153c831b5
 2012-09-19 09:00:38 +00:00
ahe@google.com 34c503ae73 Don't invoke user-defined code in NoSuchMethodError.toString. 
Review URL: https://codereview.chromium.org//10939020

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12533 260f80e4-7a28-3924-810f-c04153c831b5
 2012-09-19 07:55:50 +00:00