5377cb5c12
[bots] Add vm-aot-dyn-linux-debug-x64 builder configuration
...
Change-Id: I176e2bab919a5f5d3c1f01142dce0f8f8c80fb85
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/380584
Reviewed-by: Alexander Thomas <athom@google.com >
Commit-Queue: Alexander Markov <alexmarkov@google.com >
Reviewed-by: Slava Egorov <vegorov@google.com >
2024-08-19 16:34:26 +00:00
3d8829fad2
Add dart2bytecode snapshot and VM/AOT dynamic modules test configurations
...
Change-Id: I84f8dbc174dbac5a11ca84e248c7aecb3759aaad
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/380283
Reviewed-by: Slava Egorov <vegorov@google.com >
Reviewed-by: Sigmund Cherem <sigmund@google.com >
Commit-Queue: Alexander Markov <alexmarkov@google.com >
2024-08-15 15:28:25 +00:00
8fbca8ba67
[vm] Initial implementation of dynamic modules in the VM/AOT
...
TEST=Manually tested dynamic modules
Change-Id: Icb2616e414167bd1fbd10f01dea64c57dbdeeac7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/380281
Reviewed-by: Slava Egorov <vegorov@google.com >
Commit-Queue: Alexander Markov <alexmarkov@google.com >
2024-08-15 14:09:52 +00:00
570ed43611
[ddc] Turning down unsound testing on canary (6)
...
Stop running co19 suite on the ddc-canary-linux-chrome bot.
Cleanup temporary skips from status file.
These changes are staged across multiple CLs to avoid crashing
the infra when too many tests status changes need to be uploaded
at the same time.
Change-Id: I378954fc0cbb47c0f54edf158b3b7c38744bf0b8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/379525
Reviewed-by: Kevin Moore <kevmoo@google.com >
Commit-Queue: Nicholas Shahan <nshahan@google.com >
2024-08-14 21:31:30 +00:00
ea3cac1e65
[fuchsia] Use Fuchsia API level 22
...
Change-Id: I9c8ba5bb16bc07288384ed5a3b29c4ca07e678a5
Fixes: b/359664492
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/380580
Auto-Submit: Jonny Wang <jonnywang@google.com >
Commit-Queue: Jonny Wang <jonnywang@google.com >
Reviewed-by: Ben Konyi <bkonyi@google.com >
Commit-Queue: Ben Konyi <bkonyi@google.com >
2024-08-14 14:49:54 +00:00
aa0a5da4b8
[infra] Fix tools/bots/find_base_commit.dart.
...
Broken in dd5b9cd7d7https://dart-review.googlesource.com/c/sdk/+/377726
Commit-Queue: Ryan Macnak <rmacnak@google.com >
Reviewed-by: Siva Annamalai <asiva@google.com >
2024-08-13 18:37:33 +00:00
c008c159ee
Enable feature digit-separators
...
This CL makes the `digit-separators` feature enabled by default in
Dart Language Version 3.6.
Tested: Presubmit bots
Change-Id: If0776e96066ecaad3baa7f92fce167317fb976f2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/379660
Reviewed-by: Leaf Petersen <leafp@google.com >
Reviewed-by: Johnni Winther <johnniwinther@google.com >
Commit-Queue: Samuel Rawlins <srawlins@google.com >
2024-08-13 04:09:39 +00:00
6c9b36fdc9
[ddc] Turning down unsound testing on canary (2)
...
Stop running language suite on the ddc-canary-linux-chrome bot.
These changes are staged across multiple CLs to avoid crashing
the infra when too many tests status changes need to be uploaded
at the same time.
Change-Id: I68916c86010a7291c2535c3d61325c3a44dc2a8a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/379521
Reviewed-by: Kevin Moore <kevmoo@google.com >
Commit-Queue: Nicholas Shahan <nshahan@google.com >
2024-08-08 17:47:31 +00:00
8bfd59d77d
[ddc] Turning down unsound testing on canary (1)
...
Stop running corelib, dartdevc, lib, and web suites on the
ddc-canary-linux-chrome bot.
These changes are staged across multiple CLs to avoid crashing
the infra when too many tests status changes need to be uploaded
at the same time.
Change-Id: I60fa5f9acff12081bea0f7756d43f8ab313d91ad
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/379520
Reviewed-by: Kevin Moore <kevmoo@google.com >
Commit-Queue: Nicholas Shahan <nshahan@google.com >
2024-08-07 21:18:49 +00:00
f019c8188d
Update the specification parser to follow language repo #4016
...
The PR https://github.com/dart-lang/language/pull/4016 updates the
augmentation feature specification such that augmenting extension type
declarations do not specify the primary constructor. This CL changes
Dart.g (and hence the specification parser) accordingly.
It also corrects a typo in Dart.g.
Change-Id: I10b49873a96524a9d363f842b39688f3c624b9f5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/379100
Reviewed-by: Chloe Stefantsova <cstefantsova@google.com >
Commit-Queue: Erik Ernst <eernst@google.com >
2024-08-07 15:43:29 +00:00
f4423e61ec
Remove 4 old HintCodes, all replaced with WarningCodes
...
* UNNECESSARY_CAST
* UNUSED_ELEMENT
* UNUSED_ELEMENT_PARAMETER
* UNUSED_LOCAL_VARIABLE
Work towards https://github.com/dart-lang/sdk/issues/50796
Cq-Include-Trybots: luci.dart.try:flutter-analyze-try,analyzer-win-release-try,pkg-win-release-try
Change-Id: I15c74e5ebc626f7e513c04013aa2f81b36ca39a8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/377762
Reviewed-by: Nate Bosch <nbosch@google.com >
Commit-Queue: Samuel Rawlins <srawlins@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2024-07-29 18:55:49 +00:00
e5120a3fd5
[fuchsia] Use API level 21
...
Change-Id: Iacc2324ad0a23d6e9cf6278c45c9dccccf8f1f96
Fixed: b:352147418
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/376980
Reviewed-by: Alexander Aprelev <aam@google.com >
Commit-Queue: Alexander Aprelev <aam@google.com >
Auto-Submit: Jonny Wang <jonnywang@google.com >
2024-07-22 14:53:10 +00:00
dd5b9cd7d7
[tools/] remove many uses of dynamic in the tools/ directory
...
Change-Id: I1bd930c11e0463ba0de1938ba417b6664c8cdb28
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/376023
Reviewed-by: Nate Bosch <nbosch@google.com >
Commit-Queue: Devon Carew <devoncarew@google.com >
Reviewed-by: Alexander Thomas <athom@google.com >
2024-07-17 15:38:50 +00:00
c7ba784b3a
address lint issues from tools/addlatexhash.dart
...
Change-Id: Icd1516c34d86eaedc9dd5e071963b2ca461fe98d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/375801
Reviewed-by: Erik Ernst <eernst@google.com >
Commit-Queue: Devon Carew <devoncarew@google.com >
2024-07-16 16:56:15 +00:00
2f0ccf965c
Remove tools/line_doc_comments.dart.
...
Change-Id: I556e66acfe8f2910d1c4e3b0073ba49fa9f41801
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/375785
Reviewed-by: Bob Nystrom <rnystrom@google.com >
Commit-Queue: Devon Carew <devoncarew@google.com >
2024-07-16 00:38:57 +00:00
4e7a94bdc2
[tools] updating linting in tools/ and reduce use of dynamic
...
Change-Id: I9e543a384fb10495af4598bfeb12c42944ff614f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/375745
Commit-Queue: Devon Carew <devoncarew@google.com >
Reviewed-by: Nate Bosch <nbosch@google.com >
2024-07-15 23:55:30 +00:00
b198a897e7
Add experimental flags 'enhanced-parts' and 'augmentations'
...
Change-Id: I74c36b2509ed38132b30f7cfaf86522dbe2f17b5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/374960
Reviewed-by: Johnni Winther <johnniwinther@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Nate Bosch <nbosch@google.com >
Commit-Queue: Erik Ernst <eernst@google.com >
2024-07-10 08:27:44 +00:00
5e8ee77772
Support digit separators
...
Work towards https://github.com/dart-lang/language/issues/2
The feature is well-specified at the issue, but I will also follow
up with a specification to check into the language repo.
This change implements the feature more-or-less from front to back
(because the back is very close to the front in this case :P; no
"backend" work in the VM, etc). Digit separators are made available
via a new experiment, `digit-separators`.
Care is taken to report a single error when an underscore appears in
an unexpected position (see new `separators_error_test.dart`).
Three test files are added:
* `separators_test.dart` is run with the experiment enabled, and has
no compile-time errors.
* `separators_error_test.dart` is run with the experiment enabled, and
has many compile-time errors.
* `separators_error_no_experiment_test.dart` is run with the
experiment _disabled_.
Change-Id: I7f1b1305d28b708b5ddf83f26188cd6e9ce3dd58
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/365181
Commit-Queue: Samuel Rawlins <srawlins@google.com >
Reviewed-by: Lasse Nielsen <lrn@google.com >
Reviewed-by: Kevin Moore <kevmoo@google.com >
Reviewed-by: Jens Johansen <jensj@google.com >
2024-07-09 14:50:59 +00:00
5e68eee8c3
[deps] rev args, bazel_worker, benchmark_harness, collection, ecosystem, file, glob, http, http_multi_server, http_parser, json_rpc_2, logging, mockito, package_config, source_maps, source_span, sync_http, test, yaml_edit
...
Revisions updated by `dart tools/rev_sdk_deps.dart`.
args (https://github.com/dart-lang/args/compare/6a5a2e6..1a24d61 ):
1a24d61 2024-07-01 dependabot[bot] Bump the github-actions group with 2 updates (dart-lang/args#278 )
bazel_worker (https://github.com/dart-lang/bazel_worker/compare/c76d7c8..02f190b ):
02f190b 2024-07-01 Kevin Moore blast_repo fixes (dart-lang/bazel_worker#94 )
benchmark_harness (https://github.com/dart-lang/benchmark_harness/compare/f6ef33d..a06785c ):
a06785c 2024-07-01 Kevin Moore blast_repo fixes (dart-lang/benchmark_harness#108 )
collection (https://github.com/dart-lang/collection/compare/9354f38..0c1f829 ):
0c1f829 2024-07-01 dependabot[bot] Bump the github-actions group with 2 updates (dart-lang/collection#354 )
ecosystem (https://github.com/dart-lang/ecosystem/compare/54ca01a..4171189 ):
4171189 2024-07-02 Jacob MacDonald support nested packages in firehose (dart-lang/ecosystem#277 )
459041b 2024-07-01 dependabot[bot] Bump the github-actions group with 4 updates (dart-lang/ecosystem#275 )
file (https://github.com/google/file.dart/compare/07cacae..855831c ):
855831c 2024-07-01 dependabot[bot] Bump actions/checkout from 4.1.6 to 4.1.7 (google/file.dart#242 )
da79121 2024-07-01 dependabot[bot] Bump dart-lang/setup-dart from 1.6.4 to 1.6.5 (google/file.dart#241 )
glob (https://github.com/dart-lang/glob/compare/6d3ba5e..8b05be8 ):
8b05be8 2024-07-01 dependabot[bot] Bump the github-actions group with 2 updates (dart-lang/glob#96 )
http (https://github.com/dart-lang/http/compare/8d89385..4178b67 ):
4178b67 2024-07-03 Brian Quinlan Clarify when Client.close must be called (dart-lang/http#1255 )
719dc5f 2024-07-02 Brian Quinlan Upgrade to http_image_provider: 0.0.3 (dart-lang/http#1253 )
75b1efb 2024-07-02 dependabot[bot] Bump the github-actions group across 1 directory with 4 updates (dart-lang/http#1251 )
cdfb94c 2024-07-01 Brian Quinlan Add an section explaining the benefits of using `package:ok_http`. (dart-lang/http#1252 )
http_multi_server (https://github.com/dart-lang/http_multi_server/compare/25941e2..8348be1 ):
8348be1 2024-07-01 dependabot[bot] Bump the github-actions group with 2 updates (dart-lang/http_multi_server#71 )
http_parser (https://github.com/dart-lang/http_parser/compare/9bf7bd9..ce528cf ):
ce528cf 2024-07-01 dependabot[bot] Bump the github-actions group with 2 updates (dart-lang/http_parser#101 )
json_rpc_2 (https://github.com/dart-lang/json_rpc_2/compare/616937f..b4810dc ):
b4810dc 2024-07-01 dependabot[bot] Bump the github-actions group with 2 updates (dart-lang/json_rpc_2#117 )
logging (https://github.com/dart-lang/logging/compare/6c3fb37..8752902 ):
8752902 2024-07-01 Kevin Moore blast_repo fixes (dart-lang/logging#170 )
mockito (https://github.com/dart-lang/mockito/compare/a7fdf71..eb4d1da ):
eb4d1da 2024-07-03 James Lin Update with review feedback from srawlins
db19e8c 2024-06-05 James Lin Provide better documentation for `provideDummy`/`provideDummyBuilder`
330976e 2024-07-01 dependabot[bot] Bump the github-actions group across 1 directory with 2 updates (dart-lang/mockito#761 )
package_config (https://github.com/dart-lang/package_config/compare/903a0e5..f0b7256 ):
f0b7256 2024-07-01 dependabot[bot] Bump the github-actions group with 2 updates (dart-lang/package_config#156 )
source_maps (https://github.com/dart-lang/source_maps/compare/caa79c2..5f82c61 ):
5f82c61 2024-07-01 dependabot[bot] Bump the github-actions group with 2 updates (dart-lang/source_maps#95 )
source_span (https://github.com/dart-lang/source_span/compare/89520f3..f81cd4a ):
f81cd4a 2024-07-01 dependabot[bot] Bump the github-actions group with 2 updates (dart-lang/source_span#115 )
sync_http (https://github.com/dart-lang/sync_http/compare/7622bdd..ab8377e ):
ab8377e 2024-07-01 dependabot[bot] Bump dart-lang/setup-dart from 1.6.2 to 1.6.5 (dart-lang/sync_http#48 )
test (https://github.com/dart-lang/test/compare/3256c23..14f9b3e ):
14f9b3ec 2024-07-08 Jacob MacDonald use pub workspaces (dart-lang/test#2249 )
c14ce93a 2024-07-03 Nate Bosch Prepare to publish (dart-lang/test#2250 )
yaml_edit (https://github.com/dart-lang/yaml_edit/compare/57a28da..d605cce ):
d605cce 2024-07-04 Kavisi Fix fold literal encoding with trailing line break (dart-lang/yaml_edit#91 )
Change-Id: I70ee32b3fa1912457b7b08affb3446523ef3b0d1
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/374860
Reviewed-by: Brian Quinlan <bquinlan@google.com >
Commit-Queue: Devon Carew <devoncarew@google.com >
2024-07-08 19:06:29 +00:00
b82383953d
[build] Link with lld on Windows when using Clang.
...
- Make the build deterministic
Bug: https://github.com/dart-lang/sdk/issues/55995
Change-Id: Ic800dd66f23bc402dfede09db3f67f01aa82d29d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/373360
Reviewed-by: Alexander Aprelev <aam@google.com >
Commit-Queue: Ryan Macnak <rmacnak@google.com >
2024-07-02 21:16:39 +00:00
87b790b6d0
Bump version to 3.6
...
Change-Id: I1d096140adb8c01914e0b9d1c7cb2017204e7f0a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/373940
Reviewed-by: Devon Carew <devoncarew@google.com >
Commit-Queue: Kevin Chisholm <kevinjchisholm@google.com >
Reviewed-by: Kevin Chisholm <kevinjchisholm@google.com >
2024-07-02 00:02:19 +00:00
957106e29d
[null-aware-elements] Add experiment flag 'null-aware-elements'.
...
Part of https://github.com/dart-lang/sdk/issues/55949
Closes https://github.com/dart-lang/sdk/issues/55926
Change-Id: Ic8c6a9226bcad54daf99e01746044045937376b1
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/369960
Commit-Queue: Chloe Stefantsova <cstefantsova@google.com >
Reviewed-by: Johnni Winther <johnniwinther@google.com >
Reviewed-by: Slava Egorov <vegorov@google.com >
Reviewed-by: Keerti Parthasarathy <keertip@google.com >
2024-06-26 09:28:16 +00:00
09e87e6d7b
[fuchsia] Update Fuchsia API version to 19
...
Bug: b/347292659
Change-Id: I16422488566c91b2efc1c06192583eb3937dd4b4
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/372185
Auto-Submit: Jonny Wang <jonnywang@google.com >
Commit-Queue: Derek Xu <derekx@google.com >
Reviewed-by: Derek Xu <derekx@google.com >
2024-06-19 14:50:30 +00:00
4f5dc5603f
analyzer: Deprecate dead properties on Comment
...
Work towards https://github.com/dart-lang/sdk/issues/56038
Cq-Include-Trybots: luci.dart.try:flutter-analyze-try,analyzer-win-release-try,pkg-win-release-try
Change-Id: If7ae2738fec598f16756c524b6bd6c258ee5609e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/372100
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Nate Bosch <nbosch@google.com >
Commit-Queue: Sam Rawlins <srawlins@google.com >
2024-06-18 18:27:25 +00:00
ff3f629d4b
[3xH] Migrate apply.sh to python 3.12
...
See https://docs.python.org/dev/whatsnew/3.12.html#imp
Fixes: https://github.com/dart-lang/sdk/issues/55973
Change-Id: I0ac6e60104bddc17cfe5cd537a409c4ded3eb1a9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/371302
Reviewed-by: Daco Harkes <dacoharkes@google.com >
Commit-Queue: Alexander Thomas <athom@google.com >
2024-06-14 06:52:12 +00:00
e18c43a21e
[dart2wasm] Add dart2wasm-asserts-* configurations
...
Our tests (including code in core libraries) are never run with
assertions enabled.
=> Add the necessary configuration support in test_matrix.json
=> We'll then add a new builder running one configuration with asserts.
Change-Id: Id1bc27ddf7d683846510af4711679ad14f0e4168
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/370620
Reviewed-by: Slava Egorov <vegorov@google.com >
Commit-Queue: Martin Kustermann <kustermann@google.com >
2024-06-10 14:24:12 +00:00
cb64e64ccc
[third_party/pkg] put package:dap and package:language_server_protocol under analysis
...
Change-Id: Ie1a48956055fa0f4ebcd85e5d2b762021fc074d7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/370101
Commit-Queue: Devon Carew <devoncarew@google.com >
Reviewed-by: Sam Rawlins <srawlins@google.com >
2024-06-07 19:33:13 +00:00
c5cd8ff349
[cfe] Remove agnostic mode
...
The agnostic mode was added to allow the platform dill embedded in
the VM to support both weak and strong mode. Since weak mode is no
longer supported in the VM, the agnostic mode can new be deleted.
All uses of the agnostic in Dart and Flutter have been removed prior
to this change.
Change-Id: Iff0f69d9cd64e887e01cd7e7d336a97761bd6d4b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/366801
Reviewed-by: Alexander Thomas <athom@google.com >
Commit-Queue: Johnni Winther <johnniwinther@google.com >
Reviewed-by: Jens Johansen <jensj@google.com >
2024-06-06 11:02:37 +00:00
b56843da32
Spec parse null aware elements
...
Change-Id: Ib61fea3bec110c0a2c560c965912c51a1c4e22cf
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/368569
Reviewed-by: Lasse Nielsen <lrn@google.com >
Commit-Queue: Erik Ernst <eernst@google.com >
2024-05-31 09:12:01 +00:00
12e5feec19
Restore ARM32 GCC testing.
...
Bug: https://github.com/dart-lang/sdk/issues/52080
Bug: https://github.com/dart-lang/sdk/issues/55669
Change-Id: Ic248f9f25e4fa2a6ed4471eff57062c5eb2d8af1
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/367641
Reviewed-by: Alexander Thomas <athom@google.com >
Commit-Queue: Ryan Macnak <rmacnak@google.com >
2024-05-28 22:50:19 +00:00
213e679f59
Reapply "[CFE] Coverage on try bot"
...
This reverts commit 60a52f66f5https://dart-review.googlesource.com/c/sdk/+/367901
Reviewed-by: Johnni Winther <johnniwinther@google.com >
Reviewed-by: Alexander Thomas <athom@google.com >
Commit-Queue: Jens Johansen <jensj@google.com >
2024-05-24 07:44:08 +00:00
101faa6929
[tool] Fix tools/generate_idefiles.py after RBE migration
...
Closes: https://github.com/dart-lang/sdk/issues/55813
Change-Id: Ia724f291a8893c7ee8622c687ab8181f23d0c405
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/367580
Reviewed-by: Alexander Thomas <athom@google.com >
Commit-Queue: Daco Harkes <dacoharkes@google.com >
2024-05-22 16:17:33 +00:00
035be2b0d4
Update Dart.g to clarify the association of metadata and its target AST
...
Change-Id: I02a3e155aab73d638ddbc20485db9db3dcbe6c9f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/365781
Reviewed-by: Chloe Stefantsova <cstefantsova@google.com >
Commit-Queue: Erik Ernst <eernst@google.com >
2024-05-21 09:07:23 +00:00
3da6b50905
[infra] Add configurations for ARM64 sanitizer testing.
...
Runs only the ffi test suite with no shards due to limited capacity. Runs JIT and AOT on the same builder to avoid building twice without RBE.
Change-Id: I1cebff950d89b3302169e9e4cdb68772cd8bf413
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/365865
Reviewed-by: Alexander Thomas <athom@google.com >
Commit-Queue: Ryan Macnak <rmacnak@google.com >
2024-05-17 16:57:13 +00:00
8fa0675a6d
[dart2wasm] Make optimized builders run with --use-sdk (and therefore dart compile wasm)
...
This gives some more coverage for `dart compile wasm`
Change-Id: I62e7f9c6ecbdf80a1445c35d1733a7f89e6bcf54
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/366623
Reviewed-by: Ömer Ağacan <omersa@google.com >
Commit-Queue: Martin Kustermann <kustermann@google.com >
2024-05-17 13:08:31 +00:00
60a52f66f5
Revert "[CFE] Coverage on try bot"
...
This reverts commit 4ab652b38fhttps://dart-review.googlesource.com/c/sdk/+/366340
> Reviewed-by: Johnni Winther <johnniwinther@google.com >
> Reviewed-by: Alexander Thomas <athom@google.com >
> Commit-Queue: Jens Johansen <jensj@google.com >
Change-Id: I1afcb77bd44dc785bcf445ec041ab633fe7277a8
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/367022
Auto-Submit: Johnni Winther <johnniwinther@google.com >
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com >
Commit-Queue: Alexander Thomas <athom@google.com >
Reviewed-by: Chloe Stefantsova <cstefantsova@google.com >
Reviewed-by: Alexander Thomas <athom@google.com >
2024-05-17 10:53:17 +00:00
4ab652b38f
[CFE] Coverage on try bot
...
This runs the strong suite, does coverage, and compares the coverage
(percentage) to the (hardcoded) expected percentage.
Change-Id: I2e7511d7841b19c15139a7c84bf0861b56b81ccc
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/366340
Reviewed-by: Johnni Winther <johnniwinther@google.com >
Reviewed-by: Alexander Thomas <athom@google.com >
Commit-Queue: Jens Johansen <jensj@google.com >
2024-05-16 11:48:12 +00:00
732d95288a
Update OWNERS to avoid incorrect reviewer assignments
...
This helps to make "suggest owners" more accurate.
Change-Id: Iea61eb8a1307bf88bffaf0c1c86dddf4bdcfd597
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/366600
Reviewed-by: Slava Egorov <vegorov@google.com >
2024-05-15 08:27:20 +00:00
ebcf5fee57
[fuchsia] Update Fuchsia API level to 18
...
Bug: b/339619418
Change-Id: Id8cc841ca1efd4356d54ed5513e958dc2c8c0cc6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/365981
Reviewed-by: Ryan Macnak <rmacnak@google.com >
2024-05-09 18:33:33 +00:00
8c1de038e0
[vm, compiler] Allow targeting TSAN or MSAN by passing a flag to gen_snapshot.
...
Add check that the snapshot and runtime agree on whether to use MSAN. We already have this check for TSAN.
TEST=vm/dart/sanitizer_compatibility_test
Bug: https://github.com/dart-lang/sdk/issues/55637
Bug: https://github.com/dart-lang/sdk/issues/55638
Change-Id: I320e6f55cd59209ce6e58a82ac205a87c8a60a84
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/365487
Reviewed-by: Daco Harkes <dacoharkes@google.com >
Commit-Queue: Ryan Macnak <rmacnak@google.com >
Reviewed-by: Ivan Inozemtsev <iinozemtsev@google.com >
Reviewed-by: Siva Annamalai <asiva@google.com >
2024-05-08 17:03:59 +00:00
2cfca4e677
[wildcard-variables] Add experiment flag 'wildcards-variables'.
...
Getting the flag out so we can at least start writing language and co19 tests.
Adds the experiment flag so we can hide future wildcards work until we're ready to ship.
Bug: https://github.com/dart-lang/sdk/issues/55654
Change-Id: I6185360f371bc7c3c7a109b33aeb7df44e1f1a60
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/365545
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Johnni Winther <johnniwinther@google.com >
Reviewed-by: Nate Bosch <nbosch@google.com >
Reviewed-by: Phil Quitslund <pquitslund@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2024-05-08 00:37:29 +00:00
7fe83c8e70
Add OWNERS_DEVTOOLS to OWNERS_ENG, remove old entries
...
Change-Id: I5047a0d7240bcc6b0ab2c5fe9c16aa2fa53aeea2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/365640
Commit-Queue: Siva Annamalai <asiva@google.com >
Auto-Submit: Ben Konyi <bkonyi@google.com >
Reviewed-by: Kenzie Davisson <kenzieschmoll@google.com >
Reviewed-by: Siva Annamalai <asiva@google.com >
2024-05-07 17:31:58 +00:00
bc084d0a53
[ddc] Cleanup some unsound test suites
...
The first in a series of changes that deletes all DDC tests running
with unsound null safety. Follow up changes will remove more tests
configurations, and null safety mode plumbing for the DDC infra.
* Delete the unsound version of some suites.
* Renames the sound suites to be more descriptive of the code in the
test instead of the mode it is run in.
Change-Id: If2edfecc811bb78a77a1e93bd6d0b75f22c3e80c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/365520
Reviewed-by: Mark Zhou <markzipan@google.com >
Reviewed-by: Nate Bosch <nbosch@google.com >
2024-05-06 22:19:20 +00:00
281241ea71
Retire inference-update-3 experiment introduced in Dart 3.4.
...
The expriment is now retired in Dart 3.5, and the flag
stops being valid.
Change-Id: I1ecb087d45b90e98a7f0d3c15a6c8038a1c6982e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/365260
Reviewed-by: Nate Bosch <nbosch@google.com >
Reviewed-by: Johnni Winther <johnniwinther@google.com >
Reviewed-by: Paul Berry <paulberry@google.com >
Commit-Queue: Lasse Nielsen <lrn@google.com >
2024-05-03 12:26:59 +00:00
06dd95bd8e
[infra] Expand sanitizer test coverage.
...
TEST=ci
Change-Id: I5e7709572f3ea0a16925996be8ab903b6eccc0e1
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/365100
Reviewed-by: Siva Annamalai <asiva@google.com >
Commit-Queue: Ryan Macnak <rmacnak@google.com >
2024-05-02 23:31:48 +00:00
bda15ba43e
[dartfuzz] Make dart2js source available to the shards.
...
Change-Id: Ic2047f37f7de9b8d82f911b6a0c64a981619d0bb
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/365124
Reviewed-by: Siva Annamalai <asiva@google.com >
Reviewed-by: Alexander Aprelev <aam@google.com >
Commit-Queue: Ryan Macnak <rmacnak@google.com >
2024-05-01 17:32:32 +00:00
be210a8e76
[dartfuzz] Also stress test using dart2js with various GC and compiler flags.
...
TEST=dartf
Change-Id: I03fde5903159eeabe6df12513ca491844b0e8fec
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/364962
Reviewed-by: Alexander Markov <alexmarkov@google.com >
Reviewed-by: Siva Annamalai <asiva@google.com >
Commit-Queue: Ryan Macnak <rmacnak@google.com >
2024-04-30 21:43:38 +00:00
d42a4b7219
[test] Run FFI tests on Fuchsia ARM64.
...
- Compile tests to kernel and use that instead of source for the Fuchsia test package.
- Skip multitests instead of the running them and approving the failures.
TEST=ci
Bug: https://github.com/dart-lang/sdk/issues/38752
Change-Id: Idd9bef0f6026c6d882712eb1083e88433bb53b13
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/333121
Reviewed-by: Siva Annamalai <asiva@google.com >
Reviewed-by: Daco Harkes <dacoharkes@google.com >
Commit-Queue: Ryan Macnak <rmacnak@google.com >
2024-04-30 17:37:45 +00:00
2a2781edff
[vm] Add vm:align-loops pragma
...
This pragma forces compiler to align loop headers within the
function by architecture specific boundary: 32 bytes on X64
and ARM64 (with the exception of Apple Silicon, which explicitly
discourages aligning branch targets in the optimization manual).
Current implementation is rather naive and does not do any
attempt to decide whether aligning is actually profitable
based on loop body itself.
I have found this pragma to be helpful both to stabilize
benchmark results and achieve better performance
for tight loops on Intel hardware.
Issue https://github.com/dart-lang/sdk/issues/55522
TEST=vm/dart/align_loops_test
Cq-Include-Trybots: luci.dart.try:vm-aot-linux-product-x64-try,vm-aot-linux-debug-x64c-try,vm-aot-linux-debug-x64-try,vm-aot-linux-release-arm64-try,vm-aot-linux-release-simarm_x64-try,vm-aot-linux-release-x64-try,vm-aot-mac-product-arm64-try,vm-aot-mac-release-arm64-try,vm-aot-mac-release-x64-try,vm-aot-obfuscate-linux-release-x64-try,vm-aot-optimization-level-linux-release-x64-try,vm-aot-win-release-x64-try,vm-aot-win-debug-arm64-try,vm-aot-win-debug-x64-try,vm-aot-win-debug-x64c-try,vm-aot-win-product-x64-try,vm-aot-win-release-arm64-try,vm-aot-linux-debug-simarm_x64-try,vm-aot-linux-debug-simriscv64-try,vm-aot-dwarf-linux-product-x64-try,vm-aot-android-release-arm64c-try,vm-aot-android-release-arm_x64-try
Change-Id: Ic22fb90d85e7fdebeeaa3908a43328c59436ab58
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/364121
Reviewed-by: Alexander Markov <alexmarkov@google.com >
Commit-Queue: Slava Egorov <vegorov@google.com >
2024-04-24 08:52:18 +00:00
cfc705ce09
Introduce analysis_server_plugin package; replacement for server_plugin
...
We have chosen a new name for this package. So before we write more
code inside, we need to move everything from 'server_plugin' to
'analysis_server_plugin'. There are some steps do doing so, to not
break various infra:
1. Land this change, introducing the new package in the SDK, but no
dependencies on it.
2. Land this change independently in google3 (the package is not
yet "unbundled.")
3. Mark the package as "unbundled" in google3.
4. Move all code from server_plugin to analysis_server_plugin; update
imports; and delete server_plugin.
5. Remove server_plugin as an "unbundled" package; and remove
server_plugin from google3.
Bug: https://github.com/dart-lang/sdk/issues/53402
Change-Id: I70197fdf61dd5862c2220d8ed5dd0880a1593ead
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/363600
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Alexander Thomas <athom@google.com >
Commit-Queue: Samuel Rawlins <srawlins@google.com >
2024-04-19 01:38:29 +00:00
Alexander Markov