9ab5245b89
Reapply "[vm] Don't use a fuzzy lookup for recognized methods."
...
- Fix incorrectly named ALL_INTRINSICS_LIST to ASM_INTRINSICS_LIST and restore setting intrinsic bit for graph intrinsics.
- Remove more dead code.
TEST=ci
Bug: https://github.com/dart-lang/sdk/issues/56007
Change-Id: Iebceaab86509e34f47e3d6918706b0e69ed7dfc5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/374842
Reviewed-by: Alexander Markov <alexmarkov@google.com >
Commit-Queue: Ryan Macnak <rmacnak@google.com >
2024-07-09 16:33:19 +00:00
b5d6c50e1a
Revert "[vm] Don't use a fuzzy lookup for recognized methods."
...
This reverts commit 1dbb56c77ahttps://github.com/dart-lang/sdk/issues/56007
> Change-Id: I30debb6b9c9890739cc1b25b7b2c097551b4c2aa
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/374200
> Reviewed-by: Alexander Markov <alexmarkov@google.com >
> Commit-Queue: Ryan Macnak <rmacnak@google.com >
Bug: https://github.com/dart-lang/sdk/issues/56007
Change-Id: I1b8fddb967f0189ce223aad1768477229a8a36b0
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/374863
Commit-Queue: Alexander Aprelev <aam@google.com >
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com >
Reviewed-by: Alexander Aprelev <aam@google.com >
Auto-Submit: Ryan Macnak <rmacnak@google.com >
2024-07-08 21:40:47 +00:00
1dbb56c77a
[vm] Don't use a fuzzy lookup for recognized methods.
...
TEST=ci
Bug: https://github.com/dart-lang/sdk/issues/56007
Change-Id: I30debb6b9c9890739cc1b25b7b2c097551b4c2aa
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/374200
Reviewed-by: Alexander Markov <alexmarkov@google.com >
Commit-Queue: Ryan Macnak <rmacnak@google.com >
2024-07-08 18:25:48 +00:00
f51fedce26
[ dart:developer ] Remove Metrics related classes
...
Fixes https://github.com/dart-lang/sdk/issues/51668
TEST=CI
CoreLibraryReviewExempt:VM only functionality
Change-Id: I5d41863fca05e50d9c20266402c516b92f8de153
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/287820
Reviewed-by: Michael Thomsen <mit@google.com >
Commit-Queue: Ben Konyi <bkonyi@google.com >
2023-03-10 16:50:10 +00:00
cb478b21f4
Don't mutate argument to dart:developer's postEvent.
...
Bug: https://github.com/dart-lang/sdk/issues/50713
Change-Id: Iadc3eb0b4306d7500a03bd77b8b6dc3c19227200
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/275984
Commit-Queue: Dan Chevalier <danchevalier@google.com >
Reviewed-by: Ben Konyi <bkonyi@google.com >
2022-12-22 23:10:13 +00:00
df97aca1fa
Spelling tests
...
Closes https://github.com/dart-lang/sdk/pull/50764
GitOrigin-RevId: ee2fe9a75d50e877f4ad2fe3743acdbc04f186ef
Change-Id: Ia73cd22da4e6ec95e84772aa4e1345ce2dbde215
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/276360
Reviewed-by: Erik Ernst <eernst@google.com >
Commit-Queue: Erik Ernst <eernst@google.com >
2022-12-19 12:56:47 +00:00
fd6fa010ec
[ VM Service / DDS ] Add custom service stream support (Revised)
...
NOTES:
Original CL: https://dart-review.googlesource.com/c/sdk/+/274061
Revert CL: https://dart-review.googlesource.com/c/sdk/+/274802
Regression tests that failed after merging Original CL:
- https://ci.chromium.org/ui/p/dart/builders/ci.sandbox/pkg-mac-release/24046/overview
- https://ci.chromium.org/ui/p/dart/builders/ci.sandbox/pkg-mac-release-arm64/5999/overview
----------
DESCRIPTION:
Setting the `stream` parameter on `developer.postEvent` will now forward those events to a custom stream inside DDS.
The first use of this will be for widget inspection. A navigation event will be posted to a custom stream. Our IDE DAP can listen for the Event and react to it by navigating to the desired location in the code.
TEST=Made sure that regression from original PR could be reproduced, and then resolved by applying this change. Updated observatory tests. Created new developer test to check assertions. Added DDS tests for new custom stream behaviour. Manually tested the postEvent and StreamListen with multiple clients
https://github.com/flutter/devtools/issues/4533
Change-Id: I2b04a84b4daf11dd9d72f899928b5e1f62a5ae02
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/275121
Reviewed-by: Ben Konyi <bkonyi@google.com >
Commit-Queue: Ben Konyi <bkonyi@google.com >
2022-12-13 16:31:37 +00:00
3ed65601b0
Revert "[ VM Service / DDS ] Add custom service stream support"
...
This reverts commit 4981cbffe2https://github.com/flutter/devtools/issues/4533
>
> Change-Id: I870dc634c9a9a7d2ee3a6605319c2a18517ad197
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/274061
> Reviewed-by: Ben Konyi <bkonyi@google.com >
> Commit-Queue: Dan Chevalier <danchevalier@google.com >
TBR=bkonyi@google.com ,dart-scoped@luci-project-accounts.iam.gserviceaccount.com ,danchevalier@google.com
Change-Id: Ia1dce25444a6329c0553c931c9a6dbbec65ee583
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/274802
Reviewed-by: Ben Konyi <bkonyi@google.com >
Commit-Queue: Daco Harkes <dacoharkes@google.com >
Reviewed-by: Dan Chevalier <danchevalier@google.com >
2022-12-12 11:24:37 +00:00
4981cbffe2
[ VM Service / DDS ] Add custom service stream support
...
Setting the `stream` parameter on `developer.postEvent` will now forward those events to a custom stream inside DDS.
The first use of this will be for widget inspection. A navigation event will be posted to a custom stream. Our IDE DAP can listen for the Event and react to it by navigating to the desired location in the code.
TEST=Updated observatory tests. Created new developer test to check assertions. Added DDS tests for new custom stream behaviour. Manually tested the postEvent and StreamListen with multiple clients
https://github.com/flutter/devtools/issues/4533
Change-Id: I870dc634c9a9a7d2ee3a6605319c2a18517ad197
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/274061
Reviewed-by: Ben Konyi <bkonyi@google.com >
Commit-Queue: Dan Chevalier <danchevalier@google.com >
2022-12-09 20:18:30 +00:00
bf19cfc8fe
[ dart:developer ] Expose the set of currently registered Metrics
...
Fixes https://github.com/dart-lang/sdk/issues/49062
Change-Id: I2e12dd51c7e43c3cd33d7ad6716849a010ec57d6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/251121
Reviewed-by: Sigmund Cherem <sigmund@google.com >
Commit-Queue: Ben Konyi <bkonyi@google.com >
2022-07-11 15:52:18 +00:00
ffa7969bb8
Migrate lib_2/developer/timeline_recorders_test.dart to null safety.
...
Looks like this was added to lib_2 after the initial migration.
Change-Id: Ic56357cd99c9b369c38628f4527cfa84f50f5f72
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/152600
Auto-Submit: Bob Nystrom <rnystrom@google.com >
Commit-Queue: Ryan Macnak <rmacnak@google.com >
Reviewed-by: Ryan Macnak <rmacnak@google.com >
2020-06-25 21:21:32 +00:00
bd6cd9cd3a
[test] Move and migrate dart:profiler tests.
...
Move tests from tests/lib_2/profiler to tests/lib_2/developer since `dart:profiler` no longer exists.
Bug: https://github.com/dart-lang/sdk/issues/40142
Change-Id: Iccf68ea2922caa52122d48c91fe5fa35a241b051
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/133281
Reviewed-by: Ben Konyi <bkonyi@google.com >
Commit-Queue: Ryan Macnak <rmacnak@google.com >
2020-01-24 20:15:48 +00:00
7b44fa4265
Migrate "lib_2/developer" to NNBD.
...
Close #40140 .
Change-Id: I897a486f7b1f421f3691b83b10b9f18837199e82
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/132042
Auto-Submit: Bob Nystrom <rnystrom@google.com >
Reviewed-by: Leaf Petersen <leafp@google.com >
Commit-Queue: Bob Nystrom <rnystrom@google.com >
2020-01-17 00:16:15 +00:00
f6ca2c1d8f
Remove the Dart 1 tests.
...
This deletes:
tests/co19
tests/corelib
tests/html
tests/isolate
tests/language
tests/lib
It does not delete tests/standalone because apparently there are tests
in there that are not in standalone_2. (I assume they were added after
the test migration. I don't know why they were added there.)
I have tried to remove references to the old tests from various scripts
and tools but may have missed some. (As you can imagine, grepping for
"lib" does not have the best signal-to-noise ratio.)
"It was a pleasure to burn. It was a special pleasure to see things
eaten, to see things blackened and changed. With the brass nozzle in his
fists, with this great python spitting its venomous kerosene upon the
world, the blood pounded in his head, and his hands were the hands of
some amazing conductor playing all the symphonies of blazing and burning
to bring down the tatters and charcoal ruins of history."
- Ray Bradbury, Fahrenheit 451
Change-Id: If3db4a50e7a5ee25aff8058b1483e2ce8e68424e
Reviewed-on: https://dart-review.googlesource.com/c/75420
Commit-Queue: Bob Nystrom <rnystrom@google.com >
Auto-Submit: Bob Nystrom <rnystrom@google.com >
Reviewed-by: William Hesse <whesse@google.com >
Reviewed-by: Terry Lucas <terry@google.com >
Reviewed-by: Sigmund Cherem <sigmund@google.com >
2018-10-11 23:45:18 +00:00
291befa1cd
Redo TimelineTask API
...
A TimelineTask represents an asynchronous track of operations on the timeline.
The old API allowed multiple isolates to emit events simultaneously on the same task or to start / finish events in any order. This isn't supported by our UI and probably many other tools that consume trace-event.
With this change, operations within a TimelineTask must complete in the reverse order of their start calls (aka a stack). You can pass a TimelineTask from one isolate to another but you must first complete all open operations before passing it.
Example:
var task = new TimelineTask();
task.start('Some phase');
await someFuture;
task.finish();
Also: Add support for instant events.
R=rmacnak@google.com
Review URL: https://codereview.chromium.org/1412183008 .
2015-11-11 10:59:38 -08:00
f01c1490f7
Revert 45783
...
BUG=
Review URL: https://codereview.chromium.org//1138993005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45784 260f80e4-7a28-3924-810f-c04153c831b5
2015-05-14 00:32:32 +00:00
95515238cc
Move 'dart:profiler' contents into 'dart:developer' and remove 'dart:profiler'
...
BUG=
R=iposva@google.com
Review URL: https://codereview.chromium.org//1139503002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45783 260f80e4-7a28-3924-810f-c04153c831b5
2015-05-13 23:48:04 +00:00
016214f002
Add Debugger.inspect. 1976 here we come!
...
R=johnmccutchan@google.com
Review URL: https://codereview.chromium.org//1132153002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45664 260f80e4-7a28-3924-810f-c04153c831b5
2015-05-08 22:18:43 +00:00
Ryan Macnak