73cd7c6439
CQ. Deprecate exports from package:analyzer/src/source/source.dart
...
Change-Id: I6256ad2a8472636fd39a9db7e0360f8d7104da0e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/369560
Reviewed-by: Sam Rawlins <srawlins@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2024-06-11 22:49:51 +00:00
0ef8f05c6c
Fix 'unnecessary_final' in analyzer/.
...
But don't enable it yet, pending https://github.com/dart-lang/linter/issues/4938
Change-Id: I42df6e5c2699b08d729518c0565165d81e07ad3d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/363160
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2024-04-16 21:46:15 +00:00
19665111e5
remove unnecessary library names
...
Fixes generated using `dart fix --code=unnecessary_library_name --apply`
See conversation in https://github.com/dart-lang/lints/issues/181
Change-Id: Id2b975e4aa27348d8883f1aea22e00dd9f4fc493
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/359322
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Phil Quitslund <pquitslund@google.com >
2024-03-22 23:45:30 +00:00
fe6950eceb
enable flutter_style_todos
...
Change-Id: Ic82963b754404d54e37f5fb03819aebc3fa67954
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/336502
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Phil Quitslund <pquitslund@google.com >
2023-11-15 23:04:19 +00:00
73ab31b98a
analyzer: Move the Source class to be public API.
...
Deprecate accessing LineInfo, Source, or SourceRange via the
old library (pkg/analyzer/lib/src/generated/source.dart).
Migrate all SDK code to the new library.
Fixes https://github.com/dart-lang/sdk/issues/46420
Change-Id: Ic7c98a5820415c92a457f9fa2756351b05520cd1
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/335382
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Samuel Rawlins <srawlins@google.com >
Reviewed-by: Johnni Winther <johnniwinther@google.com >
2023-11-14 17:10:37 +00:00
57ac271bf1
Verify that 'utf8.encode()' is not used in the analyzer.
...
To be removed after Dart SDK 3.1 is published, and the analyzer
SDK constraints updated.
See
https://dart-review.googlesource.com/c/sdk/+/254903
Change-Id: I2c3321d991cd3e123f08c5a360487362be16f258
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/313920
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Samuel Rawlins <srawlins@google.com >
2023-07-17 17:28:31 +00:00
98014e0e2e
fixed dangling library doc comments
...
Change-Id: I28f5cd8ae31cb7b69da09028d0328e9f6c76bb69
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/294681
Reviewed-by: Samuel Rawlins <srawlins@google.com >
Commit-Queue: Phil Quitslund <pquitslund@google.com >
2023-04-12 00:29:48 +00:00
04c1d58a4a
Use mixins for analyzer packages, to prepate for language 3.0
...
Change-Id: I28fb5cf51c5dae887f19613d874d1ff264954be0
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/290912
Reviewed-by: Samuel Rawlins <srawlins@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2023-03-23 23:57:53 +00:00
63180b95ed
Remove superfluous words.
...
Fixes #51095
TEST=ci
CoreLibraryReviewExempt: There are no API changes, just removal of superfluous words in the comments.
Change-Id: Ib1020c62fe6baed5ca68f0074323f025cc90e9f8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/279500
Reviewed-by: Lasse Nielsen <lrn@google.com >
Commit-Queue: Lasse Nielsen <lrn@google.com >
Reviewed-by: Siva Annamalai <asiva@google.com >
2023-01-30 15:58:38 +00:00
777ce9b368
Use UriCache to ensure there is only one instance of Uri for each string.
...
I tested this on rwf-materials/01-setting-up-your-environment
Short version:
1. 475060 less live objects.
2. 37.5 MB less heap usage.
Before:
[Analysis contexts: 35]
[time: 20575 ms]
[4781 ms] Downloaded heap snapshot, 641.5832576751709 MB.
[26763 ms] Created HeapSnapshotGraph.
externalSize: 7168
shallowSize: 1796013552
Objects: 23954314
[26764 ms] Created Analysis.
All objects.
size count class
-------- -------- --------
284017 kb 2194914 _OneByteString dart:core
269992 kb 2088293 _List dart:core
229846 kb 2066511 _Uint32List dart:typed_data
154248 kb 4935956 _GrowableList dart:core
63042 kb 158891 _Uint8List dart:typed_data
56224 kb 1199459 Reference package:analyzer/src/summary2/reference.dart
42643 kb 682297 _InfoMethodDeclaration package:analyzer/src/summary2/informative_data.dart
40358 kb 234812 PropertyAccessorElementImpl_ImplicitGetter package:analyzer/src/dart/element/element.dart
38075 kb 203067 ConstFieldElementImpl package:analyzer/src/dart/element/element.dart
34247 kb 438367 _SimpleUri dart:core
32181 kb 686528 _InfoFormalParameter package:analyzer/src/summary2/informative_data.dart
29730 kb 475686 _Closure dart:core
27722 kb 6868 _TwoByteString dart:core
25594 kb 409517 _Map dart:collection
17778 kb 81273 ClassElementImpl package:analyzer/src/dart/element/element.dart
16479 kb 411893 Context
14672 kb 93903 LibraryImportElementImpl package:analyzer/src/dart/element/element.dart
14074 kb 90077 ParameterElementImpl package:analyzer/src/dart/element/element.dart
13316 kb 284078 _InfoFieldDeclaration package:analyzer/src/summary2/informative_data.dart
12932 kb 19671 Instructions
-------- --------
1739370 kb 23741574
Instances of: _SimpleUri
size count class
-------- -------- --------
34247 kb 438367 _SimpleUri dart:core
size unique-size count class data
-------- -------- -------- -------- --------
313 kb 0 kb 10024 _OneByteString dart:core
189 kb 0 kb 4033 _OneByteString package:flutter/foundation.dart
100 kb 0 kb 2137 _OneByteString package:flutter/widgets.dart
76 kb 0 kb 1626 _OneByteString package:flutter/rendering.dart
68 kb 0 kb 2207 _OneByteString dart:ui
62 kb 0 kb 1994 _OneByteString dart:async
62 kb 0 kb 1989 _OneByteString dart:math
43 kb 0 kb 935 _OneByteString package:flutter/services.dart
43 kb 0 kb 1378 _OneByteString theme.dart
42 kb 0 kb 907 _OneByteString package:flutter/gestures.dart
39 kb 0 kb 1278 _OneByteString framework.dart
38 kb 0 kb 1243 _OneByteString debug.dart
29 kb 0 kb 466 _OneByteString package:vector_math/vector_math_64.dart
27 kb 0 kb 594 _OneByteString package:flutter/scheduler.dart
27 kb 0 kb 577 _OneByteString package:meta/meta.dart
25 kb 0 kb 549 _OneByteString material_state.dart
25 kb 0 kb 549 _OneByteString material_localizations.dart
25 kb 0 kb 822 _OneByteString colors.dart
23 kb 0 kb 510 _OneByteString package:flutter/material.dart
23 kb 0 kb 752 _OneByteString basic.dart
-------- -------- --------
11153 kb 258 kb 201628
After:
[Analysis contexts: 35]
[time: 20763 ms]
[4711 ms] Downloaded heap snapshot, 620.3819370269775 MB.
[25756 ms] Created HeapSnapshotGraph.
externalSize: 5984
shallowSize: 1758470480
Objects: 23479254
[25756 ms] Created Analysis.
All objects.
size count class
-------- -------- --------
278669 kb 2110355 _OneByteString dart:core
270129 kb 2088300 _List dart:core
229910 kb 2066512 _Uint32List dart:typed_data
154248 kb 4935956 _GrowableList dart:core
63049 kb 159021 _Uint8List dart:typed_data
56224 kb 1199459 Reference package:analyzer/src/summary2/reference.dart
42643 kb 682297 _InfoMethodDeclaration package:analyzer/src/summary2/informative_data.dart
40358 kb 234812 PropertyAccessorElementImpl_ImplicitGetter package:analyzer/src/dart/element/element.dart
38075 kb 203067 ConstFieldElementImpl package:analyzer/src/dart/element/element.dart
32181 kb 686528 _InfoFormalParameter package:analyzer/src/summary2/informative_data.dart
29730 kb 475686 _Closure dart:core
27722 kb 6868 _TwoByteString dart:core
25594 kb 409517 _Map dart:collection
17778 kb 81273 ClassElementImpl package:analyzer/src/dart/element/element.dart
16479 kb 411893 Context
14672 kb 93903 LibraryImportElementImpl package:analyzer/src/dart/element/element.dart
14074 kb 90077 ParameterElementImpl package:analyzer/src/dart/element/element.dart
13316 kb 284078 _InfoFieldDeclaration package:analyzer/src/summary2/informative_data.dart
12937 kb 19673 Instructions
11985 kb 191772 InterfaceTypeImpl package:analyzer/src/dart/element/type.dart
-------- --------
1700325 kb 23223116
Instances of: _SimpleUri
size count class
-------- -------- --------
359 kb 4598 _SimpleUri dart:core
size unique-size count class data
-------- -------- -------- -------- --------
0 kb 0 kb 1 _OneByteString file:///Users/scheglov/dart/rwf-materials/01-setting-up-your-environment/project
0 kb 0 kb 1 _OneByteString file:///Users/scheglov/dart/rwf-materials/01-setting-up-your-environment/project
0 kb 0 kb 1 _OneByteString package:firebase_dynamic_links_platform_interface/src/platform_interface/platfor
0 kb 0 kb 1 _OneByteString package:infinite_scroll_pagination/src/widgets/helpers/default_status_indicators
0 kb 0 kb 1 _OneByteString package:infinite_scroll_pagination/src/widgets/helpers/default_status_indicators
0 kb 0 kb 1 _OneByteString package:infinite_scroll_pagination/src/widgets/helpers/default_status_indicators
0 kb 0 kb 1 _OneByteString package:firebase_remote_config_platform_interface/src/platform_interface/platfor
0 kb 0 kb 1 _OneByteString package:firebase_dynamic_links_platform_interface/src/method_channel/method_chan
0 kb 0 kb 1 _OneByteString package:firebase_core_platform_interface/src/platform_interface/platform_interfa
0 kb 0 kb 1 _OneByteString package:infinite_scroll_pagination/src/widgets/helpers/default_status_indicators
0 kb 0 kb 1 _OneByteString package:infinite_scroll_pagination/src/widgets/helpers/default_status_indicators
0 kb 0 kb 1 _OneByteString package:firebase_analytics_platform_interface/src/method_channel/method_channel_
0 kb 0 kb 1 _OneByteString package:firebase_remote_config_platform_interface/src/method_channel/method_chan
0 kb 0 kb 1 _OneByteString package:infinite_scroll_pagination/src/widgets/helpers/default_status_indicators
0 kb 0 kb 1 _OneByteString package:firebase_crashlytics_platform_interface/src/platform_interface/platform_
0 kb 0 kb 1 _OneByteString package:firebase_crashlytics_platform_interface/src/method_channel/method_channe
0 kb 0 kb 1 _OneByteString package:firebase_analytics_platform_interface/src/platform_interface/platform_in
0 kb 0 kb 1 _OneByteString package:firebase_dynamic_links_platform_interface/src/method_channel/utils/conve
0 kb 0 kb 1 _OneByteString package:infinite_scroll_pagination/src/widgets/helpers/default_status_indicators
0 kb 0 kb 1 _OneByteString package:firebase_core_platform_interface/src/platform_interface/platform_interfa
-------- -------- --------
260 kb 260 kb 4598
Change-Id: I31e0c5ee979e360021bf65a532424f0bd19a0820
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/279450
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2023-01-23 18:05:44 +00:00
52be8e0f3e
Issue 50496. Add mixin super invoked names to the unlinked signature.
...
Bug: https://github.com/dart-lang/sdk/issues/50496
Change-Id: I09c6dbc025cecc52e8f0340388bbf2b79ea78057
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/273831
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2022-12-07 22:17:22 +00:00
edb66fe3bb
Capture the prefix for references in the search index, take 2
...
Change-Id: I600dd7c064ce9779251d043305becd4a8203bbc5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/271802
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
2022-12-02 18:00:59 +00:00
f811d53450
Add some recent lint rules to analyzer
...
Change-Id: I962812880b660dd17c821fb4264da28783fa14ac
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/269441
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Samuel Rawlins <srawlins@google.com >
2022-11-14 04:14:40 +00:00
197344ba22
[analysis_server] Pass relation kind back from search for subtypes
...
Change-Id: I4faf4c6194967d69df74829bdb1789e691e4b985
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/263902
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2022-11-09 02:13:17 +00:00
b8ffc08d5b
Add AnalysisDriverForPackageBuild.sdkLibraryUris
...
https://github.com/dart-lang/build/pull/3389
Change-Id: Ib54ba5d5411fc6213ecf1733dd056f9347f27462
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/265401
Reviewed-by: Jake Macdonald <jakemac@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2022-10-24 21:06:27 +00:00
e139fb1527
Tidy some lint issues in analyzer
...
* Move many identifiers from snake_case or SCREAMING_SNAKE_CASE to
camelCase. I think I restricted the changes to private API.
* Add an ignore in generated files for constant_identifier_names;
we often just mirror names found in YAML files or whatever, where
things are not necessarily named according to Effective Dart
standards.
* Avoid some implementation imports which I think were accidental.
* Use single quotes in some more places.
Bug: https://github.com/dart-lang/sdk/issues/48784
Change-Id: I439fe50cb9f8f8f5e9c74ce594aea15e394ee7da
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/254500
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Samuel Rawlins <srawlins@google.com >
2022-08-10 21:23:21 +00:00
19271551ff
Cache error results locally in FileResolver.
...
There is no good mechanism to release these bytes from the shared
cache, we would have to either keep them forever, or release immediately
after we put them (so useless). So, as a compromise, we cache them
space-restrictedly locally.
Change-Id: Iae6227bda31b40374390a6a6bb02501222be4e92
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/246981
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Keerti Parthasarathy <keertip@google.com >
2022-06-02 17:00:48 +00:00
8ded7af5f5
Add LibraryOrAugmentationFileKind.exports/imports
...
These will replace eventually FileState.exported/importedFiles,
because only libraries or augmentation can have them. Also, we will
build Export/ImportElement(s) from them, when google3 switches to
using AnalysisDriver.buildPackageBundle(), so we are free to make
changes to the way linker works.
Change-Id: I66674dc7720aa704cfc36d16fc78e17dd05a8b93
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/246681
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2022-06-01 06:35:14 +00:00
eb32d0c7be
PackageBundle from IDL.
...
We use PackageBundleBuilder / PackageBundleReader instead.
Change-Id: Icd67eefbe739968a08b90fd8c05e914ae1ac6d12
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/246300
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2022-05-27 18:31:40 +00:00
f0a07ac120
Enforce use_super_parameters in analyzer/.
...
Change-Id: I92a002d69a10b83b9600455156a43c1592439477
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/245420
Reviewed-by: Samuel Rawlins <srawlins@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2022-05-19 19:36:41 +00:00
139385c615
Breaking changes for analyzer version 4.0.0
...
Change-Id: I26961f29f9171e94db2f5c95f1f8af5fd01bb9b9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/233681
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Jens Johansen <jensj@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2022-04-07 06:52:27 +00:00
c2c1cdc153
Move DependencyWalker from analyzer into _fe_analyzer_shared.
...
For https://github.com/dart-lang/language/issues/731 (improved
inference for fold etc.), I want to re-use this logic as part of the
algorithm for computing the order in which to visit an invocation's
closure arguments. That algorithm, in turn, will be shared between
the front end and the analyzer, so the DependencyWalker needs to move
into _fe_analyzer_shared first.
Change-Id: I953e027448cbd660dc30f92d1bdcce26a8d7bda3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/238920
Reviewed-by: Johnni Winther <johnniwinther@google.com >
Commit-Queue: Paul Berry <paulberry@google.com >
2022-03-28 12:47:10 +00:00
9a79d61c36
Do not rename method parameter names in overrides
...
Change-Id: I8c2f91a56c767c89dc4d0bea22b64dec147870c4
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/237852
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Samuel Rawlins <srawlins@google.com >
2022-03-21 17:32:22 +00:00
e2f615fa9d
Remove the temporary SummaryDataStore constructor.
...
Change-Id: Id14fc6502bb0885b6843748a1ed833656e1a2df9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/237625
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Samuel Rawlins <srawlins@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2022-03-16 23:53:45 +00:00
98fde68b2b
Replace SummaryDataStore default constructor.
...
Change-Id: If34d2365ecd2a643a40d660250bf2d5936ab953f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/236305
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2022-03-09 21:33:35 +00:00
2192cc6098
Deprecate SummaryDataStore() constructor with paths.
...
Change-Id: I2317a7ae0dbeefafc7e09ff2032b77fa022eb534
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/235403
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2022-03-04 20:01:20 +00:00
f481cbf2fa
Use IS_INVOKED_BY_ENUM_CONSTANT_WITHOUT_ARGUMENTS
...
Change-Id: I870ece21708c1e96bf8b3bd4d4373ca6bdade9cf
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/232133
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2022-02-09 16:16:56 +00:00
a1d5eba2ae
analyzer: do not use leading underscores in local variable names
...
This is not yet enforced in analysis_options.yaml due to a just-closed
bug in linter.
Change-Id: I450ed2a24f1de7657b2f535a1dcdabdb1f9afbbb
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/226321
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Samuel Rawlins <srawlins@google.com >
2022-01-05 18:00:44 +00:00
4125babe76
Remove SummaryBasedDartSdk default constructor.
...
Change-Id: I2eca1a00079f51d1fdac34b1112a23ed40117cb4
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/225040
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Samuel Rawlins <srawlins@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2021-12-21 00:08:53 +00:00
f317d7c1db
Breaking changes for analyzer version 3.0.0
...
Internal presubmit:
https://fusion2.corp.google.com/presubmit/tap/366560067/OCL:366560067:BASE:415321249:1639080094301:ae113907
Change-Id: Idf9cb7d98f490409bec4eab8833b95328ece9e86
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/212610
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Samuel Rawlins <srawlins@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2021-12-09 23:07:19 +00:00
d6d45d96f8
Deprecate Source.modificationStamp
...
Change-Id: Id7f361beff1c4e3f9edc743c58cce7888d330c1f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/220860
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2021-11-19 19:33:07 +00:00
fb05622b3b
Deprecate Source.uriKind
...
We almost can remove it.
Unfortunately surveyor/lib/src/analysis.dart uses it, so we need to
update it first.
Change-Id: I239d24506f99183147bf45744a6f8d66d3eb4f94
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/220826
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Phil Quitslund <pquitslund@google.com >
2021-11-19 18:29:07 +00:00
9d7df725f6
Deprecated restoreAbsolute(), use pathToUri().
...
Change-Id: Id705e4f0eda7beba4c3d2dd2f6ba4b82691ef1f8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/220480
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Samuel Rawlins <srawlins@google.com >
2021-11-18 21:17:17 +00:00
6451799849
API for package:build
...
Change-Id: I00bb4d6866202d404eee0b8bf6c13b4702cab617
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/217561
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Jake Macdonald <jakemac@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2021-10-21 19:38:35 +00:00
519c222101
Use Uint8List in more places.
...
Change-Id: Ib3bd4c4833c2f3fa497ffbadf9c4f95dd7a062b1
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/216688
Reviewed-by: Samuel Rawlins <srawlins@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2021-10-13 22:56:56 +00:00
f83b1dfb9f
Remove unused IDL declarations.
...
Change-Id: Ib753bdd4b9c0464f0a0ed52f11aa473644d89ac5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/216480
Reviewed-by: Samuel Rawlins <srawlins@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2021-10-12 22:34:35 +00:00
1edcd482f3
Use Uint8List in ResourceProvider(s).
...
Change-Id: I0f0d3af1d196117c3e722013eb708af27130269e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/216278
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Samuel Rawlins <srawlins@google.com >
2021-10-12 21:04:13 +00:00
c3b31a94d3
Return Uint8List from summary builders.
...
R=brianwilkerson@google.com
Change-Id: Ib8e71d9094049129b3c4c6d3d3dcbf3f055e2864
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/216271
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2021-10-12 01:20:44 +00:00
cef4426306
Store unlinked data for AnalysisDriver in a more direct binary format.
...
Change-Id: Ie1421bdda0c9962a097d1bb77587c2088d805db4
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/216264
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2021-10-11 22:18:33 +00:00
88a5f824b2
Return Uint8List from ApiSignature.
...
Change-Id: I14c184d0b1999379a5a07ed9dda4fc7f8e4a901b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/216265
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2021-10-11 21:22:18 +00:00
5eeb0b3964
Support for 'Import Library' quick fixes in Cider.
...
Bug: https://buganizer.corp.google.com/issues/201080674
Change-Id: Ie3c410f51df9d29725823f2aa6797fff54391f88
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/215640
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Keerti Parthasarathy <keertip@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2021-10-05 20:44:22 +00:00
51d5c58d6a
Remove redundant imports from analyzer
...
Many of these are a redundancy between
'package:analyzer/src/generated/source.dart' and
'package:analyzer/src/generated/source_io.dart'
I chose to remove the latter, for no particular reason.
Bug: https://github.com/dart-lang/sdk/issues/44569
Change-Id: Ic69b09fd502c978cef9e4d3b8a0ef9acd92d5184
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/213849
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Samuel Rawlins <srawlins@google.com >
2021-09-20 15:22:51 +00:00
74d2704382
Separate index/search kind for ConstructorReference.
...
When we just search, it is enough to know that there is just any
reference kind, however wheb I attempted to implemented rename
refactoring, I realized that we need to know if the reference is
from a ConstructorReference, so `.new` is required.
I think this change will let us do this, however I still have not
tried to actually wire it, so might still be wrong.
Change-Id: Ie97e23d391ea89d7f3695663368835e747cbeee5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/212546
Reviewed-by: Samuel Rawlins <srawlins@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2021-09-07 16:52:32 +00:00
88a41363bc
[analyzer] Support generic type aliases in available declarations
...
Fixes https://github.com/dart-lang/sdk/issues/46409 .
Change-Id: I16fe47f52254956e58cb5f034c49e1d8fa4c22c5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/204403
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2021-08-31 17:35:04 +00:00
51b78099da
Clean up computing unlinked/elements/unresolved salt, use toUint32List().
...
Change-Id: Ib667dd3553edcf55afed0eaa9e6503556fe1e843
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/202341
Reviewed-by: Samuel Rawlins <srawlins@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2021-06-04 02:03:35 +00:00
b10a592341
Add a url field to DiagnosticMessage.
...
This paves the way for allowing analyzer and analysis server clients
to format diagnostic message URLs in a special way (e.g. to make them
clickable).
Note that DiagnosticMessage is part of the public API of the analyzer,
so I've retained the old behavior in a deprecated fashion to avoid
breaking clients that don't yet handle diagnostic messages containing
URLs.
See
https://dart-review.googlesource.com/c/sdk/+/193749/comment/86d1ce4b_77a60b1e/
for additional discussion.
Change-Id: Iae9d43a2be7dbc67cb7cb82afe0a7824043d6113
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/196101
Commit-Queue: Paul Berry <paulberry@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2021-04-23 20:34:32 +00:00
8161b299c9
When in Cider 'part of some.name;' try to find the library as a sibling file.
...
Change-Id: I489bac7ebaaa5b61e7972f1ea01a4613220bde7c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/192980
Reviewed-by: Keerti Parthasarathy <keertip@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2021-04-16 23:56:47 +00:00
46e4363df5
Enforce lint: always_use_package_imports
...
Change-Id: Ib7c9f2b4fe3d3d1a874f97f73def6ba1ffaf911e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/187360
Reviewed-by: Samuel Rawlins <srawlins@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2021-02-25 16:57:16 +00:00
8a80001cb9
Fix null checks in generated summary format.
...
Change-Id: Ie8c0f19c1604a92c07b8be98301d5ee8f89a2ed8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/184520
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2021-02-11 22:21:57 +00:00
1d5555e67a
Remove support for variants in summary format.
...
We don't use it anymore.
Change-Id: I3c1eaa7bb19629275a2839fd53607d5388178a94
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/184340
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2021-02-11 17:36:46 +00:00
Konstantin Shcheglov