e85e203e73
Deprecate DartType.name
...
Change-Id: If3a967bba976aa78493764513edbb3d406b08d27
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/130625
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2020-01-08 07:00:59 +00:00
39f14a000e
Rewrite most getDisplayString() to ElementDisplayStringBuilder.
...
R=brianwilkerson@google.com
Change-Id: I500d0045873a12d550d9ffe302e066a63ba56660
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/130221
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2020-01-06 16:43:40 +00:00
e5705943d8
Enable prefer_conditional_assignment in several packages
...
Other than the changes to the code generators and the analysis options
files, the changes were all generated by dartfix.
Change-Id: I80055e3992452c5b40eed41ac79807cf5c932976
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/130340
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2020-01-06 05:19:19 +00:00
fbadd6a832
Enable prefer_equal_for_default_value in several packages
...
Other than the changes to the code generators and analysis options files,
all of these changes were produced using dartfix.
Change-Id: I24f47b9f6b929b0b5d5e08da7ef2016f4bdc4108
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/130260
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2020-01-05 20:59:19 +00:00
850ca2d410
Add Element.getDisplayString(withNullability), use it in analyzer.
...
R=brianwilkerson@google.com
Change-Id: Ic4924e19612f2a7713f9a3f2059a880ebff9d2db
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/129983
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2020-01-01 19:01:14 +00:00
7d41ae7d15
Enable unnecessary_this in several packages
...
Change-Id: I743066d66dbf1dff984e8f8bf5b7a472c9bc7ff7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/129821
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2019-12-28 20:43:16 +00:00
e2431d1452
Update the generators to not generate unnecessary uses of "this"
...
Change-Id: I20d15e3b0f8046065906d96860073ad4cf353868
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/129815
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2019-12-28 16:23:06 +00:00
278551426e
Enable prefer_adjacent_string_concatenation in most of the packages
...
Change-Id: I4d061710573c63a9db700c6156470705cf4f8548
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/129762
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2019-12-27 17:03:35 +00:00
c547f5d933
Enable prefer_generic_function_type_aliases in most of the packages
...
Change-Id: I1338e731aa3f42f67fec605b20455a83fd5fce43
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/129760
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2019-12-27 00:43:14 +00:00
2fb3f09948
Extract TypeProvider class into lib/dart/element/type_provider.dart file
...
Change-Id: I96cdfccc33e35a9625c14a89a08826758eac0f2c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/129601
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2019-12-26 21:31:04 +00:00
1fe55651cb
Generate end-of-line doc comments in server and plugin packages
...
Change-Id: I1d5517932e1c78744cfe43fc6a768a104e527091
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/129520
Reviewed-by: Phil Quitslund <pquitslund@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2019-12-24 00:34:30 +00:00
a3d5ae4b30
Enable prefer_is_empty and prefer_is_not_empty in analyzer_plugin and analyzer_cli
...
Change-Id: I277b05dbeece24c227611fb0ebd62c806ec13b6e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/129020
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2019-12-19 01:51:53 +00:00
991f529122
Remove unnecessary uses of const in analyzer-plugin
...
Change-Id: I200f499558e3eb473e150da606af240bd12380c8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/128841
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2019-12-18 14:29:01 +00:00
03c33360b7
Remove unnecessary uses of new in analyzer_plugin
...
Other than
- the change to enable the lint (in analysis_options.yaml) and
- updates to the generator (in tool) to stop generating 'new',
all of the changes were generated by dartfix.
Change-Id: I9d14b99ab748ef5b80f8800a802e20100eee04a1
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/128577
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2019-12-17 20:12:05 +00:00
2e1dd98e5e
Create burndown lists for enabling the pedantic lints
...
Change-Id: Ie57ea31912ba4d702b82ffd327889044988b1ab5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/128520
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2019-12-15 21:58:36 +00:00
b92cd2cb95
Deprecate DartType.displayName, use getDisplayString() instead.
...
We call it with `withNullability: false` almost everywhere.
My attempt to update all places turned out to be a long chain of
changes. So, instead I will make decisions and updates in separate
CLs, starting with ErrorReporter.
R=brianwilkerson@google.com , paulberry@google.com
Change-Id: I9d72475577ba2934bed1c06a4808ab620e92a20e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/127441
Reviewed-by: Paul Berry <paulberry@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2019-12-06 22:43:59 +00:00
674810a38d
Generated overriding methods throw an exception rather than returning null
...
Change-Id: I4e0b19b4773e557b8e31583c4ad110ad79a3e426
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/126361
Reviewed-by: Danny Tuppeny <dantup@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2019-11-26 18:00:09 +00:00
273ca5858b
Deprecate AnalysisContext.typeProvider/typeSystem
...
Change-Id: I5235aa38bcde93618a10b88da9ad6a8c3e5dc29c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/126141
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2019-11-25 22:00:47 +00:00
6294c73f3e
Deprecate 'typeSystem' parameter for InheritanceManager3.
...
Change-Id: If14eb8900b0fb5cac5e49cf865f2e6e3a0a0263d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/126083
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2019-11-22 23:08:41 +00:00
615928c514
Stop referencing non-API TypeSystem in analyzer.
...
Replace it with TypeSystem from lib/dart/element/type_system.dart,
or (internally) with TypeSystemImpl.
We keep the old TypeSystem where its is exposed from API:
- ResolveResult.typeSystem
- AnalysisSession.typeSystem
- AnalysisContext.typeSystem
We will make changes to these as a breaking change later.
Change-Id: I40ca53ea77e440457c6d0f3832ec3b6286bacdf0
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/125770
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2019-11-21 01:09:24 +00:00
1e7d4fd81e
Simplify ForEachPartsWithDeclaration case in LocalDeclarationVisitor.
...
These nodes are never null.
R=brianwilkerson@google.com
Change-Id: Ia0b073f0816c7ba6243f0a8b47bb8b18b48ef802
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/125560
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2019-11-18 18:10:33 +00:00
8fbb053092
Issue 39021. Guard against invalid generic type alias, without function type.
...
R=brianwilkerson@google.com
Bug: https://github.com/dart-lang/sdk/issues/39021
Change-Id: I0259ef04f95e1935ca273b5540aafb069c7ad455
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/125526
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2019-11-18 16:06:53 +00:00
fe3fadbdba
Issue 39025. ForEachPartsWithIdentifier does not define anything, don't pretend that it is a LocalVariableElement.
...
R=brianwilkerson@google.com
Bug: https://github.com/dart-lang/sdk/issues/39025
Change-Id: Ieda56c73a1928434a29aa947c44fc29b66a79464
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/125525
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2019-11-18 15:44:13 +00:00
2a5ece5d89
Fix analyzer_plugin tutorial link
...
Note that this link is dead on pub.dev: https://pub.dev/packages/analyzer_plugin
Change-Id: Ibdf97510d927517be651cb5f866601aa275ae7e3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/124081
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Samuel Rawlins <srawlins@google.com >
2019-11-04 16:32:18 +00:00
924ec34e01
Remove analysis logger, replace with calls to InstrumentationService
...
Change-Id: Ifddd58b731aa0af8f76a91261757997dc52a9fc7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/123328
Commit-Queue: Mike Fairhurst <mfairhurst@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2019-10-31 21:26:44 +00:00
fb362b54a7
Stop using FunctionTypeAliasElement.parameters/returnType in analyzer.
...
The goal is to stop implementing FunctionTypedElement in
FunctionTypeAliasElement, and keep only TypeParameterizedElement.
For some time we will have to keep implementing TypeDefiningElement, it
is used currently as a marker for top-level declarations.
Change-Id: I0062aaa66861a4d7dd5337eb9a44338ad49f5901
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/123545
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2019-10-30 21:36:33 +00:00
abecefd1ac
Forward compatible portion of CL that does not set types for identifiers that are not expressions.
...
The full CL:
https://dart-review.googlesource.com/c/sdk/+/119761
Change-Id: I9c909a4e1eec5d05f5718849ea45da79f01c5291
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/121643
Reviewed-by: Paul Berry <paulberry@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2019-10-15 17:29:07 +00:00
164e11b542
Prepare to publish analyzer_plugin version 0.2.1.
...
Change-Id: If363a80390fdde940cf4421f992c28ae0861a82a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/120931
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Paul Berry <paulberry@google.com >
2019-10-09 21:48:10 +00:00
595022bdea
Remove summary1, part 1.
...
Change-Id: I557785ac13fa411280ce032324b0305bf25a0a6d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/119170
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Paul Berry <paulberry@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2019-09-28 14:30:05 +00:00
d2c0bffde3
Bump analyzer_plugin's maximum supported analyzer version
...
analyzer_plugin has max constraint to analyzer version 0.38.0 while the latest version is 0.38.3 and it causes a lot of issues for libraries that use it (built_value for instance)
Closes #38558
https://github.com/dart-lang/sdk/pull/38558
GitOrigin-RevId: 83fb8a811cae2845aec5e66a2f53259e7b347eb2
Change-Id: I68a7f4e8108d06565e9ef9d2d0411c97d4f09993
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/118721
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2019-09-26 14:04:42 +00:00
6066271811
Don't use Element.type in analyzer_plugin.
...
Change-Id: Ia4223916118d1ce5ddee143044f6bd36d44cf2d1
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/118421
Reviewed-by: Mike Fairhurst <mfairhurst@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2019-09-20 22:37:23 +00:00
d4f1b8f8db
Deprecate TypeProvider.futureType/futureOrType
...
R=paulberry@google.com
Change-Id: Idde7d82b217b5921c0770d9b69f6934a1e1fc493
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/117682
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2019-09-18 15:37:21 +00:00
74fb313c78
nodeInList utility
...
Change-Id: I213dcb281c8484bc2f44a2046dbbe54e92e5d645
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/117422
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Phil Quitslund <pquitslund@google.com >
2019-09-16 21:56:21 +00:00
6a9d792454
Move NullabilitySuffix to API.
...
R=brianwilkerson@google.com
Change-Id: I58547075d3472e6708e6b5ff1c6d89f768aba66a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/117440
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2019-09-16 21:14:11 +00:00
f470695875
Stop using ClassElement/TypeParameterElement.type in tests.
...
There are 4 references to `type` left in tests, because it looks
that these tests validate peculiarities of the `type` getter itself.
I will remove them later, when the production code is off `type`.
R=brianwilkerson@google.com
Change-Id: I4b8a590e561fe3d3103500b097c13d989514976e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/117280
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2019-09-16 15:53:29 +00:00
25edeb7ae1
Support completing the extension name locally
...
Change-Id: I49174918ca84f2aaafe4b47200e9396f2191a727
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/116802
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
2019-09-11 21:42:26 +00:00
4f8f592b51
Remove adding prefixes for auto imports.
...
Adding import prefixes often has false positives.
At this point I think that this feature does more harm than benefit.
R=brianwilkerson@google.com
Bug: https://github.com/dart-lang/sdk/issues/38326
Change-Id: I99e3400aebc062d9de3c298d7ed58520534d061c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/116746
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2019-09-11 19:04:47 +00:00
eb60f0531e
Support a fix to add a setter, both in extensions and elsewhere
...
Change-Id: I94d7ec13a2bcf73b120be18facf473a4710a6e28
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/116053
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2019-09-06 21:59:14 +00:00
8022f885af
Stop using TestTypeProvider in analyzer_plugin.
...
R=brianwilkerson@google.com
Change-Id: Idfc57043d72793858805aed745db02c1740df28a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/116081
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2019-09-06 19:01:29 +00:00
9f57cf71d7
Add a blacklist to spelling tests; spell-check all packages and sdk with blacklist
...
Change-Id: I5bf3d5784d2ba48568a2699bb09ae39a85be17c4
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/115214
Reviewed-by: Johnni Winther <johnniwinther@google.com >
Commit-Queue: Jens Johansen <jensj@google.com >
2019-09-03 12:39:24 +00:00
b6897ea094
Stop using resolutionMap in analyzer and analysis_server.
...
R=brianwilkerson@google.com , paulberry@google.com
Change-Id: Ie8f75e330e9efee67ded892929a3d78b7de1c586
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/114565
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2019-08-26 23:18:54 +00:00
74e09abc6e
[CFE] Remove/move file that wasn't needed by frontend; cleanup pubspec.yaml a bit
...
Change-Id: I204b844e7f1cb892a529bca3a13017ed836275f8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/114074
Reviewed-by: Paul Berry <paulberry@google.com >
Commit-Queue: Jens Johansen <jensj@google.com >
2019-08-23 07:42:03 +00:00
04bd34ed87
Issue 37916. The name of ConstructorName cannot be shadowed.
...
R=brianwilkerson@google.com
Bug: https://github.com/dart-lang/sdk/issues/37916
Change-Id: I905e0b9ebfa4514f9a7f28555f95a2154bcf2f04
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/113846
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2019-08-20 18:31:41 +00:00
6408a9cc4d
Tweaks for writeType() and summary2.
...
R=brianwilkerson@google.com
Change-Id: If3c682f3dfc12a9e13d805bc25476b16249c7754
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/113273
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2019-08-17 07:28:52 +00:00
802937e5a6
Add support for completions inside extension (and mixin) bodies
...
Change-Id: I549e91ac7a8e293ea6592043988a67a2da680620
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/113133
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Dan Rubel <danrubel@google.com >
2019-08-15 16:39:05 +00:00
0e24437b81
Replace InterfaceType with Substitution in Member(s).
...
I ran it in google3:
https://test.corp.google.com/ui#id=OCL:261214112:BASE:261244079:1564722983792:f6286cfb
Change-Id: I820d2dbbaefe495c20b0d8fe3f7c54f1766d5689
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/111383
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2019-08-02 19:34:18 +00:00
1a0fe21fb2
Add ExecutableElement(s) based InheritanceManager3, and switch analyzer to it.
...
This reverts commit b8614ca613https://dart-review.googlesource.com/c/sdk/+/110941
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Paul Berry <paulberry@google.com >
2019-07-29 19:02:24 +00:00
ec5bf35152
Update analysis_server and analyzer_plugin to stop using DartType.isSubtypeOf().
...
R=brianwilkerson@google.com , paulberry@google.com
Change-Id: If7365bd82b97bd692af9508697307976ea7c69e7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/110881
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Paul Berry <paulberry@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2019-07-29 00:19:37 +00:00
b8614ca613
Revert InheritanceManager3 changes.
...
These changes were inadvertenly rolled out in a way that breaks
clients, so we need to stage them out more gradually. See discussion
at
https://dart-review.googlesource.com/c/sdk/+/110552/2/pkg/analyzer/lib/src/generated/resolver.dart#3768
This reverts commit 5b5ddeda92e76879acc427bec56744https://dart-review.googlesource.com/c/sdk/+/110841
Auto-Submit: Paul Berry <paulberry@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Paul Berry <paulberry@google.com >
2019-07-28 13:54:09 +00:00
27bec56744
Add ExecutableElement(s) based InheritanceManager3, and switch analyzer to it.
...
Initial: 5d6bab4ed239afa4e555https://dart-review.googlesource.com/c/sdk/+/110552
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2019-07-26 16:16:11 +00:00
Konstantin Shcheglov