dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 3 Packages Projects Releases Wiki Activity
29,575 Commits 2 Branches 0 Tags
6ea61b568612e69e40779d4efbf8317cf204edeb
Commit Graph

7512 Commits

Author SHA1 Message Date
kustermann@google.com 700bea9f78 Parenthesize expression using bit-wise and on windows 
R=sgjesse@google.com

Review URL: https://codereview.chromium.org//895533006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43640 260f80e4-7a28-3924-810f-c04153c831b5
 2015-02-10 12:17:54 +00:00
sgjesse@google.com 7b7ac3620a Add support to specify the source address for socket connect 
BUG=http://dartbug.com/22253
R=kustermann@google.com, lrn@google.com

Review URL: https://codereview.chromium.org//908873002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43638 260f80e4-7a28-3924-810f-c04153c831b5
 2015-02-10 11:56:51 +00:00
kustermann@google.com f0e8ff5381 Fix mac build: Add new disable_tokens=false value to super constructor call 
Review URL: https://codereview.chromium.org//899593004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43634 260f80e4-7a28-3924-810f-c04153c831b5
 2015-02-10 10:34:35 +00:00
kustermann@google.com 1c7ef3c4f2 Implement mac support for having multiple Dart_Port's registered on one OS socket 
R=sgjesse@google.com

Review URL: https://codereview.chromium.org//908183002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43632 260f80e4-7a28-3924-810f-c04153c831b5
 2015-02-10 10:15:33 +00:00
kustermann@google.com 74c0f65c89 Implement windows support for having multiple Dart_Port's registered on one OS socket 
R=sgjesse@google.com

Review URL: https://codereview.chromium.org//910863003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43631 260f80e4-7a28-3924-810f-c04153c831b5
 2015-02-10 10:08:49 +00:00
sgjesse@google.com 91e7a32eb5 Remove SetNonBlocking/SetBlocking methods from Socket and add missing close-on-exec 
The methods SetNonBlocking/SetBlocking on Sockets where not implemented on Linux
and not used on Windwsm. Removed and call directly to FDUtils when needed.

In Socket::Accept setting close on exec was missing on OS X and Android.

R=kustermann@google.com
BUG=

Review URL: https://codereview.chromium.org//907883002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43627 260f80e4-7a28-3924-810f-c04153c831b5
 2015-02-10 07:29:36 +00:00
johnmccutchan@google.com 20efd2f0c4 Add Log::VPrint and remove duplicated code. 
BUG=
R=srdjan@google.com

Review URL: https://codereview.chromium.org//913603002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43624 260f80e4-7a28-3924-810f-c04153c831b5
 2015-02-09 23:28:47 +00:00
johnmccutchan@google.com 420aa94c56 Split profiler.cc into profiler.cc and profiler_service.cc 
BUG=
R=asiva@google.com

Review URL: https://codereview.chromium.org//864173008

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43623 260f80e4-7a28-3924-810f-c04153c831b5
 2015-02-09 23:22:19 +00:00
srdjan@google.com 81d8099650 Redesign inlining interval computation. 
Review URL: https://codereview.chromium.org//904763003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43622 260f80e4-7a28-3924-810f-c04153c831b5
 2015-02-09 23:11:05 +00:00
johnmccutchan@google.com 23763129a5 Fix missing new lines in disassembly 
BUG=
R=srdjan@google.com

Review URL: https://codereview.chromium.org//908853005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43621 260f80e4-7a28-3924-810f-c04153c831b5
 2015-02-09 22:58:16 +00:00
turnidge@google.com e1f31e1513 Add a working command line debugger to Observatory. 
Try it!

Review URL: https://codereview.chromium.org//866663003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43618 260f80e4-7a28-3924-810f-c04153c831b5
 2015-02-09 22:03:31 +00:00
hausner@google.com 22054b3119 Make yield* throw an error if not yielding an Iterable 
Fixes issue 22323

R=gbracha@google.com

Review URL: https://codereview.chromium.org//910923002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43616 260f80e4-7a28-3924-810f-c04153c831b5
 2015-02-09 21:47:12 +00:00
rmacnak@google.com ccc8865226 Random-walk fuzzer for the Dart VM. 
Start with all the classes and libraries and various interesting values.  Repeatedly choose one as a receiver, construct a message it is likely to understand, send the message, and add the result.

R=groebert@google.com

Review URL: https://codereview.chromium.org//801113003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43615 260f80e4-7a28-3924-810f-c04153c831b5
 2015-02-09 21:32:37 +00:00
johnmccutchan@google.com 74469b2a9f Use printf("%s", str); to avoid glibc assertion 
BUG=

Review URL: https://codereview.chromium.org//911713002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43614 260f80e4-7a28-3924-810f-c04153c831b5
 2015-02-09 21:28:54 +00:00
johnmccutchan@google.com ddbefcab7e Fix disassembly comments 
BUG=

Review URL: https://codereview.chromium.org//914463002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43610 260f80e4-7a28-3924-810f-c04153c831b5
 2015-02-09 20:57:41 +00:00
johnmccutchan@google.com 635ba4bbd9 Port flow_graph*, disassembler to ISL_Print 
BUG=
R=srdjan@google.com

Review URL: https://codereview.chromium.org//907093002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43609 260f80e4-7a28-3924-810f-c04153c831b5
 2015-02-09 20:49:32 +00:00
johnmccutchan@google.com fee26a9bbb Fix Linux build 
BUG=

Review URL: https://codereview.chromium.org//901303005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43605 260f80e4-7a28-3924-810f-c04153c831b5
 2015-02-09 19:06:55 +00:00
johnmccutchan@google.com a6483aefd1 Per isolate Log with block support 
BUG=
R=srdjan@google.com

Review URL: https://codereview.chromium.org//913503004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43604 260f80e4-7a28-3924-810f-c04153c831b5
 2015-02-09 18:54:20 +00:00
zra@google.com 9705799256 Adds dart_debug parameter to GN build. 
R=johnmccutchan@google.com

Review URL: https://codereview.chromium.org//905753003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43602 260f80e4-7a28-3924-810f-c04153c831b5
 2015-02-09 17:02:12 +00:00
vegorov@google.com e5f3e69eeb Add --print-flow-graph-filter to allow filtering debugging output. 
Extend filtering pattern with % symbol: xyz% matches names that end at "...xyz".

R=fschneider@google.com
BUG=

Review URL: https://codereview.chromium.org//905363002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43598 260f80e4-7a28-3924-810f-c04153c831b5
 2015-02-09 16:26:46 +00:00
fschneider@google.com 56853c6bc9 Undo unnecessary changes to ARM assembler. 
R=zra@google.com

Review URL: https://codereview.chromium.org//885443012

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43596 260f80e4-7a28-3924-810f-c04153c831b5
 2015-02-09 16:14:11 +00:00
fschneider@google.com df94b27666 VM: Align implementations of assembler constant pools. 
Add Support for adding patchable/non-patchable entries on ARM/MIPS like
already done for x64/ARM64.

R=vegorov@google.com

Review URL: https://codereview.chromium.org//886173003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43589 260f80e4-7a28-3924-810f-c04153c831b5
 2015-02-09 11:47:36 +00:00
kustermann@google.com ebde0dbaeb Extract common Mask/Dart_Port settings of linux event handler implementation to eventhandler.h 
R=sgjesse@google.com, wibling@google.com

Review URL: https://codereview.chromium.org//905733002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43585 260f80e4-7a28-3924-810f-c04153c831b5
 2015-02-09 08:50:32 +00:00
regis@google.com 62a1d34c36 Clarify result returned by remainder intrinsics. 
R=zra@google.com

Review URL: https://codereview.chromium.org//905653004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43576 260f80e4-7a28-3924-810f-c04153c831b5
 2015-02-06 22:42:53 +00:00
koda@google.com f3387ccc3f In this first version, we just track the set of objects and verify that calls to release match. The next step is to copy the data to a side buffer, which is then unmapped on release to catch use-after-release bugs. 
Explicitly disallow nested acquires, since the visibility of writes would depend on whether data is acquired in-place.

Also explicitly disallow other access to the data (e.g., trough list accessors) for the same reason.

R=asiva@google.com

Review URL: https://codereview.chromium.org//905823002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43575 260f80e4-7a28-3924-810f-c04153c831b5
 2015-02-06 22:31:46 +00:00
regis@google.com 8e5cd57b7e Add modPow(int exponent, int modulus) method to int abstract class. 
Provide a dart2js implementation.

R=floitsch@google.com, lrn@google.com

Review URL: https://codereview.chromium.org//896393004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43572 260f80e4-7a28-3924-810f-c04153c831b5
 2015-02-06 21:46:32 +00:00
koda@google.com 0edad1cc7c Fix Dartium DEBUG failures by ensuring proper scoping within GC prologue/epilogue. 
This ensures that the zone-allocating parts of ScavengeVisitor and MarkingVisitor are destroyed before the Dartium GC epilogue deletes the zone in which they were allocating.

(This only explains DEBUG mode failures, caused by the zapping in the GrowableArray destructor, because the values of the arrays are not used after the epilogue runs.)

BUG=dart:22224
R=asiva@google.com

Review URL: https://codereview.chromium.org//896133003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43558 260f80e4-7a28-3924-810f-c04153c831b5
 2015-02-06 17:38:39 +00:00
koda@google.com 253de5e60a Fix race condition in Redirection global list using CAS. 
Note that a simple Mutex cannot be used, since the profiler may interrupt the thread at any point, and also walks this list.

Review URL: https://codereview.chromium.org//898123002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43557 260f80e4-7a28-3924-810f-c04153c831b5
 2015-02-06 15:50:08 +00:00
johnmccutchan@google.com 7cfc0d2e78 Fix checked mode failure in _asyncLoadError 
Fixes dartbug.com/22295

Review URL: https://codereview.chromium.org//877763004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43554 260f80e4-7a28-3924-810f-c04153c831b5
 2015-02-06 14:39:08 +00:00
kustermann@google.com 3ea331e741 Introduce a kSetEventMaskCommand, some cleanups in windows eventhandler 
R=sgjesse@google.com

Review URL: https://codereview.chromium.org//900363004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43547 260f80e4-7a28-3924-810f-c04153c831b5
 2015-02-06 09:36:57 +00:00
iposva@google.com 6898a10c93 - Make sure to fail early if an non-stacktrace is passed into the VM 
where we expect one.

Review URL: https://codereview.chromium.org//908433002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43546 260f80e4-7a28-3924-810f-c04153c831b5
 2015-02-06 09:23:57 +00:00
koda@google.com 96bed4dd79 Add missing call to VerifiedMemory::Accept when initializing Smi field. 
BUG=dart:22224
R=asiva@google.com

Review URL: https://codereview.chromium.org//898453009

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43533 260f80e4-7a28-3924-810f-c04153c831b5
 2015-02-06 00:02:29 +00:00
kustermann@google.com a7f50cd5d2 Move CircularLinkedList to eventhandler.h 
Move constants and InterruptMessage to eventhandler.h

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43524 260f80e4-7a28-3924-810f-c04153c831b5
 2015-02-05 21:45:47 +00:00
hausner@google.com 00366dcfa1 Fix Windows build 
Review URL: https://codereview.chromium.org//903843002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43522 260f80e4-7a28-3924-810f-c04153c831b5
 2015-02-05 21:00:02 +00:00
hausner@google.com a28a13d936 Attempt to fix the Windows build 
Review URL: https://codereview.chromium.org//901263002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43518 260f80e4-7a28-3924-810f-c04153c831b5
 2015-02-05 19:33:37 +00:00
terry@google.com 06f06cd029 Fixed Window's Debug warning, results in compilation failure. 
Reviewers=asiva@google.com

R=asiva@google.com

Review URL: https://codereview.chromium.org//904603003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43517 260f80e4-7a28-3924-810f-c04153c831b5
 2015-02-05 19:30:16 +00:00
hausner@google.com 2487c76886 Add support for sync* and yield and yield* 
R=srdjan@google.com

Review URL: https://codereview.chromium.org//888463004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43516 260f80e4-7a28-3924-810f-c04153c831b5
 2015-02-05 18:36:40 +00:00
turnidge@google.com 8ebad12515 Fix dart warnings. 
BUG=
R=johnmccutchan@google.com

Review URL: https://codereview.chromium.org//899303002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43515 260f80e4-7a28-3924-810f-c04153c831b5
 2015-02-05 18:21:23 +00:00
turnidge@google.com d554f4fbfe Finish moving service protocol to json rpc. 
Service

- Remove support for old-style service requests.

- Drop 'arguments' from JsonStream and ServiceRequestHandler.

- Json-rpc inspired renaming: command->method, options->params all over.

- Implement getFlagList, setFlag, getObjectByAddress.

- Add helpers PrintMissingParamError and PrintInvalidParamError
  to make our error messages more regular.

- Update tests.

- Service_SetSource removed for now.  John will resurrect.

Observatory

- Drop all Deprecated 'get' functions.  We now use json rpc for everything.

- Drop 'link' and 'relativeLink' from ServiceObject -- they were
  ui-specific and they are no longer meaningful anyways.  Use 'id' instead.

- New pages: VMPage, FlagsPage, InspectPage, ErrorPage.  All urls
  used by Observatory are now 'new school' and have a proper
  prefix.  ErrorPage is the new catch-all.

- Pages now use a Uri instead of a url String.  This lets them
  grab query parameters more easily.

- SimplePage replaces IsolateSuffixPage.

- We now use gotoLink() or makeLink() to make our navigation
  links.  gotoLink gets some optional parameters to make it
  easier to construct links to ServiceObjects.

- Rework mouse clicks on the heap map to use getObjectByAddress.

- Remove the breakpoint_list.  It wasn't working.  I'll add it back later.

- Silence logging of getIsolateMetric/getVMMetric.

R=johnmccutchan@google.com

Review URL: https://codereview.chromium.org//897193002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43514 260f80e4-7a28-3924-810f-c04153c831b5
 2015-02-05 17:45:52 +00:00
ricow@google.com 922f06abad fix status file entry for the vm 
SkippedByDesign -> SkipByDesign

R=iposva@google.com
BUG=

Review URL: https://codereview.chromium.org//898043005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43512 260f80e4-7a28-3924-810f-c04153c831b5
 2015-02-05 16:36:48 +00:00
iposva@google.com 23c1843a78 - Only attempt to spawn processes on the VM. 
Review URL: https://codereview.chromium.org//899273002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43509 260f80e4-7a28-3924-810f-c04153c831b5
 2015-02-05 16:28:30 +00:00
iposva@google.com c859d25679 - Return exit code 253 in case of API errors during loading. This 
will trigger for example when loading outdated snapshots.

R=ricow@google.com

Review URL: https://codereview.chromium.org//899523005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43505 260f80e4-7a28-3924-810f-c04153c831b5
 2015-02-05 14:30:24 +00:00
kustermann@google.com cae03aaf1a Wait for eventhandler to shut down before exiting 
R=sgjesse@google.com

Review URL: https://codereview.chromium.org//875403006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43504 260f80e4-7a28-3924-810f-c04153c831b5
 2015-02-05 13:16:07 +00:00
fschneider@google.com 2727257bf8 VM: Fix source location in stack trace of async code. 
This eliminates an invalid source position and allows async code
to work with the stack_traces package to a get full async stack chain.

Frames with an invalid location (file.dart:1:1) are now printed without
line/column information (file.dart)

BUG=dartbug.com/22009
R=iposva@google.com

Review URL: https://codereview.chromium.org//904443002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43497 260f80e4-7a28-3924-810f-c04153c831b5
 2015-02-05 10:26:27 +00:00
regis@google.com a5ee233d1b Make Bigint instances immutable by removing all setters. 
This required rewriting a large portion of bigint.dart.

R=rmacnak@google.com

Review URL: https://codereview.chromium.org//842033005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43492 260f80e4-7a28-3924-810f-c04153c831b5
 2015-02-04 23:56:23 +00:00
johnmccutchan@google.com 9c89a1bdc8 Synchronize gen_snapshot sources in bin/BUILD.gn with bin.gypi 
BUG=
R=zra@google.com

Review URL: https://codereview.chromium.org//901053002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43490 260f80e4-7a28-3924-810f-c04153c831b5
 2015-02-04 22:33:12 +00:00
rmacnak@google.com cc2e1e4bd1 Make _FileSystemWatcher.watch private. 
It doesn't verify the path is a string before running native code, so when invoked via mirrors it will hit an uncatchable API error instead of a Dart exception.

R=asiva@google.com

Review URL: https://codereview.chromium.org//897703002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43487 260f80e4-7a28-3924-810f-c04153c831b5
 2015-02-04 21:39:38 +00:00
johnmccutchan@google.com 1426cfc03b Port metrics to RPC 
R=turnidge@google.com

Review URL: https://codereview.chromium.org//886353006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43486 260f80e4-7a28-3924-810f-c04153c831b5
 2015-02-04 21:27:49 +00:00
zra@google.com 1299ad1485 Allows turning on checked mode on a per-isolate basis 
using the embedding API.

R=regis@google.com, srdjan@google.com

Review URL: https://codereview.chromium.org//883263004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43481 260f80e4-7a28-3924-810f-c04153c831b5
 2015-02-04 18:32:48 +00:00
kustermann@google.com 1d6231bacd Revert "Introduce optional 'bool shared' parameter to ServerSocket.bind() ..." 
Review URL: https://codereview.chromium.org//896213002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43476 260f80e4-7a28-3924-810f-c04153c831b5
 2015-02-04 16:00:21 +00:00