92e3e1b94a
Fix notifications for nested packages
...
R=paulberry@google.com
Review URL: https://codereview.chromium.org//907183002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43620 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-09 22:57:44 +00:00
94dd9d28f8
Fix a null pointer exception
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org//908873003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43617 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-09 21:55:48 +00:00
07d2c82919
Issue 22316. Don't propose to create invalid local variable.
...
R=brianwilkerson@google.com
BUG= https://code.google.com/p/dart/issues/detail?id=22316
Review URL: https://codereview.chromium.org//895773004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43600 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-09 16:45:43 +00:00
5194a2b1b4
filter static methods when showing instance completions
...
BUG=dartbug.com/22171
R=scheglov@google.com
Review URL: https://codereview.chromium.org//908493003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43580 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-07 00:56:15 +00:00
8cee600323
Don't propose fixes to update SDK sources.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//902273002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43574 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-06 22:21:48 +00:00
8d35890475
Convert refactoring tests to use 'await'.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//908463004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43573 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-06 22:13:37 +00:00
2593c00b36
Quick Fix for adding 'async' to fix invalid 'await'.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//894373005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43571 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-06 21:10:11 +00:00
f43912dfce
fix code completion in string literals
...
BUG=dartbug.com/22297
R=scheglov@google.com
Review URL: https://codereview.chromium.org//907453005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43567 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-06 20:07:29 +00:00
bd8778a87b
Quick Assist to add explicit types to formal parameters.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//908503004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43566 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-06 20:03:39 +00:00
f473ae15a3
Spec changes for issue 22254
...
Review URL: https://codereview.chromium.org//882643004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43565 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-06 19:35:40 +00:00
eac4b2e0a3
Discard pending notifications on the same source change.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//904093002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43564 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-06 19:31:13 +00:00
c2d3ff3b95
Handle exception and clean-up code
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org//907483004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43563 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-06 19:19:55 +00:00
172b8bee6e
Fix for the server version test.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//891473006
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43561 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-06 19:11:28 +00:00
4468038300
Rework requests in execution domain
...
R=paulberry@google.com , scheglov@google.com
Review URL: https://codereview.chromium.org//904733003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43556 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-06 15:49:44 +00:00
20b64a97a4
fix completion in for statement
...
BUG=
R=scheglov@google.com
Review URL: https://codereview.chromium.org//862803008
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43541 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-06 04:58:11 +00:00
84350e186c
fix named param default value code completion
...
BUG=
R=scheglov@google.com
Review URL: https://codereview.chromium.org//897483003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43540 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-06 04:50:57 +00:00
dc95fd3689
use propogated type for completions
...
BUG=dartbug.com/21457
R=scheglov@google.com
Review URL: https://codereview.chromium.org//902983002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43539 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-06 04:43:15 +00:00
fa0dc53f6f
fix code completion in conditional expressions
...
BUG=
R=scheglov@google.com
Review URL: https://codereview.chromium.org//904653004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43538 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-06 04:33:07 +00:00
95a9962be0
Use MemoryResourceProvider in server and execution domain tests
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org//896423004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43530 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-05 22:46:41 +00:00
81ebd5fd77
Fix for extracting local variable in if-else-if statements.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//879463004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43528 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-05 22:36:56 +00:00
e5a34c3c12
fix completions in indexed expression
...
BUG=
R=scheglov@google.com
Review URL: https://codereview.chromium.org//902913002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43523 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-05 21:42:43 +00:00
ae2e608ff9
Send notificatinos after no-op changes.
...
This should solve the problem when client remove some part of the code,
so removes also error markers for it, and then quickly restores it,
so for the server it looks as an empty/no-op change. But information is
lost, and the server should resend it to the client.
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//899753004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43521 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-05 20:42:17 +00:00
2425d0c57c
const rename and cleanup
...
BUG=
R=scheglov@google.com
Review URL: https://codereview.chromium.org//904603004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43520 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-05 19:50:42 +00:00
8233434126
move relevance computation from client to server
...
BUG=
R=scheglov@google.com
Review URL: https://codereview.chromium.org//901253002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43519 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-05 19:36:19 +00:00
fcd7fdb93a
Fix ambiguous description
...
R=paulberry@google.com
Review URL: https://codereview.chromium.org//901063002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43493 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-05 01:31:09 +00:00
a65a5b599b
Have analysis.getLibraryDependencies wait for the server.onAnalysisComplete completer
...
R=paulberry@google.com
Review URL: https://codereview.chromium.org//891693003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43489 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-04 22:06:50 +00:00
6ddc37a5cc
Disable analysis in hidden directories (fix for issue 22170)
...
R=paulberry@google.com
Review URL: https://codereview.chromium.org//880313006
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43485 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-04 21:27:43 +00:00
dbd0fa9d68
fix exception and improve keyword completion
...
BUG=dartbug.com/22231
R=scheglov@google.com
Review URL: https://codereview.chromium.org//897833002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43466 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-04 13:18:42 +00:00
51842b06f2
Fix type hierarchy when there is no element.
...
This one was caught by an integration test.
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//892913004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43445 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-03 23:01:51 +00:00
1a94fa3a6a
Wait for analysis in search domain. Rewrite with async/await.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//894323003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43435 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-03 21:59:31 +00:00
75c26fe8e9
New analyzer version before push.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//893223002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43412 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-03 17:39:27 +00:00
d04ad125fc
Add link to performance data
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org//892843005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43410 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-03 17:28:11 +00:00
658d3e949e
Check PackageMapUriResolver constructor arguments.
...
R=brianwilkerson@google.com , paulberry@google.com
BUG=
Review URL: https://codereview.chromium.org//887943004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43405 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-03 16:06:25 +00:00
98e926db9a
Support for inspecting index.
...
Page http://127.0.0.1:2040/index/element-by-name?name=sendAnalysisNotificationHighlights
shows all relations with elements named 'sendAnalysisNotificationHighlights'.
R=brianwilkerson@google.com , paulberry@google.com
BUG=
Review URL: https://codereview.chromium.org//894853004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43377 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-03 03:11:09 +00:00
cd996f37bf
Improve error reporting on status page
...
R=paulberry@google.com
Review URL: https://codereview.chromium.org//899513003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43374 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-02 23:34:29 +00:00
ba6742f9fe
Formatter service API tweaks.
...
Some way to indicate no selection is required in the case where there is none. I opted for the -1 convention not becuase I particularly like it but because, well, it's convention! :)
R=brianwilkerson@google.com , scheglov@google.com
Review URL: https://codereview.chromium.org//894863002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43369 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-02 23:14:22 +00:00
81c90c6492
Specify mapUri for directories
...
R=paulberry@google.com , scheglov@google.com
Review URL: https://codereview.chromium.org//896513002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43364 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-02 22:45:50 +00:00
b40a5702b3
Fix async/await type checking in analyzer.
...
This required making the "async" library into TypeProvider so that we
can create Future<...> types when doing resolution and error/hint
checking.
BUG=21888,22053,22091,22092,22160,22164
R=brianwilkerson@google.com
Review URL: https://codereview.chromium.org//898513002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43361 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-02 20:58:37 +00:00
03874e1c60
record and display request latency
...
and update unknown page handler
BUG=
R=scheglov@google.com
Review URL: https://codereview.chromium.org//894823002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43359 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-02 19:44:51 +00:00
46e5078360
Bump analyzer rev pre pub publish.
...
Addresses bug in setting linter options.
R=danrubel@google.com , paulberry@google.com
Review URL: https://codereview.chromium.org//873883005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43341 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-30 17:46:37 +00:00
dd09212ee5
fix internal option typo
...
BUG=
Review URL: https://codereview.chromium.org//887053002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43339 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-30 15:53:36 +00:00
01ea08c589
Fix incremental resolution of files referenced by multiple contexts.
...
There were two problems:
1. When a file was set as a priority, we weren't propagating that
information to all contexts; as a result, the resolved AST wasn't
cached in all contexts, so incremental resolution wasn't able to take
place in all contexts.
2. In setPriorityFiles we weren't scheduling analysis operations, so
even after the file was made a priority, its resolved AST wouldn't be
available until some other event triggered analysis in that context.
BUG=dartbug.com/22209
R=scheglov@google.com
Review URL: https://codereview.chromium.org//892493003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43323 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-30 00:27:58 +00:00
952c2c260f
Bump server analyzer dep to point to latest dev build.
...
R=brianwilkerson@google.com , scheglov@google.com
Review URL: https://codereview.chromium.org//880103002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43316 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-29 21:56:55 +00:00
f9f324ca9b
Avoid redundant notifications when a file is analyzed in multiple contexts.
...
BUG=dartbug.com/22210
R=danrubel@google.com
Review URL: https://codereview.chromium.org//887793003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43315 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-29 21:42:48 +00:00
675b99110c
fix race condition when recording computeCache performance
...
and improve completion performance status page
BUG=dartbug.com/22205
R=paulberry@google.com
Review URL: https://codereview.chromium.org//889583004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43299 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-29 17:00:57 +00:00
ef89b4c21a
tests for earlier CL
...
BUG=dartbug.com/21768
R=paulberry@google.com
Review URL: https://codereview.chromium.org//882273002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43295 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-29 16:50:24 +00:00
cb6c16922f
Fix for issue 22052
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org//881403002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43292 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-29 16:01:58 +00:00
b9f3559e03
(TBR) fix failing test
...
BUG=
Review URL: https://codereview.chromium.org//881413002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43258 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-28 20:39:36 +00:00
4229cb1c6f
use CompletionTarget for replacement offset/length
...
add code completion replacementLength and replacementOffset assertions
BUG=
R=paulberry@google.com
Review URL: https://codereview.chromium.org//886463002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43255 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-28 20:11:10 +00:00
36ce6423a6
Fix for two semantic highlighting problems.
...
1. We need to dispose the existing semantic highlighting manager before setting a new input.
So, we would not apply old highlighting to the new file.
2. We need to clear "input" fields to correctly determine full file path.
R=danrubel@google.com
BUG=
Review URL: https://codereview.chromium.org//882203002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43254 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-28 19:55:25 +00:00
brianwilkerson@google.com