Commit Graph

5491 Commits

Author SHA1 Message Date
paulberry@google.com 6ea61b5686 Partial backport of analyzer async/await fixes to Java.
Backport of r43613, r43537, r43446, r43427, r43424, r43418, r43403,
r43361 to the Java-based analyzer.  The backport is partial in that
the TypeProvider was not modified to include Future and Stream types
(this would have required substantial additional effort), and
consequently not all static warnings are correctly produced.  However,
all NonErrorResolverTest cases were successfully backported and pass,
meaning that the Java-based analyzer shouldn't produce false positive
warnings for async/await code anymore.

BUG=dartbug.com/22252
R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//913623002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43655 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-10 16:04:50 +00:00
floitsch@google.com 1baffdd2da dart2js: fix deferred loading in the new emitter.
Only works in drt/browser for now.

R=zarah@google.com

Review URL: https://codereview.chromium.org//903283002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43654 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-10 15:33:29 +00:00
floitsch@google.com 41e936ef00 Extract invoke-main stub generator.
R=zarah@google.com

Committed: https://code.google.com/p/dart/source/detail?r=43644

Reverted: https://code.google.com/p/dart/source/detail?r=43649

Review URL: https://codereview.chromium.org//906713002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43653 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-10 15:22:43 +00:00
johnniwinther@google.com 986ce5c39c Support default constructors in analyzer2dart.
BUG=
R=paulberry@google.com, sigurdm@google.com

Review URL: https://codereview.chromium.org//900403003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43652 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-10 15:18:36 +00:00
sigurdm@google.com 18e885d1ea Use a VariableUse instead of VariableDeclaration for left-hand side of
assignments.

BUG=dartbug.com/22328
R=floitsch@google.com

Review URL: https://codereview.chromium.org//909113002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43651 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-10 15:13:19 +00:00
floitsch@google.com 7955b2d856 Revert "Extract invoke-main stub generator."
This reverts commit r43644.

Review URL: https://codereview.chromium.org//910063004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43649 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-10 15:00:31 +00:00
sigurdm@google.com 454602332b Only schedule the execution of an async* when the stream is
subscribed to.

BUG=
R=floitsch@google.com

Review URL: https://codereview.chromium.org//902783008

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43646 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-10 14:19:54 +00:00
floitsch@google.com 7aa556dcbd Extract invoke-main stub generator.
R=zarah@google.com

Review URL: https://codereview.chromium.org//906713002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43644 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-10 13:39:15 +00:00
asgerf@google.com febb77ce10 dart2js cps: Handle optional parameters in builder.
For static invocations, default values are inlined.

For all invocations, named parameters are reordered alphabetically.

BUG=
R=karlklose@google.com

Review URL: https://codereview.chromium.org//908863003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43643 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-10 13:36:58 +00:00
floitsch@google.com ddc1701c8c dart2js: make "CREATE_JS_ISOLATE" an embedded global.
R=zarah@google.com

Review URL: https://codereview.chromium.org//868283005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43642 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-10 13:08:42 +00:00
zarah@google.com 5e0dd0affd dart2js: don't emit unneeded tear-off data in the new emitter.
R=floitsch@google.com

Review URL: https://codereview.chromium.org//910723002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43639 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-10 12:00:48 +00:00
johnniwinther@google.com 827e265786 Revert "Add sharedfrontend package"
This reverts commit r43635.

BUG=

Review URL: https://codereview.chromium.org//914613002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43637 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-10 11:32:18 +00:00
johnniwinther@google.com d7118339b5 Add sharedfrontend package
- initial element model includes Element, LibraryElement and ClassElement
- AccessSemantics moved to sharedfrontend to be utilized from both analyzer2dart and dart2js.

BUG=
R=brianwilkerson@google.com, paulberry@google.com

Review URL: https://codereview.chromium.org//898113002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43635 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-10 10:44:56 +00:00
asgerf@google.com fbf1f00690 cps2js: Bugfix in named parameters in call to superconstructor.
BUG=
R=karlklose@google.com

Review URL: https://codereview.chromium.org//909483003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43633 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-10 10:31:22 +00:00
johnniwinther@google.com 4f5b823f9b Fix yield for dart2dart minified.
BUG=

Review URL: https://codereview.chromium.org//912483005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43629 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-10 09:25:50 +00:00
brianwilkerson@google.com 92e3e1b94a Fix notifications for nested packages
R=paulberry@google.com

Review URL: https://codereview.chromium.org//907183002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43620 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-09 22:57:44 +00:00
brianwilkerson@google.com 94dd9d28f8 Fix a null pointer exception
R=scheglov@google.com

Review URL: https://codereview.chromium.org//908873003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43617 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-09 21:55:48 +00:00
paulberry@google.com 6a869d5e34 Fix inference of the static type of an async function literal.
This implements the spec change currently under review here:
https://codereview.chromium.org/902703003

R=scheglov@google.com

Review URL: https://codereview.chromium.org//905293003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43613 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-09 21:21:36 +00:00
scheglov@google.com d7a2309a92 Fix for incremental resolution in case of inserting a new token into elegant comments.
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//913573002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43607 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-09 19:12:04 +00:00
brianwilkerson@google.com ebad629834 Handle exception getting modification stamp
R=scheglov@google.com

Review URL: https://codereview.chromium.org//913513003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43603 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-09 17:19:00 +00:00
scheglov@google.com 07d2c82919 Issue 22316. Don't propose to create invalid local variable.
R=brianwilkerson@google.com
BUG= https://code.google.com/p/dart/issues/detail?id=22316

Review URL: https://codereview.chromium.org//895773004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43600 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-09 16:45:43 +00:00
johnniwinther@google.com 6fcf4caa95 Refactor handling of source map information.
BUG=
R=floitsch@google.com

Review URL: https://codereview.chromium.org//893963005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43595 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-09 15:04:00 +00:00
johnniwinther@google.com aa5e543b8b Allow sync *, async * and yield * in dart2js
BUG=http://dartbug.com/22234
R=sigurdm@google.com

Review URL: https://codereview.chromium.org//864643006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43593 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-09 14:26:03 +00:00
asgerf@google.com 990e824303 dart2dart: Fix bad type annotation in backend_ast_emitter.
Issue: https://code.google.com/p/dart/issues/detail?id=22326

R=kmillikin@google.com

Review URL: https://codereview.chromium.org//911573002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43592 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-09 12:38:20 +00:00
sigurdm@google.com 7b0bc3d220 Implementation of async-await transformation on js ast.
BUG=
R=floitsch@google.com, johnniwinther@google.com

Review URL: https://codereview.chromium.org//839323003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43591 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-09 12:02:52 +00:00
asgerf@google.com f72a18378b Revert "dart2js: Refactoring, documentation, and a few bugfixes in Namer class."
This reverts commit r43588.

BUG=

Review URL: https://codereview.chromium.org//906273002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43590 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-09 11:58:07 +00:00
asgerf@google.com c767597da3 dart2js: Refactoring, documentation, and a few bugfixes in Namer class.
See long doc comment in namer.dart.

BUG=
R=floitsch@google.com

Review URL: https://codereview.chromium.org//891673003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43588 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-09 11:31:10 +00:00
pquitslund@google.com 5ca6eca321 Version bump pre dev pub push.
R=brianwilkerson@google.com, scheglov@google.com

Review URL: https://codereview.chromium.org//909743002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43583 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-09 05:13:55 +00:00
pquitslund@google.com e3a0244b58 Tweak to error formatter to fix LINT display name.
R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//902383002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43582 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-08 21:01:35 +00:00
danrubel@google.com 5194a2b1b4 filter static methods when showing instance completions
BUG=dartbug.com/22171
R=scheglov@google.com

Review URL: https://codereview.chromium.org//908493003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43580 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-07 00:56:15 +00:00
scheglov@google.com 8cee600323 Don't propose fixes to update SDK sources.
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//902273002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43574 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-06 22:21:48 +00:00
scheglov@google.com 8d35890475 Convert refactoring tests to use 'await'.
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//908463004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43573 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-06 22:13:37 +00:00
scheglov@google.com 2593c00b36 Quick Fix for adding 'async' to fix invalid 'await'.
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//894373005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43571 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-06 21:10:11 +00:00
danrubel@google.com f43912dfce fix code completion in string literals
BUG=dartbug.com/22297
R=scheglov@google.com

Review URL: https://codereview.chromium.org//907453005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43567 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-06 20:07:29 +00:00
scheglov@google.com bd8778a87b Quick Assist to add explicit types to formal parameters.
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//908503004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43566 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-06 20:03:39 +00:00
brianwilkerson@google.com f473ae15a3 Spec changes for issue 22254
Review URL: https://codereview.chromium.org//882643004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43565 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-06 19:35:40 +00:00
scheglov@google.com eac4b2e0a3 Discard pending notifications on the same source change.
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//904093002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43564 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-06 19:31:13 +00:00
brianwilkerson@google.com c2d3ff3b95 Handle exception and clean-up code
R=scheglov@google.com

Review URL: https://codereview.chromium.org//907483004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43563 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-06 19:19:55 +00:00
scheglov@google.com 172b8bee6e Fix for the server version test.
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//891473006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43561 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-06 19:11:28 +00:00
brianwilkerson@google.com d682527d1e Fix a stack overflow
R=scheglov@google.com

Review URL: https://codereview.chromium.org//908603002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43559 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-06 18:00:16 +00:00
brianwilkerson@google.com 4468038300 Rework requests in execution domain
R=paulberry@google.com, scheglov@google.com

Review URL: https://codereview.chromium.org//904733003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43556 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-06 15:49:44 +00:00
johnniwinther@google.com b964042fcd Support instance methods in analyzer2dart.
BUG=
R=paulberry@google.com

Review URL: https://codereview.chromium.org//898303002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43555 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-06 14:59:18 +00:00
zarah@google.com c839cece99 dart2js: add constructor for directly instatiated mixin classes in the new emitter.
R=floitsch@google.com

Review URL: https://codereview.chromium.org//900423003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43553 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-06 14:27:48 +00:00
karlklose@google.com 8175ce696b Fix merge error: Call visitExpression instead of visit.
R=asgerf@google.com

Review URL: https://codereview.chromium.org//881073004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43551 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-06 11:57:30 +00:00
herhut@google.com 44541ff62b Support [AssumeDynamic] and [TrustTypeAnnotations] in the inferrer.
BUG=
R=floitsch@google.com, johnniwinther@google.com

Review URL: https://codereview.chromium.org//875163004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43550 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-06 11:38:46 +00:00
karlklose@google.com 2b8950be87 cps-ir: Implement string concatenation.
R=kmillikin@google.com

Review URL: https://codereview.chromium.org//870353004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43549 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-06 11:36:27 +00:00
karlklose@google.com 055f09c02b cps-ir: Correctly bailout on unresolved static calls.
This adds a better error message and the ability to fallback to the old backend when compiling code like this:
  main() { new foo(); }
and
  class C {}
  main() { C.foo(); }

R=asgerf@google.com, kmillikin@google.com

Review URL: https://codereview.chromium.org//879233005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43548 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-06 10:36:04 +00:00
zarah@google.com c544068f6f dart2js: add common names to mangledGlobalNames in new emitter.
R=floitsch@google.com

Review URL: https://codereview.chromium.org//897013003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43545 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-06 08:52:15 +00:00
karlklose@google.com e45aaa58e4 Move matching of arguments/selector against signature out of buildStaticInvoke.
R=sigurdm@google.com

Review URL: https://codereview.chromium.org//890663004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43544 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-06 08:32:05 +00:00
danrubel@google.com 20b64a97a4 fix completion in for statement
BUG=
R=scheglov@google.com

Review URL: https://codereview.chromium.org//862803008

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43541 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-06 04:58:11 +00:00