dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
71,643 Commits 2 Branches 0 Tags
6e53ac6e4c7b3d94de5ee0370a538b03dafded1c
Commit Graph

41 Commits

Author SHA1 Message Date
Robert Nystrom 4f01e01d1f Sort the tests needing migration work. 
Got tired of hopping around the lists of tests randomly.

Change-Id: If8e5f915b7871d8ae916e565d9d4e787a44c6a50
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/137724
Auto-Submit: Bob Nystrom <rnystrom@google.com>
Commit-Queue: Nicholas Shahan <nshahan@google.com>
Reviewed-by: Nicholas Shahan <nshahan@google.com>
 2020-02-28 01:00:34 +00:00
Jonas Termansen a739002cfa Analyze both nnbd and non-nnbd concurrently when migrating tests. 
Only write out the tests if the source files changed, so editors
don't reload files that didn't actually change.

Change-Id: Ifd8621e36aab88b6f0740881a6289bc392a0f52f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/134841
Reviewed-by: Bob Nystrom <rnystrom@google.com>
 2020-02-21 13:55:58 +00:00
Srujan Gaddam 2109617eb2 Fix multi-line error handling in analyze.dart 
Preexisting comments on multi-line errors modify the length of the error
reported from the analyzer since it includes the comments in between. So
the error length increases every time you run this script, making the
error comments unwieldly.

Change-Id: Iaeab9118710738f3ebf534d85b7fd08be0bf302f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/136526
Commit-Queue: Srujan Gaddam <srujzs@google.com>
Auto-Submit: Srujan Gaddam <srujzs@google.com>
Reviewed-by: Bob Nystrom <rnystrom@google.com>
 2020-02-20 19:12:11 +00:00
Robert Nystrom 40d544bc26 Always count non-core libs when tracking migration progress. 
Now that they're farther along, there's little need to keep them
separate.

Change-Id: I3dedcf34b97cf5f0645fe429b357a459850d65d5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/135740
Auto-Submit: Bob Nystrom <rnystrom@google.com>
Commit-Queue: Nicholas Shahan <nshahan@google.com>
Reviewed-by: Nicholas Shahan <nshahan@google.com>
 2020-02-13 23:05:29 +00:00
Robert Nystrom 7bc7f58992 Show subdirectories in test migration progress report. 
Change-Id: I2b7c059030d0c5a87d074e37c86f7532c302ff9c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/130963
Auto-Submit: Bob Nystrom <rnystrom@google.com>
Reviewed-by: Nicholas Shahan <nshahan@google.com>
 2020-01-10 22:07:23 +00:00
Robert Nystrom fd501c74a5 Track files that do not need to be migrated in the NNBD progress script. 
Change-Id: I77014aad502ae6e44a9d0c20c288efb822bd1068
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/128984
Reviewed-by: Nicholas Shahan <nshahan@google.com>
Commit-Queue: Bob Nystrom <rnystrom@google.com>
Auto-Submit: Bob Nystrom <rnystrom@google.com>
 2019-12-20 21:25:35 +00:00
Robert Nystrom 5973e04ebd Tweak the NNBD test migration progress script output a bit. 
Change-Id: Ia722ea4b90702063166c99a1acf48a34d5c46da3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/128480
Reviewed-by: Nicholas Shahan <nshahan@google.com>
Commit-Queue: Bob Nystrom <rnystrom@google.com>
Auto-Submit: Bob Nystrom <rnystrom@google.com>
 2019-12-17 22:14:34 +00:00
Robert Nystrom f95ef086a9 Small script to track NNBD test migration progress and estimate. 
Change-Id: I14ad73f79c689d3154bd7260ee247fe478439e43
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/128283
Auto-Submit: Bob Nystrom <rnystrom@google.com>
Commit-Queue: Nicholas Shahan <nshahan@google.com>
Reviewed-by: Nicholas Shahan <nshahan@google.com>
 2019-12-13 22:35:42 +00:00
Robert Nystrom a8c68e094a Turn the Dart 2.0 migration tool into an NNBD migration tool. 
It's pretty bare bones right now, but it helps automate some of the
steps.

Change-Id: I64280751870f1cb0d34ac464879c9c0edfc75d1f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/128280
Auto-Submit: Bob Nystrom <rnystrom@google.com>
Reviewed-by: Nicholas Shahan <nshahan@google.com>
Commit-Queue: Bob Nystrom <rnystrom@google.com>
 2019-12-13 00:01:11 +00:00
Bob Nystrom 67525aef37 Convert a batch of negative tests to multitests. 
Change-Id: I380c12ef633ec8c40de982782623d3e3659a4834
Reviewed-on: https://dart-review.googlesource.com/57162
Reviewed-by: Leaf Petersen <leafp@google.com>
 2018-06-08 19:43:34 +00:00
Paul Berry be8748997d Remove configurations that aren't useful to test anymore 
Change-Id: I555ce0b54fec59d8c21b7574055ef7f444a3d423
Reviewed-on: https://dart-review.googlesource.com/38600
Reviewed-by: Bob Nystrom <rnystrom@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
 2018-02-06 08:28:37 +00:00
Paul Berry c236d4ff3b Add dartdevk configurations to run_tests.dart 
Change-Id: Iebf97f192ad84118f75656ba665030ff851eb9f7
Reviewed-on: https://dart-review.googlesource.com/25081
Commit-Queue: Paul Berry <paulberry@google.com>
Reviewed-by: Bob Nystrom <rnystrom@google.com>
 2017-12-01 21:31:03 +00:00
Paul Berry 54143ef90c Add --dart2js-with-kernel configurations to run_tests.dart 
Change-Id: Ie837af2934b2596a0dbe3e7f9a38d906bb6336d7
Reviewed-on: https://dart-review.googlesource.com/22341
Reviewed-by: Bob Nystrom <rnystrom@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
 2017-11-21 17:01:20 +00:00
Paul Berry 9b8f917b90 Add more configurations to run_tests.dart 
Change-Id: I3b0080c4d637d121b6c6e173b323632c7d808817
Reviewed-on: https://dart-review.googlesource.com/20040
Reviewed-by: Bob Nystrom <rnystrom@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
 2017-11-10 18:08:29 +00:00
Bob Nystrom cac79d8db9 Fix some tests to be better Dart 2.0 tests. 
async_await_test was correct, but was using a misleading name. It really
cares about assertions being enabled, not "checked mode".

The setter tests originally validated the runtime type checks but were
changed to compile time checks. Used a little judicious dynamic to get
back to testing the runtime type checking.

Change-Id: I0e121bd1443376e885777d609f5d6507537c0b8c
Reviewed-on: https://dart-review.googlesource.com/14161
Commit-Queue: Bob Nystrom <rnystrom@google.com>
Reviewed-by: Janice Collins <jcollins@google.com>
 2017-10-17 23:11:25 +00:00
Siva Annamalai bd2a8e1d60 Reland migrate most of the tests in standalone to be strong mode clean and move them to standalone_2 directory. 
Bug:
Change-Id: I4ca50f315361422db1d4356055862463bfe1d6f3
Reviewed-on: https://dart-review.googlesource.com/12240
Reviewed-by: Siva Annamalai <asiva@google.com>
Reviewed-by: Ben Konyi <bkonyi@google.com>
Commit-Queue: Siva Annamalai <asiva@google.com>
 2017-10-07 01:29:36 +00:00
Bob Nystrom 9a61fd572a Remove unittest checking from migration script. 
It's OK for a test to keep using unittest.

Change-Id: I5789cda2baea44731e1ce01ccff04d81f42b9b0c
Reviewed-on: https://dart-review.googlesource.com/12080
Reviewed-by: Phil Quitslund <pquitslund@google.com>
Commit-Queue: Bob Nystrom <rnystrom@google.com>
 2017-10-06 21:31:43 +00:00
Siva Annamalai ff32187145 Revert "Migrate most of the tests in standalone to be strong mode clean and move" 
This reverts commit c85563f582.

Reason for revert: <INSERT REASONING HERE>

Original change's description:
> Migrate most of the tests in standalone to be strong mode clean and move
> them to standalone_2 directory.
> 
> Change-Id: I9887b8d6d4d86001e4660b400224b881205e6273
> Reviewed-on: https://dart-review.googlesource.com/6080
> Reviewed-by: Ben Konyi <bkonyi@google.com>

TBR=bkonyi@google.com,asiva@google.com

Change-Id: I3c7b6081f17fca45e7828603538f50d06417e2be
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://dart-review.googlesource.com/12020
Reviewed-by: Siva Annamalai <asiva@google.com>
Commit-Queue: Siva Annamalai <asiva@google.com>
 2017-10-06 17:24:20 +00:00
Siva Annamalai c85563f582 Migrate most of the tests in standalone to be strong mode clean and move 
them to standalone_2 directory.

Change-Id: I9887b8d6d4d86001e4660b400224b881205e6273
Reviewed-on: https://dart-review.googlesource.com/6080
Reviewed-by: Ben Konyi <bkonyi@google.com>
 2017-10-06 17:07:34 +00:00
Bob Nystrom 1f3d67ddbc Don't migrate status entries from "_parser.status" files. 
Change-Id: Ic5e3cbe8d6f95e1f3e9b2e0f4313d54e240d6f7d
Reviewed-on: https://dart-review.googlesource.com/7850
Reviewed-by: Ben Konyi <bkonyi@google.com>
 2017-09-22 22:39:14 +00:00
Terry Lucas 65a2303696 Updated to support migrating *.html files too 
R=rnystrom@google.com

Change-Id: Icca5b36c87cb7c3af566b66cec537c53552deeab
Reviewed-on: https://dart-review.googlesource.com/7635
Reviewed-by: Bob Nystrom <rnystrom@google.com>
Commit-Queue: Terry Lucas <terry@google.com>
 2017-09-22 17:50:57 +00:00
Ben Konyi 0b7d8e9688 Fixed status file migration issues for html and isolate directories. 
Bug:
Change-Id: Ie4853d109b95731018f63487fd658b76841c8742
Reviewed-on: https://dart-review.googlesource.com/4603
Reviewed-by: Janice Collins <jcollins@google.com>
Reviewed-by: Bob Nystrom <rnystrom@google.com>
 2017-09-12 17:57:20 +00:00
Bob Nystrom 090efb342c Don't delete 1.0 tests and status entries when migrating. 
We do still remove the "_strong" ones since there's no reason to keep
those -- "_2" strictly supersedes them.

Change-Id: If6b9a8a5d22d8995a5fd0ac5538449c646b053ef
Reviewed-on: https://dart-review.googlesource.com/3403
Reviewed-by: Ben Konyi <bkonyi@google.com>
 2017-09-06 17:40:19 +00:00
Janice Collins 51cc9689b3 Remove corelib and corelib_strong and migrate last two remaining tests. 
This includes a migration of linked_hash_map_from_iterable_test and
stacktrace_current_test, which were migrated without changes.

BUG=
R=rnystrom@google.com, whesse@google.com

Review-Url: https://codereview.chromium.org/3004073002 .
 2017-09-01 08:11:15 -07:00
Bob Nystrom 574022c0e2 Add "-1" and "-2" to run subsets of the configurations. 
R=jmesserly@google.com

Review-Url: https://codereview.chromium.org/3011593003 .
 2017-08-30 14:53:29 -07:00
Bob Nystrom 0cbd1ea1ea Don't migrate status entries under a "[ $strong ]" header. 
R=jcollins@google.com

Review-Url: https://codereview.chromium.org/3009653002 .
 2017-08-25 16:50:27 -07:00
Bob Nystrom f9da770441 Fix message about status entries that need manual splitting. 
It described the entry as being in the destination file when it's
actually still in the source file.

R=mkroghj@google.com

Review-Url: https://codereview.chromium.org/2997093002 .
 2017-08-17 13:05:39 -07:00
Janice Collins d2f2b0f44d Add cases to all configs and allow for running a single test. 
This adds analyzer-strong-checked as distinct from analyzer-strong,
which seems to be how the bots run it.  Also adds the d8 runtime to dart2js as that was the cause of some bot breakage.

Finally, you can now run one test by just passing a single parameter.

BUG=
R=bkonyi@google.com, jmesserly@google.com

Review-Url: https://codereview.chromium.org/2997673002 .
 2017-08-14 07:48:11 -07:00
Bob Nystrom 850b80a84e Fix analyzer status for cast_test. 
Also add another configuration in the migration test runner to catch
this in the future.

Review-Url: https://codereview.chromium.org/2993123003 .
 2017-08-04 18:37:18 -07:00
Bob Nystrom f2b8669a0b Output test results in diff mode. 
R=jmesserly@google.com

Review-Url: https://codereview.chromium.org/2996563002 .
 2017-08-04 17:16:45 -07:00
Bob Nystrom 6b7819ec5a Handle migration status entries into split up status files. 
R=jcollins@google.com

Review-Url: https://codereview.chromium.org/2994573002 .
 2017-08-04 13:49:30 -07:00
Janice Collins 481ce5813c Add more targets to run_tests based on experience in blocks 7 and 8 
BUG=
R=rnystrom@google.com

Review-Url: https://codereview.chromium.org/2988423002 .
 2017-08-03 11:39:47 -07:00
Bob Nystrom dbd48de07d Fix a couple of things causing bot redness: 
- Migrate over built_in_identifier_test since it imports a helper
  library that was migrated.
- Fix some status file entries.

Also:

- Removed some old commented out status entries.
- Fix a bug in migration script.

R=jcollins@google.com

Review-Url: https://codereview.chromium.org/2992903002 .
 2017-08-02 14:54:07 -07:00
Bob Nystrom 95693b30a3 Add a script to run the tests in a migration block. 
R=bkonyi@google.com

Review-Url: https://codereview.chromium.org/2987223002 .
 2017-08-01 13:52:20 -07:00
Bob Nystrom 385b88f289 Migrate status file entries when migrating files. Yay! 
This looks at all the files in the batch being migrated. It goes through
the status files in the 1.0 and strong directories. If it sees an entry
that matches that file, it adds it to the resulting "_2" status file.

It handles adding entries to an existing section if already present in
the new status file. Otherwise, it adds a new section at the end with
the entries.

R=bkonyi@google.com

Review-Url: https://codereview.chromium.org/2989033002 .
 2017-07-28 11:10:30 -07:00
Bob Nystrom 1419935fa6 Better support for re-running in the middle of a migration. 
- Track files that only exist in the "_2" directories. That way we can
  show what work still remains to be done even if the unmigrated files
  are gone.

- Friendlier matching of command line arguments. Pass in any substring
  of the test path and if only one test matches, it will be used.

- Make --dry-run not crash.

R=bkonyi@google.com

Review-Url: https://codereview.chromium.org/2988973002 .
 2017-07-27 12:07:21 -07:00
Bob Nystrom cc8ae6b723 Add some more validation of things in expect that should not be used. 
Also add some helper functions in expect.

R=bkonyi@google.com

Review-Url: https://codereview.chromium.org/2989743002 .
 2017-07-26 16:52:18 -07:00
Bob Nystrom 158e95a940 Report more heuristics for tests that require manual work. 
If the contents of a test mention "checked", "TypeError", or
"AbstractClassInstantiationError", they will need some work. Tell the
user about those.

R=bkonyi@google.com

Review-Url: https://codereview.chromium.org/2991803003 .
 2017-07-26 12:57:30 -07:00
Ben Konyi caf87da9ed Added functionality to dump relevant status file entries to a single file to make it easier to see which tests have which status file entries. Future work: remove entries from original status files. 
BUG=
R=jcollins@google.com, rnystrom@google.com

Review-Url: https://codereview.chromium.org/2987633002 .
 2017-07-25 17:48:09 -07:00
Bob Nystrom 456ebea38f Check in the .packages file for the migration tool. 
This way, users don't have to run "pub get" on it before they can use
it. Since the .packages file only contains relative paths, it's safe to
check into the repo.

R=bkonyi@google.com

Review-Url: https://codereview.chromium.org/2983993002 .
 2017-07-20 14:01:01 -07:00
Bob Nystrom 152bc2d538 Add simple test migration helper. 
R=bkonyi@google.com

Review-Url: https://codereview.chromium.org/2987533002 .
 2017-07-20 12:54:46 -07:00