dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
71,643 Commits 2 Branches 0 Tags
6e53ac6e4c7b3d94de5ee0370a538b03dafded1c
Commit Graph

705 Commits

Author SHA1 Message Date
Ryan Macnak e7c6a72760 [test] Update use of Null as a bottom type to Never. 
Change-Id: Ied7176bf9bd1dafeb2b6e7e764361d2e1b1f460e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/141363
Reviewed-by: Liam Appelbe <liama@google.com>
Commit-Queue: Ryan Macnak <rmacnak@google.com>
 2020-03-27 19:49:22 +00:00
Ryan Macnak bc53ecefae [vm] Don't try to include resume_capabilities, exit_listeners or error_listeners in snapshots. 
Change-Id: I50ed4b5e0adbf98f157fec0905dfbb2ce38cd285
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/140942
Reviewed-by: Alexander Aprelev <aam@google.com>
Commit-Queue: Ryan Macnak <rmacnak@google.com>
 2020-03-25 23:12:47 +00:00
Lasse R.H. Nielsen 8760283247 New implementation of runZoned. 
A combination of `runZoned` and `runZonedGuarded` where only the latter allows an `onError` parameter,
and only that has a nullable return type.

Retains the `onError` parameter on `runZoned` for now because it's too breaking to remove it until packages have been migrated off of it.
It will be removed in a follow-up CL.

Change-Id: If0e86c8d14e13fa089c66f4af975aeacb2616cf6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/137302
Reviewed-by: Jake Macdonald <jakemac@google.com>
Reviewed-by: Nate Bosch <nbosch@google.com>
 2020-03-25 00:24:33 +00:00
Kevin Moore 6a5d73dfe7 Address a vulnerability in node validator 
Related to DOM clobbering of previousSibling

Change-Id: Ib4ed1cdba4217c351804b0689a999b73713f79ed
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/140622
Auto-Submit: Kevin Moore <kevmoo@google.com>
Reviewed-by: Vijay Menon <vsm@google.com>
Reviewed-by: Sigmund Cherem <sigmund@google.com>
 2020-03-23 20:01:58 +00:00
Leaf Petersen 7aace6fa60 Make StackTrace generally not nullable in migrated NNBD library. 
Bug: https://github.com/dart-lang/sdk/issues/40130
Change-Id: I13aba0c2a3fa5b1c3d3995f075ffd38f03aca897
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/139880
Reviewed-by: Bob Nystrom <rnystrom@google.com>
 2020-03-19 23:31:30 +00:00
Ben Konyi d1c8aae6d8 [ VM ] Update lib_2/isolate tests to no longer use package:unittest 
Fixes https://github.com/dart-lang/sdk/issues/40799

Change-Id: Ia65221c2a14b9d8e923e394ebc1c35ea5dad4c6f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/139953
Commit-Queue: Ben Konyi <bkonyi@google.com>
Reviewed-by: Siva Annamalai <asiva@google.com>
 2020-03-19 00:57:26 +00:00
Erik Ernst 41fa72ef11 Adjust test for new default values of .fromEnvironment 
Breaking change #40678 mandates new default values for
String.fromEnvironment, this CL adjusts the expectations of a test
accordingly.

Change-Id: Ib8a26005673d07c67f65708fc9c4ae7b17421670
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/139811
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Commit-Queue: Erik Ernst <eernst@google.com>
 2020-03-18 07:55:15 +00:00
Srujan Gaddam 1ea7d52d63 Migrate the rest of html tests off unittest 
Migrated to minitest where possible and async_minitest elsewhere,
but kept the same import for file suites (e.g. history_*).

Change-Id: Iecd16dfbbcf0691d290fcb82555ff53d715e8500
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/139827
Commit-Queue: Srujan Gaddam <srujzs@google.com>
Reviewed-by: Bob Nystrom <rnystrom@google.com>
 2020-03-17 22:40:05 +00:00
Srujan Gaddam cf265d0309 Migrate js_util_test to async_minitest 
Change-Id: I9b232f7a093107df93b8fd4a62c29a70f206a550
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/139826
Reviewed-by: Bob Nystrom <rnystrom@google.com>
Commit-Queue: Srujan Gaddam <srujzs@google.com>
 2020-03-17 22:27:25 +00:00
Srujan Gaddam f295f381b6 Migrate html xhr tests to async_minitest 
Tests needed to be restructured in order to maintain asynchronous
behavior.

Change-Id: I4502188e8edada39dfacf9c5f3d59cbccac66133
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/139825
Reviewed-by: Bob Nystrom <rnystrom@google.com>
Commit-Queue: Srujan Gaddam <srujzs@google.com>
 2020-03-17 21:54:45 +00:00
Srujan Gaddam 4f2e49038b Migrate js_interop_1_test to async_minitest 
Semantics needed to change to replace expectAsyncUntil.

Change-Id: I7dd55c9571b405e471c812e966e708e6ef76a134
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/139822
Reviewed-by: Bob Nystrom <rnystrom@google.com>
Commit-Queue: Srujan Gaddam <srujzs@google.com>
 2020-03-17 19:19:25 +00:00
Erik Ernst 568255dbec Change tests to expect new behavior of fromEnvironment 
Constructors int.fromEnvironment and String.fromEnvironment will now
yield 0 or '' rather than null in the case where the requested
environment declaration does not exist, so various expectations needed
to be updated accordingly.

Change-Id: Ie6f3b9ee18a970e50520ac84c2741b4875ada3c9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/139804
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Commit-Queue: Erik Ernst <eernst@google.com>
 2020-03-17 13:43:17 +00:00
Robert Nystrom a1f87c6962 Reland "Fail synchronously if null is passed as an error to async APIs." 
This is a reland of bef363bfb7

Original change's description:
> Fail synchronously if null is passed as an error to async APIs.
> 
> The first patchset is Lasse's original changes.
> 
> Change-Id: Ic5f24bcfc0ef4e82edee68d61e015b095cb5916e
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/138605
> Reviewed-by: Leaf Petersen <leafp@google.com>

Change-Id: I142831dca5dc4ca266ded08d93cb427ad3fbde74
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/139683
Auto-Submit: Bob Nystrom <rnystrom@google.com>
Commit-Queue: Leaf Petersen <leafp@google.com>
Reviewed-by: Leaf Petersen <leafp@google.com>
 2020-03-17 00:39:31 +00:00
Robert Nystrom 54ae6c123e Make minitest and async_minitest NNBD agnostic. 
Fix a couple of errors when compiling those libraries as opted in to
NNBD.

Change-Id: I7dfb629d951d8531c8bed4e765950984e9291f44
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/139686
Auto-Submit: Bob Nystrom <rnystrom@google.com>
Commit-Queue: Srujan Gaddam <srujzs@google.com>
Reviewed-by: Srujan Gaddam <srujzs@google.com>
 2020-03-16 19:58:10 +00:00
Srujan Gaddam 3cbf1f65f3 Migrate interactive_geolocation_test to async_minitest 
Change-Id: I46ae16ccca91823b68421fd5c067ff68166a7cf3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/139499
Commit-Queue: Srujan Gaddam <srujzs@google.com>
Reviewed-by: Sigmund Cherem <sigmund@google.com>
Reviewed-by: Bob Nystrom <rnystrom@google.com>
 2020-03-16 17:48:48 +00:00
Srujan Gaddam 47e495a89a Migrate indexeddb_* tests to async_minitest 
Change-Id: Ie43d3f4610eb01cfc800556f30e93514a7ac1ac5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/139498
Reviewed-by: Sigmund Cherem <sigmund@google.com>
Reviewed-by: Bob Nystrom <rnystrom@google.com>
 2020-03-16 17:48:48 +00:00
Srujan Gaddam 5f8df3af03 Migrate file_sample_test to async_minitest 
Refactored to use Futures for asynchronous tests.

Change-Id: I95c7b3e0230f9c8d81b32b7323aa58ff339eadea
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/139493
Reviewed-by: Sigmund Cherem <sigmund@google.com>
Reviewed-by: Bob Nystrom <rnystrom@google.com>
 2020-03-16 17:48:48 +00:00
Srujan Gaddam 739e79e863 Migrate events_test to async_minitest 
Change-Id: I994d376d3a6a86be989130104fabdc6d217fc0e1
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/139492
Reviewed-by: Sigmund Cherem <sigmund@google.com>
Reviewed-by: Bob Nystrom <rnystrom@google.com>
 2020-03-16 17:48:48 +00:00
Srujan Gaddam 87779c4225 Migrate element_test to async_minitest 
Change-Id: If99d88551b245d28a7898769703758c4747d693a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/139360
Commit-Queue: Srujan Gaddam <srujzs@google.com>
Reviewed-by: Bob Nystrom <rnystrom@google.com>
 2020-03-13 23:09:07 +00:00
Srujan Gaddam 5c02523f4f Migrate html element_animate tests to async_minitest 
Change-Id: Icfbcbe7aa69e337d923aa678986d0f40ba8a76dc
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/139301
Reviewed-by: Bob Nystrom <rnystrom@google.com>
 2020-03-13 23:09:07 +00:00
Srujan Gaddam d044aeca59 Migrate html custom_ tests to async_minitest 
Change-Id: I8fa192967c5c7083e780433fce0e246cbc846c24
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/139300
Reviewed-by: Bob Nystrom <rnystrom@google.com>
 2020-03-13 23:09:07 +00:00
Srujan Gaddam e60e7378b9 Migrate custom/entered_left_view tests to async_minitest 
Change-Id: Ida616678a146fa7a6a0c90bba7339758a84e3aa8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/139261
Reviewed-by: Bob Nystrom <rnystrom@google.com>
 2020-03-13 23:09:07 +00:00
Srujan Gaddam 799cf665ea Move html custom tests off unittest 
Many of the setUps were meant to be one time setUps, so
they're only called once.

anyOf is added to async_minitest using the minitest impl.

Change-Id: Ibb2d4d0c3990d0df025fcaf6c02d49faa9733569
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/139147
Reviewed-by: Bob Nystrom <rnystrom@google.com>
 2020-03-13 23:09:07 +00:00
Ryan Macnak 8ed772d37f Reland "[vm] Fix some further mirror breaks with frontend NNBD checks enabled." 
Without loadLibrary()! changes.

Change-Id: I78806547ac62fa806e99eb2d5e3f2041f20ce942
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/139404
Reviewed-by: Régis Crelier <regis@google.com>
Commit-Queue: Ryan Macnak <rmacnak@google.com>
 2020-03-13 17:11:52 +00:00
Ryan Macnak 42e6cf4967 Revert "[vm] Fix some further mirror breaks with frontend NNBD checks enabled." 
This reverts commit daf91f56b9.

Reason for revert: Analyzer and CFE disagree

Original change's description:
> [vm] Fix some further mirror breaks with frontend NNBD checks enabled.
> 
> Change-Id: I3c52dac2244c1f7eae59d85bc637cce2cbb3faa9
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/139302
> Reviewed-by: Régis Crelier <regis@google.com>
> Reviewed-by: Siva Annamalai <asiva@google.com>
> Commit-Queue: Ryan Macnak <rmacnak@google.com>

TBR=rmacnak@google.com,asiva@google.com,regis@google.com

Change-Id: I2f13dac7f2d7441f8db61543261ca28f500b8adc
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/139319
Reviewed-by: Ryan Macnak <rmacnak@google.com>
Commit-Queue: Ryan Macnak <rmacnak@google.com>
 2020-03-12 22:41:41 +00:00
Ryan Macnak daf91f56b9 [vm] Fix some further mirror breaks with frontend NNBD checks enabled. 
Change-Id: I3c52dac2244c1f7eae59d85bc637cce2cbb3faa9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/139302
Reviewed-by: Régis Crelier <regis@google.com>
Reviewed-by: Siva Annamalai <asiva@google.com>
Commit-Queue: Ryan Macnak <rmacnak@google.com>
 2020-03-12 20:58:56 +00:00
Srujan Gaddam 871bb5a06e Convert remaining canvasrendering tests to async_minitest 
Refactored code to handle lack of setUp and tearDown and async
completion across tests.

Change-Id: I5411e7b7cf3a5687c892c8d0a33f4a6e6a440c32
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/139028
Commit-Queue: Srujan Gaddam <srujzs@google.com>
Reviewed-by: Bob Nystrom <rnystrom@google.com>
 2020-03-12 02:48:50 +00:00
David Morgan a5bf30c401 Revert "Fail synchronously if null is passed as an error to async APIs." 
This reverts commit bef363bfb7.

Reason for revert: Breaks google3 tests, see b/151204525.

Original change's description:
> Fail synchronously if null is passed as an error to async APIs.
> 
> The first patchset is Lasse's original changes.
> 
> Change-Id: Ic5f24bcfc0ef4e82edee68d61e015b095cb5916e
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/138605
> Reviewed-by: Leaf Petersen <leafp@google.com>

TBR=leafp@google.com,rnystrom@google.com

Change-Id: Ie17c35e9d23c70a7aecd1ef292962154cf6f007d
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/138925
Reviewed-by: David Morgan <davidmorgan@google.com>
Commit-Queue: David Morgan <davidmorgan@google.com>
 2020-03-11 10:07:49 +00:00
Robert Nystrom bef363bfb7 Fail synchronously if null is passed as an error to async APIs. 
The first patchset is Lasse's original changes.

Change-Id: Ic5f24bcfc0ef4e82edee68d61e015b095cb5916e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/138605
Reviewed-by: Leaf Petersen <leafp@google.com>
 2020-03-10 23:42:43 +00:00
Srujan Gaddam fcb00812ed Migrate canvasrendering tests off of unittest 
Migration to minitest where possible. async tests will
be migrated in a different CL.

Change-Id: I4662300bd841c56b7113adf2182ee2f8e3d7eae8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/138889
Commit-Queue: Srujan Gaddam <srujzs@google.com>
Reviewed-by: Sigmund Cherem <sigmund@google.com>
 2020-03-10 22:04:21 +00:00
Srujan Gaddam a61e012e93 Migrate html tests using async_minitest and minitest 
Move them to async_minitest.

Change-Id: Ibe850b05a838dd64ae62b30c9a979de371b24db6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/138741
Commit-Queue: Srujan Gaddam <srujzs@google.com>
Reviewed-by: Bob Nystrom <rnystrom@google.com>
 2020-03-09 20:32:49 +00:00
Srujan Gaddam 3d0432eafc Add returnsNormally to async_minitest 
Included change in fileapi_supported_throws_test to sanity test the
change in async_minitest.

Change-Id: I6e6b6b4eb0740ae695a85d4b3c1e2b4f8f63615a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/138614
Commit-Queue: Srujan Gaddam <srujzs@google.com>
Reviewed-by: Bob Nystrom <rnystrom@google.com>
 2020-03-07 02:02:24 +00:00
Srujan Gaddam 29d4b611fb Remove html_individual_config from indexeddb_1_test 
Change-Id: I1fe053dd575b8bdaeff61d9424af614eef946b7c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/138242
Reviewed-by: Sigmund Cherem <sigmund@google.com>
Reviewed-by: Bob Nystrom <rnystrom@google.com>
Commit-Queue: Srujan Gaddam <srujzs@google.com>
 2020-03-06 21:32:43 +00:00
Srujan Gaddam 7b6adc6083 Remove html_individual_config from remaining html tests 
Change-Id: Ic60687e434cb3fef911245982f2f959f82291766
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/138267
Commit-Queue: Srujan Gaddam <srujzs@google.com>
Reviewed-by: Bob Nystrom <rnystrom@google.com>
Reviewed-by: Sigmund Cherem <sigmund@google.com>
 2020-03-06 06:25:51 +00:00
Srujan Gaddam a54a5eebb2 Remove html_individual_config from interactive_geolocation_test 
Change-Id: I145450eac12c311c1a8c0d5684fa31bc8609fd37
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/138268
Reviewed-by: Bob Nystrom <rnystrom@google.com>
Commit-Queue: Srujan Gaddam <srujzs@google.com>
 2020-03-06 00:17:51 +00:00
Nate Bosch 9d76737487 Remove support for --emit-metadata in DDC 
This flag is unused and the behavior it enables was only useful along with
`dart:mirrors`.

- Remove the flag and the field on the options object.
- Prune code branches that are no longer reachable.
- Remove or inline some functions that became either empty or trivially small.
- Remove the manual check for a `dart:mirrors` import since this is handled by
  the CFE now.
- Remove references to the flag in tests.
- Remove test files which only existed to enable the flag for other tests.

Change-Id: I21bf594271fb4eeb5b73fcbf07da736e9e8d1f33
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/138018
Reviewed-by: Nicholas Shahan <nshahan@google.com>
Commit-Queue: Nate Bosch <nbosch@google.com>
Auto-Submit: Nate Bosch <nbosch@google.com>
 2020-03-05 23:26:13 +00:00
Srujan Gaddam 6e8efe2a15 Remove html_config from document_register_basic_test 
Change-Id: I9df37df1d6f4d0ad90d33e09e6da4b94fb668fa2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/138387
Commit-Queue: Srujan Gaddam <srujzs@google.com>
Reviewed-by: Bob Nystrom <rnystrom@google.com>
 2020-03-05 23:26:11 +00:00
Srujan Gaddam 90f3dadb2e Remove html_individual_config from js_interop tests 
These tests were not being run since they were not in groups before.
These tests were also not split correctly, as the js file they're
associated with was deleted and there's only one html file. An html file
per test is included and the js file is reintroduced.

Change-Id: I058ec68220bc9c96325c460523e600578f25e5f4
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/138264
Reviewed-by: Sigmund Cherem <sigmund@google.com>
Reviewed-by: Bob Nystrom <rnystrom@google.com>
Commit-Queue: Srujan Gaddam <srujzs@google.com>
 2020-03-05 01:23:44 +00:00
Srujan Gaddam b60e9ae71f Move js_function_getter_trust_types_test off of unittest 
Both html_individual_config.dart and unittest.dart are removed. Lack of
groups before were hiding what are now compile time errors, so static
error testing is introduced to handle them.

Change-Id: I1b87f7438f2ab301207cc401254206bcd77eb072
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/138244
Reviewed-by: Sigmund Cherem <sigmund@google.com>
Commit-Queue: Srujan Gaddam <srujzs@google.com>
 2020-03-04 23:56:55 +00:00
Srujan Gaddam 2215221a2d Remove html_individual_config from worker_test 
Separate out the tests into separate test files due to failures for the
functional group.

Change-Id: Iafbb77e08145f04c56f807ba8f945abd8ec63d53
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/138243
Reviewed-by: Bob Nystrom <rnystrom@google.com>
Reviewed-by: Sigmund Cherem <sigmund@google.com>
Commit-Queue: Srujan Gaddam <srujzs@google.com>
 2020-03-04 21:56:26 +00:00
Srujan Gaddam c0e8126716 Separate out lib_2/html/history_test 
Remove html_individual_config and refactor groups out to separate test
files. The 'history' group of tests was never being run due to its name,
so 'popstateevent' introduces a new failure, although it isn't actually
new.

Change-Id: I8569ab7f8a47cd0ea60901da2afa296c9593631f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/138241
Commit-Queue: Srujan Gaddam <srujzs@google.com>
Reviewed-by: Bob Nystrom <rnystrom@google.com>
 2020-03-04 21:50:56 +00:00
Jacob MacDonald 6f620781c9 delete packageRoot support in test runner package, migrate to package_config from package_resolver 
Not sure what might be relying on this - going to check what the bots think about it :D

Bug: https://github.com/dart-lang/package_resolver/issues/30
Change-Id: I283d60d749a3db8a4e02dfdb1889ce56c8630620
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/138324
Commit-Queue: Jake Macdonald <jakemac@google.com>
Reviewed-by: Bob Nystrom <rnystrom@google.com>
 2020-03-04 20:15:19 +00:00
Srujan Gaddam 95bb6d8d19 Separate entered_left_view tests into separate test files 
Note that groups are maintained since group-level setUps are applied to
each test. This removes html_individual_config.

Change-Id: I62e722252202372880d888161e9b7544b1194034
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/138045
Reviewed-by: Sigmund Cherem <sigmund@google.com>
Reviewed-by: Bob Nystrom <rnystrom@google.com>
Commit-Queue: Srujan Gaddam <srujzs@google.com>
 2020-03-04 00:11:43 +00:00
Srujan Gaddam 18f366cf7e Move element_animate_test into separate test files 
Remove html_individual_config and separate groups out into test files.

Change-Id: Icb0b81d97797bf78d19f100c92ce9582120beed6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/138044
Commit-Queue: Srujan Gaddam <srujzs@google.com>
Reviewed-by: Sigmund Cherem <sigmund@google.com>
Reviewed-by: Bob Nystrom <rnystrom@google.com>
 2020-03-03 22:33:33 +00:00
Srujan Gaddam e797a066dc Separate canvasrenderingcontext2d into multiple tests 
Separate each group into its own test file and have them refer to a
shared util file.

Change-Id: I3f3534b22cb6921da19eb9534af8c4ebd8a2d1b5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/137727
Commit-Queue: Srujan Gaddam <srujzs@google.com>
Reviewed-by: Sigmund Cherem <sigmund@google.com>
 2020-02-29 01:23:30 +00:00
Srujan Gaddam 3de553f7ef Remove html_individual_config from some html tests 
Only landing the ones that don't introduce rename failures in this CL.

Change-Id: I052058a0168eaad71c3e10d804bce63d9f52b194
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/137647
Reviewed-by: Bob Nystrom <rnystrom@google.com>
Commit-Queue: Srujan Gaddam <srujzs@google.com>
 2020-02-27 21:13:25 +00:00
Ryan Macnak 2a5d0589ac [vm, gc] Verify the store buffer contains all old-space objects that reference new-space objects. 
Speed-up ObjectSets.

Fix pointer verification before and after scavenging to set the correct mark expectation being on concurrent marking state.

Bug: https://github.com/dart-lang/sdk/issues/40780
Change-Id: Ic7ce6d5a829e41634083b0c274b9764da3f4b619
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/137240
Commit-Queue: Ryan Macnak <rmacnak@google.com>
Reviewed-by: Alexander Markov <alexmarkov@google.com>
Reviewed-by: Siva Annamalai <asiva@google.com>
 2020-02-27 19:26:33 +00:00
Srujan Gaddam b3a1299f22 Revert "Remove html_individual_config from lib_2/html tests" 
This reverts commit ccd2f7e7d1.

Reason for revert: CL broke other targets outside of try jobs

Original change's description:
> Remove html_individual_config from lib_2/html tests
> 
> Change-Id: I4a9684096f8e6d6a9af95f8a160c532e16f1be93
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/137247
> Reviewed-by: Bob Nystrom <rnystrom@google.com>

TBR=rnystrom@google.com,srujzs@google.com

Change-Id: I762f7b7eec167dab3c96a03bd8df07b1c6ad7876
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/137431
Reviewed-by: Srujan Gaddam <srujzs@google.com>
Commit-Queue: Srujan Gaddam <srujzs@google.com>
 2020-02-27 04:10:34 +00:00
Srujan Gaddam ccd2f7e7d1 Remove html_individual_config from lib_2/html tests 
Change-Id: I4a9684096f8e6d6a9af95f8a160c532e16f1be93
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/137247
Reviewed-by: Bob Nystrom <rnystrom@google.com>
 2020-02-27 02:25:56 +00:00
Robert Nystrom fca91e4dfd Migrate css_selector_test off unittest. 
This test was actually totally broken. It called
useHtmlIndividualConfiguration(), which tells the test runner to treat
each group() as a separate test. But it had no group() calls at all, so
the test runner didn't enqueue *anything* for it. It was completely
skipped. :-O

Change-Id: Ib7b030c94d286f467601ec490308c32fb500c7a8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/137291
Commit-Queue: Bob Nystrom <rnystrom@google.com>
Commit-Queue: Srujan Gaddam <srujzs@google.com>
Auto-Submit: Bob Nystrom <rnystrom@google.com>
Reviewed-by: Srujan Gaddam <srujzs@google.com>
 2020-02-26 02:17:55 +00:00