6e53ac6e4c
[vm/nnbd] Fix supertype check in GenerateSubtype1TestCacheLookup
...
Before calling Subtype1TestCache stub, there was a quick check if
supertype's class id matches tested class id.
Null extends Object, so supertype of Null matches Object.
However, in NNBD strong mode Null is not assignable to Object.
Fixes https://github.com/dart-lang/sdk/issues/41272
Change-Id: Icc3efaf90992b5083cbe086af81db7504724b855
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/142085
Reviewed-by: Régis Crelier <regis@google.com >
Commit-Queue: Alexander Markov <alexmarkov@google.com >
2020-04-02 01:39:10 +00:00
b177e44ffa
Add mixed inheritance tests
...
Updates Mar 19, for better precision in tests (that is, catching
more bugs):
Added tests where `r.m(null).isEven` is used
to near-verify that the receiver `r` implements `A<int*>`:
With `A<int>` it's an error to pass `null`, and with `A<int?>`
it is an error to invoke `isEven`.
Added '1_error' test to detect that `r.m(null).isEven` is a
compile-time error in cases where the receiver has a different
member signature for `m`.
Added '3_error' test to detect that it is a compile-time error to assign
'D().a' to a specific type, for many `D`. This helps catching the
situation where the member signature of `a` is legacy: if that were
true then this test will fail because there is no error).
Change-Id: If6abafbadb51dcb04d13876b577d15c74bf47ccc
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/139817
Commit-Queue: Erik Ernst <eernst@google.com >
Reviewed-by: Leaf Petersen <leafp@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Johnni Winther <johnniwinther@google.com >
2020-04-01 13:18:04 +00:00
0f89df0c00
[tests/nnbd] Fork language/bool tests for weak and strong mode
...
Migrated language/bool tests expect TypeError when null value is used
in a condition (which is still possible if static type of condition is
dynamic). This is right in NNBD strong mode, as implicit cast of null
to bool will fail with TypeError. However, in NNBD weak mode implicit
cast passes, and then AssertionError is thrown as before.
Before migration language_2/bool tests expected AssertionError.
This change forks the tests to behave differently in weak and strong
modes.
Change-Id: Iaba9e606bafe5740a998a60a74a6b54e38cac86b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/141800
Reviewed-by: Leaf Petersen <leafp@google.com >
Reviewed-by: Bob Nystrom <rnystrom@google.com >
Commit-Queue: Alexander Markov <alexmarkov@google.com >
2020-04-01 00:35:37 +00:00
2eed35d650
Migrate language_2/class to NNBD.
...
Change-Id: I5f9aa5799cf88a320675debb919011f8a19b6faa
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/141742
Auto-Submit: Bob Nystrom <rnystrom@google.com >
Reviewed-by: Lasse R.H. Nielsen <lrn@google.com >
Commit-Queue: Bob Nystrom <rnystrom@google.com >
2020-03-31 18:16:55 +00:00
80ff59ed27
Migrate language_2/cascade to NNBD.
...
Change-Id: I2b3a52b6df08bf31c4fc0cfe0512ccf65bd0506b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/141701
Auto-Submit: Bob Nystrom <rnystrom@google.com >
Reviewed-by: Erik Ernst <eernst@google.com >
Commit-Queue: Bob Nystrom <rnystrom@google.com >
2020-03-31 18:06:40 +00:00
959bf6e1c3
Migrate language_2/compile_time_constant to NNBD.
...
Change-Id: I6cbad15f7151a1a5e1ece71f91ddfb826dca5de5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/141762
Auto-Submit: Bob Nystrom <rnystrom@google.com >
Reviewed-by: Leaf Petersen <leafp@google.com >
Commit-Queue: Bob Nystrom <rnystrom@google.com >
2020-03-31 15:51:50 +00:00
7cf6e52cd1
Migrate language_2/canonicalize to NNBD.
...
Change-Id: I603740794fc286527f7f37c0d57feb9b57157784
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/141661
Auto-Submit: Bob Nystrom <rnystrom@google.com >
Reviewed-by: Erik Ernst <eernst@google.com >
Commit-Queue: Bob Nystrom <rnystrom@google.com >
2020-03-31 00:42:49 +00:00
4a5e6e649a
Update default_list_constructor_test to reflect that any use of the default List constructor is an error.
...
Change-Id: I97657eb8c44fd07c4940b757d6962534b8276e36
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/140766
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2020-03-24 20:01:55 +00:00
9ea09ce17b
[cfe] Improve message on final variable assignment
...
Closes #40242
Change-Id: Iccdfbf01da18ddd501dc705b678358c974003551
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/140654
Commit-Queue: Johnni Winther <johnniwinther@google.com >
Reviewed-by: Jens Johansen <jensj@google.com >
2020-03-24 13:11:29 +00:00
e3af7e724f
Update usage of int/String fromEnvironment
...
Breaking change 40678 requires the constructors int.fromEnvironment and
String.fromEnvironment to get new default values for the named
parameter `defaultValue`. This CL changes usages of these constructors
such that they do not depend on the default value, such that it
becomes a non-breaking change for code in the SDK repo to perform the
change in sdk and in sdk_nnbd.
Change-Id: I82af0e1f92d6cd3618b65c0c50d754ae8c39eb0a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/140284
Reviewed-by: Lasse R.H. Nielsen <lrn@google.com >
Reviewed-by: Leaf Petersen <leafp@google.com >
Commit-Queue: Erik Ernst <eernst@google.com >
2020-03-24 11:19:14 +00:00
62f84880ef
[cfe] Report error on missing return from non-nullable function
...
Closes #40520
Closes #40948
Closes #40425
Change-Id: I0aa3cfa51b410c90dd0bea963846eeb6b2e73efb
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/140540
Commit-Queue: Johnni Winther <johnniwinther@google.com >
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com >
2020-03-24 08:21:36 +00:00
b8544e8220
[cfe] Don't report nnbd errors/warnings in top level inference
...
Closes #41102
Change-Id: Ieede171d92aa28b0ad9478a1b4293ddf35418d7e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/140040
Commit-Queue: Johnni Winther <johnniwinther@google.com >
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com >
2020-03-23 16:39:03 +00:00
7aace6fa60
Make StackTrace generally not nullable in migrated NNBD library.
...
Bug: https://github.com/dart-lang/sdk/issues/40130
Change-Id: I13aba0c2a3fa5b1c3d3995f075ffd38f03aca897
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/139880
Reviewed-by: Bob Nystrom <rnystrom@google.com >
2020-03-19 23:31:30 +00:00
3ae7394979
[tests] Update test expectation methods
...
`Expect.identical()` --> `Expect.equals()`
The spec defines runtime type object equality but not that they are
identical.
Issue: https://github.com/dart-lang/sdk/issues/41005
Change-Id: I57a0a5da0af18974d4081ea463ec0bff86f7d3e4
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/139843
Reviewed-by: Régis Crelier <regis@google.com >
Commit-Queue: Nicholas Shahan <nshahan@google.com >
2020-03-17 23:43:05 +00:00
fa77a43c76
[tests] Add analysis options file to migrated test directories
...
The intent of this change is to make editing the tests in these
directories more user friendly. When you open these directories in an
analyzer enabled editor it will produce results consistent with the
language features being used in the test.
Change-Id: I68e9cdc0e9fccfc360a2649261a5fdca042ec108
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/139560
Reviewed-by: Paul Berry <paulberry@google.com >
Reviewed-by: Bob Nystrom <rnystrom@google.com >
Commit-Queue: Nicholas Shahan <nshahan@google.com >
2020-03-16 20:51:26 +00:00
0f8238efe9
Issue 41036. Add null-shorting for prefix/postfix expressions.
...
Bug: https://github.com/dart-lang/sdk/issues/41036
Change-Id: Iccff235bc81b6e65a3b40f972aaa75707ac2232c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/139462
Reviewed-by: Janice Collins <jcollins@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2020-03-16 20:23:16 +00:00
9301c2f593
[tests] Fix analysis errors in tests
...
Non-nullable and optional method arguments need default values. Embedded
the generic type argument into a List as an easy way to create a default
value.
Change-Id: Ib171c272c75b114447d356d423c45dc9aeff9bb4
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/139160
Commit-Queue: Nicholas Shahan <nshahan@google.com >
Reviewed-by: Erik Ernst <eernst@google.com >
2020-03-12 18:16:36 +00:00
33349076ee
[tests] Add tests for type object equality after FutrureOr normalization
...
Change-Id: I61d0b35fff087091eafa921f679a29760b00b84f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/138103
Reviewed-by: Erik Ernst <eernst@google.com >
Commit-Queue: Nicholas Shahan <nshahan@google.com >
2020-03-12 01:20:50 +00:00
5e9be81d5e
Make all CastErrors be TypeErrors.
...
This makes CastError implement TypeError, and changes all test
expectations to look for TypeError. A followup CL will deprecate
CastError.
Bug: https://github.com/dart-lang/language/issues/787
Bug: https://github.com/dart-lang/sdk/issues/34097
Change-Id: I7102c6260901317572d2df08c4be9c4c48197688
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/138670
Reviewed-by: Bob Nystrom <rnystrom@google.com >
Reviewed-by: Sigmund Cherem <sigmund@google.com >
2020-03-11 23:31:06 +00:00
a44f680932
Update assignment in language/nnbd/operator_type_test
...
Change-Id: I81b87af6bd8ae51d626afb79412730c4bc39204a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/138980
Reviewed-by: Erik Ernst <eernst@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2020-03-11 15:09:24 +00:00
0e0cde55a0
Add default values for tests/language/nnbd/type_equality/function_type_equality_test
...
R=brianwilkerson@google.com , paulberry@google.com
Change-Id: I5f1f356e96f66b4b0098fba6ab61109ae5cc3ac5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/139026
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2020-03-11 15:01:29 +00:00
21cddbd4cf
Fix language/nnbd/syntax/late_modifier_error_test
...
R=brianwilkerson@google.com , paulberry@google.com
Change-Id: Icdefdfcae39a496fff6f8cf0b505b0a67a282ef2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/139021
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2020-03-11 15:01:21 +00:00
d7f697f64a
Include additional analyzer errors in language/nnbd/syntax/class_member_declarations_error_test
...
Change-Id: Iee4344a65e85890c3361294a6bdaa0920a3a4f10
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/139020
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2020-03-11 00:45:41 +00:00
f34fa57d98
Update null aware subscript test
...
Change-Id: Ib3a37f575906c125b850fa82732595f1532c9d9e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/138721
Reviewed-by: Bob Nystrom <rnystrom@google.com >
2020-03-10 17:41:51 +00:00
bbb449dfa4
Issue 40931. Update inference constraint for T? to be non-nullable.
...
Bug: https://github.com/dart-lang/sdk/issues/40931
Change-Id: I483c3febad236b366f911f38339c712dd928cfcf
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/138790
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Paul Berry <paulberry@google.com >
2020-03-10 02:19:50 +00:00
24c8021f03
Replace initialize() with declare().
...
Fixes https://github.com/dart-lang/sdk/issues/38791
Change-Id: I954059160c75de91e1e32fe2f82ebfdc5569d947
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/138666
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Paul Berry <paulberry@google.com >
2020-03-09 18:24:51 +00:00
9a62df57fa
Fix a test to get the analyzer nnbd bot to pass
...
Change-Id: I5892c245d4aa984c896471bf18cd71362958d0c6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/138782
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2020-03-09 17:47:47 +00:00
2c5a56e7bb
[vm] Disable late field init for constructor initialized fields
...
Change-Id: Ibdab37839d07b77bf2c92a09f760f44b54d94bcb
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/138620
Reviewed-by: Alexander Markov <alexmarkov@google.com >
Commit-Queue: Liam Appelbe <liama@google.com >
2020-03-06 17:10:08 +00:00
331067017f
[vm] Fix late field store bug
...
Late field stores were being incorrectly marked as initializations,
causing them to be incorrectly optimised out in some cases.
Change-Id: I7487d24238af3b3922e76a9ca6ae6df4bf5ab849
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/138566
Reviewed-by: Alexander Markov <alexmarkov@google.com >
Reviewed-by: Liam Appelbe <liama@google.com >
Commit-Queue: Liam Appelbe <liama@google.com >
2020-03-05 23:34:16 +00:00
739852d99d
Migrate language_2/call to NNBD.
...
Change-Id: I3356296e72dfa07b0ac994da0ce96f766b182e80
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/137722
Commit-Queue: Bob Nystrom <rnystrom@google.com >
Auto-Submit: Bob Nystrom <rnystrom@google.com >
Reviewed-by: Leaf Petersen <leafp@google.com >
2020-03-05 19:56:49 +00:00
f6b0a70230
Migrate language_2/await to NNBD.
...
Change-Id: I59ae5b01c00f3bebda0ba74eb5eb1950ade59925
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/137720
Reviewed-by: Erik Ernst <eernst@google.com >
Commit-Queue: Bob Nystrom <rnystrom@google.com >
Auto-Submit: Bob Nystrom <rnystrom@google.com >
2020-03-05 18:17:29 +00:00
1c64138e56
Migrate language_2/bool to NNBD.
...
Change-Id: Id061ea5cb02e6fbac7430df95dc88786ce281363
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/137721
Commit-Queue: Bob Nystrom <rnystrom@google.com >
Auto-Submit: Bob Nystrom <rnystrom@google.com >
Reviewed-by: Erik Ernst <eernst@google.com >
2020-03-05 18:15:39 +00:00
bd6899269e
[vm] Handle required params in closures and tear-offs
...
I planned to make this conditional on function_.IsClosureFunction, but
the Goto is so trivial that there's no harm in doing this for all
required params (in fact it actually shrinks the prologue size).
Fixes: https://github.com/dart-lang/sdk/issues/39660
Fixes: https://github.com/dart-lang/sdk/issues/38843
Change-Id: I8e4db906ae709778d76c6b81524e45377266e32b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/138328
Reviewed-by: Alexander Markov <alexmarkov@google.com >
Commit-Queue: Liam Appelbe <liama@google.com >
2020-03-04 20:57:26 +00:00
149b799ae4
[vm] Check required flag during function resolution.
...
Bug: https://github.com/dart-lang/sdk/issues/39660
Bug: https://github.com/dart-lang/sdk/issues/38843
Change-Id: I2eb5f5ac38d7b1896db5c57399c42cdb41b16094
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/137737
Commit-Queue: Liam Appelbe <liama@google.com >
Reviewed-by: Alexander Markov <alexmarkov@google.com >
Reviewed-by: Régis Crelier <regis@google.com >
2020-03-02 23:05:16 +00:00
434f7228bf
Make parameter required to fix nullability error.
...
It is only used in one place and is always passed.
Change-Id: I8bdc46963ee9e10591edb951dc72e065ba5678cb
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/137760
Commit-Queue: Bob Nystrom <rnystrom@google.com >
Auto-Submit: Bob Nystrom <rnystrom@google.com >
Reviewed-by: Leaf Petersen <leafp@google.com >
2020-02-28 01:43:01 +00:00
16f072c783
Migrate language_2/async to NNBD.
...
Change-Id: Id66e712eaf52fda2069ce5177aa091e373ad52c1
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/134244
Commit-Queue: Bob Nystrom <rnystrom@google.com >
Reviewed-by: Nicholas Shahan <nshahan@google.com >
Reviewed-by: Erik Ernst <eernst@google.com >
Auto-Submit: Bob Nystrom <rnystrom@google.com >
2020-02-27 23:04:03 +00:00
21bc1ed76c
[VM/nnbd] Allow instantiation of a non-nullable type parameter to a nullable type.
...
Change-Id: Icc3413cd5c285fa40ee5188f39837625d78b9e67
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/137427
Commit-Queue: Régis Crelier <regis@google.com >
Reviewed-by: Alexander Markov <alexmarkov@google.com >
2020-02-27 19:48:23 +00:00
77e1c72d04
[vm/nnbd] Type testing stubs in NNBD strong mode
...
Issue: https://github.com/dart-lang/sdk/issues/38845
Change-Id: I82e7a1b3c4220abdd2a215529230fbb158adbe9e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/135627
Commit-Queue: Alexander Markov <alexmarkov@google.com >
Reviewed-by: Martin Kustermann <kustermann@google.com >
Reviewed-by: Régis Crelier <regis@google.com >
2020-02-27 04:36:24 +00:00
781cd94279
[tests] Adding test for recursive legacy class type bounds.
...
See fix: https://dart-review.googlesource.com/c/sdk/+/136724
Change-Id: I85b005898579c1c6fe6904e590e13cc20f754fee
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/136820
Reviewed-by: Erik Ernst <eernst@google.com >
Reviewed-by: Nicholas Shahan <nshahan@google.com >
2020-02-27 00:06:20 +00:00
36cc80d576
[tests] Adding runtime tests for required named arguments.
...
Change-Id: I1c76fa279c8c3572b48f5eb58eff53f703baca6b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/124106
Reviewed-by: Nicholas Shahan <nshahan@google.com >
2020-02-27 00:06:14 +00:00
0c7b9cf470
Issue 40764. Use Never instead of Null when converting super-bounded to regular-bounded.
...
Bug: https://github.com/dart-lang/sdk/issues/40764
Change-Id: I58f0e9860dd000aa2d8e416c5fce7e8964db0ef8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/137280
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Paul Berry <paulberry@google.com >
2020-02-26 20:12:51 +00:00
05d2586099
[nnbd] Fix analyser error in required params test
...
Bug: https://github.com/dart-lang/sdk/issues/40781
Change-Id: Id5eefd844ac80c48b8558ead859adb451eb9fcb4
Fixes: https://github.com/dart-lang/sdk/issues/40781
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/137320
Reviewed-by: Alexander Markov <alexmarkov@google.com >
Commit-Queue: Liam Appelbe <liama@google.com >
2020-02-26 17:43:27 +00:00
9e03c2c506
[vm] Add required flag to parameters, and implement subtyping rules.
...
This CL only covers AST mode, and doesn't address function resolution.
Bug: https://github.com/dart-lang/sdk/issues/39755
Change-Id: I19280fb0d373aa9eb17da13677fd5bb1230385da
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/131701
Commit-Queue: Liam Appelbe <liama@google.com >
Reviewed-by: Alexander Markov <alexmarkov@google.com >
Reviewed-by: Régis Crelier <regis@google.com >
2020-02-26 00:38:54 +00:00
d10ffdb4c3
[VM/nnbd] Check nullability of function types in strong mode ( fixes #39820 ).
...
Also added "// Requirements=nnbd-strong" to test (correctly fails in weak mode).
Change-Id: If375b912b03c50cf968fcc45bd78be3d9bc1cb33
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/137241
Commit-Queue: Régis Crelier <regis@google.com >
Reviewed-by: Alexander Markov <alexmarkov@google.com >
2020-02-26 00:05:53 +00:00
3bd8e36bea
[tests/nnbd] Fix language/async_star/throw_in_catch_test
...
Fixes a compile-time error which was introduced during migration.
Change-Id: Id2b44f11481c354c76cd216cbd3190703ed968f6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/137200
Reviewed-by: Bob Nystrom <rnystrom@google.com >
Commit-Queue: Alexander Markov <alexmarkov@google.com >
2020-02-25 22:47:43 +00:00
550ac009b3
Update tests expectations with DEAD_NULL_AWARE_EXPRESSION.
...
R=brianwilkerson@google.com , paulberry@google.com
Change-Id: I26f585c5ea4ec872d574a8bcd09226b8d1a1cc0e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/137180
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2020-02-25 21:21:16 +00:00
9d1b5ced65
[dartdevc] Update instantiated type arguments in tear-offs
...
They now become a `Object*` or `Object?` if the library where the method
is defined is legacy or null safe.
Change-Id: Ia3de0d728187b9c5bf64cc8c08aa075e63aff942
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/136723
Reviewed-by: Sigmund Cherem <sigmund@google.com >
Reviewed-by: Mark Zhou <markzipan@google.com >
Commit-Queue: Nicholas Shahan <nshahan@google.com >
2020-02-22 00:34:21 +00:00
a47b9996c8
[tests] Add tests for function type equality with Null Safety
...
Change-Id: I85d9764aee2f6260267ad7b499b2c138ffcc4501
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/135533
Commit-Queue: Nicholas Shahan <nshahan@google.com >
Reviewed-by: Bob Nystrom <rnystrom@google.com >
Reviewed-by: Erik Ernst <eernst@google.com >
2020-02-21 19:59:11 +00:00
98b4635aa9
Make TypeError no longer implement AssertionError.
...
This means that TypeError no longer inherits a spurious `message` member.
The message of a platform-thrown TypeError is still available as `toString()`.
Fixes #40317
Bug: http://dartbug.com/40317
Change-Id: I77312859ebae3f92c2e56aeea6283b075b71c8d5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/136129
Commit-Queue: Lasse R.H. Nielsen <lrn@google.com >
Reviewed-by: Erik Ernst <eernst@google.com >
2020-02-21 14:02:57 +00:00
b81f12a549
Migrate language_2/async_star to NNBD.
...
Change-Id: I0fa2ee2561dd0bc399d88868d790d56e6df3c94d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/134940
Commit-Queue: Bob Nystrom <rnystrom@google.com >
Auto-Submit: Bob Nystrom <rnystrom@google.com >
Reviewed-by: Lasse R.H. Nielsen <lrn@google.com >
2020-02-21 00:22:06 +00:00
Alexander Markov