dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 3 Packages Projects Releases Wiki Activity
71,643 Commits 2 Branches 0 Tags
6e53ac6e4c7b3d94de5ee0370a538b03dafded1c
Commit Graph

6234 Commits

Author SHA1 Message Date
Konstantin Shcheglov a373aa7ce1 Convert GenericInferrer tests to non-nullable. 
I.e. print types with nullabilities, and use 'none' types in tests.

R=brianwilkerson@google.com

Change-Id: Ia53885ebe7077b0de12e01ac5171711ca8b57e46
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/142086
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-04-01 22:36:18 +00:00
Konstantin Shcheglov 3af491ecd8 Move additional tests and remove GreatestLowerBoundTest. 
Change-Id: I463e4dacb5226d417e6ee13b53540c7c6b76cfc2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/142065
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-04-01 21:38:48 +00:00
Konstantin Shcheglov 191be51124 Extract GenericInferrer and type schema. 
Change-Id: Ic306342609911e3e232dbf95f30b60cff94c34be
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/142062
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-04-01 20:54:48 +00:00
Konstantin Shcheglov cf5620fa9e Use the deep-most packages. 
Change-Id: I8c03e67d16a58f48e0ac334c216b21dcf2e532c0
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/141921
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-04-01 17:42:52 +00:00
Konstantin Shcheglov 0e5b596e0d Extract GreatestLowerBoundHelper and LeastUpperBoundHelper. 
Change-Id: I1e10798d2dfe231ab5e6fb87a5eed42e81e43998
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/141905
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-04-01 17:41:42 +00:00
Johnni Winther d68f552e70 [analyzer,cfe] Handle (un)assigned state in try-statement 
This handles (un)assigned state in try-statement that do not
complete normally. In this case we could create a variable model
for an unreachable state that would be both assigned and unassigned
leading to an assertion failure.

Closes #41284

Change-Id: Id4c7689bc7c614338af3542eb342c964696fca1e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/141981
Auto-Submit: Johnni Winther <johnniwinther@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2020-04-01 15:46:15 +00:00
Konstantin Shcheglov 37773d39be Make 'covariant' parameter required in tryMatchSubtypeOf(). 
R=brianwilkerson@google.com, paulberry@google.com

Change-Id: I7a30e886c8fe2abdc5402d0d9da283cdd8f32c87
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/141913
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-04-01 15:36:45 +00:00
Konstantin Shcheglov 9864a9532a Set dynamic resolution for super MethodInvocation in invalid context. 
Every MethodInvocation should be resolved, even if to dynamic.
Leaving it undersolved caused NPEs later.

R=brianwilkerson@google.com, paulberry@google.com

Change-Id: I43ad2889639684ecaecf3810127213f69765a271
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/141703
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-03-30 23:25:49 +00:00
Konstantin Shcheglov 44b6f02985 Revert "Fix the result type of binary expression with the left TypeParameter extends num type." 
This reverts commit 35ebf66c6a.

Reason for revert: This change is not supported by the specification.

Original change's description:
> Fix the result type of binary expression with the left TypeParameter extends num type.
> 
> R=​brianwilkerson@google.com, paulberry@google.com
> 
> Change-Id: I279093c6d155a667b42c47dcd8ca734b874dde57
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/141473
> Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
> Commit-Queue: Konstantin Shcheglov <scheglov@google.com>

TBR=paulberry@google.com,scheglov@google.com,brianwilkerson@google.com

# Not skipping CQ checks because original CL landed > 1 day ago.

Change-Id: I84e90001d97f95dc729072d4dfa54a9bb53ab002
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/141640
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-03-30 16:35:56 +00:00
Konstantin Shcheglov 35ebf66c6a Fix the result type of binary expression with the left TypeParameter extends num type. 
R=brianwilkerson@google.com, paulberry@google.com

Change-Id: I279093c6d155a667b42c47dcd8ca734b874dde57
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/141473
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-03-29 04:09:23 +00:00
Konstantin Shcheglov 1807cf2030 Add LibraryElement.languageVersionMajor/Minor 
Change-Id: I33d2acb269381abf4f26aad0abe4e1feb2435931
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/141464
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2020-03-28 17:01:08 +00:00
Konstantin Shcheglov ea9df6827e Fix crash in index when the invoked element is multiply defined. 
Saw this in crash reports.

R=brianwilkerson@google.com, paulberry@google.com

Change-Id: Ib2052c8d17abcd0194d75eae43f9f0df37d123db
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/141522
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-03-28 16:53:03 +00:00
Konstantin Shcheglov 8120ee57d2 Merge types during instance member inference. 
Change-Id: If3f252d1c031fcb5219e485ac7a053186e6b950c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/141207
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-03-27 16:22:26 +00:00
Jens Johansen 4ab3bda5db [parser] Change recovery for constructor; report errors in bad constructors 
Change-Id: I3d656afce4a3ec14c7c099893a434abba3945ebf
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/140862
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Commit-Queue: Jens Johansen <jensj@google.com>
 2020-03-27 11:57:56 +00:00
Konstantin Shcheglov 216d98ad2c Use NNBD_TOP_MERGE to combine signatures of the inherited members. 
Initial: https://dart-review.googlesource.com/c/sdk/+/133041
Reverted: https://dart-review.googlesource.com/c/sdk/+/133086

Instance inference is not supported yet in this CL, will continue
in following CLs.

Change-Id: I72de01180b0624eeafc03bfe415ed3d928f1110f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/133167
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-03-26 21:13:12 +00:00
Konstantin Shcheglov fc91636703 Fix for crash when FieldFormalParameter in a local function has annotations. 
Saw this in the crash reports.

R=brianwilkerson@google.com

Change-Id: I890592b264a3c33df80d89b45ad55ebe3fdf0c09
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/141024
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-03-26 17:07:03 +00:00
Mike Fairhurst 3095a082cd [analyzer] Add an API to get a language comment token off a unit. 
Change-Id: I377fdc44d5e514d6d9a601b3947c3908e5a4497a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/140768
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2020-03-26 03:47:57 +00:00
Konstantin Shcheglov 8e91510b16 Issue 41180. Test that analyzer infers correctly. 
Bug: https://github.com/dart-lang/sdk/issues/41180
Change-Id: I177e0f5bad1522a98af987494ff02cad49b817e1
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/140820
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Leaf Petersen <leafp@google.com>
 2020-03-25 16:00:12 +00:00
Konstantin Shcheglov 70567aa8df Report an error when a null-aware index expression in legacy library. 
Change-Id: I931445a748d88bf7a1416b880de3299b4a3e19bc
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/140774
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-03-24 20:55:47 +00:00
Konstantin Shcheglov a06325447d Use InheritanceManager3 directly in id_tests/inheritance_test 
Change-Id: I2914b08f4c6b2b32f70001cd1445f5077e810a1d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/140761
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-03-24 15:29:23 +00:00
Erik Ernst e3af7e724f Update usage of int/String fromEnvironment 
Breaking change 40678 requires the constructors int.fromEnvironment and
String.fromEnvironment to get new default values for the named
parameter `defaultValue`. This CL changes usages of these constructors
such that they do not depend on the default value, such that it
becomes a non-breaking change for code in the SDK repo to perform the
change in sdk and in sdk_nnbd.

Change-Id: I82af0e1f92d6cd3618b65c0c50d754ae8c39eb0a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/140284
Reviewed-by: Lasse R.H. Nielsen <lrn@google.com>
Reviewed-by: Leaf Petersen <leafp@google.com>
Commit-Queue: Erik Ernst <eernst@google.com>
 2020-03-24 11:19:14 +00:00
Konstantin Shcheglov 5e4f28b900 Use ClassHierarchy for computing implemented interfaces. 
Change-Id: Ie7acf61f9a29d59cc1416dea85a6adb7c534b8c7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/140703
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-03-23 22:00:37 +00:00
Konstantin Shcheglov 6b7d7aa2c1 Type Function should be excluded from extended / implemented / mixed types. 
Change-Id: If225400a976657f042856bfdaf95b285f98cebb4
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/140660
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-03-23 20:35:37 +00:00
Konstantin Shcheglov 1dc03cc80c Fix for resolving MethodInvocation(s) with the synthetic method name. 
I saw crashes because of this internally, mostly around ListLiteral
resolution (which were arguments of method invocations), and left
unresolved.

Change-Id: I814a7ac6cb4bfdffff701a8ed51b80849cedb82c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/140483
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-03-22 21:19:39 +00:00
Konstantin Shcheglov bdf1454357 Consider FunctionType(s) with required named parameters as subtypes of legacy FunctionType(s) with named parameters. 
Change-Id: Ic2f6b0226ec7885e45ef54053b95b84d3bbf8201
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/140181
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2020-03-21 21:51:36 +00:00
Konstantin Shcheglov 3586f4ccde Issue 41130. Report an error for any default List constructor invocation. 
Bug: https://github.com/dart-lang/sdk/issues/41130
Change-Id: Ib9f440773f7a2ac68b9bcba8a5b380541298434b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/140363
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2020-03-21 18:39:16 +00:00
Konstantin Shcheglov 0100a5e7f9 Issue 41095. Update flatten() to null safety. 
Bug: https://github.com/dart-lang/sdk/issues/41095
Change-Id: Id72bbe6f51657c474f70eca35677225ba40a5569
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/140220
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-03-20 16:18:39 +00:00
Konstantin Shcheglov 532f43dcb2 Stop clearing evaluationResult for ConstVariableElement(s). 
This was causing constant errors in _fe_analyzer_shared

With summary2, after https://dart-review.googlesource.com/c/sdk/+/109460
we infer types of fields and field formal parameters together, so
https://github.com/dart-lang/sdk/issues/35940 does not happen.

Change-Id: I3d8532fa938f4942d971d8f9055c8f0f50f482df
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/140001
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2020-03-19 23:04:19 +00:00
Konstantin Shcheglov 4844fa9622 Issue 40959. Support null-shorting for cascades. 
Bug: https://github.com/dart-lang/sdk/issues/40959
Change-Id: Ia7fd153debafd13ab469bbfcc3a2d1ef3feaa5f5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/139865
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2020-03-18 07:36:36 +00:00
Konstantin Shcheglov f4592159d6 Issue 41050. Support for evaluating bool.hasEnvironment(). 
Bug: https://github.com/dart-lang/sdk/issues/41050
Change-Id: I806c201dde6e4692a3252fef5aec2fbcbd663147
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/139823
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2020-03-18 02:53:05 +00:00
Sam Rawlins 3fc075d397 Do not report on collision of private _static_ members 
Fixes #29751; related to #27218

Change-Id: I8adcc5dcc7a97ec3e8237506af84aff2667aff6f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/139866
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
 2020-03-18 01:05:25 +00:00
Sam Rawlins 9dfd0127da Do not report super-constructor errors on external constructors 
Bug: https://github.com/dart-lang/sdk/issues/27218
Change-Id: I1772cc850b21e97694eaa1852893993f6d4037b6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/139824
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
 2020-03-17 18:34:04 +00:00
Konstantin Shcheglov faae2ec2c5 Issue 41019. Fix for readType of IndexExpression. 
Bug: https://github.com/dart-lang/sdk/issues/41019
Change-Id: I861b355c14c6bb30e570bb0c0101871db423ffb0
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/139821
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-03-17 17:16:56 +00:00
Konstantin Shcheglov db5dc11b9b Issue 41050. Get default values for fromEnvironment() from element model. 
Bug: https://github.com/dart-lang/sdk/issues/41050
Change-Id: I8fee34a6b5816a725df4e4886fc85061ac4ec9b5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/139661
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-03-17 02:05:41 +00:00
Konstantin Shcheglov fbd232dbe6 Issue 40958. Fix null shorting for MethodInvocation. 
Bug: https://github.com/dart-lang/sdk/issues/40958
Change-Id: Ic96b54feeeced5adb3b4271180636b493f951976
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/139749
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-03-17 00:29:51 +00:00
Konstantin Shcheglov efdbd86647 Issue 40704. Fix AstTextPrinter for '?[' support. 
R=brianwilkerson@google.com

Bug: https://github.com/dart-lang/sdk/issues/40704
Change-Id: Icc800f8d5244030170b414c4f8c4d95cefab09a9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/139743
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-03-16 22:15:51 +00:00
Konstantin Shcheglov 0f8238efe9 Issue 41036. Add null-shorting for prefix/postfix expressions. 
Bug: https://github.com/dart-lang/sdk/issues/41036
Change-Id: Iccff235bc81b6e65a3b40f972aaa75707ac2232c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/139462
Reviewed-by: Janice Collins <jcollins@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-03-16 20:23:16 +00:00
Konstantin Shcheglov 7c5059f528 Issue 40704. Report INVALID_NULL_AWARE_OPERATOR for unnecessary '?['. 
Bug: https://github.com/dart-lang/sdk/issues/40704
Change-Id: I67b45a4b5c6afba38141b33b44e2fc28726dffd3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/139483
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-03-13 20:42:56 +00:00
Konstantin Shcheglov 29fe8b85c2 Issue 2025. Report an error when evaluating Set/Map literal and ForElement. 
Bug: https://github.com/dart-lang/linter/issues/2025
Change-Id: Ifa61299ed69e029a51f3f05fa11583e7abd5a2f5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/139420
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Phil Quitslund <pquitslund@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-03-13 16:50:32 +00:00
Johnni Winther 6c6144bb74 [cfe] Implement consolidated in ClassHierarchyBuilder 
Closes #40414 and #40156



Change-Id: I066aa8ceef4f998230215fd9e9b446b2281cc3bc
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/138294
Commit-Queue: Johnni Winther <johnniwinther@google.com>
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com>
 2020-03-13 08:16:49 +00:00
Konstantin Shcheglov 474c7c495b Extract MIXIN_DECLARES_CONSTRUCTOR tests. 
R=brianwilkerson@google.com

Change-Id: Ie48021e4f951f4342d04d59fb097201bd83b4efd
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/139403
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2020-03-13 00:59:02 +00:00
Konstantin Shcheglov 668c81ffbf Don't report FINAL_NOT_INITIALIZED_CONSTRUCTOR for mixins. 
We already report MIXIN_DECLARES_CONSTRUCTOR, and there was a crash
in quick fixes when we attempted to fix it for a mixin.

R=brianwilkerson@google.com

Change-Id: I453d1de0702e36978c3972fd586494d2cd92aa40
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/139316
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2020-03-12 22:49:46 +00:00
Keerti Parthasarathy cd3a13e3f6 Add an option to allow for prefecthing of directly referenced files when building unlined summaries. 
Change-Id: I20869dd6aee3ab5f4fc0bf99eab05c08173cb782
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/139320
Commit-Queue: Keerti Parthasarathy <keertip@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2020-03-12 22:28:46 +00:00
Konstantin Shcheglov ef6c7efc9f Issue 40941. Report FINAL_AND_COVARIANT_LATE_WITH_INITIALIZER. 
Bug: https://github.com/dart-lang/sdk/issues/40941
Change-Id: Ica0bbbdeee447c410cbfd64aea1a643711d21655
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/139322
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2020-03-12 21:04:06 +00:00
Konstantin Shcheglov e9e1d5a7f1 Issue 40956. Legacy view on required named parameters is not required. 
Bug: https://github.com/dart-lang/sdk/issues/40956
Change-Id: Ib4be27f084f7c88ccc4dab92aa557eab85eda166
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/139323
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-03-12 20:39:46 +00:00
Konstantin Shcheglov 3da03a648a Issue 40955. Late final variables without initializers have setters. 
Bug: https://github.com/dart-lang/sdk/issues/40955
Change-Id: I7cdccbf7f16e3a070b79f05062e6b5692a9f0051
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/139283
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-03-12 19:02:06 +00:00
Konstantin Shcheglov ad4762343b Issue 39876. Report DEFINITELY_UNASSIGNED_LATE_LOCAL_VARIABLE. 
Bug: https://github.com/dart-lang/sdk/issues/39876
Change-Id: I855579c47ab8f932bb3977eb44d0c17d0ce5987a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/139034
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-03-12 15:41:07 +00:00
Konstantin Shcheglov cdac6f614c Issue 40837. Fix for invalid function expression flow analysis. 
R=brianwilkerson@google.com

Bug: https://github.com/dart-lang/sdk/issues/40837
Change-Id: Id7021aa6b54fede6af2d03f51fd1d53445d174c9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/139149
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-03-12 15:33:02 +00:00
Jens Johansen 13dbe2a815 [parser] Correct precedence on ?[ when it's an index bracket operator 
Fixes #40267.

Change-Id: I1929da0500f85f70dc241d969d05590a1e0c277e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/138927
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Jens Johansen <jensj@google.com>
 2020-03-12 11:25:02 +00:00
Sam Rawlins 75f591b859 Remove extraneous extension_method experiment from analyzer tests 
Change-Id: I8373ab343cd95ef977beb82154f866f8f44fb4f0
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/134142
Commit-Queue: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2020-03-10 22:22:41 +00:00