dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
71,643 Commits 2 Branches 0 Tags
6e53ac6e4c7b3d94de5ee0370a538b03dafded1c
Commit Graph

3409 Commits

Author SHA1 Message Date
Paul Berry b7130b0bf7 Migration: improve preview tool display when ! is added due to an explicit hint. 
Change-Id: Ie9b2a6cabaf02c46da2e8b8ac1bffa0e699acc64
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/141741
Reviewed-by: Mike Fairhurst <mfairhurst@google.com>
 2020-03-31 22:04:46 +00:00
Konstantin Shcheglov ca6b0fd0df Fix for crash in WrapInText when the parameter is not InterfaceType. 
There was a crash in the logs.

_TypeError: type 'GenericFunctionTypeElementImpl' is not a subtype of type 'ClassElement'
at WrapInText.compute	(wrap_in_text.dart:26 )
at FixProcessor._addFromProducers.compute	(fix_internal.dart:4506 )
at FixProcessor._addFromProducers	(fix_internal.dart:4520 )
at FixProcessor.compute	(fix_internal.dart:762 )
at DartFixContributor.computeFixes	(fix_internal.dart:82 )


R=brianwilkerson@google.com, pquitslund@google.com

Change-Id: I187b3348a212391cc6c64ab2c412653bd2319334
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/141820
Reviewed-by: Phil Quitslund <pquitslund@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-03-31 15:56:40 +00:00
Brian Wilkerson 8969b1839c Enable omit_local_variable_types in analysis_server 
Change-Id: I7e5c13d40fd276854601681fc84be321e6031b10
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/141583
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2020-03-30 03:58:44 +00:00
Konstantin Shcheglov 3a0bf3ad36 Fix for creating a setter when the target is in a part without a library. 
R=brianwilkerson@google.com

Change-Id: I3c364f01c9cb31166e24f2b28d6a4640fa7d8c93
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/141560
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-03-28 21:00:23 +00:00
Brian Wilkerson 7e724e70b0 Sort non-generated files in analyis_server and add a test to ensure they stay that way 
Change-Id: I6c7a38cefa69f46737bd50eefe2fbb88c127017b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/141520
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2020-03-28 17:12:03 +00:00
Mike Fairhurst 62c4b1fb2e [nnbd_migration] Add a "rerun from sources" button. 
Change-Id: I09f1c76cb41549b81218783ec69d190271508ba0
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/141028
Commit-Queue: Janice Collins <jcollins@google.com>
Reviewed-by: Janice Collins <jcollins@google.com>
 2020-03-27 16:50:12 +00:00
Mike Fairhurst 3095a082cd [analyzer] Add an API to get a language comment token off a unit. 
Change-Id: I377fdc44d5e514d6d9a601b3947c3908e5a4497a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/140768
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2020-03-26 03:47:57 +00:00
Brian Wilkerson d194838578 Add new relevance scores to LibraryElementSuggestionBuilder, which covers both LibraryMemberContributor and CombinatorContributor 
This should have tests, but I (or someone else) need to do some data
mining to figure out the correct relevance values and hence the correct
ordering to test for.

Change-Id: I7782d7b7e13ff38a785c445cd0d6fc82a388a6aa
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/141000
Reviewed-by: Phil Quitslund <pquitslund@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2020-03-25 22:49:26 +00:00
Mike Fairhurst 5f20fe7d83 Revert "Trim not useful bottoms off of the non/nullability stack traces" 
This reverts commit a225178919.

Reason for revert: This seems to remove useful info from the stack trace. Will revert, then hopefully land an improved version.

Original change's description:
> Trim not useful bottoms off of the non/nullability stack traces
> 
> Change-Id: I2f7bfab13fd3d70c5cbdbb10ce14a8a91f8c7a60
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/140000
> Commit-Queue: Samuel Rawlins <srawlins@google.com>
> Reviewed-by: Paul Berry <paulberry@google.com>

TBR=paulberry@google.com,mfairhurst@google.com,srawlins@google.com

# Not skipping CQ checks because original CL landed > 1 day ago.

Change-Id: I9a2fb07e387d57394242b694e27456333f2cf2b8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/140908
Reviewed-by: Mike Fairhurst <mfairhurst@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
Commit-Queue: Mike Fairhurst <mfairhurst@google.com>
 2020-03-25 20:57:36 +00:00
Brian Wilkerson 3abbcd0da9 Attempt to fix windows bot failure 
Change-Id: I6288838fe5dea2cb7b8e0d79ee90d09c91496769
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/140901
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Auto-Submit: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2020-03-25 20:39:56 +00:00
Paul Berry 244b4247e9 Migration: better description text for edges. 
Change-Id: I58651c927a741721283c3c4c951673a86aa7a1b3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/140883
Reviewed-by: Mike Fairhurst <mfairhurst@google.com>
 2020-03-25 19:38:34 +00:00
Jaime Wren 81894b958f Fix another case of the form described in https://github.com/dart-lang/sdk/issues/41039, this fixes the FunctionDeclaration case. 
Bug: https://github.com/dart-lang/sdk/issues/41039
Change-Id: I03df7f8d92b1e7754410dc88e1c09ad83476960e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/140769
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Jaime Wren <jwren@google.com>
 2020-03-24 19:11:15 +00:00
Brian Wilkerson 2d0fed35bb Update the ArgListContributor to have new relevance scores 
This also includes a new metric computation showing how often function
typed parameters have closures as arguments.

Change-Id: I8999cc3935bcc7514ebba90a8a4d246b2f236c42
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/140702
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Phil Quitslund <pquitslund@google.com>
Reviewed-by: Jaime Wren <jwren@google.com>
 2020-03-24 17:00:55 +00:00
Devon Carew 1e45051341 [analyzer] initial implementation of SDK, file based configuration of the analysis server 
Change-Id: Iff3808fb073b062fa566993e7f05e2669a5fde7e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/140003
Commit-Queue: Devon Carew <devoncarew@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2020-03-24 14:07:59 +00:00
Erik Ernst e3af7e724f Update usage of int/String fromEnvironment 
Breaking change 40678 requires the constructors int.fromEnvironment and
String.fromEnvironment to get new default values for the named
parameter `defaultValue`. This CL changes usages of these constructors
such that they do not depend on the default value, such that it
becomes a non-breaking change for code in the SDK repo to perform the
change in sdk and in sdk_nnbd.

Change-Id: I82af0e1f92d6cd3618b65c0c50d754ae8c39eb0a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/140284
Reviewed-by: Lasse R.H. Nielsen <lrn@google.com>
Reviewed-by: Leaf Petersen <leafp@google.com>
Commit-Queue: Erik Ernst <eernst@google.com>
 2020-03-24 11:19:14 +00:00
Konstantin Shcheglov 6b7d7aa2c1 Type Function should be excluded from extended / implemented / mixed types. 
Change-Id: If225400a976657f042856bfdaf95b285f98cebb4
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/140660
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-03-23 20:35:37 +00:00
Jaime Wren 6f76f194b1 Fix the common case of https://github.com/dart-lang/sdk/issues/41039, around MethodDeclarations 
Code completion will now include void, dynamic and other class declaration keywords in the return type location, in the following snippet: '@override void someMethod(...) {}'

This is relatively common, this happens 103 times in the collection package.

Bug: https://github.com/dart-lang/sdk/issues/41039
Change-Id: I28129f2d735d2ff7d0a0e65194b7963c74b01c51
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/140360
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Jaime Wren <jwren@google.com>
 2020-03-23 18:03:44 +00:00
Jaime Wren dd95365f76 Optimization for the MeanReciprocalRankComputer.  This change doesn't have the object hold onto the list of ranks for the entire duration of a run, but has a running sum instead (similar to ArithmeticMeanComputer). 
This would have been an over-optimization originally, but at this point, we have 10 of these computer objects in completion_metrics.dart, and we are running this algorithm with up to 1.2 million ranks.

(Assuming that an int takes 4 bytes which I believe is true...) On a recent run of Brians, 29.4 MB of data was the running total of all the ranks.  With this change, the same data will be stored with 10 doubles and 10 ints.

Change-Id: If97ca18e78782c02a3ca0a3ed9d6a9725f5a05ea
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/140321
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Jaime Wren <jwren@google.com>
 2020-03-21 19:50:36 +00:00
Sam Rawlins b6ef199bc0 Migrator: fix test to assert on information region when not making a parameter nullable 
Change-Id: I1df34c06ec0f6ffac29fcef873ab7a83e7636044
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/140249
Reviewed-by: Paul Berry <paulberry@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
 2020-03-20 18:30:28 +00:00
pq a3499f0849 quickfix for prefer_const_constructors_in_immutables 
Fixes: https://github.com/dart-lang/sdk/issues/41097

Change-Id: I2ff001437ff4a4174bc7ba10b9f6ea5fab89317e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/140163
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
 2020-03-20 17:04:29 +00:00
Jens Johansen 71e05a8d37 [analyzer] Make setters work in 'Add explicit 'show' combinator' 
Fixes #41069

Change-Id: I12586b761b92b25be592bb61b4df11a0f1ebbfe3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/139802
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Jens Johansen <jensj@google.com>
 2020-03-20 08:19:40 +00:00
Brian Wilkerson ce67d6ae27 Consolidate relevance tests into a single directory 
Change-Id: Iee3a3553b17d2e8b3b6f479159e6fe560e44192f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/140120
Reviewed-by: Jaime Wren <jwren@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2020-03-19 20:51:38 +00:00
Sam Rawlins a225178919 Trim not useful bottoms off of the non/nullability stack traces 
Change-Id: I2f7bfab13fd3d70c5cbdbb10ce14a8a91f8c7a60
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/140000
Commit-Queue: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
 2020-03-19 18:13:33 +00:00
Brian Wilkerson dcdde433b6 Use the deprecated feature for static members 
Change-Id: I718a30d9c392ebae2fe611b402c13cdb60a90825
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/140080
Reviewed-by: Jaime Wren <jwren@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2020-03-19 16:09:59 +00:00
Brian Wilkerson 2a2855c781 Perform new relevance computations for extension members 
Sorry for the size of the change.

This started out looking like a fairly simple task of repeating the work
done for type mambers, but it was too similar so I ended up doing some
refactoring in order to share the code.

Along the way I realized that we didn't yet have a feature for demoting
deprecated members, so I added it.

Then I discovered some more places where the old and new logic were
getting intertwined, so I straightened that out as well.

Change-Id: Ic24babd30bbbeeae9709a8019642e497a2ebb65d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/139949
Reviewed-by: Phil Quitslund <pquitslund@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2020-03-19 13:34:19 +00:00
Paul Berry 096bf5769d Migration: add "why not nullable" traces to preview tool. 
Change-Id: If945d32f33124e5e85429bd76c1db14167c0024e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/139960
Reviewed-by: Mike Fairhurst <mfairhurst@google.com>
Reviewed-by: Samuel Rawlins <srawlins@google.com>
 2020-03-18 21:18:22 +00:00
Paul Berry 41b67a9b52 Migration: add grayed-out spaces to indicate types not being made nullable. 
Change-Id: I4fa076693c25cf9466d33332030df3983043ffd1
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/139940
Reviewed-by: Mike Fairhurst <mfairhurst@google.com>
Reviewed-by: Samuel Rawlins <srawlins@google.com>
 2020-03-18 21:18:22 +00:00
Brian Wilkerson 486467c02d Bulk sort of a subset of the files in analysis_server 
Change-Id: Id811d37ad565c6f3c0ed508ae2b42e22469cbd3d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/139830
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2020-03-17 19:13:14 +00:00
Paul Berry d9ce4d57aa Migration: create data structures for the navigation tree view. 
Change-Id: I482b07d3ae2025cf3a9375a02ddaa509beabc2de
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/139780
Reviewed-by: Mike Fairhurst <mfairhurst@google.com>
Reviewed-by: Janice Collins <jcollins@google.com>
 2020-03-17 17:19:41 +00:00
Paul Berry 2ce64e4a7e Migration: create data structures for file details. 
Change-Id: Ibb909795431b33f826e52c39cd7108cc3ec7f204
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/139684
Reviewed-by: Mike Fairhurst <mfairhurst@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
 2020-03-17 00:07:41 +00:00
Jaime Wren 4590cd86c1 Add some missing tests for the new class ArithmeticMeanComputer in pkg/analysis_server/tool/completion_metrics/completion_metrics.dart 
Change-Id: Icff02abe7912e7d9b36a63181aa0a2f84b78aab7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/139742
Commit-Queue: Jaime Wren <jwren@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Auto-Submit: Jaime Wren <jwren@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2020-03-16 22:11:41 +00:00
Janice Collins 34fee361b6 Add sanity checks for NNBD state in migration. 
Also adds some ability for the migration tool to abort itself on
a few known-fatal errors and armor-plates dartdev tests against
CWD problems.

Bug: https://github.com/dart-lang/sdk/issues/40329
Change-Id: I1cfa2c9dcc7815eed075ecb38c63a74c75889002
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/139282
Reviewed-by: Paul Berry <paulberry@google.com>
Commit-Queue: Janice Collins <jcollins@google.com>
 2020-03-16 18:27:58 +00:00
Mike Fairhurst 1ec961a7f9 [nnbd_migration] Reload changed paths on rerun to remove hack. 
Fixes https://github.com/dart-lang/sdk/issues/41025

Change-Id: I40fc3aa3438bdcecd595768d8b34dbe864b2a5d5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/139407
Commit-Queue: Mike Fairhurst <mfairhurst@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2020-03-16 18:14:48 +00:00
Konstantin Shcheglov 3237380259 Fix for creating a field when the target is in a part without a library. 
R=brianwilkerson@google.com

Change-Id: I90b8031a805ba0cb51e7ccb8c2477d4f0d0ac8ec
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/139603
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-03-16 15:52:08 +00:00
Brian Wilkerson 8929bbfbe1 Add a fix for the prefer_interpolation_to_compose_strings lint 
Change-Id: I24cf735233dcf4c0e0c269ba14fbc59873a89751
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/139600
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2020-03-16 14:31:58 +00:00
Brian Wilkerson 48ac44b0e9 Fix a typo in a comment 
Change-Id: I4bbe3a7703cbd954aafd4e53b43649a29617f571
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/139561
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Phil Quitslund <pquitslund@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2020-03-14 00:28:28 +00:00
pq a6a879577d remove non_const_const fix 
Change-Id: Ib2c96b06416b4f392f726de9af22bbf6700dd9dd
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/139487
Commit-Queue: Phil Quitslund <pquitslund@google.com>
Reviewed-by: Jaime Wren <jwren@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2020-03-13 22:08:16 +00:00
Brian Wilkerson cf4b7d312a Add a flutter-specific fix for ARGUMENT_TYPE_NOT_ASSIGNABLE. 
Change-Id: I1687f88a274c69dd2fb6af5bcca7425378b9fd61
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/139480
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2020-03-13 17:33:01 +00:00
Paul Berry c3a0bb086a Migration: Add "why not nullable" traces where "!"s are inserted. 
Change-Id: I0367f869d59da0397589df7df43170f1ecbcb69c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/139401
Reviewed-by: Mike Fairhurst <mfairhurst@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
 2020-03-13 16:31:11 +00:00
Brian Wilkerson 28309556e6 Add more coverage in the relevance tests 
Change-Id: Iadf8c0f0931ba58aaad9aa03087011ea3bc62bad
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/139481
Reviewed-by: Jaime Wren <jwren@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2020-03-13 16:27:51 +00:00
Mike Fairhurst 563aebd5c7 [nnbd_migration] Rerun migration after performing edits. 
The way the server is managed is not 100% ideal, filed here: #41018

Change-Id: Idca6dd56e8375b2e8ea7cbb2f2bf329f2643a442
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/139308
Reviewed-by: Paul Berry <paulberry@google.com>
 2020-03-13 16:16:21 +00:00
Paul Berry 8361357e6e Fix assertion failure in stack trace builder. 
Fixes #41020.

Change-Id: I6cf52c3a5aac545c352f653def53508356676d71
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/139317
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
 2020-03-13 12:27:40 +00:00
Konstantin Shcheglov a42efec049 Don't suggest ADD_RETURN_TYPE for setters. 
R=brianwilkerson@google.com, pquitslund@google.com

Change-Id: Ia584be1de6d6e4237f316bdd8cef77ae841a15ae
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/139315
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Phil Quitslund <pquitslund@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-03-12 22:54:36 +00:00
Konstantin Shcheglov 68b0b83bfe Issue 40842. Fix for getter return type location. 
R=brianwilkerson@google.com, pquitslund@google.com

Bug: https://github.com/dart-lang/sdk/issues/40842
Change-Id: Ifc8343a6df62d64d05b3870255b4602ab898d4cc
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/139260
Reviewed-by: Phil Quitslund <pquitslund@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-03-12 17:44:26 +00:00
Konstantin Shcheglov d5eb515a88 Extract AddReturnType producer. 
As a preparation to fix the bug.

R=brianwilkerson@google.com, pquitslund@google.com

Bug: https://github.com/dart-lang/sdk/issues/40842
Change-Id: I9b448ebb79520e1f0f79cb008feeecd657e5b596
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/139148
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Phil Quitslund <pquitslund@google.com>
 2020-03-12 16:20:58 +00:00
pq 1f9881b63f type member relevance test 
Change-Id: Ifbe90c9478add7f1c7b93c1491ca6f08f96e9b39
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/139145
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
 2020-03-12 01:16:30 +00:00
Konstantin Shcheglov 51f5636daf Report FLUTTER_GET_WIDGET_DESCRIPTION_CONTENT_MODIFIED when a file is changed during the request. 
R=brianwilkerson@google.com

Change-Id: I9d77df28dd16fdaf30ba4dd04fe8cfff221c236d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/139144
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-03-12 01:09:00 +00:00
Paul Berry 93448a47c6 Migration: change trace view to alternate between edges and nodes. 
Previously, we only included edges in the trace view, which resulted
in a lot of missing information.  Generally the reasoning process
looks like "type at A is nullable because of an expression at B, which
propagates nullability from a type at C, which is nullable because of
an expression at D, etc."  This change makes the trace reflect that
reasoning process better.

Change-Id: I27d1b7aac736529b6f1fa2f7be8dea0d3eca9a6c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/139064
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
 2020-03-11 21:30:40 +00:00
Konstantin Shcheglov 4e55949fa6 Refactor RemoveUnusedLocalVariable and fix for locals outside of function bodies. 
R=brianwilkerson@google.com, pquitslund@google.com

Change-Id: Idfb85bbe97a48055fc96dc5441618b7889a7cc00
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/139060
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-03-11 18:19:40 +00:00
Jaime Wren 60dd17d053 Add the void keyword into additional missing portions of the AST in the keyword_contributor.dart - type arguments and method invocation type arguments 
Related PR: https://dart-review.googlesource.com/c/sdk/+/138743

Change-Id: I085cb0718ae00867e245fc13ef219e738306f14e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/138914
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Jaime Wren <jwren@google.com>
 2020-03-11 15:29:59 +00:00