dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
35,317 Commits 2 Branches 0 Tags
6bb8cd8943850ffc8ea17299d210baee4ed0db49
Commit Graph

29 Commits

Author SHA1 Message Date
Brian Wilkerson 56fe38f0ab Clean up imports in analysis_server and analyzer_cli (and one missed in analyzer) 
R=paulberry@google.com, scheglov@google.com

Review URL: https://codereview.chromium.org/1527793003 .
 2015-12-14 19:31:46 -08:00
pq 62656833d4 Wraps up the server-side of the 'Allow a user to configure which hints are "fatal"' ask (#24452). 
* migrates error filtering from a predicate to a process that can customize severities.
* moves filtering/processing from the `dart` task into the `getErrors` request and the errors notification.

See: https://github.com/dart-lang/sdk/issues/24452

(Pending a thumbs-up, support for CLI to follow.)

R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org/1517723002 .
 2015-12-10 13:35:11 -08:00
danrubel 55a8740ba1 extract named constructor suggestions from prefixed element contributor 
R=scheglov@google.com

Review URL: https://codereview.chromium.org/1507633002 .
 2015-12-07 11:58:39 -05:00
Konstantin Shcheglov 78da03cd97 Extract protocol_dart.dart APIs. 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org/1398333002 .
 2015-10-12 06:58:34 -07:00
Brian Wilkerson 9ad256cf18 Move the wire protocol support into the public API 
R=paulberry@google.com, scheglov@google.com

Review URL: https://codereview.chromium.org/1398293002 .
 2015-10-11 07:34:28 -07:00
pq 8697392367 AnalysisError hasFix attr (Implements #23874). 
R=brianwilkerson@google.com, scheglov@google.com

Review URL: https://codereview.chromium.org/1385523002 .
 2015-10-05 09:46:17 -07:00
Konstantin Shcheglov 6bab7d9cbc Use Element.nameLength where possible. 
...or don't use it when there is a better alternative.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//1372673003 .
 2015-09-25 15:03:46 -07:00
Konstantin Shcheglov b15a031276 Navigation extension point. 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//1303033010 .
 2015-09-01 13:06:25 -07:00
Brian Wilkerson 4bd6b4b048 Fix display of parameter lists in servers Element structure (issue 24194) 
R=scheglov@google.com

Review URL: https://codereview.chromium.org//1313113002 .
 2015-08-25 09:23:26 -07:00
danrubel bf05b75f43 update suggestion element return type to have type param 
cleanup loadLibrary suggestion to have correct element

dartbug.com/23905

R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//1260593005 .
 2015-08-04 22:08:55 -07:00
Dan Rubel 4224b9c049 fix ENUM_CONSTANT suggestions 
BUG=
R=scheglov@google.com

Review URL: https://codereview.chromium.org//1157283004
 2015-06-04 18:01:06 -04:00
danrubel 0e39092fd0 add enum suggestions 
and update LocalDeclarationVisitor to visit enum declarations

BUG=
R=paulberry@google.com

Review URL: https://codereview.chromium.org//1157113004
 2015-06-01 12:10:46 -04:00
Paul Berry 535394c265 Remove debugging print statements. 
R=scheglov@google.com

Review URL: https://codereview.chromium.org//1149063005
 2015-05-27 20:24:06 -07:00
scheglov@google.com f058a6ad33 Tweaks for using task model in Editor. 
It works in general, bug currently it is buggy and slow.

Notes:

1. Implicit dependencies backfire.
   If the cache size is not big enough and we end up flushing some CU, then recreating it, it looses its LibraryElement.
   We need an explicit dependency on it.

2. If the cache size is not big enough, this still may cause an infinite analysis cycle.

3. We need to implement activating / deactivating cache partitions to change cache size.

4. Probably we need to set LineInfo into ChangeNotice always.

5. There are bugs in type hierarchy.

6. Semantic highlighting takes too long to display.

7. Overlay changes are not used.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//1125303008

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45811 260f80e4-7a28-3924-810f-c04153c831b5
 2015-05-15 15:04:50 +00:00
scheglov@google.com ed26cdbf05 Remove old debug output. 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//1070223002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45025 260f80e4-7a28-3924-810f-c04153c831b5
 2015-04-09 18:40:00 +00:00
scheglov@google.com 2e77fcdd11 Add an optional 'typeParameters' to Element. 
Also use it in Editor, e.g. in Outline.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//990343002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44349 260f80e4-7a28-3924-810f-c04153c831b5
 2015-03-09 22:02:44 +00:00
brianwilkerson@google.com cd58e290c4 Reformat 
R=paulberry@google.com

Review URL: https://codereview.chromium.org//969113002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44151 260f80e4-7a28-3924-810f-c04153c831b5
 2015-03-02 22:43:12 +00:00
danrubel@google.com 01a1ea75b8 fix function type alias conversion to protocol element 
BUG=
R=paulberry@google.com

Review URL: https://codereview.chromium.org//848943002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42850 260f80e4-7a28-3924-810f-c04153c831b5
 2015-01-14 01:58:15 +00:00
danrubel@google.com 14a97cafed suggest fields rather than synthetic getters 
and return dynamic returnType rather than null

BUG=dartbug.com/21679
R=paulberry@google.com

Review URL: https://codereview.chromium.org//791553007

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42786 260f80e4-7a28-3924-810f-c04153c831b5
 2015-01-12 19:02:47 +00:00
scheglov@google.com 8c99b69287 Log more information to debug 'null' location for constructor. 
R=paulberry@google.com
BUG= https://code.google.com/p/dart/issues/detail?id=21842

Review URL: https://codereview.chromium.org//809203002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42463 260f80e4-7a28-3924-810f-c04153c831b5
 2014-12-18 18:52:34 +00:00
scheglov@google.com e73e5faaad Getters should not have parameters. 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//787603004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42183 260f80e4-7a28-3924-810f-c04153c831b5
 2014-12-08 21:04:44 +00:00
scheglov@google.com 354081528c Update local functions methods/functions. 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//770253003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42078 260f80e4-7a28-3924-810f-c04153c831b5
 2014-12-02 23:51:10 +00:00
scheglov@google.com 2427406da3 Fix for NPE in navigation after some incremental changes. 
TBR

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//774543002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42058 260f80e4-7a28-3924-810f-c04153c831b5
 2014-12-02 02:07:10 +00:00
scheglov@google.com 20d82e5135 Compressed/optimized navigation notification. 
R=brianwilkerson@google.com, paulberry@google.com
BUG=

Review URL: https://codereview.chromium.org//766323002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42049 260f80e4-7a28-3924-810f-c04153c831b5
 2014-12-01 22:21:28 +00:00
scheglov@google.com b8da9bc651 Format and sort analyzer and analysis_server packages. 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//725143004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41792 260f80e4-7a28-3924-810f-c04153c831b5
 2014-11-17 22:23:53 +00:00
danrubel@google.com 67071bd861 Refactor CompletionSuggestionKind 
- Remove many CompletionSuggestionKinds that duplicate ElementKind
- Add two new CompletionSuggestionKinds: INVOCATION and IDENTIFIER
- regenerate Analysis Server Dart and Java API and docs
- rework Dart and Java tests
- remove/rename unused Dart and Java classes and methods
- remove unnecessary reference to SDK

BUG=
R=brianwilkerson@google.com, scheglov@google.com

Review URL: https://codereview.chromium.org//684183002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41396 260f80e4-7a28-3924-810f-c04153c831b5
 2014-10-29 16:09:56 +00:00
scheglov@google.com 07cf72a3ec Improve import prefix search results UI. 
1. Bug fix for search on an import directive without a prefix.

2. Pretend that import prefixes are children on libraries' compilation units.

3. Icon for import prefix elements in Editor.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//640333002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41024 260f80e4-7a28-3924-810f-c04153c831b5
 2014-10-09 20:30:49 +00:00
scheglov@google.com b67b33f60c Move Engine to Server element / error converters into protocol_server.dart 
Also move the corrsponding tests.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//628023003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@40983 260f80e4-7a28-3924-810f-c04153c831b5
 2014-10-07 22:25:08 +00:00
scheglov@google.com e9e0694e2f Remove references to Engine classes from protocol.dart 
R=brianwilkerson@google.com, paulberry@google.com, danrubel@google.com
BUG=

Review URL: https://codereview.chromium.org//628293004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@40948 260f80e4-7a28-3924-810f-c04153c831b5
 2014-10-07 00:24:48 +00:00