dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
44,205 Commits 2 Branches 0 Tags
683fe6ab7c1925cfb63f7b36a7ff6088e4ff937e
Commit Graph

2304 Commits

Author SHA1 Message Date
Devon Carew 09725fc5c8 Show the platform version in the analysis server status page. 
BUG=
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2661043004 .
 2017-01-31 18:33:40 -08:00
Konstantin Shcheglov 75fff1fdb6 Implement completion in WithDirective. 
R=brianwilkerson@google.com
BUG=

Review-Url: https://codereview.chromium.org/2665053004 .
 2017-01-31 15:06:54 -08:00
Konstantin Shcheglov 678021c7cf Fix SDK partitions leak in tests. 
R=brianwilkerson@google.com
BUG=

Review-Url: https://codereview.chromium.org/2668103002 .
 2017-01-31 13:04:13 -08:00
Brian Wilkerson fb5e367ca5 Update server generator 
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2668733002 .
 2017-01-31 08:26:10 -08:00
Brian Wilkerson 058b5a9c5b Add missed return leading to an NPE 
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2668523002 .
 2017-01-30 13:46:32 -08:00
Konstantin Shcheglov d29ba1e238 Store exceptions with transitive files context into ByteStore. 
The key under which the exception context is stored, is included into
ExceptionResult, so Analysis Server can include the key into the message.

R=brianwilkerson@google.com, paulberry@google.com
BUG=

Review-Url: https://codereview.chromium.org/2663903002 .
 2017-01-30 12:57:44 -08:00
Konstantin Shcheglov 6be5d918d0 Fix strong mode warning in the 'getter to method refactoring.' 
R=brianwilkerson@google.com
BUG=

Review-Url: https://codereview.chromium.org/2662893002 .
 2017-01-30 08:53:13 -08:00
Konstantin Shcheglov 2acfb1d818 ContextBuilder should to throw when a root folder does not exist. 
Otherwise, removing an analysis root with .analysis_options file
causes an exception.

R=brianwilkerson@google.com
BUG=

Review-Url: https://codereview.chromium.org/2660073002 .
 2017-01-29 09:37:24 -08:00
Kevin Moore c1a0b12159 use latest pkg/isolate 
R=brianwilkerson@google.com

Review-Url: https://codereview.chromium.org/2662723002 .
 2017-01-28 13:53:17 -08:00
Konstantin Shcheglov 8c738c2dad Revert "Revert "Enable the new analysis driver by default, use --disable-new-analysis-driver to disable."" 
This reverts commit 878775607c.

R=brianwilkerson@google.com, paulberry@google.com
BUG=

Review-Url: https://codereview.chromium.org/2658273002 .
 2017-01-27 12:13:04 -08:00
Konstantin Shcheglov 47967ac9f2 Guard against FunctionExpression nodes with null parameters. 
I see this exception in logs, but I was not able to find which Dart
code would cause this.

R=brianwilkerson@google.com
BUG=

Review-Url: https://codereview.chromium.org/2664493004 .
 2017-01-27 11:57:08 -08:00
Janice Collins 93c3a194ad Better error message for missing async with await 
R=brianwilkerson@google.com

Review-Url: https://codereview.chromium.org/2662483003 .
 2017-01-27 10:48:27 -08:00
Konstantin Shcheglov f1f5d490d7 Fix MockSdk.fromFileUri() implementations. 
This should fix the test failure on Windows bot.

TBR

R=brianwilkerson@google.com
BUG=

Review-Url: https://codereview.chromium.org/2653753006 .
 2017-01-25 12:08:25 -08:00
Brian Wilkerson ed40bd3eca Add failing test for sort issue 
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2655803004 .
 2017-01-25 09:06:49 -08:00
Konstantin Shcheglov fcd5f16d10 Stop using SDK summary bundle. Analyze dart:xxx as any other libraries. 
Unfortunately this makes runnings tests about 30% slower :-(

I suspect that's because we have to build unlinked and linked summaries
for SDK libraries again and again for every tiny test.

R=brianwilkerson@google.com, paulberry@google.com
BUG=

Review-Url: https://codereview.chromium.org/2653683004 .
 2017-01-24 18:32:26 -08:00
Brian Wilkerson c25bd9403f Move driver creation into ContextBuilder 
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2647293007 .
 2017-01-24 14:43:39 -08:00
Konstantin Shcheglov 5f6ea67c1e Make Analysis Server tests use MockSdk again. 
R=brianwilkerson@google.com
BUG=

Review-Url: https://codereview.chromium.org/2650803005 .
 2017-01-24 13:49:48 -08:00
Konstantin Shcheglov b206c84210 Reland c9e1b88 and 56726fc with a DDC fix. 
Revert "Revert "Use single InputPackagesResultProvider, without SdkSummaryResultProvider.""

This reverts commit b701ad6453.

R=brianwilkerson@google.com, vsm@google.com
BUG=

Review-Url: https://codereview.chromium.org/2647323006 .
 2017-01-24 09:13:26 -08:00
Vijay Menon b701ad6453 Revert "Use single InputPackagesResultProvider, without SdkSummaryResultProvider." 
This reverts commit c9e1b888a3.

Revert "Remove parent from SummaryResynthesizer."

This reverts commit 56726fcce0.

TBR=scheglov@google.com

Review-Url: https://codereview.chromium.org/2648213007 .
 2017-01-24 06:21:38 -08:00
Konstantin Shcheglov c9e1b888a3 Use single InputPackagesResultProvider, without SdkSummaryResultProvider. 
Each SummaryResynthesizer is now responsible for creating its TypeProvider.
And with the new AnalysisDriver we stop using SDK CachePartition.

For now we add SDK's summary bundle into SummaryDataStore.
Eventually we will get rid of it and add individual SDK libraries.

R=brianwilkerson@google.com, paulberry@google.com, vsm@google.com
BUG=

Review-Url: https://codereview.chromium.org/2652823002 .
 2017-01-23 16:54:17 -08:00
Konstantin Shcheglov a483610a96 Issue 28386. Implement search for potential usages with the new analysis driver. 
R=brianwilkerson@google.com
BUG= https://github.com/dart-lang/sdk/issues/28386

Review-Url: https://codereview.chromium.org/2653493006 .
 2017-01-23 14:07:01 -08:00
Konstantin Shcheglov 917a137a03 Don't create FileState(s) for SDK source in _ContentCacheWrapper. 
R=brianwilkerson@google.com
BUG=

Review-Url: https://codereview.chromium.org/2640793006 .
 2017-01-19 08:51:58 -08:00
Konstantin Shcheglov 0160332713 Issue 28027. Move Null to the bottom in the Analyzer. 
R=brianwilkerson@google.com, paulberry@google.com
BUG= https://github.com/dart-lang/sdk/issues/28027

Review-Url: https://codereview.chromium.org/2638183002 .
 2017-01-18 11:15:11 -08:00
Konstantin Shcheglov 8d326e9a14 Report StateError if the DartSDK for an AnalysisDriver does not have summary. 
R=brianwilkerson@google.com, paulberry@google.com
BUG=

Review-Url: https://codereview.chromium.org/2639743002 .
 2017-01-17 20:46:00 -08:00
Konstantin Shcheglov 878775607c Revert "Enable the new analysis driver by default, use --disable-new-analysis-driver to disable." 
This reverts commit 7e560a612f.

R=brianwilkerson@google.com, paulberry@google.com, devoncarew@google.com
BUG=

Review-Url: https://codereview.chromium.org/2634603002 .
 2017-01-13 15:23:22 -08:00
Konstantin Shcheglov 914a117649 Report errors like IMPORT_OF_NON_LIBRARY with the new analysis driver. 
R=brianwilkerson@google.com
BUG=

Review-Url: https://codereview.chromium.org/2627093010 .
 2017-01-12 13:41:52 -08:00
Paul Berry c6206ea1de Split "_Driver" tests to separate test files. 
This avoids timeouts on my machine.  Also it makes it easier to disable these tests when necessary.

R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2627293002 .
 2017-01-12 08:19:19 -08:00
Brian Wilkerson e7577172d1 Add preliminary parser support for generic function types 
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2628973003 .
 2017-01-12 07:00:24 -08:00
Brian Wilkerson 22f561e914 Reapply "Add support for generic function type syntax, part 1" 
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2622303006 .
 2017-01-11 14:10:05 -08:00
Brian Wilkerson 85b1e7abbe Revert "Add support for generic function type syntax, part 1" 
Review-Url: https://codereview.chromium.org/2624283003 .
 2017-01-11 13:30:52 -08:00
Brian Wilkerson 1cd918533d Add support for generic function type syntax, part 1 
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2613383003 .
 2017-01-11 13:12:10 -08:00
Konstantin Shcheglov 5a9c5ac1ec Issue 28068. Implement diagnostics domain for the new analysis driver. 
R=brianwilkerson@google.com
BUG= https://github.com/dart-lang/sdk/issues/28068

Review-Url: https://codereview.chromium.org/2625493002 .
 2017-01-09 12:07:15 -08:00
Konstantin Shcheglov db1950ef65 Rewrite DiagnosticDomainTest using @reflectiveTest. 
R=brianwilkerson@google.com
BUG=

Review-Url: https://codereview.chromium.org/2622493003 .
 2017-01-09 10:45:33 -08:00
Konstantin Shcheglov 266280f0c4 Issue 28300. Reset refactoring when analysis started with the new analysis driver. 
R=brianwilkerson@google.com
BUG= https://github.com/dart-lang/sdk/issues/28300

Review-Url: https://codereview.chromium.org/2626433002 .
 2017-01-09 10:18:20 -08:00
Leaf Petersen 83fc4b6b46 Put a TypeProvider on the TypeSystem implementations. 
Adding a TypeProvider instance to TypeSystem to avoid needing to
thread it through the various APIs, and to avoid having to change
the API every time a method which previously did not need to
access the TypeSystem suddenly does.

BUG=
R=jmesserly@google.com

Review-Url: https://codereview.chromium.org/2590883004 .
 2017-01-09 02:40:10 -08:00
Konstantin Shcheglov e80a54e432 Fix the rest of the completion tests with the new analysis driver. 
R=brianwilkerson@google.com
BUG=

Review-Url: https://codereview.chromium.org/2618243002 .
 2017-01-08 15:16:33 -08:00
Konstantin Shcheglov 0c4cc3fdaf Fix the last Quick Fix test. 
R=brianwilkerson@google.com
BUG=

Review-Url: https://codereview.chromium.org/2619633003 .
 2017-01-06 16:37:12 -08:00
Konstantin Shcheglov 7fc5bc3634 Remove REPLACE_IMPORT_URI Quick Fix. 
I decided that it is not so useful to worth adding special support
for it with the new analysis driver.

R=brianwilkerson@google.com
BUG=

Review-Url: https://codereview.chromium.org/2616163002 .
 2017-01-06 14:56:20 -08:00
Konstantin Shcheglov 0377beb128 Update 'Add final field formal parameters' Quick Fix to support the new analysis driver. 
R=brianwilkerson@google.com
BUG=

Review-Url: https://codereview.chromium.org/2618923003 .
 2017-01-06 14:34:49 -08:00
Konstantin Shcheglov d5fc0cda3b Fix Quick Fix tests that used AnalysisContext. 
R=brianwilkerson@google.com
BUG=

Review-Url: https://codereview.chromium.org/2615303002 .
 2017-01-06 14:31:38 -08:00
Konstantin Shcheglov ea98b0db45 Fix the rest of Quick Assist tests with the new analysis driver. 
R=brianwilkerson@google.com
BUG=

Review-Url: https://codereview.chromium.org/2613123003 .
 2017-01-06 14:08:51 -08:00
Konstantin Shcheglov 12bdc9eb95 Fix code for @failingTest refactoring tests. 
We should have used 'super.name()'.
Some tests are now passing.

R=brianwilkerson@google.com
BUG=

Review-Url: https://codereview.chromium.org/2619623002 .
 2017-01-06 13:53:36 -08:00
Konstantin Shcheglov 188c087036 Run 'Inline Method' refactoring tests with the new analysis driver. 
R=brianwilkerson@google.com
BUG=

Review-Url: https://codereview.chromium.org/2619053002 .
 2017-01-06 13:51:02 -08:00
Konstantin Shcheglov d6fdc65220 Run 'Rename Library' refactoring tests with the new analysis driver. 
R=brianwilkerson@google.com
BUG=

Review-Url: https://codereview.chromium.org/2614903006 .
 2017-01-06 12:33:23 -08:00
Konstantin Shcheglov 429379045b Run rename-import tests with the new analysis driver. 
R=brianwilkerson@google.com
BUG=

Review-Url: https://codereview.chromium.org/2617213002 .
 2017-01-06 11:35:29 -08:00
Brian Wilkerson 07895169be Remove code duplication 
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2618983003 .
 2017-01-06 10:55:55 -08:00
Konstantin Shcheglov 31c7cce275 Run refactoring tests with the new analysis driver. 
There are some failures because of missing potential search results.

These tests are not updated yet because they have too many problems now.

inline_method_test.dart
move_file_test.dart
rename_import_test.dart
rename_library_test.dart

R=brianwilkerson@google.com
BUG=

Review-Url: https://codereview.chromium.org/2618993003 .
 2017-01-06 10:49:34 -08:00
Konstantin Shcheglov c7380f5d14 Run Quick Fixes tests with the new analysis driver. 
There is a handful of failing tests though.
I fill triage them in subsequent CLs.

R=brianwilkerson@google.com
BUG=

Review-Url: https://codereview.chromium.org/2617833003 .
 2017-01-06 09:27:04 -08:00
Konstantin Shcheglov 71fc176b9b Run class/member hierarchy tests with the new analysis driver. 
R=brianwilkerson@google.com
BUG=

Review-Url: https://codereview.chromium.org/2618033002 .
 2017-01-06 09:24:31 -08:00
Konstantin Shcheglov 4e49205c61 Run AssistProcessor tests with the new analysis driver. 
R=brianwilkerson@google.com
BUG=

Review-Url: https://codereview.chromium.org/2617833002 .
 2017-01-05 16:59:35 -08:00