Jacob Richman
a993294503
Format all analyzer packages
...
BUG=
R=brianwilkerson@google.com
Review-Url: https://codereview.chromium.org/2753923003 .
2017-03-16 16:11:43 -07:00
danrubel
c04f6a2ab1
fix dartanalyzer find options in bazel workspace
...
- add dartanalyzer test for bazel workspace
- ensure call to getAnalysisOptions passes an absolute path
- update BasicWorkspace to have an absolute normalized path similar to BazelWorkspace
R=brianwilkerson@google.com
Review-Url: https://codereview.chromium.org/2719703005 .
2017-02-26 08:52:55 -08:00
danrubel
abee739921
rework analyzer_cli to use ContextBuilder getAnalysisOptions
...
This is a follow on to https://codereview.chromium.org/2716693003
that refactors analyzer_cli to use ContextBuilder.
As a result, dartanalyzer now correctly finds the default
flutter analysis options when the project references package:flutter
but does not contain an analysis options file.
R=brianwilkerson@google.com
Review-Url: https://codereview.chromium.org/2710313002 .
2017-02-23 16:52:26 -05:00
Devon Carew
46cacfeae9
Some improvements to the command-line analyzer's output.
...
BUG=
R=brianwilkerson@google.com , danrubel@google.com
Review-Url: https://codereview.chromium.org/2704103002 .
2017-02-22 12:35:09 -08:00
Konstantin Shcheglov
7e9f4ba34c
Make the test's dart:core import dart:async in tests.
...
SDK's version does it, and we probably don't want to protect aginst
something what happens only in tests, but is not expected actually.
R=brianwilkerson@google.com
BUG=
Review-Url: https://codereview.chromium.org/2696013004 .
2017-02-14 13:31:18 -08:00
Leaf Petersen
0c2bf046f1
Add FutureOr to analyzer_cli test async.dart.
...
Fixes https://github.com/dart-lang/sdk/issues/28653 .
BUG=
R=brianwilkerson@google.com , whesse@google.com
Review-Url: https://codereview.chromium.org/2675203006 .
2017-02-06 17:08:33 -08:00
danrubel
167107e94c
fix dartanalyzer sdk setup
...
Separate analysis options initialization from context setup
so that analysis options can be used to correctly setup the SDK
in strong mode.
Fix https://github.com/dart-lang/sdk/issues/28507
R=brianwilkerson@google.com
Review-Url: https://codereview.chromium.org/2678633002 .
2017-02-04 12:08:53 -05:00
Dan Rubel
aff6b796f3
update analyzer cli to support include directive in analysis options file
...
R=brianwilkerson@google.com
Review URL: https://codereview.chromium.org/2541933002 .
2016-11-30 15:16:55 -05:00
Konstantin Shcheglov
92ee0b2488
Fix for the new hint in super_mixin_example.dart in analyzer_cli.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org/2364763002 .
2016-09-22 15:03:06 -07:00
pq
43bbf11dd8
SDK ext test fix (add missing packages file).
...
BUG=
R=paulberry@google.com
Review URL: https://codereview.chromium.org/1988603003 .
2016-05-17 13:49:04 -07:00
Brian Wilkerson
44836f8538
Support the name analysis_options.yaml for analysis options files
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org/1975963002 .
2016-05-13 07:33:06 -07:00
pq
7913968725
Fix CLI SDK option config timing ( #26129 ).
...
Fixes: https://github.com/dart-lang/sdk/issues/26129
The issue was that we were creating the SDK and populating its options (notably `strong-mode`) *before* options processors were called. The result was that client code analysis contexts and SDK contexts were getting configured differently causing confusion when client code was getting analyzed with a non-strong-mode SDK.
BUG=
R=paulberry@google.com
Review URL: https://codereview.chromium.org/1962403002 .
2016-05-10 13:35:40 -07:00
pq
082edc9fa3
Suppress TODOs ( #26215 ).
...
BUG=
R=brianwilkerson@google.com , scheglov@google.com
Review URL: https://codereview.chromium.org/1870123002 .
2016-04-08 08:54:59 -07:00
Brian Slesinsky
9e21594c2a
add --x-package-warnings-prefix option to dartanalyzer
...
This is similar to --package-warnings, except that diagnostics will
only be reported for Dart packages matching the given prefix.
Also added the number of source files analyzed and the number of
errors generated to performance report.
Cleanup: simplified code for triggering diet parsing.
BUG=
R=paulberry@google.com
Review URL: https://codereview.chromium.org/1806263004 .
2016-03-21 11:37:49 -07:00
pq
9b1fa223a8
Embedded libs key rename to defuse server landmine.
...
1.13 stable builds of the SDK contain a version of server that fails catastrophically when analyzing source that imports packages that define embedded libraries. Since we can't pragmatically require more recent SDKs for flutter development we have been prevented from landing embedded libs in the flutter engine. By renaming the key we use to identify contributed libraries, this change avoids the issue. Old versions of server will simply ignore the new key and new ones will process it properly. Win-win!
BUG=
R=danrubel@google.com
Review URL: https://codereview.chromium.org/1643023002 .
2016-01-29 09:52:04 -08:00
pq
3d3c9c5af4
CLI support for embedders ( #25380 ).
...
Background here: https://github.com/dart-lang/sdk/issues/25380
BUG=
R=brianwilkerson@google.com
Review URL: https://codereview.chromium.org/1631763007 .
2016-01-26 11:33:14 -08:00
pq
8887cd69f0
Fix analyzer_cli error overrides ( #24452 ).
...
Brings `analyzer_cli` inline with server wrt processing errors configured in `.analysis_options`.
Note some added complexity due to interactions with flags that globally escalate warnings/hints to errors.
https://github.com/dart-lang/sdk/issues/24452
R=brianwilkerson@google.com
Review URL: https://codereview.chromium.org/1529243002 .
2015-12-16 12:44:38 -08:00
pq
9ae1265ff5
analyzer_cli move to SDK.
...
Tracking bug: https://github.com/dart-lang/sdk/issues/24731
Note, dartium build changes are in a separate CL: https://codereview.chromium.org/1453413006/
Some tests had to be disabled for want of mockito in the SDK; tracking their reimplementation is here: https://github.com/dart-lang/sdk/issues/24994
BUG=24731
R=whesse@google.com
Review URL: https://codereview.chromium.org/1459683003 .
2015-11-19 14:52:54 -08:00
pq
5cc9a288bb
Revert "Move analyzer_cli into the SDK."
...
This reverts commit a573ed31f1 .
BUG=
R=whesse@google.com
Review URL: https://codereview.chromium.org/1462143002 .
2015-11-19 11:28:52 -08:00
pq
a573ed31f1
Move analyzer_cli into the SDK.
...
Build changes to follow.
Tracking bug: https://github.com/dart-lang/sdk/issues/24731
BUG=24731
R=brianwilkerson@google.com
Review URL: https://codereview.chromium.org/1464553003 .
2015-11-19 11:11:17 -08:00