99aefce48c
do not allow built-in keywords to specified when refactoring
...
R=scheglov@google.com
Review-Url: https://codereview.chromium.org/2802433002 .
2017-04-04 17:13:42 -04:00
3c234a72c2
Update failing tests (TBR)
...
Review-Url: https://codereview.chromium.org/2793123002 .
2017-04-03 11:26:45 -07:00
0ea61b64ab
Bug fixes and added support for creating source edits
...
R=scheglov@google.com
Review-Url: https://codereview.chromium.org/2790173003 .
2017-04-03 10:56:41 -07:00
dd49e79f74
Add context information to driver and add hooks for plugin management
...
R=scheglov@google.com
Review-Url: https://codereview.chromium.org/2795743002 .
2017-04-03 10:13:45 -07:00
d4c1531b5b
Use the *correct* type for the fix to analysis_server/test/mocks.dart.
...
It's a stream, not an iterable, so the return type is a Future.
Review-Url: https://codereview.chromium.org/2784363003 .
2017-03-31 16:36:24 +02:00
83298690b0
Fix static typing problem in analysis_server tests.
...
After changing argument of `Future` constructor to be `()->FutureOr<T>`,
the `()->Future<dynamic>` argument didn't work.
Problem compounded by return type of `Stream<T>.firstWhere` being `dynamic`.
R=karlklose@google.com
Review-Url: https://codereview.chromium.org/2794503002 .
2017-03-31 14:12:32 +02:00
543d0dc20e
Update coverage testing
...
R=devoncarew@google.com
Review-Url: https://codereview.chromium.org/2780393004 .
2017-03-30 11:15:55 -07:00
4a2cca3a52
Add getStatementCompletion to the API spec
...
R=brianwilkerson@google.com , scheglov@google.com
Review-Url: https://codereview.chromium.org/2784673003 .
2017-03-30 10:13:21 -07:00
56afa1abb0
Add experimental attribute to requests (recreated due to git failure)
...
R=brianwilkerson@google.com
Review-Url: https://codereview.chromium.org/2787013002 .
2017-03-30 10:10:43 -07:00
394a106074
Remove unused imports.
...
BUG=
R=danrubel@google.com , scheglov@google.com
Review-Url: https://codereview.chromium.org/2786553002 .
2017-03-29 07:10:44 -07:00
483066a697
Fix for Quick Fix to import SDK classes.
...
It's not 100% replacement, we handle SDK libraries just as any other
library, if it has not been imported yet somewhere, we don't know
about it. But probably this covers the most often case of using a
library in a new file of the project that already uses this SDK
library.
R=brianwilkerson@google.com
BUG=
Review-Url: https://codereview.chromium.org/2781963002 .
2017-03-28 14:15:52 -07:00
84f2f4a677
Enhance the change builders
...
R=scheglov@google.com
Review-Url: https://codereview.chromium.org/2776233002 .
2017-03-28 08:29:30 -07:00
5a237935f0
Fix tests to verify defaultArgListString specified as null are null.
...
* introduces a sentinel default value to ensure that we know when asserting if `null` was specified or the result of an excluded optional arg
BUG=
R=brianwilkerson@google.com
Review-Url: https://codereview.chromium.org/2769223004 .
2017-03-24 11:53:00 -07:00
4a9cabf493
Arglist children: default value gen fixes.
...
* fixed arglist codegen (include params)
* fixed defaultTextRange generation (and added tests)
* cleanup (followup from https://codereview.chromium.org/2768273003/
R=brianwilkerson@google.com , danrubel@google.com
See: https://github.com/flutter/flutter-intellij/issues/832
Review-Url: https://codereview.chromium.org/2771123002 .
2017-03-24 09:36:24 -07:00
6f846bcd53
<Widget> boilerplate for Flutter children: suggestions.
...
Cleanup (tracked in TODOs) and consolidation to follow.
R=brianwilkerson@google.com , danrubel@google.com
See: https://github.com/flutter/flutter-intellij/issues/832
Review-Url: https://codereview.chromium.org/2768273003 .
2017-03-23 15:20:42 -07:00
d3c926b089
Fix errors in analyzer
...
R=scheglov@google.com
Review-Url: https://codereview.chromium.org/2772473004 .
2017-03-23 11:26:49 -07:00
61d5c85b48
Allow navigation from var when there is an inferred type (issue 29091)
...
R=scheglov@google.com
Review-Url: https://codereview.chromium.org/2769813005 .
2017-03-23 10:34:09 -07:00
03398561a1
IdeOptions awareness for Driver (for access via IDEA registry).
...
R=brianwilkerson@google.com
See: https://github.com/flutter/flutter-intellij/issues/463
Review-Url: https://codereview.chromium.org/2768003003 .
2017-03-23 09:33:37 -07:00
df06af12eb
Completion boilerplate for Flutter cons children (flutter-intellij#463)
...
* plumbs IDE options into completion requests
* simple POC test
More tests and a bit of cleanup to come.
R=brianwilkerson@google.com
See: https://github.com/flutter/flutter-intellij/issues/463
Review-Url: https://codereview.chromium.org/2771653002 .
2017-03-22 15:14:28 -07:00
cd826a144c
Fix typing in analyzer.
...
Review-Url: https://codereview.chromium.org/2764413002 .
2017-03-22 19:01:54 +01:00
a231501692
Format generated files.
...
BUG=
R=brianwilkerson@google.com , jacobr@google.com
Review-Url: https://codereview.chromium.org/2765953002 .
2017-03-21 15:54:16 -07:00
d95508183d
Introducing IdeOptions.
...
* add simple `IdeOptions` class
* remove unused `ServerOptions`
R=brianwilkerson@google.com
See: https://github.com/flutter/flutter-intellij/issues/463
Review-Url: https://codereview.chromium.org/2765063002 .
2017-03-21 14:48:27 -07:00
9a66373ee9
Fix errors and warnings
...
R=scheglov@google.com
Review-Url: https://codereview.chromium.org/2760993002 .
2017-03-20 11:30:32 -07:00
c56210c294
Create a new element for generic function types
...
R=scheglov@google.com
Review-Url: https://codereview.chromium.org/2758123002 .
2017-03-19 10:45:50 -07:00
221125d1ac
Add quick-fix to convert child: to children:
...
R=brianwilkerson@google.com
Review-Url: https://codereview.chromium.org/2753123003 .
2017-03-17 14:49:42 -07:00
319b726f8b
Guard analysis server's getAnalysisResult, must be dart
...
Otherwise spews errors inside html files when users do things like
autocomplete in the middle of them.
BUG=
R=brianwilkerson@google.com , scheglov@google.com
Review-Url: https://codereview.chromium.org/2755023002 .
2017-03-17 10:42:00 -07:00
a993294503
Format all analyzer packages
...
BUG=
R=brianwilkerson@google.com
Review-Url: https://codereview.chromium.org/2753923003 .
2017-03-16 16:11:43 -07:00
9a9074bf6b
Add assist to convert child: to children: in Flutter new-exprs
...
R=brianwilkerson@google.com , scheglov@google.com
Review-Url: https://codereview.chromium.org/2749283004 .
2017-03-16 07:44:05 -07:00
550443f147
Improve performance of PluginLocator by caching results
...
R=scheglov@google.com
Review-Url: https://codereview.chromium.org/2754473005 .
2017-03-16 07:28:34 -07:00
f33d072d91
Correct target of ADD_MISSING_REQUIRED_ARGUMENT fixes (flutter-intellij#788)
...
* corrects insert target of `ADD_MISSING_REQUIRED_ARGUMENT` fixes
* updates `assertHasFix` to optionally verify fix target
R=brianwilkerson@google.com
Fixes: https://github.com/flutter/flutter-intellij/issues/788
Review-Url: https://codereview.chromium.org/2749373002 .
2017-03-15 13:27:27 -07:00
8afab37d55
Add PluginWatcher to watch for new plugins that need to be run
...
R=scheglov@google.com
Review-Url: https://codereview.chromium.org/2750483006 .
2017-03-15 11:26:14 -07:00
985160c08d
Replace making getInnermostContext public with making a getFolder method
...
This way SingleContextManager can fulfill the interface too (it can't
provide a ContextInfo, and the concept of `innermost` doesn't really
exist).
BUG=
R=brianwilkerson@google.com
Review-Url: https://codereview.chromium.org/2754473004 .
2017-03-14 16:13:16 -07:00
c78b4d66bb
Move some of analyzer's code generation utilities into front_end.
...
These utilities are needed for generating the code that supports
summaries; in order to move summary logic into front_end, we will need
these code generation tools in front_end as well.
Also make a minor change to summary code generation logic so that it
talks to the file system directly rather than depending on analyzer's
file system abstraction.
R=brianwilkerson@google.com
Review-Url: https://codereview.chromium.org/2742333005 .
2017-03-14 12:30:18 -07:00
72323291fe
Add an object that can manage which plugins are associated with each context / driver
...
R=scheglov@google.com
Review-Url: https://codereview.chromium.org/2746293004 .
2017-03-14 12:09:53 -07:00
ebab20824a
Formalizing the hacks letting the angular analyzer plugin run for now.
...
Mostly just making private methods public. But also add in some hooks
(via streams and callbacks) that allow the angular analyzer to wrap
analysis drivers in new angular drivers.
This code will likely all be reverted at some point when a much much
better plugin API is available.
BUG=
R=brianwilkerson@google.com
Review-Url: https://codereview.chromium.org/2742343006 .
2017-03-14 12:09:24 -07:00
a83e7fd18e
Add analysis server integration tests for the search domain.
...
BUG=
R=brianwilkerson@google.com , scheglov@google.com
Review-Url: https://codereview.chromium.org/2747893004 .
2017-03-13 17:06:13 -07:00
b5ded5fb3c
Add unit test for 'search.findMemberReferences' with the driver.
...
R=brianwilkerson@google.com
BUG=
Review-Url: https://codereview.chromium.org/2746123003 .
2017-03-13 15:55:17 -07:00
8f36669937
Add instrumentation data to the analysis server diagnostics page.
...
BUG=
R=brianwilkerson@google.com
Review-Url: https://codereview.chromium.org/2717253002 .
2017-03-10 14:08:14 -08:00
2fe848502c
Update context manager test after turning DOWN_CAST_COMPOSITE strong mode warning into a hint.
...
R=brianwilkerson@google.com
BUG=
Review-Url: https://codereview.chromium.org/2741633004 .
2017-03-09 07:31:40 -08:00
24d5466a72
Send error notifications only for files in analysis roots (and not excluded).
...
R=brianwilkerson@google.com
BUG=
Review-Url: https://codereview.chromium.org/2734673002 .
2017-03-05 15:01:27 -08:00
cc0036d5ad
Calculate text ranges for default args.
...
Continued work on generating sensible default contents for args in completions.
Calculated text ranges allow us to produce linked edits in the IDE.
BUG=
R=brianwilkerson@google.com , scheglov@google.com
Review-Url: https://codereview.chromium.org/2727343002 .
2017-03-02 13:14:49 -08:00
b17f4b2b5d
CompletionSuggestion API for arg list text ranges.
...
BUG=
R=brianwilkerson@google.com
Review-Url: https://codereview.chromium.org/2726923003 .
2017-03-01 16:10:46 -08:00
d826b1f931
Default arg support continued (flutter-intellij#553).
...
Default arg support for:
* inherited refs
* imported refs
* type members
* local constructors
BUG=
R=brianwilkerson@google.com , scheglov@google.com
See: https://github.com/flutter/flutter-intellij/issues/553
Review-Url: https://codereview.chromium.org/2728653004 .
2017-03-01 15:00:47 -08:00
d1bfe8bccb
Calculate default args for local reference completions.
...
First step towards wiring up default args for completions.
See: https://github.com/flutter/flutter-intellij/issues/553
Next up: similar enhancements for type_members, imported_refs, etc.
BUG=
R=brianwilkerson@google.com , scheglov@google.com
Review-Url: https://codereview.chromium.org/2722253002 .
2017-03-01 11:45:01 -08:00
b3ed30b822
Add assists to move Flutter widgets up and down one level.
...
Fixes:
https://github.com/flutter/flutter-intellij/issues/461
R=brianwilkerson@google.com
Review-Url: https://codereview.chromium.org/2724473002 .
2017-02-27 15:03:51 -10:00
2816c93faf
Ask Dart analysis results only for Dart files.
...
R=brianwilkerson@google.com
BUG= https://github.com/dart-lang/sdk/issues/28905
Review-Url: https://codereview.chromium.org/2720023002 .
2017-02-27 11:50:42 -08:00
8e6817f1da
New Completion defaultArgumentListString protocol.
...
BUG=
R=brianwilkerson@google.com
See: https://github.com/flutter/flutter-intellij/issues/553 .
Review-Url: https://codereview.chromium.org/2719083003 .
2017-02-27 11:36:30 -08:00
5c0bf9539c
Await in DefaultFixContributor.internalComputeFixes() to catch exceptions.
...
R=brianwilkerson@google.com
BUG=
Review-Url: https://codereview.chromium.org/2720013002 .
2017-02-27 10:40:24 -08:00
c416aabed1
Deprecate the analysis.updateOptions request
...
R=devoncarew@google.com
Review-Url: https://codereview.chromium.org/2719853004 .
2017-02-27 10:37:02 -08:00
25dfd0fa80
Deprecate execution.setSubscriptions.
...
BUG=
R=brianwilkerson@google.com , scheglov@google.com
Review-Url: https://codereview.chromium.org/2713513007 .
2017-02-24 11:01:00 -08:00
Dan Rubel