dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
33,955 Commits 2 Branches 0 Tags
65872873d260950273b45bc3064eaab4e165b671
Commit Graph

8753 Commits

Author SHA1 Message Date
Søren Gjesse 65872873d2 Remove server socket references 
The use of server socket references was deprecated in 1.9 and marked
for removal in 1.10.

R=kustermann@google.com

BUG=http://dartbug.com/22187

Review URL: https://codereview.chromium.org/1072783003 .
 2015-10-05 12:25:20 +02:00
Lasse R.H. Nielsen da8baacae4 Make root-zone handleUncaughtError rethrow with the correct stack. 
Adds _rethrow function which reifies the stack trace of an async
error on the VM. There is no corresponding JS functionality, it still
just throws an AsyncError wrapper.

Fixes issue #24163
BUG= http://dartbug.com/24163
R=iposva@google.com, turnidge@google.com

Review URL: https://codereview.chromium.org//1383983002.
 2015-10-05 08:16:52 +02:00
Ivan Posva ba6c0ace3e - Add getters for the current packageRoot or packageMap to the Isolate class. 
- Simplify loading in builtin.dart.

BUG=
R=asiva@google.com, lrn@google.com

Review URL: https://codereview.chromium.org//1334353002 .
 2015-10-03 06:53:13 -07:00
Daniel Andersson f066ce03b8 Add link to BMU benchmark gallery generator tool. 
BUG=
R=iposva@google.com

Review URL: https://codereview.chromium.org/1387693002 .
 2015-10-02 17:18:39 -07:00
Chinmay Garde 8a2d122e1a Fix build breaks on iOS. Adds missing import and avoid use of unavailable macro. 
BUG=
R=rmacnak@google.com

Review URL: https://codereview.chromium.org/1384063002 .
 2015-10-02 11:14:24 -07:00
Ryan Macnak bbee4de6d5 Also reset the stub of native calls. 
Fixes precompiled dart2js (the real one in sdk, not the benchmark that was
already running).

R=fschneider@google.com

Review URL: https://codereview.chromium.org/1373333004 .
 2015-10-02 10:08:14 -07:00
Regis Crelier 451eaab718 Remove --supermixin flag from VM. 
Update tests and test status files.

Fixes #24479.

R=hausner@google.com

Review URL: https://codereview.chromium.org/1383923002 .
 2015-10-01 18:04:31 -07:00
Ryan Macnak 5dc51af924 Resolve some disagreements between SIMARM and XARM on offsets used in compiled code. 
gcc ia32 (SIMARM) seems to prefer to pack structures whereas gcc arm (XARM) seems to prefer to keeping things aligned.

R=fschneider@google.com

Review URL: https://codereview.chromium.org//1351403004 .
 2015-10-01 15:01:20 -07:00
Ryan Macnak 8fac3bf53c Support serializing ObjectPool as reference. 
Revert to serializing ObjectPool and ICData slots by reference.

Fixes loading precompiled full dart2js snapshot.

Increases size of precompiled.isolate by 3.2%.

R=asiva@google.com

Review URL: https://codereview.chromium.org/1378423002 .
 2015-10-01 14:33:37 -07:00
Srdjan Mitrovic 1a11dbfc1c Allocate error messages in old space: needed for background compilation and rarely done 
BUG=
R=koda@google.com, regis@google.com

Review URL: https://codereview.chromium.org//1375443004 .
 2015-10-01 13:13:04 -07:00
John McCutchan 7b01e5fa11 Fix Mac dartium build 
BUG=

Review URL: https://codereview.chromium.org/1380103006 .
 2015-10-01 11:26:41 -07:00
Todd Turnidge 23823cd0fd Add a scroll bar when the console prints looooooooong lines. 
Closes #24299

R=johnmccutchan@google.com

Review URL: https://codereview.chromium.org/1383843002 .
 2015-10-01 11:10:50 -07:00
John McCutchan fd6135927e Ensure that service protocol specification and implementation use the correct numeric types 
Fixes #24245

R=turnidge@google.com

Review URL: https://codereview.chromium.org/1387433002 .
 2015-10-01 11:05:13 -07:00
Todd Turnidge 473413753d Some changes to service protocol before we land 1.13. 
- Split AddBreakpoint into two rpcs: AddBreakpoint and
  AddBreakpointWithScriptUri.

- Remove Isolate.entry.

Closes #24329

R=johnmccutchan@google.com

Review URL: https://codereview.chromium.org//1379163002 .
 2015-10-01 10:46:44 -07:00
John McCutchan 03b41129a2 Add Timeline to dart:developer 
- This CL only adds support for synchronous blocks of time. A follow up CL will add asynchronous blocks of time.
- Reports true thread id to tracing system. This is an improvement over Mojo's tracing helper.
- Dart events are included in individual isolate traces and global traces obtained via the embedders API.
- Dart events are included in the write to disk path (--timeline_dir).

R=rmacnak@google.com

Review URL: https://codereview.chromium.org//1377663002 .
 2015-10-01 09:30:47 -07:00
William Hesse e5ebc9c630 Free copy of hostname in SecureSocket implementation. 
BUG=https://github.com/dart-lang/sdk/issues/24186
BUG=https://github.com/dart-lang/sdk/issues/24225
R=sgjesse@google.com

Review URL: https://codereview.chromium.org//1383713002 .
 2015-10-01 17:28:32 +02:00
William Hesse 1b5e4cc506 Enable SNI hostname extension in SecureSocket. 
BUG=https://github.com/dart-lang/sdk/issues/24330
R=sgjesse@google.com

Review URL: https://codereview.chromium.org//1384463003 .
 2015-10-01 17:28:06 +02:00
John McCutchan c5aeb5a808 Remove trailing slash in codereview.settings to fix review url double slash 
BUG=
R=ricow@google.com

Review URL: https://codereview.chromium.org/1382853002 .
 2015-10-01 07:27:13 -07:00
John McCutchan 4b4e836960 Fix build breakage encountered by Flutter 
BUG=

Review URL: https://codereview.chromium.org//1376143004 .
 2015-10-01 07:18:27 -07:00
Florian Schneider a979c07e03 VM: More compact code for pushing constant arguments on ia32/x64. 
Generate

push imm8/imm32

instead of

mov reg, imm32
push reg

R=srdjan@google.com

Review URL: https://codereview.chromium.org//1383573002 .
 2015-10-01 11:16:16 +02:00
Ryan Macnak 67c15fc982 Make --noopt behave like an in-place precompilation. 
Breaks --noopt for IA32.

R=srdjan@google.com

Review URL: https://codereview.chromium.org//1373873004 .
 2015-09-30 13:11:47 -07:00
Matthias Hausner 4995b84051 Remove obsolete timer list from VM 
The functionality is now covered with TimeLine and CompilerStats

BUG=
R=johnmccutchan@google.com

Review URL: https://codereview.chromium.org//1375343002 .
 2015-09-30 12:47:23 -07:00
Ryan Macnak 7b0937f524 Remove checked mode instrinsic for _List.[]= from the precompilation architectures. 
BUG=http://dartbug.com/24336
R=srdjan@google.com

Review URL: https://codereview.chromium.org//1379743002 .
 2015-09-30 10:24:27 -07:00
Srdjan Mitrovic edccf3af0a Cleanup: we are not patching entries any longer 
BUG=
R=rmacnak@google.com

Review URL: https://codereview.chromium.org//1376963002 .
 2015-09-30 10:22:59 -07:00
Daniel Andersson f500a1bdd8 Clarify heap write protection interface and use WritableVMIsolateScope to resolve issue 23217. 
BUG=23217
R=asiva@google.com

Review URL: https://codereview.chromium.org//1374373004 .
 2015-09-30 10:17:51 -07:00
John McCutchan 6b622133ca Fill the header of an Instructions object with null 
Fixes debug mode failure discovered on mips bot.

R=rmacnak@google.com

Review URL: https://codereview.chromium.org//1375283003 .
 2015-09-30 10:06:30 -07:00
John McCutchan 3e5214ab2e Restore back pointer from Instructions to Code 
Fixes #24449

R=rmacnak@google.com

Review URL: https://codereview.chromium.org//1377583005 .
 2015-09-30 07:27:37 -07:00
William Hesse 322a735424 Allow X509 certificate chains where we trust a certificate in the middle of the chain. 
BUG=https://github.com/dart-lang/sdk/issues/24330
R=sgjesse@google.com

Review URL: https://codereview.chromium.org//1381673002 .
 2015-09-30 15:25:45 +02:00
Siva Annamalai 575fa10d39 Fix for issue 24487951 (heap buffer overflow problem) 
BUG=
R=srdjan@google.com

Review URL: https://codereview.chromium.org//1376973002 .
 2015-09-29 15:18:30 -07:00
Ryan Macnak 6a3255f4ae Avoid eagerly enqueueing converted forms of selectors or eagerly creating their symbols. 
Fix setter closurization.

Shrinks precompiled snapshot by 11.4%.

R=hausner@google.com

Review URL: https://codereview.chromium.org//1373213003 .
 2015-09-29 13:41:36 -07:00
Siva Annamalai aac5baa90e Clean up serialization of RawFunction, RawCode 
BUG=
R=rmacnak@google.com

Review URL: https://codereview.chromium.org//1377543003 .
 2015-09-29 13:11:53 -07:00
John McCutchan 95513b0a1d Switch from Google charts to Charted 
R=turnidge@google.com

Review URL: https://codereview.chromium.org//1310153002 .
 2015-09-29 12:59:05 -07:00
Srdjan Mitrovic d867784de5 Cleanups and preemptively pass Heap::kOld whenever subtype testing in compiler 
BUG=
R=regis@google.com

Review URL: https://codereview.chromium.org//1377453005 .
 2015-09-29 11:05:54 -07:00
Ryan Macnak 9d69945328 Remove duplicate kind-to-c-string for LocalVarDescriptors. 
R=fschneider@google.com

Review URL: https://codereview.chromium.org//1372173005 .
 2015-09-29 10:01:18 -07:00
John McCutchan 85d1e2c908 Bump observatory_pub_packages in DEPS 
BUG=
R=rmacnak@google.com

Review URL: https://codereview.chromium.org//1377583002 .
 2015-09-28 12:57:19 -07:00
Florian Schneider 66bc931b69 VM: Fix bug in the new edge counter code on ARM and MIPS. 
The offset into the edge counter array may exceed the limit
of what fits into an Address operand on ARM and MIPS.

BUG=
R=rmacnak@google.com

Review URL: https://codereview.chromium.org//1373013002 .
 2015-09-28 19:38:42 +02:00
Ryan Macnak da006acfdf Extend precompilation test to Mac. Attempt to fix for host MIPS. 
R=fschneider@google.com

Review URL: https://codereview.chromium.org//1370833003 .
 2015-09-28 10:04:45 -07:00
Rico Wind c2ff661740 Mark service/process_service_test as flaky on arm 
Updated issue 24344 to reflect that this is flaky

R=fschneider@google.com
BUG=

Review URL: https://codereview.chromium.org//1373853002 .
 2015-09-28 17:01:35 +02:00
Florian Schneider 4a653d9e17 VM: Store edge counters in one per-function array. 
Reserve first element in the Function's ic_data_array to hold the edge
counter array.

Until now we had a one-element array per edge counter. This reduces memory
used by edge counters.

This CL allows to optimize code without having to have the unoptimized
code present.

Also, save space in Instruction by making place_id_ and lifetime_position_
a union. place_id_ is exclusively needed by Load/StoreOptimizer,
lifetime_position by the FlowGraphAllocator.

BUG=
R=asiva@google.com

Review URL: https://codereview.chromium.org//1343383003 .
 2015-09-28 13:28:04 +02:00
Florian Schneider fe8bda5c4d VM: Handle null-case when running with --trace-ic. 
BUG=
R=rmacnak@google.com

Review URL: https://codereview.chromium.org//1369703003 .
 2015-09-28 11:09:36 +02:00
Srdjan Mitrovic 98340f7d9e Do not eagerly finalize when optimizing. Remove allocation of temporary strings in new space. 
BUG=
R=regis@google.com

Review URL: https://codereview.chromium.org//1368173002 .
 2015-09-25 14:30:48 -07:00
Ryan Macnak d7b46bf5c1 Don't use a special var descriptor for :async_op since it can now be either stack or context allocated. 
BUG=http://dartbug.com/24439
R=regis@google.com

Review URL: https://codereview.chromium.org//1361423004 .
 2015-09-25 13:47:41 -07:00
John McCutchan 2a9c5c0a91 Add public_config to :libdart in runtime/BUILD.gn 
BUG=
R=jamesr@chromium.org

Review URL: https://codereview.chromium.org//1373613002 .
 2015-09-25 12:41:03 -07:00
John McCutchan 3d0c4bf586 Make timeline use the same clock source as mojo's tracing infrastructure 
- This ensures that we have consistent timestamps across processes.
- This is necessary to properly support mojo.
- Add new public API to query timeline clock.

R=rmacnak@google.com

Review URL: https://codereview.chromium.org//1367973004 .
 2015-09-25 10:04:23 -07:00
Florian Schneider 9fa3d7c9e4 VM: Initialize Instruction objects with break instructions instead of null. 
On ia32 this is int3().  This also makes precompiled instruction snapshots
deterministic (to be precise the empty space due to alignment), and not depending
 on the address of the null object at snapshot creation time.

BUG=
R=rmacnak@google.com

Review URL: https://codereview.chromium.org//1367973002 .
 2015-09-25 14:10:32 +02:00
Ryan Macnak fcdd855859 Precompile invoke-field-dispatchers for closures. 
Improves precompiled DeltaBlueClosures by 8.6x and increases
instructions size by 0.05% (0.0005) on ARM.

R=fschneider@google.com

Review URL: https://codereview.chromium.org//1371453002 .
 2015-09-24 17:19:37 -07:00
John McCutchan 08118282d7 Fix TimelinePauses_Basic test failure 
BUG=

Review URL: https://codereview.chromium.org//1368823002 .
 2015-09-24 15:31:24 -07:00
John McCutchan a44db4a0f3 Fix MacOS build 
BUG=

Review URL: https://codereview.chromium.org//1365183002 .
 2015-09-24 15:16:03 -07:00
Srdjan Mitrovic 1ffada9e98 Modify String::IdentifierPrettyName to work with zone allocated temporary strings instead of String heap objects. 
BUG=
R=regis@google.com

Review URL: https://codereview.chromium.org//1368773002 .
 2015-09-24 14:59:53 -07:00
John McCutchan 8685d2ebf5 Add OSThread::GetCurrentThreadTraceId and use it in the timeline implementation 
- This ensures our trace-event thread ids match the thread ids used in Chromium's base.

R=rmacnak@google.com

Review URL: https://codereview.chromium.org//1368793002 .
 2015-09-24 14:57:30 -07:00