e6053aa135
Rollback https://codereview.chromium.org/1380223003
...
TBR
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org/1390463002 .
2015-10-04 17:07:10 -07:00
1af7b154af
Issue 23694. Include 'docSummary' and 'docComplete' into CompletionSuggestion.
...
R=brianwilkerson@google.com
BUG= https://github.com/dart-lang/sdk/issues/23694
Review URL: https://codereview.chromium.org/1380223003 .
2015-10-04 16:16:45 -07:00
0b01edac17
More tests for 'Organize Directives'.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org/1380893003 .
2015-10-02 13:11:34 -07:00
c06ad0db30
Issue 24420. Don't allow renaming in pub packages.
...
There are no ideal solution for this.
But all our users want it somehow.
R=brianwilkerson@google.com
BUG= https://github.com/dart-lang/sdk/issues/24420
Review URL: https://codereview.chromium.org/1380253003 .
2015-10-02 13:09:55 -07:00
66a122a9db
Stop defensively copying AST structures before resolution
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org/1383043002 .
2015-10-02 12:38:18 -07:00
04e21a2a7c
Completions with exact prefix should be prioritized - fixes #23099
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org//1369033002 .
2015-10-02 15:12:23 -04:00
6e441f62e8
only suggest rethrow inside catch block - fixes #24214
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org//1360123003 .
2015-10-02 15:10:14 -04:00
62fd9ac787
Issue 24487. Annotations with constructor resolution should produce navigation reginos to constructors.
...
R=brianwilkerson@google.com
BUG= https://github.com/dart-lang/sdk/issues/24487
Review URL: https://codereview.chromium.org/1378713004 .
2015-10-02 10:44:58 -07:00
8eef458f9c
add completion after export - fixes #24400
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org//1368173004 .
2015-10-02 13:00:06 -04:00
a24ae72e74
suggest argument name completions for annotations - fixes #24296 and fixes #24259
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org//1362353003 .
2015-10-02 12:54:22 -04:00
03e379de7a
Compute Outline.kind/libraryName actually.
...
R=brianwilkerson@google.com
BUG= https://github.com/dart-lang/sdk/issues/24279
Review URL: https://codereview.chromium.org/1380103005 .
2015-10-01 13:09:38 -07:00
c4d0ff8a4c
pkg: Eliminate flaky analysis test failure.
...
Running in debug mode (or any slower configuration) makes this test fail since
it waits for a max of 100 event loop iterations for the analysis results.
Instead wait without limit until results are ready, with checking every few milliseconds.
BUG=
R=scheglov@google.com
Review URL: https://codereview.chromium.org//1379153002 .
2015-10-01 19:34:50 +02:00
9d48af9ee3
Specification change for the 'libraryName' and 'partOfLibraryName' fields in Outline.
...
R=brianwilkerson@google.com , paulberry@google.com
BUG=
Review URL: https://codereview.chromium.org//1375163003 .
2015-10-01 09:53:20 -07:00
7beaf28f32
Always include Object and its members into 'inherited'.
...
Analyzing them honestly is too expensive.
R=brianwilkerson@google.com
BUG=
Review URL: https://chromiumcodereview.appspot.com//1375313004 .
2015-09-30 18:23:53 -07:00
184fe4ae58
Publish new version of analyzer and use it in AS.
...
R=pquitslund@google.com
BUG=
Review URL: https://codereview.chromium.org//1377233002 .
2015-09-30 11:15:23 -07:00
1d28f99524
Fix for 'implemented' notification after an incremental change.
...
R=brianwilkerson@google.com , paulberry@google.com
BUG=
Review URL: https://codereview.chromium.org//1374943005 .
2015-09-30 11:08:41 -07:00
db4e79b74d
Issue 24459. Fix for 'Create Method' QF in different unit.
...
R=brianwilkerson@google.com
BUG= https://github.com/dart-lang/sdk/issues/24459
Review URL: https://codereview.chromium.org//1375043004 .
2015-09-29 21:29:07 -07:00
f9aebddc67
Ignore added files in hidden directories.
...
In commit 6ddc37a5ccFixes #24212 .
R=brianwilkerson@google.com
Review URL: https://codereview.chromium.org//1372173004 .
2015-09-28 14:10:32 -07:00
5bc38481a7
Report a fatal error on attempt to rename an element declared in SDK.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//1377623002 .
2015-09-28 14:00:13 -07:00
6cd9e0da71
Do not suggest static fields in constructor initializer - fixes #24256
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org//1365403002 .
2015-09-26 11:59:15 +02:00
6bab7d9cbc
Use Element.nameLength where possible.
...
...or don't use it when there is a better alternative.
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//1372673003 .
2015-09-25 15:03:46 -07:00
3924b15d85
Remove ElementLocator.locateWithOffset altogether.
...
It was needed only for the old Angular implementation support, which
overlayed its own Element subclasses into normal Dart AST, for example
for string literals - names of components.
As we don't support this anymore, there is no need for the method.
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//1370833002 .
2015-09-25 14:57:15 -07:00
6c029f9cb1
Issue 24440. Fix for renaming libraries using 'part of' directives.
...
R=brianwilkerson@google.com
BUG= https://github.com/dart-lang/sdk/issues/24440
Review URL: https://codereview.chromium.org//1364853007 .
2015-09-25 14:24:05 -07:00
4f8649f1b3
Issue 24442. Fix for renaming library names with spaces.
...
R=brianwilkerson@google.com
BUG= https://github.com/dart-lang/sdk/issues/24442
Review URL: https://codereview.chromium.org//1370793003 .
2015-09-25 13:55:13 -07:00
83f94a2114
Add navigation region for 'library' directives.
...
Dart Editor uses presence of a navigation region as a sign that there is something that can be renamed, and enables the Rename action.
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//1373593002 .
2015-09-25 12:35:51 -07:00
df827a06ae
The 'analysis.implemented' notification implementation.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//1368793003 .
2015-09-25 12:33:02 -07:00
da29a447c4
New analysis.implemented notification specification.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//1372623004 .
2015-09-25 09:57:29 -07:00
56e39e99eb
rename _test => _tests
...
BUG=
Review URL: https://codereview.chromium.org//1358243005 .
2015-09-25 09:07:15 -07:00
6f775acc7b
add performance tests
...
BUG=
R=brianwilkerson@google.com
Review URL: https://codereview.chromium.org//1366923003 .
2015-09-25 08:35:42 -07:00
805f6ec3ba
Record HAS_ANCESTOR relations into index.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//1371463002 .
2015-09-24 16:21:09 -07:00
d869088ea3
Error handling for bad .analysis_options files.
...
R=brianwilkerson@google.com
Review URL: https://codereview.chromium.org//1364813003 .
2015-09-23 13:27:19 -07:00
6899986bfe
Use TypeSystem in the 'Extract Method' refactoring.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//1364803003 .
2015-09-23 10:28:50 -07:00
5fd8b38737
Tweak navigation for 'part of' directives.
...
This makes it consistent with import/export/part directives, where only URIs are navigation sources.
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//1365663002 .
2015-09-23 10:14:49 -07:00
4aa6466ccb
Use IndexContributor(s) in LocalIndex.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//1359113002 .
2015-09-23 08:17:33 -07:00
7aa459affd
Add more performance data
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org//1363653005 .
2015-09-23 07:44:44 -07:00
d2f4a19fa6
Import cleanup.
...
R=brianwilkerson@google.com , scheglov@google.com
Review URL: https://codereview.chromium.org//1364583002 .
2015-09-22 17:06:55 -07:00
531f1d1e5b
Extract Dart specific node management into DartUnitIndexObjectManager.
...
We want to be able to index not just CompilationUnitElement(s), but also
for example results of Angular resolution, which while are based on resolved
CompilationUnit(s), are not ready together with it, so should live in separate
split index nodes.
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//1359023002 .
2015-09-22 12:26:41 -07:00
163ad75127
Fix status pages when running new task model
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org//1351243003 .
2015-09-22 11:03:56 -07:00
f67bc2f546
Replace NameElement with IndexableName.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//1347943006 .
2015-09-21 12:02:34 -07:00
bd51946e6f
Remove old translated code from DAS.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//1355173002 .
2015-09-21 10:43:35 -07:00
173cb44a85
Add '<!doctype html>' to spec.
...
The new task model's HTML parser reports an error otherwise.
R=brianwilkerson@google.com , paulberry@google.com
BUG=
Review URL: https://codereview.chromium.org//1351323004 .
2015-09-21 10:10:57 -07:00
d6051a53a0
refactor ContributionSorter to use new API
...
move CompletionTarget to public API
modify DartCompletionRequest to return completion target
R=brianwilkerson@google.com
Review URL: https://codereview.chromium.org//1347283005 .
2015-09-18 16:03:22 -04:00
9ad1bf1f0e
rename inherited_computer to inherited_contributor (TBR)
...
Review URL: https://codereview.chromium.org//1357003002 .
2015-09-18 15:56:59 -04:00
3d05453793
add inherited_computer.dart (TBR)
...
Review URL: https://codereview.chromium.org//1346813005 .
2015-09-18 15:46:56 -04:00
42593f4094
(TBD) Disable broken test
...
Review URL: https://codereview.chromium.org//1358493002 .
2015-09-18 09:17:01 -07:00
f4b1879180
Add a completion for inherited methods
...
R=danrubel@google.com
Review URL: https://codereview.chromium.org//1338173002 .
2015-09-18 08:59:56 -07:00
594fe93422
Support for NAVIGATION/OCCURRENCES notifications for any source (such as HTML).
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//1343283004 .
2015-09-17 12:37:36 -07:00
b96b1cfc5d
Add defaultCompletionSorter allowing sorting to be overridden - fixes #24339
...
I will convert CompletionSorter to use the new completion API in a subsequent CL.
R=brianwilkerson@google.com
Review URL: https://codereview.chromium.org//1353913002 .
2015-09-17 14:59:48 -04:00
75600fc162
Report UNRESOLVED_INSTANCE_MEMBER_REFERENCE for dynamicVar.member references.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//1345943006 .
2015-09-17 10:37:04 -07:00
1a6daab9d1
Wrap the http server start-up in an exception handler
...
R=devoncarew@google.com
Review URL: https://codereview.chromium.org//1349263002 .
2015-09-17 10:15:38 -07:00
Konstantin Shcheglov