568329fe06
Disallow assignment to a top level method in dartc
...
http://code.google.com/p/dart/issues/detail?id=966
Review URL: http://codereview.chromium.org//9158014
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@3154 260f80e4-7a28-3924-810f-c04153c831b5
2012-01-10 16:39:21 +00:00
d3703d84e7
Issue 1099: Compile time error for RHS this access in initializer
...
http://code.google.com/p/dart/issues/detail?id=1099
R=zundel
BUG=1099
TEST=
Review URL: http://codereview.chromium.org//9169013
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@3153 260f80e4-7a28-3924-810f-c04153c831b5
2012-01-10 16:31:48 +00:00
addcaec400
Issue 1105: Duplicate initialization should have a compile error
...
http://code.google.com/p/dart/issues/detail?id=1105
7.5.1
It is a compile-time error if more than one initializer corresponding to a
given instance variable appears in k’s initializer list. It is a
compile-time error if k’s initializer list contains an initializer for a
variable that is initialized by means of an initializing formal of k.
R=zundel,mmendez
BUG=1105
TEST=
Review URL: http://codereview.chromium.org//9166006
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@3152 260f80e4-7a28-3924-810f-c04153c831b5
2012-01-10 16:27:28 +00:00
9eb76b67ca
Include dom.dart library into ignoring shadow warnings
...
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@3146 260f80e4-7a28-3924-810f-c04153c831b5
2012-01-10 15:20:03 +00:00
4c274d4106
Fixes for parsing warnigs, issue 1060.
...
1. Diet parsing notification fix.
2. Disable name shadow warnings for htmlimpl.dart library, until library itself will be fixed.
3. Fix for identifying core libraries in Editor.
R=zundel@google.com
BUG=
TEST=
Review URL: http://codereview.chromium.org//9149008
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@3113 260f80e4-7a28-3924-810f-c04153c831b5
2012-01-09 20:33:12 +00:00
74015409f2
Issue 988: Compile time error missing for const class / non-final instance variables
...
http://code.google.com/p/dart/issues/detail?id=988
7.5.3: It is a compile-time error if a constant constructor is declared by a class that has a non-final instance variable.
The above refers to both locally declared and inherited instance variables.
R=mmendez,zundel
BUG=
TEST=
Review URL: http://codereview.chromium.org//9122015
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@3108 260f80e4-7a28-3924-810f-c04153c831b5
2012-01-09 17:58:08 +00:00
69b567e798
in dartc, generics in Typedef not working as expected, when extending generic type
...
http://code.google.com/p/dart/issues/detail?id=436
Review URL: http://codereview.chromium.org//9049016
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@3103 260f80e4-7a28-3924-810f-c04153c831b5
2012-01-09 17:06:37 +00:00
01abdc883f
Blacklist types from core library, issue 969
...
http://code.google.com/p/dart/issues/detail?id=969
R=zundel@google.com
BUG=
TEST=
Review URL: http://codereview.chromium.org//9124006
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@3102 260f80e4-7a28-3924-810f-c04153c831b5
2012-01-09 16:36:04 +00:00
34b6799f7c
Fix http://code.google.com/p/dart/issues/detail?id=990 .
...
Need to check that the implicit super call resolves. Updated the unit tests until the c019 tests are refreshed.
Review URL: http://codereview.chromium.org//9139001
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@3098 260f80e4-7a28-3924-810f-c04153c831b5
2012-01-09 15:35:16 +00:00
8fcfbe459a
Fix so that listeners will get notified. Sorry I missed this when reviewing the change.
...
Review URL: http://codereview.chromium.org//9124018
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@3073 260f80e4-7a28-3924-810f-c04153c831b5
2012-01-07 15:54:00 +00:00
2726b1e229
Issue 1061: Duplicate members causes NPE in type analyzer
...
http://code.google.com/p/dart/issues/detail?id=1061
Replace Map<Element> with MultiMap<Element> (LinkedHashMap).
R=zundel,messick
BUG=1061
TEST=
Review URL: http://codereview.chromium.org//9122003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@3047 260f80e4-7a28-3924-810f-c04153c831b5
2012-01-06 18:32:20 +00:00
bf920d8dfd
Add unitAboutToCompile() into DartCompilerListener
...
R=brianwilkerson@google.com ,codefu@google.com
BUG=
TEST=
Review URL: http://codereview.chromium.org//9113017
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@3045 260f80e4-7a28-3924-810f-c04153c831b5
2012-01-06 16:34:20 +00:00
e7469aa059
Fix for an NPE for cases where the native keyword on a class is not followed by a string identifier.
...
Review URL: http://codereview.chromium.org//9109019
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@3011 260f80e4-7a28-3924-810f-c04153c831b5
2012-01-05 21:08:30 +00:00
4bcedc935b
Convert "library unit" File path into "absolute unit path", issue 590.
...
http://code.google.com/p/dart/issues/detail?id=590
Actually URI is not expectedto be absolute path to the unit, this is just ID.
And Compiler provides it in form pathToTheLibraryUnit/unitName.dart
So, I've tweaked converting URI into File.
R=brianwilkerson@google.com
BUG=
TEST=
Review URL: http://codereview.chromium.org//8898001
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@3002 260f80e4-7a28-3924-810f-c04153c831b5
2012-01-05 16:05:32 +00:00
0c8e0d803d
Report error for interface method with body
...
http://code.google.com/p/dart/issues/detail?id=971
R=zundel@google.com
BUG=
TEST=
Review URL: http://codereview.chromium.org//9086015
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@3000 260f80e4-7a28-3924-810f-c04153c831b5
2012-01-05 15:48:06 +00:00
7360b44dac
Issue 1043: Missing --documentation-out should default to "out" instead of asserting
...
http://code.google.com/p/dart/issues/detail?id=1043
R=zundel
BUG=
TEST=
Review URL: http://codereview.chromium.org//9094001
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@2965 260f80e4-7a28-3924-810f-c04153c831b5
2012-01-04 20:16:55 +00:00
dbb10e2cc8
Issue 1039: Nested comments
...
http://code.google.com/p/dart/issues/detail?id=1039
Language Specification 0.06, 14.1.2 specifices that multiline comments can
nest:
MULTI LINE COMMENT:
‘/*’ (MULTI LINE COMMENT | ̃ ‘*/’)* ‘*/’
;
R=zundel
BUG=1039
TEST=
Review URL: http://codereview.chromium.org//9030028
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@2964 260f80e4-7a28-3924-810f-c04153c831b5
2012-01-04 19:59:21 +00:00
eb007b203c
Fix dartc bounds checking for invoking interface constructors/factory methods
...
http://code.google.com/p/dart/issues/detail?id=943
Review URL: http://codereview.chromium.org//9014029
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@2957 260f80e4-7a28-3924-810f-c04153c831b5
2012-01-04 18:24:50 +00:00
9c6d9fc4de
Flag methods as not being valid compile time constants
...
BUG=1000
TEST=
Review URL: http://codereview.chromium.org//9016050
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@2956 260f80e4-7a28-3924-810f-c04153c831b5
2012-01-04 18:19:34 +00:00
d5dbe92233
Issue 991: Missing compiler errors for uninitialized final fields
...
http://code.google.com/p/dart/issues/detail?id=991
-Track non initialized fields at declaration for classes
-Verify they are initialized in non-redirect constructors
-Check for duplicate final initialization; add tests and mark VM and Frog
as failing
BUG=
TEST=
Review URL: http://codereview.chromium.org//9081001
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@2951 260f80e4-7a28-3924-810f-c04153c831b5
2012-01-04 16:51:55 +00:00
e215e81abc
Violating type bounds on a new invocation is a static type error, not a compile error
...
http://code.google.com/p/dart/issues/detail?id=1027
Review URL: http://codereview.chromium.org//9016053
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@2921 260f80e4-7a28-3924-810f-c04153c831b5
2012-01-03 20:53:39 +00:00
5ed64c70d9
Issue 940 - Exception generating js for prefixed toplevel fields
...
http://code.google.com/p/dart/issues/detail?id=940
Talked to Gilad about the abiguity of language spec between prefix identifiers and method invocation. P.id(...) looks like o.m(...) to the parser at the moment.
Local fields are correctly represented in the AST as unqualified invocations.
R=zundel,mmendez
BUG=
TEST=
Review URL: http://codereview.chromium.org//8956062
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@2910 260f80e4-7a28-3924-810f-c04153c831b5
2012-01-03 15:04:28 +00:00
b07eeae6d3
Issue 999: NPE from CompileTimeConstantAnalyzer
...
http://code.google.com/p/dart/issues/detail?id=999
R=scheglov@google.com ,zundel@google.com
BUG=
TEST=
Review URL: http://codereview.chromium.org//9052002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@2876 260f80e4-7a28-3924-810f-c04153c831b5
2011-12-29 20:14:27 +00:00
66edafb3ab
Check for abstract method with body and top-level abstract elements, issue 871
...
http://code.google.com/p/dart/issues/detail?id=871
R=codefu@google.com
BUG=
TEST=
Review URL: http://codereview.chromium.org//9015002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@2867 260f80e4-7a28-3924-810f-c04153c831b5
2011-12-29 16:11:19 +00:00
e480e8e7fc
Issue926: NPE while traversing nodes + invalid string interpolation
...
http://code.google.com/p/dart/issues/detail?id=926
BUG=
TEST=
Review URL: http://codereview.chromium.org//9006033
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@2866 260f80e4-7a28-3924-810f-c04153c831b5
2011-12-29 13:51:26 +00:00
27f2e70854
This adds a unit test to show the type checking functionality missing in dartc
...
This refines omitting the runtime-type checks in certain cases to just apply to
type variables (original disabled by r2660)
BUG=925
TEST=
Review URL: http://codereview.chromium.org//8956047
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@2771 260f80e4-7a28-3924-810f-c04153c831b5
2011-12-22 17:45:45 +00:00
b2605b7590
Issue 250: Allow for GNU formatted errors
...
Removes --machine-problems option and added --error_format [normal|machine|gnu]
R=zundel@google.com
BUG=
TEST=
Review URL: http://codereview.chromium.org//8949055
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@2763 260f80e4-7a28-3924-810f-c04153c831b5
2011-12-22 15:39:57 +00:00
8d6ffa5af8
Issue 895: NPEs in DeltaAnalyser
...
When copying old elements in the DeltaAnalyser, skip the members that don't
have nodes.
When called with null parameters from the completion engine, just return.
BUG=
TEST=
Review URL: http://codereview.chromium.org//9004032
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@2762 260f80e4-7a28-3924-810f-c04153c831b5
2011-12-22 15:33:34 +00:00
bc620b97a8
Moves over remaining .dart code references to 'factory' in interface declartions to 'default'
...
BUG=
TEST=
Review URL: http://codereview.chromium.org//9016026
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@2752 260f80e4-7a28-3924-810f-c04153c831b5
2011-12-22 13:35:54 +00:00
b0348a06b7
Dartc was not raising an error if an interface declared constructors without a default clause
...
BUG=928
TEST=
Review URL: http://codereview.chromium.org//9017015
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@2716 260f80e4-7a28-3924-810f-c04153c831b5
2011-12-21 19:05:54 +00:00
b9cf172e4a
Workaround for referencing type args in the $named_$lookupRTT method.
...
These lookup methods references $typeArgs as if they were a parameter to the method,
but that method actually takes no arguments. There is no 'this' context either, but
at least JS compiler doesn't complain about that.
BUG=
TEST=
Review URL: http://codereview.chromium.org//9006012
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@2660 260f80e4-7a28-3924-810f-c04153c831b5
2011-12-20 19:58:50 +00:00
63a96477cd
Report errors and warnings for hiding elements, issue 572.
...
http://code.google.com/p/dart/issues/detail?id=572
R=zundel@google.com
BUG=
TEST=
Review URL: http://codereview.chromium.org//8966029
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@2636 260f80e4-7a28-3924-810f-c04153c831b5
2011-12-20 14:35:40 +00:00
09061281f7
Don't allow elements of a DartBinaryExpression to be null.
...
Issue:
http://code.google.com/p/dart/issues/detail?id=832
Note; I'm still getting NPEs, but the corelibrary isn't being found (a
different issue between Editor/DartC usage?).
R=danrubel@google.com ,mmendez@google.com
Review URL: http://codereview.chromium.org//8993011
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@2600 260f80e4-7a28-3924-810f-c04153c831b5
2011-12-19 23:23:31 +00:00
9d697de426
Updates dartc to recognize 'default' keyword on interface and updated factory method syntax.
...
Note: this does not have backwards compatibility for the old
factory syntax and updates the tests.
http://code.google.com/p/dart/issues/detail?id=417
Review URL: http://codereview.chromium.org//8948001
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@2597 260f80e4-7a28-3924-810f-c04153c831b5
2011-12-19 22:34:57 +00:00
0739223eeb
Issue 467: NPE with missing source
...
This was addressed in another issue / cl, however Brian suggested the error
reporing was wrong. Let me know if this is what you are looking for.
R=brianwilkerson@google.com ,mmendez
BUG=
TEST=
Review URL: http://codereview.chromium.org//8999001
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@2594 260f80e4-7a28-3924-810f-c04153c831b5
2011-12-19 20:57:46 +00:00
2afd27cbf6
Increase Mac stack size
...
BUG=
TEST=
Review URL: http://codereview.chromium.org//8970033
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@2552 260f80e4-7a28-3924-810f-c04153c831b5
2011-12-16 23:28:23 +00:00
3fae5d29a6
Promote class to a reserved word
...
Promote class as a reserved word http://code.google.com/p/dart/issues/detail?id=870
Cleaning old test that had invalid assumptions; makeing two new tests
(jUnit and shared test). Marking Frog and VM as failing.
R=mmendez
BUG=
TEST=
Review URL: http://codereview.chromium.org//8972003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@2550 260f80e4-7a28-3924-810f-c04153c831b5
2011-12-16 23:26:14 +00:00
263a78d588
Code for Dartest which consists of two parts:
...
1. Test runner library located in client/testing/
2. Instrumentation code for adding coverage probes
Added some fixes to the AST Writer and changes to highlight instrumented nodes.
Review URL: http://codereview.chromium.org//8905021
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@2549 260f80e4-7a28-3924-810f-c04153c831b5
2011-12-16 23:24:15 +00:00
4f655be31e
Issue 839: Bad code leading to top level methods being something other than identifier
...
Note; borrowed code from http://codereview.chromium.org/8914015/ as the
editor had the same issue.
Added support for the AST writer to handle Function Expressions and updated
the parser to give the AST writer a chance to dump the unit (if requested
via the current command line parameters) before bailing on the whole
program.
BUG=
TEST=
Review URL: http://codereview.chromium.org//8913016
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@2515 260f80e4-7a28-3924-810f-c04153c831b5
2011-12-16 12:57:19 +00:00
11abfc21e6
Fix the Dart formatter
...
This cl addresses fixing tests 001 and 002.
Other cl's will be created for continue to fix the formatter.
Review URL: http://codereview.chromium.org//8966004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@2502 260f80e4-7a28-3924-810f-c04153c831b5
2011-12-16 02:14:58 +00:00
dbd3ee5514
Don't allow new of interface without constructors.
...
Addresses http://code.google.com/p/dart/issues/detail?id=868 . The behavior of allowing default construction of interfaces that have factories has been there for sometime. We can remove that behavior once the issue has been settled.
BUG=http://code.google.com/p/dart/issues/detail?id=868
Review URL: http://codereview.chromium.org//8954016
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@2470 260f80e4-7a28-3924-810f-c04153c831b5
2011-12-15 18:38:49 +00:00
e9487a92e4
Expands on previous function RTT to support named/optional parameters.
...
Issues encountered:
http://code.google.com/p/dart/issues/detail?id=847
http://code.google.com/p/dart/issues/detail?id=848
BUG=
TEST=
Review URL: http://codereview.chromium.org//8913006
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@2465 260f80e4-7a28-3924-810f-c04153c831b5
2011-12-15 13:31:32 +00:00
03810b7877
Guard against NPE in: http://code.google.com/p/dart/issues/detail?id=815 .
...
BUG=
TEST=
Review URL: http://codereview.chromium.org//8895029
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@2429 260f80e4-7a28-3924-810f-c04153c831b5
2011-12-14 14:30:25 +00:00
2c38b7de7f
This adds a check to the resolver to detect when an override
...
has different number of parameters than in its superinterface.
Review URL: http://codereview.chromium.org//8632020
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@2354 260f80e4-7a28-3924-810f-c04153c831b5
2011-12-12 19:19:18 +00:00
34a06ec871
Use VM specific types if DartC types are not available
...
Review URL: http://codereview.chromium.org//8894031
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@2344 260f80e4-7a28-3924-810f-c04153c831b5
2011-12-12 16:32:04 +00:00
4a11fd42a3
Tweaks for reporting duplicates, issue 519.
...
http://code.google.com/p/dart/issues/detail?id=519
New tests, plus inlining existing *.dart files into tests with strict checks.
R=zundel@google.com
BUG=
TEST=
Review URL: http://codereview.chromium.org//8846002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@2343 260f80e4-7a28-3924-810f-c04153c831b5
2011-12-12 16:20:05 +00:00
40e46c0d60
Remove duplicate arguments from hoisted functions.
...
See example Dart code that tickles this problem here:
http://code.google.com/p/dart/issues/detail?id=565
Review URL: http://codereview.chromium.org//8894004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@2315 260f80e4-7a28-3924-810f-c04153c831b5
2011-12-09 16:49:47 +00:00
5613c66865
Function type checking: Part Deux
...
This replaced the following CL that was falling behind head.
http://codereview.chromium.org/8566022/
Summary:
Add support for function runtime type checking and typedefs; re-worked to
support tree-shaking at head. Static, instance, top level, and hoisted
methods have RTT lookup methods to identify their types. Respective
getters() and binds() have been updated or added to link the lookup methods
to bounded methods. Static method getters were added as well to perform this
linking for non-bound situations.
BUG=
TEST=
Review URL: http://codereview.chromium.org//8845002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@2263 260f80e4-7a28-3924-810f-c04153c831b5
2011-12-08 18:12:00 +00:00
c95fa9c286
Check for using 'this' and 'super'. Tests. Issue 662.
...
http://code.google.com/p/dart/issues/detail?id=662
R=zundel@google.com
BUG=
TEST=
Review URL: http://codereview.chromium.org//8867001
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@2252 260f80e4-7a28-3924-810f-c04153c831b5
2011-12-08 16:25:23 +00:00
98504921ed
Report error on parsing URI cleanly (don't throw exception)
...
Issue 712: http://code.google.com/p/dart/issues/detail?id=712
Review URL: http://codereview.chromium.org//8855010
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@2197 260f80e4-7a28-3924-810f-c04153c831b5
2011-12-07 21:36:05 +00:00
zundel@google.com