dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
80,627 Commits 2 Branches 0 Tags
5fbc2d3d53b3515958633cea4bd685f05ab42c07
Commit Graph

4568 Commits

Author SHA1 Message Date
Danny Tuppeny de918b2a0c [analysis_server] Use existing context when computing edits for an LSP fix-all request 
Fixes https://github.com/Dart-Code/Dart-Code/issues/3469.

Change-Id: I28812eda6b3f2263c0a341309719e8adeb1a143e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/206784
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2021-07-14 15:04:30 +00:00
Konstantin Shcheglov 79327c9f05 Make ResolvedUnitResult.content/unit non-nullable. 
Change-Id: Ia79567d248f2c91290bfdf8204ea7e9f3dc85fa4
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/206668
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2021-07-14 02:33:10 +00:00
Konstantin Shcheglov c6d59bdc6a Create ErrorsResultImpl() for errors in non-Dart files in EditDomainHandler. 
So that we don't need to keep `ResolvedUnitResultImpl.unit` nullable.

Change-Id: I498c6a7e53df8e8844ce1cfe5d52c4f2cb58958b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/206666
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2021-07-13 22:42:49 +00:00
Konstantin Shcheglov 57ce1255ad Change AnalysisDriver.results to Stream<Object>. 
This change is necessary to make `ResolvedUnitResult.unit`
non-nullable.

AnalysisDriver is not API, looking into google3 it seems that there
are no `results` usage outside of analyzer and analysis_server. So,
it should be also de-facto not a breaking change.

I'm somewhat in doubt, maybe add `SomeResult` and use it instead of
`Object` here. This interface should be them implemented by all
other result interfaces, such `SomeFileResult`, `SomeResolvedUnitResult`,
etc.

Change-Id: I2912ed2ddf23753757ff2d85d56193fa411f1225
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/206580
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2021-07-13 00:24:26 +00:00
Konstantin Shcheglov cac96f7f8d Rename AnalysisSession.getXyz2() into getXyz(). 
Change-Id: Ia76aafc6a1190dcdca026097c364270389f2860a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/206565
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2021-07-12 22:42:58 +00:00
Konstantin Shcheglov a9618ac795 Make ResolvedLibraryResult.element/units non-nullable. 
Change-Id: Ie20c2363b43555573843c038c15c0d55bcf39579
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/206563
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2021-07-12 20:48:37 +00:00
Konstantin Shcheglov 672d66cea0 Make AnalysisResult.path non-nullable. 
Change-Id: I861643f6c5493b6990c0bacddd81643aaba8e368
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/206560
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2021-07-12 18:21:11 +00:00
Brian Wilkerson 0cd008082b Remove nested const keywords when adding a const keyword 
Change-Id: I44a14360f0d223612d5ba1437546c59286f96096
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/206440
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2021-07-10 19:27:00 +00:00
pq edb0220277 quick fix for avoid_unnecessary_containers 
Fixes: https://github.com/dart-lang/sdk/issues/45922

Change-Id: Icddecacce88f725bfa72a5b4c0a667250ba268bd
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/206420
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
 2021-07-09 22:43:20 +00:00
pq 341facafc7 fix for sized_box_for_whitespace 
Fixes: https://github.com/dart-lang/sdk/issues/45928

Change-Id: I7755d75267c91f614518e8a47eb1aa12a76628d5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/206401
Commit-Queue: Phil Quitslund <pquitslund@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2021-07-09 21:56:25 +00:00
pq 3fb1586b28 quick fix for prefer_const_literals_to_create_immutables 
see: https://github.com/dart-lang/sdk/issues/45932

Fixes: https://github.com/dart-lang/sdk/issues/45924

Change-Id: I98d89e9f98b72c333f9bb274b84730d68b71e71f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/206102
Commit-Queue: Phil Quitslund <pquitslund@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2021-07-09 01:29:20 +00:00
pq 427e51697d quick fix for prefer_void_to_null 
Fixes: https://github.com/dart-lang/sdk/issues/45927

Change-Id: Iac9d5427ef89d51d082ea967febe9cb5597d6525
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/206103
Commit-Queue: Phil Quitslund <pquitslund@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2021-07-09 00:01:44 +00:00
Brian Wilkerson 7aa46618ae Add a fix for prefer_initializing_formals 
Fixes: https://github.com/dart-lang/sdk/issues/45925

Change-Id: I8b4aa081cb54de24879a2035a378409a816d0873
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/206325
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Phil Quitslund <pquitslund@google.com>
 2021-07-08 23:47:44 +00:00
Brian Wilkerson ea78e2baa8 Clean up the hasFix function 
The function was likely far out of date, and this way we don't need to
update it every time we add a fix.

Change-Id: I02ba3e7eade48cab2d427b3cee7861a2183c462f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/206301
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2021-07-08 22:09:23 +00:00
Brian Wilkerson a9147cc8b1 Add a resourceProvider getter to ChangeWorkspace 
This also cleans up the code that prompted the change to use the new
getter (and removes an unnecessary method).

Change-Id: Ie5763822ac82b8cf935b689b6d19aea3298b54ec
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/206300
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2021-07-08 18:34:03 +00:00
Parker Lougheed 7e21736935 Introduce a quick fix for prefer_final_parameters 
Change-Id: I63bd7b37325a44fbb6066d19ac4e358b675c58e9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/206160
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2021-07-08 14:30:24 +00:00
Danny Tuppeny c2f5625fa7 [analysis_server] Swap from dynamic to Object? in LSP generated code 
Change-Id: Ib8ce2c722806b53b727d256c73859becbc1dbd11
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/206120
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2021-07-07 17:14:34 +00:00
Brian Wilkerson fc22bf9f1f Add the first quick fix for pubspec.yaml files 
Change-Id: Ifeb59abe63b063fabc3338493d9ff18c0aa61c80
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/205980
Reviewed-by: Phil Quitslund <pquitslund@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2021-07-07 14:53:01 +00:00
Brian Wilkerson adcef136a6 The dart fix command should not modify generated files 
Change-Id: I485b0b0d1b99e5105402f12ad19d707f169df71a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/205900
Reviewed-by: Phil Quitslund <pquitslund@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2021-07-03 05:25:35 +00:00
Brian Wilkerson 4961455641 Update create noSuchMethod fix to also add an override annotation 
Closes: https://github.com/dart-lang/sdk/issues/46556
Change-Id: I395777947d0dc7f08681f46e3136f56f9ec800a3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/205883
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2021-07-02 23:22:05 +00:00
pq fe7ca0f4bc fix tool link 
Change-Id: I34b2a5a624190df3c41b7ece0640e2978445fd3a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/205885
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
 2021-07-02 22:00:05 +00:00
Konstantin Shcheglov 930895e8a2 Breaking changes for analyzer version 2.0.0 
Latest google3 presubmit looks green.
https://test.corp.google.com/ui#id=OCL:374078884:BASE:382671882:1625203035014:dc4c1c68

Change-Id: I12f6a8a27b8783652e3a2c16d2f39a672dee4eb1
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/185903
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2021-07-02 19:02:44 +00:00
Brian Wilkerson 38c1d4aaf8 Remove support for the deprecated dartfix tool 
Change-Id: I848334cab0dbebe121198bc91ade3a8f68c5f7b7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/205880
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2021-07-02 18:30:24 +00:00
Danny Tuppeny 85d455fbad [analysis_server] Add source.fixAll source command for LSP 
Change-Id: I2deac95e665a19065a7ef1d8c1f79485497c9de2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/205680
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2021-07-01 17:56:47 +00:00
Danny Tuppeny dc66d5df62 [analysis_server] Include documentation URLs for diagnostic codes in LSP diagnostics 
Fixes https://github.com/Dart-Code/Dart-Code/issues/3442

Change-Id: Iad741befd31eb1894ca0e45e65dc78902e8ed995
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/205642
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2021-07-01 14:57:18 +00:00
Danny Tuppeny f7bb46fced [analysis_server] Create correct relative URIs on Windows in create_file fix 
Change-Id: I69c4be3308ca79f81d2f20c2192adceaeae22668
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/205161
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2021-06-28 22:27:42 +00:00
Brian Wilkerson 47da8db2f6 Add a fix for the use_key_in_widget_constructors lint 
Closes: https://github.com/dart-lang/sdk/issues/45931
Change-Id: I9b4b3275cd5d7f5ca7e1849f3ec5951f14be9cd6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/205040
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2021-06-28 21:07:20 +00:00
Brian Wilkerson f5b28a83e8 Fix a bug in both add_missing_enum_case_clauses and add_missing_enum_like_case_clauses 
We should rename ClassMemberLocation to reflect the wider usage, but I
thought it would be better to do that in a separate CL.

Closes: https://github.com/dart-lang/sdk/issues/38693
Change-Id: I657f7945022b09eb8deb89d8f2f5d43164fe53cb
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/205061
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2021-06-28 18:04:52 +00:00
Danny Tuppeny 5dbf8992ed [analysis_server] Include file path in generated "part of" statements for unnamed libraries 
Fixes https://github.com/Dart-Code/Dart-Code/issues/3268.

Change-Id: Ic681da09d0161e2e432959989db8c8002b1669a9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/204981
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2021-06-28 17:13:41 +00:00
Brian Wilkerson 86e3c1b231 Add a fix for the unnecessary_string_escapes lint 
Closes: https://github.com/dart-lang/sdk/issues/45930
Change-Id: I7b50756256867174aa11adf7d29a67d2cb012839
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/205060
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2021-06-28 16:05:02 +00:00
Brian Wilkerson 0e4c640451 Suggest void as a return type in existing generic function types 
Change-Id: I88c37e5ce273de2e9598b182fc5fb61066c11740
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/204600
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2021-06-23 14:04:21 +00:00
Brian Wilkerson 9b4ff5e5a6 Fix the extract method refactoring to correctly handle nullable return types 
Change-Id: I2a885887a8d871f0c61afd6648843b914c59022d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/204626
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2021-06-23 01:10:07 +00:00
Devon Carew 4f5d4731c5 [analysis server] update the text for an error message 
Change-Id: Ia7d6aded597409f1c5afabb06dc7c479ff9b4f44
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/204624
Commit-Queue: Devon Carew <devoncarew@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2021-06-23 00:01:57 +00:00
Brian Wilkerson 56bf5230ca Enhance the AddTypeAnnotation fix to support prefer_typing_uninitialized_variables 
When a local variable doesn't have an initializer we now look for
assignments to find a reasonable type. This will not only allow this
lint to be fixed but will increase the number of places the assist is
offered.

Change-Id: Ib278477d277557aff7d2ddbcca3230f2a0a144b5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/204521
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Samuel Rawlins <srawlins@google.com>
 2021-06-22 22:50:37 +00:00
Danny Tuppeny c073fb6257 [analysis_server] Switch to checking isSynthetic for argument lists in LSP completions 
Change-Id: Ie57717baff1b20b6c9a9c17dd12723eecf4bfc6c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/204405
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2021-06-22 19:02:22 +00:00
Danny Tuppeny ad6c732663 [analysis_server] Support LSP SignatureHelp for type argument lists 
See https://github.com/Dart-Code/Dart-Code/issues/2834.

Change-Id: Idce0d0b133b1f40c1953e5f1c5f4531701a68c56
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/204404
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2021-06-22 14:56:44 +00:00
Brian Wilkerson 9da9768992 Use the context type to determine whether to suggest functions returning void 
Change-Id: I78dac1852cb08f01927ef7fc2603d7de0b3dd891
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/204220
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2021-06-19 20:46:24 +00:00
Brian Wilkerson 2afc8161f4 Add a fix for exhaustive_cases that adds cases for the missing constants 
Closes: https://github.com/dart-lang/sdk/issues/45923
Change-Id: I641c016dc73153d521f43c9ce4d333b50b4a702c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/204261
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2021-06-19 20:17:03 +00:00
Konstantin Shcheglov f398c9f3c1 Fix pre-existing HintCode.UNNECESSARY_TYPE_CHECK_TRUE in analyzer/ and friends. 
Change-Id: I1019d9c083b825a9f3418bc56ed410e0ba5501fe
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/204085
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2021-06-18 16:07:26 +00:00
Brian Wilkerson 9ecdfcc8f3 Improve the suggested keywords in formal parameters 
Change-Id: Iea099dc140865b109309cd932735f2d0a65fcfd0
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/204080
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2021-06-18 15:49:31 +00:00
Danny Tuppeny 75bcd5ca33 [analysis_server] Improve coloring of invalid/unresolved methods in LSP semantic tokens 
See https://github.com/Dart-Code/Dart-Code/issues/3412.

Change-Id: Icc44ff0537122d6d2211d64037666ecb58a28bd6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/203940
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2021-06-17 20:15:21 +00:00
Danny Tuppeny 41af64d0f4 [analysis_server] Use correct EOL characters for document in ignore_diagnostic fix 
Change-Id: I36f23bf164e2005a99181a4623a5dbd7acf94cda
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/203980
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2021-06-17 17:36:11 +00:00
Danny Tuppeny 2e411e5957 [analysis_server] Add quick-fixes to ignore lints/hints for line/file 
Change-Id: I773704cccffc7a7da169b3d759b80b07267c88ff
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/203760
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2021-06-17 15:37:11 +00:00
Konstantin Shcheglov ccb3943e48 Check for workspaces consistency after analysis contexts creation. 
Bug: https://github.com/dart-lang/linter/issues/2694
Change-Id: I13cae115e48ae794e0751b6099f864ca9d202cdc
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/203821
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2021-06-16 00:02:53 +00:00
Danny Tuppeny f4b4882f48 [analysis_server] Add highlights/semantic token support for conditional imports/exports 
Fixes https://github.com/Dart-Code/Dart-Code/issues/3395.

Change-Id: Ic5b9adbb4f92e5fd59c6f09dddd1e0b1b827d5c0
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/203560
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2021-06-15 16:29:12 +00:00
Danny Tuppeny f00812b5ce [analysis_server] Set CompletionSuggestionKind for extension members 
Change-Id: Ie5589ae1c3794fd8b2d335192009e65f2129a0d7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/203563
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2021-06-15 16:26:02 +00:00
Brian Wilkerson f06f09246e Suggest void in a type declaration list to support function types 
Change-Id: I2514cfd80cec6cbec7703009ba5a12df4640c560
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/203663
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2021-06-15 00:49:03 +00:00
Brian Wilkerson cbdb20d417 Erase nullability after a null-aware operator when matching extensions 
Change-Id: I6852f6acc4fb27bdfa3686b214c7c34d40c18bfb
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/203664
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2021-06-15 00:41:09 +00:00
Danny Tuppeny 5c0b3877e3 [analysis_server] Prevent extension methods showing in completion in comments 
Fixes https://github.com/dart-lang/sdk/issues/46351.

Change-Id: I762ccccceb0ec0fa453f5acb727e8c94472ac45d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/203501
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2021-06-14 15:30:33 +00:00
Danny Tuppeny d75becf4ac [analysis_server] Enable multiline element descriptions for all hovers 
Change-Id: I5521cb09172b5eee639a4d3e9e21eb5871d6a86f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/202971
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2021-06-13 15:50:32 +00:00