Srujan Gaddam
28b8cb34d3
[dart:html] Unify shared attribute metadata from MDN
...
browser-compat-data includes info on elements as both part of the
Web API and the individual tagged elements. The scripts would default
to whatever was processed last instead of trying to unify any conflicts
that may come up with the different sources of truth. This CL addresses
that issue by choosing the "stricter" of the two versions.
Change-Id: Id3437c14276faf8af3fe41d7a6eb83defc9bd0b0
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/155844
Commit-Queue: Srujan Gaddam <srujzs@google.com >
Reviewed-by: Sigmund Cherem <sigmund@google.com >
2020-08-25 23:48:43 +00:00
Konstantin Shcheglov
ba92b78acd
Move errors from StaticWarningCode to CompileTimeErrorCode.
...
Bug: https://github.com/dart-lang/sdk/issues/42821
Change-Id: I153c48d7a2e4a02026928e6203aacf8f2dc029ba
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/155849
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2020-07-26 04:19:25 +00:00
Srujan Gaddam
63a57a76ce
[dart:html] Revert "[dart:html] Revert commits using MDN compatibility info"
...
This reverts commit f8ff12008e .
This CL is a revert of the initial revert and should be landed once
Flutter changes have been merged to handle the changes here.
Change-Id: I300a5efd776bf2a596743971f4e15ad62da77f5a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/153368
Commit-Queue: Srujan Gaddam <srujzs@google.com >
Reviewed-by: Sigmund Cherem <sigmund@google.com >
2020-07-14 23:18:43 +00:00
Srujan Gaddam
f8ff12008e
[dart:html] Revert commits using MDN compatibility info
...
This reverts commits aff77e7e..e24f205d.
Due to a breakage in a Flutter roll, this CL stack needs to be
reverted. It should be reintroduced with changes to Flutter code to
compile with the changes in dart:html.
Breakage: https://github.com/flutter/engine/runs/828631927
Change-Id: I9c93c4eab823337d09d2e347015ad9ec402f2038
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/152910
Auto-Submit: Srujan Gaddam <srujzs@google.com >
Reviewed-by: Sigmund Cherem <sigmund@google.com >
Reviewed-by: Jake Macdonald <jakemac@google.com >
Commit-Queue: Sigmund Cherem <sigmund@google.com >
Commit-Queue: Jake Macdonald <jakemac@google.com >
2020-07-02 01:33:18 +00:00
Srujan Gaddam
974be4805c
[dart:html] Modify tests to compile with compat changes
...
Changes tests that use native getters that have changed to
nullable.
Change-Id: I469b283f65dc45b2359a850b09fc7f32f88086fa
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/152405
Reviewed-by: Sigmund Cherem <sigmund@google.com >
2020-07-01 22:06:34 +00:00
Srujan Gaddam
dea080253a
[dart:html] Migrate custom tests to NNBD
...
DDC should skip some of these by default from the status file,
so these were tested using dart2js in strong mode.
Change-Id: I10a9096a9af7e394c416d26530ac42646991ddc1
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/139964
Reviewed-by: Bob Nystrom <rnystrom@google.com >
2020-04-03 17:43:57 +00:00
Srujan Gaddam
1d44ef07c1
[dart:html] Copy and rename lib_2/html to NNBD.
...
Added annotations such that these tests won't fail when submitted.
Added copyright notices if there isn't a copyright notice.
Change-Id: I51ae347d44875cdfa1c6d0dad1bc41e00ea443bd
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/139963
Commit-Queue: Srujan Gaddam <srujzs@google.com >
Reviewed-by: Sigmund Cherem <sigmund@google.com >
2020-04-03 00:36:56 +00:00