dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
82,532 Commits 2 Branches 0 Tags
5e990591b9504c168d94de964560765633608ced
Commit Graph

145 Commits

Author SHA1 Message Date
Ahmed Ashour d041cf0478 Remove extra the, be and of 
Fixes #https://github.com/dart-lang/sdk/issues/47504

TEST=No tests needed, only comments affected.

Change-Id: Ie096307b5ce314d328fea6780f396aaa226ad3b0
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/216182
Reviewed-by: Lasse R.H. Nielsen <lrn@google.com>
Commit-Queue: Lasse R.H. Nielsen <lrn@google.com>
 2021-10-20 09:29:01 +00:00
Danny Tuppeny 1bfa0bb8dd [dds] Wrap DAP dart.log message in an object for future extensibility 
Change-Id: Ifbff825751f7456645b28f23684447e1271e4ece
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/216290
Reviewed-by: Ben Konyi <bkonyi@google.com>
Commit-Queue: Ben Konyi <bkonyi@google.com>
 2021-10-12 15:17:00 +00:00
Danny Tuppeny 1cc4c11257 Add changelog for DAP classes + some docs on DAP 
Change-Id: Ic74f02ec29b45c70dcf71f5d395d2bf80b85a269
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/215552
Reviewed-by: Ben Konyi <bkonyi@google.com>
 2021-10-06 12:54:18 +00:00
Danny Tuppeny 98ee47a11a [dds] Export DAP classes required to build new debug adapters externally 
Change-Id: I7bb05b2f467bad5e522898dfaa3d0f1e74c42b58
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/215081
Reviewed-by: Ben Konyi <bkonyi@google.com>
Commit-Queue: Ben Konyi <bkonyi@google.com>
 2021-10-01 16:31:34 +00:00
Danny Tuppeny df67dc892b [dds] Add some basic test reporting for DAP test adapter 
Change-Id: I39ca29ee5809fd0d6ef30ee163298f66749bed0b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/215080
Reviewed-by: Ben Konyi <bkonyi@google.com>
Commit-Queue: Ben Konyi <bkonyi@google.com>
 2021-10-01 16:31:34 +00:00
Ben Konyi b8533e6b09 [ package:dds ] Fix issue where cancelling multiple streams with the same name would throw a StateError 
Fixes https://github.com/flutter/devtools/issues/3302

TEST=test/regress_devtools_issue_3302_test.dart

Change-Id: Ica0665c8a48cdb881ecdf7e3985660513c4b98b8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/214662
Reviewed-by: Kenzie Schmoll <kenzieschmoll@google.com>
Commit-Queue: Ben Konyi <bkonyi@google.com>
 2021-09-27 16:35:53 +00:00
Danny Tuppeny 4389cf7bba [dds] Add support for services/service extensions to DAP 
Change-Id: I4f63fd60bf2128c8e88c999c0963b8a1e5304178
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/214281
Reviewed-by: Ben Konyi <bkonyi@google.com>
Commit-Queue: Ben Konyi <bkonyi@google.com>
 2021-09-24 11:53:15 +00:00
Danny Tuppeny b68ccc9a39 [dartdev] Add a "dart debug_adapter" command to run the DAP server from DDS 
Change-Id: Icf4442929f848f7f927e84c999f09206e3fd0704
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/213640
Reviewed-by: Ben Konyi <bkonyi@google.com>
Commit-Queue: Ben Konyi <bkonyi@google.com>
 2021-09-17 16:09:49 +00:00
Danny Tuppeny 35d5f857ab [dds] Add a DAP debug adapter that runs "dart test" and passes package:test JSON back 
Change-Id: I2619df1d514529457a2035f40eecc5b33f52abd2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/212576
Reviewed-by: Ben Konyi <bkonyi@google.com>
Commit-Queue: Ben Konyi <bkonyi@google.com>
 2021-09-15 15:11:25 +00:00
Ahmed Ashour d6975c1905 master branch to main 
Fixes #47190

TEST=None, only markdown files where edited.

Change-Id: Ife204f9c792b6bce30d0cd7bf2260ced11c8f2b4
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/213049
Reviewed-by: Nicholas Shahan <nshahan@google.com>
Reviewed-by: Alexander Thomas <athom@google.com>
 2021-09-15 06:22:23 +00:00
Lasse R.H. Nielsen f7e4886ad2 Make dds package not use ?. for a static call. 
This should have been a warning since null safety
(or arguably since 2.0), but analyzer and compilers
didn't display the warning.

Prepare the package for such usage now being enforced and a warning
or even an error.

Change-Id: I73a852b88dabcaa1396aeec08f33856668e31fe9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/212830
Commit-Queue: Lasse R.H. Nielsen <lrn@google.com>
Reviewed-by: Danny Tuppeny <danny@tuppeny.com>
Reviewed-by: Ben Konyi <bkonyi@google.com>
 2021-09-09 15:24:01 +00:00
Danny Tuppeny e161187728 [dds] Refactor some DAP classes in preperation for "dart test" adapter 
Change-Id: Ice48b45c0ad11a1981e8e4115bb8de6d009d7b5a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/212062
Reviewed-by: Ben Konyi <bkonyi@google.com>
Commit-Queue: Ben Konyi <bkonyi@google.com>
 2021-09-07 14:03:03 +00:00
Ben Konyi 3ff52042ea [ package:dds ] Silently handle exceptions raised within RPC request 
handlers

Fixes https://github.com/flutter/flutter/issues/84113

Change-Id: I416308845c5c7f9a1bb547b6429f1e9d49393583
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/212268
Reviewed-by: Zach Anderson <zra@google.com>
Commit-Queue: Ben Konyi <bkonyi@google.com>
 2021-09-01 23:16:07 +00:00
Ben Konyi 492d061332 [ package:dds ] Add missing RPCs and responses to DDS protocol 
Change-Id: I884c62e2be4159bc588ffa1bba3d8695b0cef3f2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/208300
Reviewed-by: Ben Konyi <bkonyi@google.com>
 2021-09-01 22:31:37 +00:00
Danny Tuppeny 2d8764a557 [dds] Don't automatically resume when attaching to processes via DAP 
Change-Id: I8b0fd4b36a9dd229226046a74e031de005908417
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/210920
Reviewed-by: Ben Konyi <bkonyi@google.com>
Commit-Queue: Ben Konyi <bkonyi@google.com>
 2021-08-25 16:37:52 +00:00
Danny Tuppeny eff9280e55 [dds] Add support for vmServiceInfoFile to DAP attachRequest 
Change-Id: Ibc3e4aef140cb2a2b061bb91b0328230ca70053d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/210861
Reviewed-by: Ben Konyi <bkonyi@google.com>
Commit-Queue: Ben Konyi <bkonyi@google.com>
 2021-08-25 00:47:34 +00:00
Ben Konyi c7fe9ada2f Reland "[ package:dds ] Add support for caching CPU samples based on UserTag" 
This reverts commit ada4278fd5.

TEST=pkg/dds/test/get_cached_cpu_samples_test.dart

Change-Id: I771410c8647fc1eb721c5aeb325c7a595430435c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/209120
Commit-Queue: Ben Konyi <bkonyi@google.com>
Reviewed-by: Siva Annamalai <asiva@google.com>
 2021-08-25 00:04:04 +00:00
Danny Tuppeny 63f1fb02a4 [dds] Support attachRequest in Dart CLI DAP 
Change-Id: I4bcd7483ab9f3ed8dd839bd69b59d21f8139c582
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/210724
Reviewed-by: Ben Konyi <bkonyi@google.com>
Commit-Queue: Ben Konyi <bkonyi@google.com>
 2021-08-23 23:22:48 +00:00
Danny Tuppeny 30a3b9c716 [dds] Improve error handling of calling getters + toString() display in DAP variables 
Change-Id: I5b93667925a7f4a6da9edd8f5c94e56b1dbff6d9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/209963
Reviewed-by: Ben Konyi <bkonyi@google.com>
Commit-Queue: Ben Konyi <bkonyi@google.com>
 2021-08-18 21:07:04 +00:00
Danny Tuppeny 7a4fbdf88f [dds] Support logging VM Service traffic to the client from DAP 
Change-Id: Id9f6b2158dcf1603468b989ed2f900b390b9b259
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/209546
Reviewed-by: Ben Konyi <bkonyi@google.com>
Commit-Queue: Ben Konyi <bkonyi@google.com>
 2021-08-18 20:55:53 +00:00
Danny Tuppeny 52e94d1bbb [dds] Improve DAP evaluation errors for Watch window 
+ allow trailing semicolons in evaluation expressions.

Change-Id: Id7b7305ecaf7035ae445100a5f1e6d7010301067
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/209960
Reviewed-by: Ben Konyi <bkonyi@google.com>
Commit-Queue: Ben Konyi <bkonyi@google.com>
 2021-08-18 20:55:23 +00:00
Devon Carew 3365b77ac2 use code from package:devtools_shared 
Change-Id: Ie16400c7c216fb165fb5c65a0150e37b5512ef69
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/210161
Reviewed-by: Ben Konyi <bkonyi@google.com>
Commit-Queue: Devon Carew <devoncarew@google.com>
 2021-08-13 21:54:01 +00:00
Danny Tuppeny c010c1d54f [dds] Add support for showing Maps in variablesRequests for DAP 
Change-Id: I92379f4f9d300d2cdbd209bb77259acdcad7a089
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/209914
Reviewed-by: Ben Konyi <bkonyi@google.com>
 2021-08-12 20:27:30 +00:00
Danny Tuppeny 57e41b122e [dds] Include evaluateNames in returned variables 
Change-Id: I26173d7b618baf431a9fa01d6e8461800427b015
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/209912
Reviewed-by: Ben Konyi <bkonyi@google.com>
Commit-Queue: Ben Konyi <bkonyi@google.com>
 2021-08-12 20:27:30 +00:00
Danny Tuppeny 659464ac3c [dds] Add support for Log Points to DAP 
Change-Id: I74dca1871d3c6b826aafecbb6425604d43b9262f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/209704
Reviewed-by: Ben Konyi <bkonyi@google.com>
Commit-Queue: Ben Konyi <bkonyi@google.com>
 2021-08-12 00:32:27 +00:00
Ben Konyi 83283a553e [ package:dds ] Prevent invalid DDS instance from being returned after 
shutdown during initialization

Subtle event queue execution ordering could result in an invalid DDS
instance being returned with the HTTP server instance not yet being
initialized. Calling shutdown() on this instance would cause a
LateInitializationError when trying to cleanup the server.

Fixes https://github.com/flutter/flutter/issues/86361

Change-Id: Idf1f271925d244811af4b61b3161ddcbc05c52eb
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/209846
Reviewed-by: Siva Annamalai <asiva@google.com>
Commit-Queue: Ben Konyi <bkonyi@google.com>
 2021-08-11 23:36:27 +00:00
Danny Tuppeny 5447c3981e [dds] Add support for conditional breakpoints in DAP 
Change-Id: I5f28337b0371f4efb52b2ba169bf27e1d61425c3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/209702
Reviewed-by: Ben Konyi <bkonyi@google.com>
Commit-Queue: Ben Konyi <bkonyi@google.com>
 2021-08-10 19:33:20 +00:00
Danny Tuppeny 215efd6642 [dds] Mark not-debuggable frames as deemphasized in DAP 
This allows user code to stand out better in the stack trace when debugging SDK/External packages is disabled.

Change-Id: I1740001f2aa085e3bc2069d788e1c53e71386866
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/209641
Reviewed-by: Ben Konyi <bkonyi@google.com>
Commit-Queue: Ben Konyi <bkonyi@google.com>
 2021-08-10 16:54:23 +00:00
Danny Tuppeny de5986ef24 [dds] Add tests for DAP exception behaviour 
Change-Id: I524a7bdebd0c4f572db67550cd42f4ba5118cfc3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/209640
Reviewed-by: Ben Konyi <bkonyi@google.com>
Commit-Queue: Ben Konyi <bkonyi@google.com>
 2021-08-09 22:44:09 +00:00
Danny Tuppeny 3d3a48ff9a [dds] Add support for DAP sourceRequest to download source from the VM 
Change-Id: Icb639c7008d51d6ffbecb95e362cc07c81993424
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/209103
Reviewed-by: Ben Konyi <bkonyi@google.com>
Commit-Queue: Ben Konyi <bkonyi@google.com>
 2021-08-09 16:48:08 +00:00
Danny Tuppeny 9e928c8587 [dds] Handle DAP debug termination more reliably based on whether there's an active process 
Change-Id: I8a14074f242dd0719624d610fa6d1768ecb4d152
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/209545
Reviewed-by: Ben Konyi <bkonyi@google.com>
Commit-Queue: Ben Konyi <bkonyi@google.com>
 2021-08-09 16:01:29 +00:00
Ivan Inozemtsev dee7d252d4 Inline non-functional type alias 
Reason: b/195648511, non-functional type aliases are not supported by
some internal infra
Change-Id: I1c164f4ecf23ac22a36cabc630bf7e8f762d4849
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/209541
Reviewed-by: Michal Terepeta <michalt@google.com>
Commit-Queue: Ivan Inozemtsev <iinozemtsev@google.com>
 2021-08-09 10:26:28 +00:00
Ben Konyi 4d4f69ab95 Reland "[ package:dds ] Add locking when modifying DDS state via client requests" 
This reverts commit 0b0bb9940d.

Fixes https://github.com/dart-lang/sdk/issues/46826

TEST=dds/test/regress_45569_test.dart and service_2/break_on_function_many_child_isolates_test/dds

Change-Id: I84ac047adb7b20a5392744993b22895bffacce9a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/209262
Commit-Queue: Ben Konyi <bkonyi@google.com>
Reviewed-by: Anna Gringauze <annagrin@google.com>
 2021-08-07 15:16:49 +00:00
Danny Tuppeny a6176ec3dd [dds] Support delegating running the debugee to the editor in DAP using runInTerminal 
Change-Id: I9fd435ee43ca9ae0d1e38bdffd9121157d33b730
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/208654
Reviewed-by: Ben Konyi <bkonyi@google.com>
Commit-Queue: Ben Konyi <bkonyi@google.com>
 2021-08-06 16:42:17 +00:00
Ben Konyi 0b0bb9940d Revert "[ package:dds ] Add locking when modifying DDS state via client requests" 
This reverts commit 0ecfc7da6f.

Reason for revert: https://github.com/dart-lang/sdk/issues/46826

Original change's description:
> [ package:dds ] Add locking when modifying DDS state via client requests
>
> Fixes https://github.com/dart-lang/sdk/issues/46696
>
> Change-Id: I666b59a0661f4df3b1f0a47aba52096133f5fbb7
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/209140
> Reviewed-by: Anna Gringauze <annagrin@google.com>

TBR=bkonyi@google.com,annagrin@google.com

Change-Id: Iec89181372a2fc1b8a461e616bbcd23dd6bbd72d
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/209280
Reviewed-by: Ben Konyi <bkonyi@google.com>
Commit-Queue: Ben Konyi <bkonyi@google.com>
 2021-08-05 21:32:42 +00:00
Ben Konyi 0ecfc7da6f [ package:dds ] Add locking when modifying DDS state via client requests 
Fixes https://github.com/dart-lang/sdk/issues/46696

Change-Id: I666b59a0661f4df3b1f0a47aba52096133f5fbb7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/209140
Reviewed-by: Anna Gringauze <annagrin@google.com>
 2021-08-05 17:56:01 +00:00
Ben Konyi ada4278fd5 Revert "Reland "[ package:dds ] Add support for caching CPU samples based on UserTag"" 
This reverts commit 1796160606.

Reason for revert: Still seeing failures.

Original change's description:
> Reland "[ package:dds ] Add support for caching CPU samples based on UserTag"
>
> This reverts commit 4160747ef6.
>
> It seems like 9397b8ff05 should have fixed the original failures we were seeing and the failing bots in question seem to be passing when running try jobs.
>
> TBR=asiva@ (discussed offline)
>
> TEST=Existing service tests + get_cached_cpu_samples_test
> Change-Id: I1c50c0e79375df819a0bd68e68ac28c3064874c8
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/208441
> Reviewed-by: Ben Konyi <bkonyi@google.com>
> Commit-Queue: Ben Konyi <bkonyi@google.com>

TBR=bkonyi@google.com,asiva@google.com

Change-Id: Ic522ab61b430673533c94ecd0c91bee569a0add6
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/208960
Reviewed-by: Ben Konyi <bkonyi@google.com>
Commit-Queue: Ben Konyi <bkonyi@google.com>
 2021-08-04 17:32:38 +00:00
Ben Konyi 1796160606 Reland "[ package:dds ] Add support for caching CPU samples based on UserTag" 
This reverts commit 4160747ef6.

It seems like 9397b8ff05 should have fixed the original failures we were seeing and the failing bots in question seem to be passing when running try jobs.

TBR=asiva@ (discussed offline)

TEST=Existing service tests + get_cached_cpu_samples_test
Change-Id: I1c50c0e79375df819a0bd68e68ac28c3064874c8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/208441
Reviewed-by: Ben Konyi <bkonyi@google.com>
Commit-Queue: Ben Konyi <bkonyi@google.com>
 2021-08-03 19:18:59 +00:00
Danny Tuppeny 874f1db1f9 [dds] Support debugging "just my code" in DAP using 'debugExternalPackageLibraries=false' 
Change-Id: I82556df94722b72240383f57524a5692d176ca11
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/208646
Reviewed-by: Ben Konyi <bkonyi@google.com>
Commit-Queue: Ben Konyi <bkonyi@google.com>
 2021-08-03 14:38:49 +00:00
Alexander Markov 4160747ef6 Revert "[ package:dds ] Add support for caching CPU samples based on UserTag" 
This reverts commits 746b8f1f5c and
9ee2259fde.

Reason for revert: https://github.com/dart-lang/sdk/issues/46746

Original change's description:
> [ package:dds ] Add support for caching CPU samples based on UserTag
>
> DDS can be configured to listen for CPU sample events and cache samples
> that were collected while certain UserTags are active. These cached
> samples are stored in a ring buffer and are stored until the isolate
> shuts down.
>
> TEST=pkg/dds/test/get_cached_cpu_samples_test.dart
>
> Change-Id: Ib20770f59f1672c703413486f87795b3bb23f676
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/207206
> Commit-Queue: Ben Konyi <bkonyi@google.com>
> Reviewed-by: Kenzie Schmoll <kenzieschmoll@google.com>

TEST=ci
TBR=bkonyi@google.com,rmacnak@google.com,kenzieschmoll@google.com

Change-Id: I1b6655ad7e3b10e1145ff545cc90ecf3bc6e092d
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/208341
Commit-Queue: Alexander Markov <alexmarkov@google.com>
Reviewed-by: Siva Annamalai <asiva@google.com>
 2021-07-28 18:00:25 +00:00
Ben Konyi 746b8f1f5c [ package:dds ] Add support for caching CPU samples based on UserTag 
DDS can be configured to listen for CPU sample events and cache samples
that were collected while certain UserTags are active. These cached
samples are stored in a ring buffer and are stored until the isolate
shuts down.

TEST=pkg/dds/test/get_cached_cpu_samples_test.dart

Change-Id: Ib20770f59f1672c703413486f87795b3bb23f676
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/207206
Commit-Queue: Ben Konyi <bkonyi@google.com>
Reviewed-by: Kenzie Schmoll <kenzieschmoll@google.com>
 2021-07-28 00:33:33 +00:00
Danny Tuppeny 248e943b97 [dds] Expand truncated strings from dart:developer log() calls in DAP output 
Change-Id: I31338b00daff33a5428e4b2229273ee8289f1c5e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/206540
Reviewed-by: Ben Konyi <bkonyi@google.com>
 2021-07-22 14:38:21 +00:00
Danny Tuppeny 33c3cfc28a [dds] Support changing DAP debug settings after the session has started 
Change-Id: I287457296408ae49950cef501780054260b57566
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/205540
Reviewed-by: Ben Konyi <bkonyi@google.com>
 2021-07-22 14:38:21 +00:00
Danny Tuppeny 6b4fc2670c [dds] Switch DAP server mode to directly using stdin/stdout 
Change-Id: Id2a8d8c9274b96cf32788e11d4452954a4f9c091
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/205500
Reviewed-by: Ben Konyi <bkonyi@google.com>
 2021-07-22 14:38:21 +00:00
Ben Konyi a99b92c252 [ package:dds ] Avoid races while handling errors during startup 
Avoids a LateInitializationError that could occur when the VM service
connection goes down during DDS startup. Done by delaying error
reporting until after DDS has completed its initial startup flow,
ensuring that all relevant state has already been initialized when we
try to cleanup.

Fixes https://github.com/flutter/flutter/issues/86361

Change-Id: I2b357bfb95c759d301ab48bce9fe1c28871d5e08
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/206672
Commit-Queue: Ben Konyi <bkonyi@google.com>
Reviewed-by: Zach Anderson <zra@google.com>
 2021-07-14 23:51:46 +00:00
Devon Carew 0512b876b3 replace copied code with references to package:devtools_shared 
Change-Id: I6707f593f643fbf1323f4f24bc76a76f66ed7ec5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/205344
Commit-Queue: Devon Carew <devoncarew@google.com>
Reviewed-by: Ben Konyi <bkonyi@google.com>
 2021-07-12 17:55:04 +00:00
Danny Tuppeny 8f01499793 [dds] Support IPv6 for DAP with --ipv6 flag 
Change-Id: I07c66b79e832f200bf5f27c20930e1ba6a2ebda7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/205261
Reviewed-by: Ben Konyi <bkonyi@google.com>
Commit-Queue: Ben Konyi <bkonyi@google.com>
 2021-07-02 00:04:52 +00:00
Danny Tuppeny c84c21e741 [dds] Support using port=0 for DAP and print the bound host/port in JSON to stdout 
Change-Id: Ib1e99f1004b59cba6fa6970dbddbf5cbe87a8b32
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/205160
Reviewed-by: Ben Konyi <bkonyi@google.com>
Commit-Queue: Ben Konyi <bkonyi@google.com>
 2021-06-28 19:58:32 +00:00
Ben Konyi 0d61348584 [ CLI ] Fix IPv6 VM service support for standalone VM 
The CLI was not providing the ipv6 flag to DDS, resulting in a "Could
not start Observatory" error.

Change-Id: Idff0f525455f121b8f1e89bc4ad20a01cd1165ef
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/204860
Reviewed-by: Ryan Macnak <rmacnak@google.com>
Commit-Queue: Ben Konyi <bkonyi@google.com>
 2021-06-24 19:50:59 +00:00
Danny Tuppeny 06fc5c522e [dds] Spawn DDS in-process with DAP 
+ Switch to package:args CommandRunner
+ Add switches to enable/disable DDS/auth tokens
+ Improve verbose logging for debugging tests
+ Fix a race condition in initial unpausing of Isolates

Change-Id: I7f7ee0ef798e198ee07c1c663bce3edb0b5c7fc9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/204143
Reviewed-by: Ben Konyi <bkonyi@google.com>
Commit-Queue: Ben Konyi <bkonyi@google.com>
 2021-06-24 18:07:49 +00:00