dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
82,532 Commits 2 Branches 0 Tags
5e990591b9504c168d94de964560765633608ced
Commit Graph

187 Commits

Author SHA1 Message Date
Ben Konyi 4de9e805ed [ CLI ] Don't resolve paths as URIs for known SDK artifacts 
Handles cases where the SDK is installed on a path which includes
percent encoded characters. The OS doesn't decode these characters, so
decoding them before trying to load a snapshot with said characters in
their path will result in files not being found.

Fixes https://github.com/dart-lang/sdk/issues/46364

TEST=pkg/dartdev/test/regress_46364_test.dart

Change-Id: I5f78e8a2049cc0c83555528fcc8f41be946141f5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/218082
Reviewed-by: Ryan Macnak <rmacnak@google.com>
 2021-10-27 16:34:00 +00:00
Sigurd Meldgaard ecc6ed1b32 Send resolution analytics from dart pub get/upgrade/... 
Also enables batched analytics (up to 20 events will be sent together in
one request if they are all issued before control is returned to the
async queue).

Change-Id: Ic23429d4981bc33a34cb19ffc00affdd09dfe511
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/217014
Reviewed-by: Jonas Jensen <jonasfj@google.com>
Commit-Queue: Sigurd Meldgaard <sigurdm@google.com>
 2021-10-25 12:35:30 +00:00
Ben Konyi bd067153d5 [ CLI ] Hide exe and aot-snapshot subcommands from dart compile on IA32 
The AOT runtime is not supported on IA32, so generating snapshots and
executables requiring the AOT runtime is not possible on IA32.

Fixes https://github.com/dart-lang/sdk/issues/47177

TEST=pkg/dartdev/test/commands/compile_test.dart

Change-Id: I99e9a16f6a93b3b63b8ed15acc1472f9ca619c08
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/213680
Commit-Queue: Ben Konyi <bkonyi@google.com>
Reviewed-by: Alexander Markov <alexmarkov@google.com>
Reviewed-by: Ryan Macnak <rmacnak@google.com>
 2021-09-24 01:21:08 +00:00
Danny Tuppeny b68ccc9a39 [dartdev] Add a "dart debug_adapter" command to run the DAP server from DDS 
Change-Id: Icf4442929f848f7f927e84c999f09206e3fd0704
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/213640
Reviewed-by: Ben Konyi <bkonyi@google.com>
Commit-Queue: Ben Konyi <bkonyi@google.com>
 2021-09-17 16:09:49 +00:00
Ben Konyi 123950ffa9 [ CLI / VM ] Add support for disabling DDS 
Allows for tooling (e.g., DAP) to spawn their own DDS instance without
having to disable the CLI.

Fixes https://github.com/dart-lang/sdk/issues/47059

TEST=pkg/dartdev/test/commands/run_test.dart

Change-Id: Ie9a4832d424edae67f32560399d3b0a6ca9f1dc0
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/213660
Reviewed-by: Siva Annamalai <asiva@google.com>
Commit-Queue: Ben Konyi <bkonyi@google.com>
 2021-09-16 20:31:45 +00:00
pq dd35db6192 "master->main" migration 
Change-Id: I773e0a60a782f9e6678cea22e2a7d8fae48cffa3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/212869
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
 2021-09-09 18:14:36 +00:00
Konstantin Shcheglov f726874678 Support for --cache in 'dart analyze'. 
Bug: https://github.com/dart-lang/sdk/issues/45267
Change-Id: I503227ac59a3562e79d3654c405debaf5d0c764c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/212420
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2021-09-03 18:43:08 +00:00
Konstantin Shcheglov 78ef2cc217 Support for --packages in 'dart analyze'. 
Bug: https://github.com/dart-lang/sdk/issues/45267
Change-Id: I660de0c80e4f280996b6ce5e90d39aa274997d07
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/212380
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2021-09-03 01:46:25 +00:00
Sigurd Meldgaard ae81cd5dab Deprecate top level pub. 
Also makes the `pub` shell script (and its .bat counterpart)
forward to a `dart __deprecated_pub` command that implements the
old top-level.

This allows us to get rid of pub.dart.snapshot saving ~15 MB in a
unzipped sdk.

The reason for not forwarding directly to `dart pub` is that the
interface is slightly different (for example there is no `dart pub --version`).


The only new commit in pub is: `3c2ce330 Expose toplevel as a command`


Bug: https://github.com/dart-lang/pub/issues/2736
Change-Id: I6eb08d120c4844b3a12bc29544df6a868cd6fcc8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/210582
Commit-Queue: Sigurd Meldgaard <sigurdm@google.com>
Reviewed-by: Jonas Jensen <jonasfj@google.com>
 2021-08-24 08:34:58 +00:00
Devon Carew d7c8e6a9d3 rev the build of devtools; add a 'dart devtools' command 
Change-Id: I98ffbceedd06b3693703518243e231d6a1a66c9a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/210423
Commit-Queue: Devon Carew <devoncarew@google.com>
Reviewed-by: Ben Konyi <bkonyi@google.com>
Reviewed-by: Kenzie Schmoll <kenzieschmoll@google.com>
 2021-08-20 16:25:24 +00:00
Ben Konyi d2855e703e [ CLI ] Default to printing CLI usage message instead of VM usage 
--disable-dart-dev disables this behavior.

Fixes https://github.com/dart-lang/sdk/issues/46411

TEST=pkg/dartdev/test/commands/flag_test.dart

Change-Id: I46b91abc89fc3ec5e06fa7e9aad3939573cff545
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/209264
Commit-Queue: Ben Konyi <bkonyi@google.com>
Reviewed-by: Siva Annamalai <asiva@google.com>
 2021-08-13 23:01:51 +00:00
Ben Konyi cccc0293c5 [ VM ] Send 'dart --help [--verbose]' output to stdout 
This is consistent with the majority of other tools and the CLI
behavior.

Fixes https://github.com/dart-lang/sdk/issues/46412

TEST=pkg/dartdev/test/commands/flag_test.dart

Change-Id: I45a3ddc9728e9cc1a273d4d5f11db74cb8104745
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/204661
Commit-Queue: Ben Konyi <bkonyi@google.com>
Reviewed-by: Ryan Macnak <rmacnak@google.com>
 2021-08-06 16:06:05 +00:00
Jaime Wren 1689a82229 Fix for https://github.com/dart-lang/sdk/issues/46509, modifying the order that dart analyze outputs the analysis error output. 
This change also adds tests for the comparison sorting.

Bug: https://github.com/dart-lang/sdk/issues/46509
Change-Id: Ie568a75c25d0a1e1f76f26f4955de92599f3a68b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/208521
Reviewed-by: Devon Carew <devoncarew@google.com>
Commit-Queue: Jaime Wren <jwren@google.com>
 2021-08-02 17:03:22 +00:00
Jaime Wren 58969783ba Add two Functions to dartdev to allow the extension of cli tool. 
Change-Id: I84e89d2c5404949a5b4aa27c17ea793a5cc92531
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/208480
Commit-Queue: Jaime Wren <jwren@google.com>
Reviewed-by: Ben Konyi <bkonyi@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2021-07-30 21:32:58 +00:00
Robert Nystrom 7f2ed4749b Roll dart_style 2.0.3 into the SDK. 
Change-Id: I3eb1ecf0fc4f3e82a3e2ebcbec7416565e5b2b2e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/207502
Auto-Submit: Bob Nystrom <rnystrom@google.com>
Reviewed-by: Ben Konyi <bkonyi@google.com>
Reviewed-by: Nate Bosch <nbosch@google.com>
Commit-Queue: Ben Konyi <bkonyi@google.com>
 2021-07-20 20:52:50 +00:00
William Hesse ac91bd3513 [test] Update test of "dart test" command after package:test update 
This test uses the version of package:test served by pub.
A new version of package:test has changed the help text of this command.

Fixes: https://github.com/dart-lang/sdk/issues/46601
Change-Id: I30afab4a395d905ddbd2ad199c7bdceebb91b89d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/206622
Auto-Submit: William Hesse <whesse@google.com>
Reviewed-by: Ben Konyi <bkonyi@google.com>
Commit-Queue: Ben Konyi <bkonyi@google.com>
 2021-07-13 16:28:07 +00:00
William Hesse 6d4c15bd0f [test] Fix analytics test: "dart format" requires a path 
Change-Id: I0a70d62aa5e204475e8a87aaddba17f281e5535d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/206241
Auto-Submit: William Hesse <whesse@google.com>
Reviewed-by: Bob Nystrom <rnystrom@google.com>
Commit-Queue: Bob Nystrom <rnystrom@google.com>
 2021-07-08 17:33:52 +00:00
Ben Konyi 0d61348584 [ CLI ] Fix IPv6 VM service support for standalone VM 
The CLI was not providing the ipv6 flag to DDS, resulting in a "Could
not start Observatory" error.

Change-Id: Idff0f525455f121b8f1e89bc4ad20a01cd1165ef
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/204860
Reviewed-by: Ryan Macnak <rmacnak@google.com>
Commit-Queue: Ben Konyi <bkonyi@google.com>
 2021-06-24 19:50:59 +00:00
Devon Carew 48ef892281 [pkg/dartdev] switch to using package:lints for analysis 
Change-Id: I7bd4843968e2f2d1454e1a79605ffc777c555ebe
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/202721
Commit-Queue: Devon Carew <devoncarew@google.com>
Reviewed-by: Ben Konyi <bkonyi@google.com>
 2021-06-07 18:36:43 +00:00
Devon Carew 154b217822 [pkg/dartdev] support analyzing multiple directories 
Bug: https://github.com/dart-lang/sdk/issues/45352
Change-Id: I9ffdf1d56ea52fd17ff8e9ce936ee82f108d7b61
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/202065
Commit-Queue: Devon Carew <devoncarew@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2021-06-02 20:11:24 +00:00
Devon Carew bfa01e5dd1 [pkg/dartdev] pass in client id for dart cli analysis server usages 
Change-Id: If35edb33a26fdc5640577b3c7b95805a020f04a9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/202060
Reviewed-by: Jaime Wren <jwren@google.com>
Commit-Queue: Devon Carew <devoncarew@google.com>
 2021-06-02 17:13:03 +00:00
Ben Konyi 4b96d7a09d [ VM / CLI ] Add support for --[no-]serve-devtools 
Fixes https://github.com/dart-lang/sdk/issues/45867

TEST=pkg/dartdev/test/commands/run_test.dart

Change-Id: I3e575db8298d47b69eb9e120f9792ed60d25c7d8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/199960
Auto-Submit: Ben Konyi <bkonyi@google.com>
Commit-Queue: Ben Konyi <bkonyi@google.com>
Reviewed-by: Siva Annamalai <asiva@google.com>
 2021-06-01 20:33:15 +00:00
Devon Carew 29f69657e5 update the links to analyzer diagnostics 
Change-Id: I293ee9bfe0e7c148a59d0cbb1b927c1edbbd15ce
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/200901
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Devon Carew <devoncarew@google.com>
 2021-05-20 17:05:45 +00:00
Ben Konyi db2ff738e6 [ CLI ] Fix dart create not outputting getting started message using 
getInstallInstructions

Fixes https://github.com/dart-lang/sdk/issues/45859

Change-Id: I983b678136ca79a01c53aecbd533a13d908b5d9c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/200287
Reviewed-by: Devon Carew <devoncarew@google.com>
Commit-Queue: Ben Konyi <bkonyi@google.com>
 2021-05-19 16:44:02 +00:00
Ben Konyi f99c918ee8 [ CLI ] Improve consistency of help messages between commands 
Updated some formatting and added '[vm-options]' to relevant commands
when '--verbose' is provided.

Fixes https://github.com/dart-lang/sdk/issues/45837

Change-Id: Ic4ccd81290ccf4000b0bce7d5dba63c469fb4c20
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/200283
Reviewed-by: Devon Carew <devoncarew@google.com>
Commit-Queue: Ben Konyi <bkonyi@google.com>
 2021-05-17 21:20:22 +00:00
Lasse R.H. Nielsen a5e18113f3 Remove references to triple-shift and generic-metadata experiments. 
TEST= removed flags from test. No behavior should change.

Change-Id: I401bfb68c082d1bd405a118d5eca6a47a807945f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/199241
Commit-Queue: Lasse R.H. Nielsen <lrn@google.com>
Reviewed-by: Alexander Thomas <athom@google.com>
 2021-05-12 13:35:00 +00:00
Ben Konyi b99466d472 Reland "[ VM / DDS / CLI ] Add DevTools support to the standalone VM" 
This reverts commit 5cbf10febe.

TEST=pkg/dds/devtools_observatory_connection_test.dart

Change-Id: I682d009f784b930094dae9b7d4e9a66efffb6ee8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/198561
Reviewed-by: Siva Annamalai <asiva@google.com>
 2021-05-11 17:55:26 +00:00
Ben Konyi 5cbf10febe Revert "[ VM / DDS / CLI ] Add DevTools support to the standalone VM" 
This reverts commit ef0e4ea107.

Reason for revert: Flutter HHH and golem builds are red. Rolls to Flutter are failing.

TEST=N/A

Original change's description:
> [ VM / DDS / CLI ] Add DevTools support to the standalone VM
>
> Example output on stdout when DevTools is enabled:
>
> Observatory listening on http://127.0.0.1:8181/CzkZzZaONW4=/
> The Dart DevTools debugger and profiler is available at: http://127.0.0.1:8181/devtools/#/?uri=ws%3A%2F%2F127.0.0.1%3A8181%2FCzkZzZaONW4%3D%2Fws
> hello world!
>
> vm-service: isolate(1674461414267555)  'main' has no debugger attached and is paused at exit.  Connect to Observatory at http://127.0.0.1:8181/CzkZzZaONW4=/ to debug.
>
> TEST=pkg/dartdev/test/commands/run_test.dart
>
> Change-Id: Icd1afda87ad4a46f228125d53094d10adf8056ec
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/188361
> Commit-Queue: Ben Konyi <bkonyi@google.com>
> Reviewed-by: Siva Annamalai <asiva@google.com>

# Not skipping CQ checks because original CL landed > 1 day ago.

Change-Id: I50e8dc4e592e13b44c2fb980b2029d5c5cc3ad2a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/198381
Reviewed-by: Ben Konyi <bkonyi@google.com>
Reviewed-by: Alexander Markov <alexmarkov@google.com>
Commit-Queue: Ben Konyi <bkonyi@google.com>
 2021-05-05 20:31:07 +00:00
Ben Konyi ef0e4ea107 [ VM / DDS / CLI ] Add DevTools support to the standalone VM 
Example output on stdout when DevTools is enabled:

Observatory listening on http://127.0.0.1:8181/CzkZzZaONW4=/
The Dart DevTools debugger and profiler is available at: http://127.0.0.1:8181/devtools/#/?uri=ws%3A%2F%2F127.0.0.1%3A8181%2FCzkZzZaONW4%3D%2Fws
hello world!

vm-service: isolate(1674461414267555)  'main' has no debugger attached and is paused at exit.  Connect to Observatory at http://127.0.0.1:8181/CzkZzZaONW4=/ to debug.

TEST=pkg/dartdev/test/commands/run_test.dart

Change-Id: Icd1afda87ad4a46f228125d53094d10adf8056ec
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/188361
Commit-Queue: Ben Konyi <bkonyi@google.com>
Reviewed-by: Siva Annamalai <asiva@google.com>
 2021-05-03 18:24:09 +00:00
Ben Konyi 1cbf7761dd [ CLI ] Add test for dart format --set-exit-if-changed 
Fixes https://github.com/dart-lang/sdk/issues/44582

Change-Id: I78033a4182a3e587730743e5dad2a1e7358a3fc7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/194119
Commit-Queue: Ben Konyi <bkonyi@google.com>
Reviewed-by: Bob Nystrom <rnystrom@google.com>
 2021-04-06 23:46:09 +00:00
Ben Konyi 628193450a [ CLI ] Check for valid package names and '.' when creating new projects 
Ensures that Dart projects created using 'dart create' are valid
packages.

Fixes https://github.com/dart-lang/sdk/issues/43216.

Change-Id: I1e38ba722f24a247e64f077d35c8e74c051c4908
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/193825
Commit-Queue: Ben Konyi <bkonyi@google.com>
Reviewed-by: Devon Carew <devoncarew@google.com>
 2021-04-01 23:58:47 +00:00
Devon Carew f6ce7a829f In-line the package:stagehand templates into 'dart create'. 
Change-Id: I717f0970314700b123b750fcfe7ed066ba88d2e5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/192944
Commit-Queue: Devon Carew <devoncarew@google.com>
Reviewed-by: Ben Konyi <bkonyi@google.com>
 2021-03-25 18:05:09 +00:00
Ben Konyi 5a20976df3 [ CLI ] Add support for program arguments to dart compile jit-snapshot 
Fixes https://github.com/dart-lang/sdk/issues/43839.

Change-Id: I3ac270aefd8a1ce7b3d8044687f686535036b336
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/192945
Commit-Queue: Ben Konyi <bkonyi@google.com>
Reviewed-by: Siva Annamalai <asiva@google.com>
Reviewed-by: Devon Carew <devoncarew@google.com>
 2021-03-24 23:53:23 +00:00
Paul Berry 58dc586929 Remove redundant line number from referencedBeforeDeclaration. 
Context messages are already displayed in a way that makes it easy for
the user to locate the line of code in question; it's unnecessary to
include the line number in the context message itself.

See discussion at
https://buganizer.corp.google.com/issues/179782591#comment9.

Change-Id: I2d1383c4cee0ece0d302449302d1f1902fbf136c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/192480
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
 2021-03-24 14:07:51 +00:00
Ben Konyi a49bea950d [ CLI ] Use 'project' instead of 'package' in CLI help messages 
Initial updates, related to
https://github.com/dart-lang/sdk/issues/45279.

Change-Id: I459e719ad6e92378f9240a612e0bd8229d0fcb2e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/192727
Reviewed-by: Devon Carew <devoncarew@google.com>
 2021-03-23 23:05:33 +00:00
Brian Wilkerson bd19cbf1d2 Add a json format to the dart analyze command 
Change-Id: I5667d845d305fa087934f73fbf09cc9b166c8461
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/192240
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Devon Carew <devoncarew@google.com>
Reviewed-by: Ben Konyi <bkonyi@google.com>
 2021-03-23 18:21:51 +00:00
Konstantin Shcheglov 1712737dea Support for single file analysis in 'dart analyze'. 
Bug: https://github.com/dart-lang/sdk/issues/43891
Bug: https://github.com/dart-lang/sdk/issues/43271
Change-Id: Ifb3c0c10eabaabb19777838bccf7851199b8c778
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/190640
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Devon Carew <devoncarew@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2021-03-11 17:21:50 +00:00
Ben Konyi 8bd3088588 [ CLI ] Update analytics messaging 
Fixes https://github.com/dart-lang/sdk/issues/45252

Change-Id: I38d4d0b1abde8c2fa3cd7ed3ed1014453bcc6744
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/190540
Commit-Queue: Ben Konyi <bkonyi@google.com>
Reviewed-by: Devon Carew <devoncarew@google.com>
Reviewed-by: Franklin Yow <frankyow@google.com>
 2021-03-10 19:44:44 +00:00
Devon Carew bb3167fe53 [analyzer] always show context messages for 'dart analyze' 
Change-Id: Ifda063de48a968f7ef013c501f6db9bec7f13246
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/188001
Commit-Queue: Devon Carew <devoncarew@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2021-03-04 01:00:16 +00:00
Sigurd Meldgaard e7fdd7b693 Let experimental features specify an example for tooling to have generic 
tests.

Bug: https://github.com/dart-lang/sdk/issues/44937
Change-Id: I309e6e4299b09705f653d59c7842a05fdf7cdaa5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/184790
Commit-Queue: Sigurd Meldgaard <sigurdm@google.com>
Reviewed-by: Lasse R.H. Nielsen <lrn@google.com>
Reviewed-by: Ben Konyi <bkonyi@google.com>
 2021-02-23 13:57:29 +00:00
Ben Konyi 410f242ebc [ CLI ] Fix issue where analytics were not correctly being disabled 
Fixes https://github.com/dart-lang/sdk/issues/45077

TEST=VM -> CLI --analytics flag smoke test in analytics_test.dart

Change-Id: Ic8d796fbc21402adfde72e9697124e144a417260
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/186381
Commit-Queue: Ben Konyi <bkonyi@google.com>
Reviewed-by: Devon Carew <devoncarew@google.com>
 2021-02-22 20:27:29 +00:00
William Hesse 88b6c207e7 [dartdev] Fix analytics test on Windows 
The default Process.runSync doesn't expect utf-8 on stdout on Windows.

Fixes: https://github.com/dart-lang/sdk/issues/44981
Change-Id: If80fcaa9ce54fdd64c2c8f40779c646f1c37fdea
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/184468
Reviewed-by: Ben Konyi <bkonyi@google.com>
Commit-Queue: Ben Konyi <bkonyi@google.com>
 2021-02-12 18:37:52 +00:00
Lasse R.H. Nielsen d352bc28b8 Remove (most) uses of the "non-nullable" experiment flag. 
Since the flag is now enabled by default, there should be no mention of it.
There are still some uses in front_end/testcases that are not just removable
(it also uses `no-non-nullable`). There migth be more uses that are not
as easily found as grepping for `--enable-experiment

Removes two VM tests where fixing them meant they were just duplicating
the corresponding non *_2/ tests.
Fixes #44941

TEST= Large number of tests chaged.=(no-)?non-nullable`.

Change-Id: Ief755981ccde9a5482fcdf408c2929c74433a710
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/183688
Commit-Queue: Lasse R.H. Nielsen <lrn@google.com>
Reviewed-by: Nate Bosch <nbosch@google.com>
 2021-02-12 17:16:54 +00:00
Ben Konyi 7ce8e3ba2e [ DartDev / CLI ] Fixed issue where analytics flags were not being forwarded to the CLI 
Forwarding logic seems to have been accidentally removed in
f3fe9dc3b3.

Fixes https://github.com/dart-lang/sdk/issues/44968

TEST=pkg/dartdev/test/analytics_test.dart

Fixed: 44968
Change-Id: Ib3c107233276ca6592247e23268f9af7ede52285
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/184502
Commit-Queue: Ben Konyi <bkonyi@google.com>
Reviewed-by: Siva Annamalai <asiva@google.com>
 2021-02-11 18:45:06 +00:00
Devon Carew 6e9ba7f66a [dart analyze] tweak the context message presentation for dart analyze 
Change-Id: I27dc1317b2dba3a1ff23a46b4db5d32405aa8aa6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/184104
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Devon Carew <devoncarew@google.com>
 2021-02-10 16:57:53 +00:00
Ben Konyi 848121e6d4 Reland "[ CLI ] Improved consistency of -D and --define across tools and commands" 
- Added support for --define to the VM and dart2js
- Added support for -D and --define for `dart run` and `dart compile js`

Remaining improvements:
- Add support for providing multiple comma separated values for `dart
  run`, `dart`, and `dart2js`

Related issue: https://github.com/dart-lang/sdk/issues/44562

TEST=Updated CLI tests and added new dart2js tests.

This reverts commit e49937769f.

Change-Id: I5f9275b829665eb5e8695403d67f230e752ab0e6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/183180
Commit-Queue: Ben Konyi <bkonyi@google.com>
Reviewed-by: Sigmund Cherem <sigmund@google.com>
 2021-02-05 23:53:28 +00:00
Alexander Markov 55daf05f4f Add --[no-]sound-null-safety option to dart2native and dart compile exe 
Fixes https://github.com/dart-lang/sdk/issues/44553

Change-Id: Id461550e7761d874719220a5cb7a6b2c9ac421a0
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/181020
Commit-Queue: Alexander Markov <alexmarkov@google.com>
Reviewed-by: Clement Skau <cskau@google.com>
Reviewed-by: Ben Konyi <bkonyi@google.com>
 2021-01-26 19:16:30 +00:00
asiva ac520f984d [ VM / CLI ] Add --verbosity to VM options 
The verbosity option allows for specifying the CFE output verbosity

Fixes https://github.com/dart-lang/sdk/issues/44727

TEST=existing tests compile_test.dart and run_test.dart have new tests

Change-Id: I3d4e50811f84650aacf774ddb370a6eb765b9b24
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/181100
Commit-Queue: Siva Annamalai <asiva@google.com>
Reviewed-by: Alexander Aprelev <aam@google.com>
 2021-01-26 03:01:58 +00:00
Johnni Winther 97a4280e52 [cfe,dartdev,dart2js] Add support for --verbosity option 
In response to https://github.com/dart-lang/sdk/issues/44727

TEST=pkg/dartdev/test/commands/compile_test.dart

Change-Id: I56b67d9362a415acd721c1cce2f7e2232d2493df
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/180566
Commit-Queue: Johnni Winther <johnniwinther@google.com>
Reviewed-by: Jens Johansen <jensj@google.com>
 2021-01-22 18:33:44 +00:00
Johnni Winther 55b34a467c Reland "[vm] Pass snapshot flag to kernel_service" 
Enable reporting of null safety compilation mode when running
`dart compile aot-snapshot`, `dart compile jit-snapshot`,
and `dart compile kernel`.

Closes #44234

TEST=pkg/dartdev/test/commands/compile_test.dart

Change-Id: Id9e72751068d5f208055ab953d2c8392e84c4798
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/180187
Reviewed-by: Ben Konyi <bkonyi@google.com>
Commit-Queue: Johnni Winther <johnniwinther@google.com>
 2021-01-21 21:18:32 +00:00