dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
82,532 Commits 2 Branches 0 Tags
5e990591b9504c168d94de964560765633608ced
Commit Graph

301 Commits

Author SHA1 Message Date
Sigurd Meldgaard 3c5e2a0d7b Bump pub to 0035a40f25d027130c0314571da53ffafc6d973b 
Changes:
```
> git log --format="%C(auto) %h %s" 78bc50c..0035a40
 https://dart.googlesource.com/pub.git/+/0035a40f Fix echo mode crash on `token add` (#3194)
 https://dart.googlesource.com/pub.git/+/a75a8c17 Don't warn against discontinued transitive dependencies (#3195)
 https://dart.googlesource.com/pub.git/+/cf2ed105 Fix analytics code (#3197)
 https://dart.googlesource.com/pub.git/+/08e13f7b Remove unused golden files (#3189)
 https://dart.googlesource.com/pub.git/+/b6293b80 Fix log message related to `pub global activate`  (#3187)
 https://dart.googlesource.com/pub.git/+/94f6b477 Introducing command-line interface tests (#3161)
 https://dart.googlesource.com/pub.git/+/3ba8134f More details from getExecutableForCommand (#3186)
 https://dart.googlesource.com/pub.git/+/a2dbcfff Shorthand syntax for hosted dependencies (#3133)
 https://dart.googlesource.com/pub.git/+/435e4e3f Shuffle analytics (#3185)

```

Diff: https://dart.googlesource.com/pub.git/+/78bc50c7833451c24e531713362e46fd50621ff0~..0035a40f25d027130c0314571da53ffafc6d973b/
Change-Id: Idfd7c382985d1ad3e3ad87a621dc79d3b74e898e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/218620
Reviewed-by: Jonas Jensen <jonasfj@google.com>
Commit-Queue: Sigurd Meldgaard <sigurdm@google.com>
 2021-10-29 13:05:39 +00:00
Ben Konyi 4de9e805ed [ CLI ] Don't resolve paths as URIs for known SDK artifacts 
Handles cases where the SDK is installed on a path which includes
percent encoded characters. The OS doesn't decode these characters, so
decoding them before trying to load a snapshot with said characters in
their path will result in files not being found.

Fixes https://github.com/dart-lang/sdk/issues/46364

TEST=pkg/dartdev/test/regress_46364_test.dart

Change-Id: I5f78e8a2049cc0c83555528fcc8f41be946141f5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/218082
Reviewed-by: Ryan Macnak <rmacnak@google.com>
 2021-10-27 16:34:00 +00:00
Michael Thomsen 800366738c Clarify how to to run compiled files 
Bug: 47518
Change-Id: Ia0d69e9ab34d41df9da943acc9433b7c5d02afca
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/217921
Reviewed-by: Ben Konyi <bkonyi@google.com>
Commit-Queue: Michael Thomsen <mit@google.com>
 2021-10-26 13:11:41 +00:00
Sigurd Meldgaard ecc6ed1b32 Send resolution analytics from dart pub get/upgrade/... 
Also enables batched analytics (up to 20 events will be sent together in
one request if they are all issued before control is returned to the
async queue).

Change-Id: Ic23429d4981bc33a34cb19ffc00affdd09dfe511
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/217014
Reviewed-by: Jonas Jensen <jonasfj@google.com>
Commit-Queue: Sigurd Meldgaard <sigurdm@google.com>
 2021-10-25 12:35:30 +00:00
Kenzie Schmoll 6a39b26d07 Unhide the devtools command from dart --help 
Change-Id: I853cdcd6cb968fa4c5c7b56a5ad69a27c60e4524
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/217743
Reviewed-by: Ben Konyi <bkonyi@google.com>
Commit-Queue: Ben Konyi <bkonyi@google.com>
Commit-Queue: Kenzie Schmoll <kenzieschmoll@google.com>
 2021-10-21 21:43:05 +00:00
Brian Wilkerson 1ac19c47ba Remove unnecessary ignore comment 
Change-Id: I40bdf75ccfc0d22c93dfbb7bbea5c860198b065b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/217022
Auto-Submit: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Ben Konyi <bkonyi@google.com>
Reviewed-by: Ben Konyi <bkonyi@google.com>
 2021-10-20 17:07:31 +00:00
Michael Thomsen 3f931429c3 Roll deps of web template 
Bug: https://github.com/dart-lang/sdk/issues/47450
Change-Id: I49c27714fd36ea60dd6e6f40928526ccf2554c99
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/216621
Reviewed-by: Kevin Moore <kevmoo@google.com>
Commit-Queue: Michael Thomsen <mit@google.com>
 2021-10-14 08:50:52 +00:00
pq 8db81bbc44 migrate to package:async unawaited 
Change-Id: I48cc9c0b2d16ecc50b3b7d1ea68006388e041a08
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/214684
Reviewed-by: Ben Konyi <bkonyi@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
 2021-09-27 19:35:43 +00:00
Ben Konyi bd067153d5 [ CLI ] Hide exe and aot-snapshot subcommands from dart compile on IA32 
The AOT runtime is not supported on IA32, so generating snapshots and
executables requiring the AOT runtime is not possible on IA32.

Fixes https://github.com/dart-lang/sdk/issues/47177

TEST=pkg/dartdev/test/commands/compile_test.dart

Change-Id: I99e9a16f6a93b3b63b8ed15acc1472f9ca619c08
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/213680
Commit-Queue: Ben Konyi <bkonyi@google.com>
Reviewed-by: Alexander Markov <alexmarkov@google.com>
Reviewed-by: Ryan Macnak <rmacnak@google.com>
 2021-09-24 01:21:08 +00:00
Danny Tuppeny b68ccc9a39 [dartdev] Add a "dart debug_adapter" command to run the DAP server from DDS 
Change-Id: Icf4442929f848f7f927e84c999f09206e3fd0704
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/213640
Reviewed-by: Ben Konyi <bkonyi@google.com>
Commit-Queue: Ben Konyi <bkonyi@google.com>
 2021-09-17 16:09:49 +00:00
Ben Konyi 123950ffa9 [ CLI / VM ] Add support for disabling DDS 
Allows for tooling (e.g., DAP) to spawn their own DDS instance without
having to disable the CLI.

Fixes https://github.com/dart-lang/sdk/issues/47059

TEST=pkg/dartdev/test/commands/run_test.dart

Change-Id: Ie9a4832d424edae67f32560399d3b0a6ca9f1dc0
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/213660
Reviewed-by: Siva Annamalai <asiva@google.com>
Commit-Queue: Ben Konyi <bkonyi@google.com>
 2021-09-16 20:31:45 +00:00
pq dd35db6192 "master->main" migration 
Change-Id: I773e0a60a782f9e6678cea22e2a7d8fae48cffa3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/212869
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
 2021-09-09 18:14:36 +00:00
Konstantin Shcheglov f726874678 Support for --cache in 'dart analyze'. 
Bug: https://github.com/dart-lang/sdk/issues/45267
Change-Id: I503227ac59a3562e79d3654c405debaf5d0c764c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/212420
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2021-09-03 18:43:08 +00:00
Konstantin Shcheglov 78ef2cc217 Support for --packages in 'dart analyze'. 
Bug: https://github.com/dart-lang/sdk/issues/45267
Change-Id: I660de0c80e4f280996b6ce5e90d39aa274997d07
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/212380
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2021-09-03 01:46:25 +00:00
Lasse R.H. Nielsen 8fd075ef6f Clean up pkg/dartdev. 
Various smaller tweaks, mainly around RegExps.

Change-Id: I7a68a563b31213a2942d622b65396b0c7de43318
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/210124
Commit-Queue: Ben Konyi <bkonyi@google.com>
Reviewed-by: Ben Konyi <bkonyi@google.com>
Reviewed-by: Nate Bosch <nbosch@google.com>
 2021-09-01 15:49:26 +00:00
Sigurd Meldgaard ae81cd5dab Deprecate top level pub. 
Also makes the `pub` shell script (and its .bat counterpart)
forward to a `dart __deprecated_pub` command that implements the
old top-level.

This allows us to get rid of pub.dart.snapshot saving ~15 MB in a
unzipped sdk.

The reason for not forwarding directly to `dart pub` is that the
interface is slightly different (for example there is no `dart pub --version`).


The only new commit in pub is: `3c2ce330 Expose toplevel as a command`


Bug: https://github.com/dart-lang/pub/issues/2736
Change-Id: I6eb08d120c4844b3a12bc29544df6a868cd6fcc8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/210582
Commit-Queue: Sigurd Meldgaard <sigurdm@google.com>
Reviewed-by: Jonas Jensen <jonasfj@google.com>
 2021-08-24 08:34:58 +00:00
Michael Thomsen 6c5fb84716 Discontinue dart2native (use dart compile) 
TEST=Existing tests updated to use dart compile

Change-Id: Ia3478069df2354a3bf057fedae0f1eea9415de95
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/210241
Commit-Queue: Michael Thomsen <mit@google.com>
Reviewed-by: Devon Carew <devoncarew@google.com>
Reviewed-by: Tess Strickland <sstrickl@google.com>
Reviewed-by: Ben Konyi <bkonyi@google.com>
 2021-08-23 20:53:09 +00:00
Devon Carew d7c8e6a9d3 rev the build of devtools; add a 'dart devtools' command 
Change-Id: I98ffbceedd06b3693703518243e231d6a1a66c9a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/210423
Commit-Queue: Devon Carew <devoncarew@google.com>
Reviewed-by: Ben Konyi <bkonyi@google.com>
Reviewed-by: Kenzie Schmoll <kenzieschmoll@google.com>
 2021-08-20 16:25:24 +00:00
Devon Carew b44250c3f6 remove some unused dartdev benchmarks 
Change-Id: I75118d2a18ae3bbea25647c9c59e3d4e4aaf809d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/210502
Reviewed-by: Ben Konyi <bkonyi@google.com>
Commit-Queue: Devon Carew <devoncarew@google.com>
 2021-08-20 00:40:24 +00:00
Ben Konyi d2855e703e [ CLI ] Default to printing CLI usage message instead of VM usage 
--disable-dart-dev disables this behavior.

Fixes https://github.com/dart-lang/sdk/issues/46411

TEST=pkg/dartdev/test/commands/flag_test.dart

Change-Id: I46b91abc89fc3ec5e06fa7e9aad3939573cff545
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/209264
Commit-Queue: Ben Konyi <bkonyi@google.com>
Reviewed-by: Siva Annamalai <asiva@google.com>
 2021-08-13 23:01:51 +00:00
Michael Thomsen cfc3a654a5 Update SDK constraint in templates of the dart tool to enable 
new languge features in 2.14


Change-Id: I731cebcb394ba17cd3a46ac92ae74cc6bf307de0
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/209916
Reviewed-by: Ben Konyi <bkonyi@google.com>
Reviewed-by: Nate Bosch <nbosch@google.com>
Reviewed-by: Lasse R.H. Nielsen <lrn@google.com>
Commit-Queue: Michael Thomsen <mit@google.com>
 2021-08-13 09:39:01 +00:00
Ben Konyi cccc0293c5 [ VM ] Send 'dart --help [--verbose]' output to stdout 
This is consistent with the majority of other tools and the CLI
behavior.

Fixes https://github.com/dart-lang/sdk/issues/46412

TEST=pkg/dartdev/test/commands/flag_test.dart

Change-Id: I45a3ddc9728e9cc1a273d4d5f11db74cb8104745
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/204661
Commit-Queue: Ben Konyi <bkonyi@google.com>
Reviewed-by: Ryan Macnak <rmacnak@google.com>
 2021-08-06 16:06:05 +00:00
Jaime Wren 1689a82229 Fix for https://github.com/dart-lang/sdk/issues/46509, modifying the order that dart analyze outputs the analysis error output. 
This change also adds tests for the comparison sorting.

Bug: https://github.com/dart-lang/sdk/issues/46509
Change-Id: Ie568a75c25d0a1e1f76f26f4955de92599f3a68b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/208521
Reviewed-by: Devon Carew <devoncarew@google.com>
Commit-Queue: Jaime Wren <jwren@google.com>
 2021-08-02 17:03:22 +00:00
Jaime Wren 58969783ba Add two Functions to dartdev to allow the extension of cli tool. 
Change-Id: I84e89d2c5404949a5b4aa27c17ea793a5cc92531
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/208480
Commit-Queue: Jaime Wren <jwren@google.com>
Reviewed-by: Ben Konyi <bkonyi@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2021-07-30 21:32:58 +00:00
Robert Nystrom 7f2ed4749b Roll dart_style 2.0.3 into the SDK. 
Change-Id: I3eb1ecf0fc4f3e82a3e2ebcbec7416565e5b2b2e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/207502
Auto-Submit: Bob Nystrom <rnystrom@google.com>
Reviewed-by: Ben Konyi <bkonyi@google.com>
Reviewed-by: Nate Bosch <nbosch@google.com>
Commit-Queue: Ben Konyi <bkonyi@google.com>
 2021-07-20 20:52:50 +00:00
William Hesse ac91bd3513 [test] Update test of "dart test" command after package:test update 
This test uses the version of package:test served by pub.
A new version of package:test has changed the help text of this command.

Fixes: https://github.com/dart-lang/sdk/issues/46601
Change-Id: I30afab4a395d905ddbd2ad199c7bdceebb91b89d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/206622
Auto-Submit: William Hesse <whesse@google.com>
Reviewed-by: Ben Konyi <bkonyi@google.com>
Commit-Queue: Ben Konyi <bkonyi@google.com>
 2021-07-13 16:28:07 +00:00
William Hesse 6d4c15bd0f [test] Fix analytics test: "dart format" requires a path 
Change-Id: I0a70d62aa5e204475e8a87aaddba17f281e5535d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/206241
Auto-Submit: William Hesse <whesse@google.com>
Reviewed-by: Bob Nystrom <rnystrom@google.com>
Commit-Queue: Bob Nystrom <rnystrom@google.com>
 2021-07-08 17:33:52 +00:00
Ben Konyi 51ad1c620b [ CLI ] Update README for package-simple project template 
Fixes #46454

Change-Id: If5d040dd83ab6bb8991c5e5e55a7558c40d8bda5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/205320
Reviewed-by: Kathy Walrath <kathyw@google.com>
Commit-Queue: Ben Konyi <bkonyi@google.com>
 2021-06-29 17:02:58 +00:00
Ben Konyi 0d61348584 [ CLI ] Fix IPv6 VM service support for standalone VM 
The CLI was not providing the ipv6 flag to DDS, resulting in a "Could
not start Observatory" error.

Change-Id: Idff0f525455f121b8f1e89bc4ad20a01cd1165ef
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/204860
Reviewed-by: Ryan Macnak <rmacnak@google.com>
Commit-Queue: Ben Konyi <bkonyi@google.com>
 2021-06-24 19:50:59 +00:00
Paul Berry c041afad9f Decouple the migration tool from package:dartdev so it can be migrated. 
In order to migrate the migration tool to null safety, it can't have a
dependency on `package:dartdev`, because `package:dartdev` isn't
migrated yet.  (This is a problem because once the migration tool's
tests have been migrated to null safety, they will require the
transitive closure of all the packages they depend on to also be
migrated).

Fortunately, it's quite easy to change the migration tool so that it
doesn't depend on `package:dartdev`; we only need to move the class
`MigrateCommand` from `package:nnbd_migration` to `package:dartdev`.

To make this work, we have to move the constant `migrationGuideLink`
from `MigrateCommand` to `MigrationCli`, and make the method
`MigrationCli._defineOptions` public.

Change-Id: Ie1ce8db0e8245e98bbb72facddd723300816340e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/204540
Reviewed-by: Devon Carew <devoncarew@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
 2021-06-23 22:57:21 +00:00
Paul Berry 8aec705f69 Sort declarations in dartdev.dart 
Change-Id: I07f8898f125f0b8bb3eb7e15dfba0b6ebbb6105f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/204541
Reviewed-by: Ben Konyi <bkonyi@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
 2021-06-22 19:39:04 +00:00
Sigmund Cherem 10819f6e21 [dart-cli]: delegate arg parsing to the underlying dart2js command 
Since we anyways delegate all work to the same snapshot, this allows us
to maintain the argument parsing in a single location and makes it easier to
migrate existing usages of `dart2js ...` to `dart compile js ...`.


Change-Id: I24172fc87c040128d552cf68b98094e1c2f2c22f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/204421
Reviewed-by: Ben Konyi <bkonyi@google.com>
Commit-Queue: Sigmund Cherem <sigmund@google.com>
 2021-06-21 17:44:00 +00:00
Devon Carew 48ef892281 [pkg/dartdev] switch to using package:lints for analysis 
Change-Id: I7bd4843968e2f2d1454e1a79605ffc777c555ebe
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/202721
Commit-Queue: Devon Carew <devoncarew@google.com>
Reviewed-by: Ben Konyi <bkonyi@google.com>
 2021-06-07 18:36:43 +00:00
pq 63a77416b7 enable depend_on_referenced_packages 
this is under consideration for core lint inclusion: https://github.com/dart-lang/lints/issues/42

(also undoubtably nice to get the early warning.)

Change-Id: I3ea204444f48d3b4bde3ff65b4ce85a2cf2a7b11
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/202301
Commit-Queue: Phil Quitslund <pquitslund@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2021-06-04 14:19:08 +00:00
Devon Carew 154b217822 [pkg/dartdev] support analyzing multiple directories 
Bug: https://github.com/dart-lang/sdk/issues/45352
Change-Id: I9ffdf1d56ea52fd17ff8e9ce936ee82f108d7b61
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/202065
Commit-Queue: Devon Carew <devoncarew@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2021-06-02 20:11:24 +00:00
Devon Carew bfa01e5dd1 [pkg/dartdev] pass in client id for dart cli analysis server usages 
Change-Id: If35edb33a26fdc5640577b3c7b95805a020f04a9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/202060
Reviewed-by: Jaime Wren <jwren@google.com>
Commit-Queue: Devon Carew <devoncarew@google.com>
 2021-06-02 17:13:03 +00:00
Ben Konyi 4b96d7a09d [ VM / CLI ] Add support for --[no-]serve-devtools 
Fixes https://github.com/dart-lang/sdk/issues/45867

TEST=pkg/dartdev/test/commands/run_test.dart

Change-Id: I3e575db8298d47b69eb9e120f9792ed60d25c7d8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/199960
Auto-Submit: Ben Konyi <bkonyi@google.com>
Commit-Queue: Ben Konyi <bkonyi@google.com>
Reviewed-by: Siva Annamalai <asiva@google.com>
 2021-06-01 20:33:15 +00:00
Devon Carew 29f69657e5 update the links to analyzer diagnostics 
Change-Id: I293ee9bfe0e7c148a59d0cbb1b927c1edbbd15ce
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/200901
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Devon Carew <devoncarew@google.com>
 2021-05-20 17:05:45 +00:00
Alexander Thomas 1cabd7d941 [dartdev] Apply updates from official image examples 
Official image docs: https://hub.docker.com/_/dart

Change-Id: I9629c33db812039dad67a082e3a6c6793bad272c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/200462
Reviewed-by: Michael Thomsen <mit@google.com>
Commit-Queue: Alexander Thomas <athom@google.com>
 2021-05-20 09:17:00 +00:00
Ben Konyi db2ff738e6 [ CLI ] Fix dart create not outputting getting started message using 
getInstallInstructions

Fixes https://github.com/dart-lang/sdk/issues/45859

Change-Id: I983b678136ca79a01c53aecbd533a13d908b5d9c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/200287
Reviewed-by: Devon Carew <devoncarew@google.com>
Commit-Queue: Ben Konyi <bkonyi@google.com>
 2021-05-19 16:44:02 +00:00
Jeffrey Swan fed6cadf77 fix(docs): corrects common typos in project documentation 
Scope of changes is restricted to markdown docs only. Changes made in agreement with Standard American English.

Closes https://github.com/dart-lang/sdk/pull/45818
https://github.com/dart-lang/sdk/pull/45818

TEST=Manual review of the changed markdown files.

GitOrigin-RevId: 6df9128b46e4e51e634baf534c0169f62bc6a67e
Change-Id: I7b67dcb5a6e0a03db2b6eea24ace8dee207c4a11
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/196742
Reviewed-by: Bob Nystrom <rnystrom@google.com>
 2021-05-18 15:48:18 +00:00
Ben Konyi f99c918ee8 [ CLI ] Improve consistency of help messages between commands 
Updated some formatting and added '[vm-options]' to relevant commands
when '--verbose' is provided.

Fixes https://github.com/dart-lang/sdk/issues/45837

Change-Id: Ic4ccd81290ccf4000b0bce7d5dba63c469fb4c20
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/200283
Reviewed-by: Devon Carew <devoncarew@google.com>
Commit-Queue: Ben Konyi <bkonyi@google.com>
 2021-05-17 21:20:22 +00:00
Devon Carew 5d95b760a3 [dartdev] rev the version constraint on package:lints 
Change-Id: Ib7b1fad99b97e779fb8f929cc8e3d7b7837ccab0
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/200040
Reviewed-by: Phil Quitslund <pquitslund@google.com>
Commit-Queue: Devon Carew <devoncarew@google.com>
 2021-05-17 15:37:50 +00:00
Michael Thomsen 2f85591b67 Switch to recommended lints 
Bug: https://github.com/dart-lang/lints/issues/20
Change-Id: I433a393a9a6755ed9140326a413f8360a4d508bb
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/199482
Reviewed-by: Phil Quitslund <pquitslund@google.com>
Commit-Queue: Michael Thomsen <mit@google.com>
 2021-05-12 20:07:51 +00:00
Lasse R.H. Nielsen a5e18113f3 Remove references to triple-shift and generic-metadata experiments. 
TEST= removed flags from test. No behavior should change.

Change-Id: I401bfb68c082d1bd405a118d5eca6a47a807945f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/199241
Commit-Queue: Lasse R.H. Nielsen <lrn@google.com>
Reviewed-by: Alexander Thomas <athom@google.com>
 2021-05-12 13:35:00 +00:00
Ben Konyi b99466d472 Reland "[ VM / DDS / CLI ] Add DevTools support to the standalone VM" 
This reverts commit 5cbf10febe.

TEST=pkg/dds/devtools_observatory_connection_test.dart

Change-Id: I682d009f784b930094dae9b7d4e9a66efffb6ee8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/198561
Reviewed-by: Siva Annamalai <asiva@google.com>
 2021-05-11 17:55:26 +00:00
Devon Carew ac7c44e4a9 update the dart create templates to use package:lints 
Bug: https://github.com/dart-lang/sdk/issues/45940
Change-Id: I61c8d3e8be8922cfa6a874213349f84aa44baff4
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/198620
Commit-Queue: Devon Carew <devoncarew@google.com>
Reviewed-by: Ben Konyi <bkonyi@google.com>
Reviewed-by: Phil Quitslund <pquitslund@google.com>
 2021-05-10 16:44:40 +00:00
Michael Thomsen d0f7a5b6d1 Updated server template 
Change-Id: If3a0e3ea3f0f0e4465bf8f875071c92c674600c3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/197167
Reviewed-by: Kevin Moore <kevmoo@google.com>
Commit-Queue: Michael Thomsen <mit@google.com>
 2021-05-07 12:07:56 +00:00
Ben Konyi 5cbf10febe Revert "[ VM / DDS / CLI ] Add DevTools support to the standalone VM" 
This reverts commit ef0e4ea107.

Reason for revert: Flutter HHH and golem builds are red. Rolls to Flutter are failing.

TEST=N/A

Original change's description:
> [ VM / DDS / CLI ] Add DevTools support to the standalone VM
>
> Example output on stdout when DevTools is enabled:
>
> Observatory listening on http://127.0.0.1:8181/CzkZzZaONW4=/
> The Dart DevTools debugger and profiler is available at: http://127.0.0.1:8181/devtools/#/?uri=ws%3A%2F%2F127.0.0.1%3A8181%2FCzkZzZaONW4%3D%2Fws
> hello world!
>
> vm-service: isolate(1674461414267555)  'main' has no debugger attached and is paused at exit.  Connect to Observatory at http://127.0.0.1:8181/CzkZzZaONW4=/ to debug.
>
> TEST=pkg/dartdev/test/commands/run_test.dart
>
> Change-Id: Icd1afda87ad4a46f228125d53094d10adf8056ec
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/188361
> Commit-Queue: Ben Konyi <bkonyi@google.com>
> Reviewed-by: Siva Annamalai <asiva@google.com>

# Not skipping CQ checks because original CL landed > 1 day ago.

Change-Id: I50e8dc4e592e13b44c2fb980b2029d5c5cc3ad2a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/198381
Reviewed-by: Ben Konyi <bkonyi@google.com>
Reviewed-by: Alexander Markov <alexmarkov@google.com>
Commit-Queue: Ben Konyi <bkonyi@google.com>
 2021-05-05 20:31:07 +00:00
Ben Konyi ef0e4ea107 [ VM / DDS / CLI ] Add DevTools support to the standalone VM 
Example output on stdout when DevTools is enabled:

Observatory listening on http://127.0.0.1:8181/CzkZzZaONW4=/
The Dart DevTools debugger and profiler is available at: http://127.0.0.1:8181/devtools/#/?uri=ws%3A%2F%2F127.0.0.1%3A8181%2FCzkZzZaONW4%3D%2Fws
hello world!

vm-service: isolate(1674461414267555)  'main' has no debugger attached and is paused at exit.  Connect to Observatory at http://127.0.0.1:8181/CzkZzZaONW4=/ to debug.

TEST=pkg/dartdev/test/commands/run_test.dart

Change-Id: Icd1afda87ad4a46f228125d53094d10adf8056ec
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/188361
Commit-Queue: Ben Konyi <bkonyi@google.com>
Reviewed-by: Siva Annamalai <asiva@google.com>
 2021-05-03 18:24:09 +00:00