dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
82,532 Commits 2 Branches 0 Tags
5e990591b9504c168d94de964560765633608ced
Commit Graph

4884 Commits

Author SHA1 Message Date
Konstantin Shcheglov 2f66c077c9 Extract CompletionSuggestion.copyWith() into an extension. 
Change-Id: I7cc391f91f74b5f9d37435a78d04c773f3672fcd
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/218744
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2021-10-31 22:02:20 +00:00
Brian Wilkerson cd59d39fe3 Remove some unused code from the fix support 
Change-Id: Ia5f04d51e92d0dea0f1b44878a3f268f1f629f96
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/218670
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2021-10-29 21:02:39 +00:00
Konstantin Shcheglov 0908835478 Tests for extension members completion, support not yet imported. 
Change-Id: Idd0d2ad814f2365fa724b246f8d84e56e7dedd25
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/218669
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2021-10-29 20:54:09 +00:00
Konstantin Shcheglov f706631f63 Move dotTarget to CompletionTarget. 
Change-Id: Idaf40cdedcb90fd68f00fd3ab994ac53c7fe1ae2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/218665
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2021-10-29 18:34:15 +00:00
Sam Rawlins 8f756bf96b Add CommentReferableExpression, for expressions which can be used in a CommentReference 
* Replace `identifier` field with `expression`, which means deprecating
  `identifier`, redirecting users to `expression`. For now, `expression`
  always returns an Identifier. In a future breaking release, it will
  return other CommentReferableExpressions.
* SimpleIdentifier, PrefixedIdentifier, PropertyAccess,
  ConstructorReference, FunctionReference, and TypeLiteral are all
  CommentReferableExpressions, but support is not implemented yet to
  parse CommentReferences with those contained expressions.

Bug: https://github.com/dart-lang/sdk/issues/47444
Change-Id: I1905afecf3878cd7dca6e275ef0a2ab80500eb4d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/216320
Commit-Queue: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Janice Collins <jcollins@google.com>
 2021-10-29 16:38:09 +00:00
Konstantin Shcheglov 132f16b3b0 Implement completion.getSuggestionDetails2 
Change-Id: Ic4b39c723d0cf90936a1db3ad3716533e6e8ca79
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/218542
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2021-10-28 20:55:48 +00:00
Konstantin Shcheglov 61e60eefd2 Abort not-yet-imported suggestions on a new completion request. 
Change-Id: Id08b7ca328253ea5190038d2204cbfb2015aac01
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/218541
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2021-10-28 20:23:31 +00:00
Konstantin Shcheglov ec1118ead7 Use CompletionBudget.defaultDuration 
Change-Id: Ic4da5ac8b5d8dc9911feecdfa4a8ab4e2e4da778
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/218524
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2021-10-28 18:17:48 +00:00
Konstantin Shcheglov 294aaab9c1 Use time budget in NotImportedContributor. 
Change-Id: Ief0ef8185accd68c7b99132393fa0a4db6be31c4
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/218380
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2021-10-28 17:37:18 +00:00
Konstantin Shcheglov 5135547aad Use Duration for waitForResponses() from plugins. 
Change-Id: I5cf1203559f601c0f5458e278a89b1fd83750ee7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/218340
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2021-10-28 15:24:12 +00:00
Konstantin Shcheglov 9243b20dcf Remove TODO for replacementOffset/Length, use them. 
Change-Id: I44c6e3f30ad29e3de7ab9a66ae2d18310a6315c3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/218328
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2021-10-28 15:20:28 +00:00
Danny Tuppeny 810dbd7fb2 [analysis_server] Fix dynamic registrations not occurring when onlyAnalyzeProjectsWithOpenFiles=true 
Fixes https://github.com/Dart-Code/Dart-Code/issues/3638.

Change-Id: I2749210a209fb0321f4833cf39c4d5fea55b579b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/218441
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2021-10-28 15:16:08 +00:00
Konstantin Shcheglov 0adfe513c0 Wait for completions from plugins with the remaining budget. 
If we wait for a fixed time, then we would spend any time we have
already spent, plus this fixed time. We probably want to restrict
how much we spend in total.

Change-Id: I457774456d7bac7d9d110784afd087f4a3d540eb
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/218323
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2021-10-27 22:11:38 +00:00
Konstantin Shcheglov 931121ee2e Create DartCompletionRequest using factory constructor. 
Change-Id: I05d7b444329c0bae6d3cd259ed015746963bf737
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/218327
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2021-10-27 22:10:07 +00:00
Konstantin Shcheglov afc0ff2048 Discover available files, filter by target and dependencies. 
Change-Id: Iad72c1e8c4d1d9cd8482ecdaebb0e2d17e74b0d5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/218321
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2021-10-27 22:00:07 +00:00
Konstantin Shcheglov 90f4b41eb0 Initial support for not yet imported libraries in getSuggestions2() 
Change-Id: I0d1a4ab68be0e9a50cd67defffef85fae79f4971
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/218183
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2021-10-27 15:25:27 +00:00
pq d4ebde69e7 bulk fix for prefer_interpolation_to_compose_strings 
Change-Id: Ieae0ec6d2bf7c2e911ddb7e7e3362145ba14dfed
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/217540
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
 2021-10-26 22:14:11 +00:00
pq e050ab05de bulk fix for prefer_expression_function_bodies 
Change-Id: I5facc84d37552153fbe1da7edb0589939183abd7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/217521
Commit-Queue: Phil Quitslund <pquitslund@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2021-10-26 20:11:50 +00:00
Konstantin Shcheglov 6e87bb3064 Support for isIncomplete flag. 
Change-Id: I36c8e2e9de4faec529604611e871191d2f4a7f66
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/218088
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2021-10-26 19:51:51 +00:00
pq 7636881d45 bulk fix support for prefer_const_constructors 
As noted in the tests, end results will be improved when we have multiple fix passes.

Fixes: https://github.com/dart-lang/sdk/issues/47519

Change-Id: I2625b6a15c31dbe9cd7ea5565fab1c64aa43d46b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/217742
Commit-Queue: Phil Quitslund <pquitslund@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2021-10-26 19:23:53 +00:00
Konstantin Shcheglov b73c62fef7 Initial implementation of 'completion.getSuggestions2'. 
Change-Id: Ie0d1d5a17662fa17b34c244268ecb051adbcafbc
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/218086
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2021-10-26 18:50:51 +00:00
Danny Tuppeny 9a873bc23f [analysis_server] Support formatting leading whitespace at the start or ranges in LSP format range 
Fixes https://github.com/Dart-Code/Dart-Code/issues/3583.

Change-Id: Id2974b173eb3589ff983316d1cec0ea1e45ecd97
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/218141
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2021-10-26 17:37:21 +00:00
Sam Rawlins 383f45ac7e Add DEPRECATED_NEW_IN_COMMENT_REFERENCE diagnostic 
This is a new HintCode for code in which comment-references is enabled.

`/// See also [new List].` is marked as deprecated, preferring a direct
reference (or "tear-off") of a constructor, like
`/// See also [List.new].`.

Additionally, a new quick fix supports making the above conversion,
taking into account both unnamed and named constructors.

Bug: https://github.com/dart-lang/sdk/issues/47446
Change-Id: Iec68ef21bd03198ea822979f6f0048cc655023c8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/217400
Commit-Queue: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Janice Collins <jcollins@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2021-10-26 16:52:51 +00:00
Konstantin Shcheglov 3753238bdf Extract methods to ask/waitFor completion plugins. 
Change-Id: Ia251fc64f0b286225dc84a5d86f29f6c804cf3d7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/218080
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2021-10-26 15:32:41 +00:00
Konstantin Shcheglov a156ee2f31 Remove CompletionRequest, use DartCompletionRequest only. 
Change-Id: I4ecec7c4bc55e6ffacf3023ed8ee62db456bdd4f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/218062
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2021-10-25 22:03:20 +00:00
Konstantin Shcheglov 76dadeecd9 Remove DartCompletionRequest, use what was Impl instead. 
I think we don't expect that users will write plugins that use these
types. So, we can remove the indirection.

Similarly, CompletionRequest is also currently de-facto a Dart
completion request, because it has `ResolvedUnitResult result`. I will
fold it into DartCompletionRequest in a future CL.

Change-Id: I2ea1d443ae18535f8c72f785dd1b91cf8d30ffa7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/218021
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2021-10-25 19:32:46 +00:00
Konstantin Shcheglov 9eddeaeb3a Make DartCompletionRequestImpl.from() synchronous. 
We give it (indirectly) ResolvedUnitResult, so it does not do any
async operation.

Change-Id: I2d29925fd20ea14bd984e6c3c226de466a03fb39
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/217824
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2021-10-25 17:47:00 +00:00
Danny Tuppeny bca554fcf4 [analysis_server] Make LSP semantic tokens consistently use "property" for top levels 
+ add a modifier to the "variable" used for import prefixes.

Change-Id: If448c3a481a3471a63b58455acaef4ebcfd1f37c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/217981
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2021-10-25 17:26:20 +00:00
Danny Tuppeny c9b5354100 [analysis_server] Add "annotation" modifier to identifiers used as annotations 
Fixes https://github.com/Dart-Code/Dart-Code/issues/3621.

Change-Id: Idf0cfb7f8a0b2a8b4f1ed269f125f6743fa19471
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/217940
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2021-10-25 17:07:40 +00:00
Konstantin Shcheglov 4258e469c2 Make DartCompletionRequestImpl immutable. 
Change-Id: I4828bf7b1f3c23eab9c8ca079a88e976013c7109
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/217840
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2021-10-25 16:34:29 +00:00
Konstantin Shcheglov 6a386a6b02 Extract fuzzyFilterSort() from Cider support. 
So that we can reuse it for getSuggestions2() request in the future.

Change-Id: I58ef19faedf27e727529bcdc6701a5137cf4ba43
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/217823
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2021-10-25 16:17:59 +00:00
Konstantin Shcheglov 75e984fe39 Don't pass DartCompletionRequest and SuggestionBuilder where already available. 
Change-Id: Ibfc2a59cde6c0bb03d8bfdfe2bbb45641e90c03a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/217841
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2021-10-25 15:35:20 +00:00
Danny Tuppeny fa5f6fc186 [analysis_server] Change LSP semantic tokens to use Property for class fields 
Fixes https://github.com/Dart-Code/Dart-Code/issues/3618.

Change-Id: I53b219dde6aeaaf64ac1b1a702b41c838c2b7819
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/217920
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2021-10-25 15:21:19 +00:00
Konstantin Shcheglov e916841bcc Deprecations and renames for getXyz() in AnalysisDriver. 
Presubmit looks green.
https://fusion2.corp.google.com/presubmit/tap/405055453/OCL:405055453:BASE:405057194:1634949541100:f811db8d/targets

Change-Id: I8f7f036003650611760523dd315ba89724a29b0d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/217805
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2021-10-23 17:15:33 +00:00
Konstantin Shcheglov 8e1e3c8f2c Pass DartCompletionRequestImpl to DartCompletionManager. 
We sometimes create it outside DartCompletionManager, and then call
and create it inside again.

Change-Id: Ifa5bd958437a5ea4e2bac65e7800183f915a9a07
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/217800
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2021-10-23 17:15:03 +00:00
Tim Sneath 5deec88041 Update diagnostics.dart 
Sorry -- fixing a grammar nit. I know it's a tiny thing, but it bugs me!

Closes https://github.com/dart-lang/sdk/pull/47535
https://github.com/dart-lang/sdk/pull/47535

GitOrigin-RevId: 5b6ec7c1a521a923f156e21bbcc81348043f45b4
Change-Id: Iea8bd74e20705cada2519b35183556c79eb0d265
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/217821
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2021-10-23 15:38:57 +00:00
pq 732224bcce bulk fix for avoid_unused_constructor_parameters 
Change-Id: I78f7af8f2f52325a558b553960b4a538a0f2e230
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/217543
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
 2021-10-21 18:59:20 +00:00
pq a21115245a bulk fix for use_full_hex_values_for_flutter_colors 
Change-Id: I930db55b7417e4c80ebf816435b4390a482f1b64
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/217541
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
 2021-10-21 18:51:36 +00:00
pq a52a43eb53 bulk fix for always_declare_return_types 
Change-Id: I31c1031062dbcd9b01e807af4578f9144af2eb2c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/217542
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
 2021-10-21 18:51:17 +00:00
Konstantin Shcheglov 4487759dd2 Document new DAS completion APIs. 
Change-Id: I2ff1f2c494033a62fead7d828d5d875b55eda203
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/215643
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2021-10-21 18:21:35 +00:00
pq 6dd4ff6a3b bulk fix support for RemoveUnusedCatchClause 
Change-Id: I2da4a200b31e6dbae5fcac476541e3517f79ccae
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/217440
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
 2021-10-20 18:54:31 +00:00
pq a399da8c9b bulk fix support for RemoveUnusedCatchStack 
Change-Id: If69c8c13715a864786944ed2cdbae31514db3481
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/217441
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
 2021-10-20 18:20:13 +00:00
pq 36bfe07b7a document un-bulk-fixable static warning corrections 
Change-Id: I8524b2147b00f3e213ae647e60c18eecbd74b401
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/217460
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
 2021-10-20 18:19:41 +00:00
pq 93370cb8b6 enable bulk fixes for use_eq_eq_null, use_not_eq_null, remove_comparison producers 
Change-Id: I91d057ffc8b8cb0053c968e1c46c4770949dfbd2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/217340
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
 2021-10-20 15:43:51 +00:00
pq f1c163e6c3 bulk fix support for use_effective_integer_division 
Change-Id: If1700c4adb83491d1173ea58cfac10f923331eb1
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/217341
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
 2021-10-20 15:34:12 +00:00
Ahmed Ashour c47cf76baf Fix typos 
Fixes https://github.com/dart-lang/sdk/issues/47505

Change-Id: Ic2e25800263e96b2b4282f89ec0be017c86d4adb
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/217361
Reviewed-by: Lasse R.H. Nielsen <lrn@google.com>
Commit-Queue: Lasse R.H. Nielsen <lrn@google.com>
 2021-10-20 10:51:53 +00:00
Ahmed Ashour d041cf0478 Remove extra the, be and of 
Fixes #https://github.com/dart-lang/sdk/issues/47504

TEST=No tests needed, only comments affected.

Change-Id: Ie096307b5ce314d328fea6780f396aaa226ad3b0
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/216182
Reviewed-by: Lasse R.H. Nielsen <lrn@google.com>
Commit-Queue: Lasse R.H. Nielsen <lrn@google.com>
 2021-10-20 09:29:01 +00:00
pq 378d304de8 document not bulk-fixable corrections 
Change-Id: I90bb91258ec0c900719fe06fbd4003690384aa28
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/217320
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
 2021-10-19 23:15:01 +00:00
Ahmed Ashour b7179853b5 [analyzer] add bulk and in-file fixes for AddTypeAnnotation 
Fixes https://github.com/dart-lang/sdk/issues/47222

Change-Id: I9155efe8a26359a872bbe9a74fadbe82e1014340
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/215762
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2021-10-19 21:22:44 +00:00
Ahmed Ashour f45a8553d0 [analyzer] ConvertToDoubleQuotes to be associated with prefer_double_quotes lint 
Fixes https://github.com/dart-lang/sdk/issues/47352

Change-Id: Ieb111ecdf6d0c9c8c47559d90dfe76203965e5d3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/215320
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2021-10-19 19:40:13 +00:00