When referring to constants via a deferred prefix in an await expression
the transformation must make sure that the generated code before and after
the deferred load agree on the number of captured variables. (i.e. the number
of await-temp variables introduced by the await-transformer is the same)
This CL uses a temporary in the case of compile-time constants, because before
the deferred load, a reference lib.C is translated into a static getter which
also requires a temporary.
Fixes#28678R=hausner@google.com
Review-Url: https://codereview.chromium.org/2683973002 .
Instead of “unresolved call to super constructor”, adapt error
message if the super class contains a factory constructor with
the same name.
Also add this error message clarification to constructor redirection
clauses.
BUG=#11202
R=fschneider@google.com
Review-Url: https://codereview.chromium.org/2673423003 .
parameters, whereas the class finalizer resolves all other type names and
performs finalization and canonicalization. This allows to remove a lot of
duplicated code between parser and class finalizer.
R=hausner@google.com
Review-Url: https://codereview.chromium.org/2673093003 .
The call in _evaluationAssertion becomes megamorphic and this is
showing up on Flutter's profile. Avoid the call becoming megamorphic
by inlining the body at the AST level.
BUG=
R=hausner@google.com
Review-Url: https://codereview.chromium.org/2655803007 .
For Dart 1.5, the VM ignores the annotation. It is just consumed by the parser, but has otherwise no effect. Errors are reported on illegal covariant declarations.
BUG=#28166
R=regis@google.com
Review-Url: https://codereview.chromium.org/2625823004 .
In some cases when loading a deferred library twice, the VM would crash/throw.
Make sure we generate the correct static NoSuchMethod error when referring to
a deferred library that is not loaded yet.
Fixes#28278.
R=rmacnak@google.com
Review-Url: https://codereview.chromium.org/2618823002 .
Clean up the VM's dart:core and dart:async library patches so that
they are clean according to the patching rules implemented in the
analyzer. Specifically:
- If a member is patched in a patch file, it must be declared external
in the SDK.
- If a member is introduced in a patch file, it must be private.
- A non-private superclass member cannot be overridden in a patch
file.
BUG=
R=lrn@google.com, sigmund@google.com
Review-Url: https://codereview.chromium.org/2563633002 .
Resolution is delayed to properly handle generic results of generic functions.
Resolution has to be done in the library declaring the function and not in the
library declaring a mixin application mixing in the function.
R=hausner@google.com
Review URL: https://codereview.chromium.org/2549443005 .
- [x] Add three public fields to the "BoundVariable" service type: declarationTokenPos, visibleStartTokenPos, and visibleEndTokenPos. (naming suggestions welcome!)
- [x] Extend LocalVarDescriptors to hold the declaration token position (it already had the scope visibility boundaries).
- [x] Extend ContextScope to hold the declaration token position.
- [x] Add a unit test which verifies this works for local variables, function parameters, and closure captured variables.
Fixes https://github.com/dart-lang/sdk/issues/25569
BUG=
R=rmacnak@google.com
Review URL: https://codereview.chromium.org/2419013004 .
When running with --load-deferred-eagerly, we don't need to collect
functions for invalidation, but instead insert runtime checks if
the prefix if loadLibrary was called loaded or not.
BUG=
R=rmacnak@google.com
Review URL: https://codereview.chromium.org/2415743004 .
Read and write parent_level field of function type parameters in snapshots.
Update TypeParameter::ToCString() to handle function type parameters.
Address Siva's comments in previous cl.
R=asiva@google.com
Review URL: https://codereview.chromium.org/2359543003 .
Eliminate the need to invoke an execute-once function to compute
type literals and implicit closures. This reduces the number of
execute-once invocations from 6000 to 60 when compiling all of
the greentea sources, about 1MB of generated code. Sadly, no
significant runtime gain was observed.
Also simplify the caching of computed compile-time constants.
Reinstate the compiler stat counter for number of constants cached.
BUG=
R=rmacnak@google.com
Review URL: https://codereview.chromium.org/2338463003 .
Florian Schneider