dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
44,449 Commits 2 Branches 0 Tags
5e09ca8d97c2b433c8ae45fcdcdcd11bd58ef3e3
Commit Graph

155 Commits

Author SHA1 Message Date
William Hesse 72b58ee3b6 Fix corelib_strong/sort_test on dev_compiler 
BUG=
R=jacobr@google.com, vsm@google.com

Review-Url: https://codereview.chromium.org/2683583009 .
 2017-02-08 23:06:52 +01:00
Jennifer Messerly 5817ba47e2 fix #28642, handling of top and bottom types in DDC 
in particular: void, Null, and combinations with FutureOr<T>

R=leafp@google.com

Review-Url: https://codereview.chromium.org/2671113002 .
 2017-02-06 14:56:10 -08:00
Vijay Menon c88a17ff55 Some test cleanup 
These tests occasionally time out on travis.  uri_test as well, but
there are two tests with that name, so I added code to disambiguate in
the logs.

R=jmesserly@google.com

Review-Url: https://codereview.chromium.org/2666593002 .
 2017-01-31 10:23:26 -08:00
Vijay Menon 50ccf6d9b5 Fix DOM constructors in inline JS 
R=jacobr@google.com

Review-Url: https://codereview.chromium.org/2659063002 .
 2017-01-27 09:47:13 -08:00
Vijay Menon fd94337b42 Fix for Animation and other polyfills 
The polyfill code needs to run before dart_sdk is loaded.  Otherwise, the registerExtension step on these types does not work.

Also fixes #27605

R=jacobr@google.com

Review-Url: https://codereview.chromium.org/2649613003 .
 2017-01-25 16:18:49 -08:00
Vijay Menon a91cc9cc9e Use microtasks in dart.async 
Not quite sure about this, but it makes ordering match for the example in  #28509

R=jmesserly@google.com

Review-Url: https://codereview.chromium.org/2653253002 .
 2017-01-25 16:14:01 -08:00
Jacob Richman d90ed8c295 Fix noSuchMethod handling of methods that are also extension methods. Fix noSuchMethod handling of methods with names that are rewritten in DDC e.g. "_get" instead of "[]" Fix some mirror system handling of symbols with names that are rewritten in DDC 
BUG=
R=jmesserly@google.com

Review-Url: https://codereview.chromium.org/2623053004 .
 2017-01-24 11:16:21 -08:00
Vijay Menon a27adee736 Update tests for FF 51 
A handful of tests started working in FF 51.

TBR=jmesserly@google.com

Review-Url: https://codereview.chromium.org/2655673003 .
 2017-01-24 08:32:17 -08:00
Bob Nystrom 590a188066 Use "Object" as the reified type of covariant override parameters. 
This ensures the runtime type is of the tear-off expression's static
type, even when accessed through a superclass.

I also moved the two tests into a subdirectory so they are easier to
find. (It is inscrutable to me why we would have a single directory
with 1,868 test files in it.) That involved enabling recursive
directory listing in codegen_test, which exposed a couple of things.

Fix #27484.

R=leafp@google.com

Review-Url: https://codereview.chromium.org/2641543003 .
 2017-01-18 14:48:42 -08:00
Vijay Menon 5b34e47f40 Fix subtyping check on number 
language_strong/null_is_test started failing on Konstantin's recent change.  Another test started passing.

Does this fix make sense to you guys?

TBR=leafp@google.com,scheglov@google.com

Review-Url: https://codereview.chromium.org/2638393004 .
 2017-01-18 13:27:27 -08:00
Vijay Menon 21e1ebc3aa Fixes to status 
TBR=rnystrom@google.com

Review-Url: https://codereview.chromium.org/2643793002 .
 2017-01-18 06:16:56 -08:00
Vijay Menon c83dac537f Throw TypeError on arg mismatch 
Improvement on #28286 - this is still not quite right as we'll throw a
TypeError instead of a NSM in certain cases depending on the order.
The spec will only throw a TypeError if NSM doesn't apply.

R=leafp@google.com

Review-Url: https://codereview.chromium.org/2636313002 .
 2017-01-17 16:26:22 -08:00
Vijay Menon 83f8ca4652 Fix status 
See #27259

TBR=rnystrom@google.com

Review-Url: https://codereview.chromium.org/2634303002 .
 2017-01-17 06:01:04 -08:00
Vijay Menon 14cf17d898 Fix FF tests 
TBR=rnystrom@google.com

Review-Url: https://codereview.chromium.org/2638493002 .
 2017-01-13 15:17:39 -08:00
Vijay Menon 1f5562e29c More test refactoring to catch failures 
Skip fewer tests.  Many are now passing.  Mark the rest as fail and test that they're still failing.

R=rnystrom@google.com

Review-Url: https://codereview.chromium.org/2634433002 .
 2017-01-13 09:02:45 -08:00
Vijay Menon 580186a655 Defend against false positives 
If a seemingly non-async test returns a Future, wait on it.  I noticed this on an earlier CL today related to the await_in_cascade_test - the test was broken, but we were falsely passing.

This still doesn't handle false negatives (e.g., tests that are expected to fail).  That's why many of these are marked skip_fail.  If the exception happens after main returns, we currently don't see it.

R=jmesserly@google.com

Review-Url: https://codereview.chromium.org/2629023002 .
 2017-01-11 14:34:07 -08:00
Vijay Menon be95523221 Cleanup references to the old DDC repo 
Reachable issues migrated over.

R=jmesserly@google.com

Review-Url: https://codereview.chromium.org/2621543004 .
 2017-01-10 12:56:29 -08:00
Vijay Menon 33c8f425b6 Disable auto "debugger" call for tests 
R=jacobr@google.com

Review-Url: https://codereview.chromium.org/2621823002 .
 2017-01-09 15:42:42 -08:00
Jacob Richman 93fb5d8119 Fix cross-window JS interop on FireFox. 
BUG=
R=vsm@google.com

Review-Url: https://codereview.chromium.org/2610813003 .
 2017-01-04 14:15:20 -08:00
Vijay Menon 77cd33722b Mark test failing on FF 
Jacob: looks like you changed the test just before the holidays?

TBR=jacobr@google.com

Review-Url: https://codereview.chromium.org/2610843002 .
 2017-01-04 05:53:57 -08:00
Bob Nystrom dca3e74882 blob_constructor_test is passing now. 
R=jacobr@google.com

Review-Url: https://codereview.chromium.org/2598853002 .
 2016-12-21 17:11:22 -08:00
Jacob Richman 7f26211c26 Correct handling of cross-frame functions in ddc. 
Misc fixes of dart:js support on ddc.
Work around issue with Blob constructor on ddc.
Fix incorrect dart:js test on dart2js (fixes https://github.com/dart-lang/sdk/issues/26197)

BUG=
R=alanknight@google.com, leafp@google.com, rnystrom@google.com

Review-Url: https://codereview.chromium.org/2587203002 .
 2016-12-19 15:00:55 -08:00
Jennifer Messerly 77f53f609f fixes #27385, implement virtual fields in DDC 
If a field is marked @virtual in Analyzer, DDC will allow it to be overridden as well

also fixes #28114, abstract getters/setters broke generation of forwarding getters/setters

R=vsm@google.com

Review-Url: https://codereview.chromium.org/2571363002 .
 2016-12-15 11:39:25 -08:00
Vijay Menon 392c242df9 Add dart:io stubs to ddc sdk, define dart.library.html 
Fixes #27302

R=brianwilkerson@google.com, jmesserly@google.com, rnystrom@google.com

Review-Url: https://codereview.chromium.org/2578573003 .
 2016-12-14 12:34:33 -08:00
Vijay Menon 94e4a98671 Migrate tests for initializing formals 
BUG=#27894
R=eernst@google.com

Review URL: https://codereview.chromium.org/2534293002 .
 2016-12-07 10:58:02 -08:00
Vijay Menon 69f0218802 Mark test pass on Chrome 55 
TBR=alanknight@google.com

Review URL: https://codereview.chromium.org/2554523002 .
 2016-12-05 05:55:44 -08:00
Vijay Menon 201c5b9297 Fix runtime strong mode error in ListMixin 
R=jacobr@google.com

Review URL: https://codereview.chromium.org/2544163002 .
 2016-12-01 15:41:46 -08:00
Alan Knight 1ff09b431f Keep only a single active stack trace, enables traces for thrown non-exceptions 
BUG=
R=jmesserly@google.com

Review URL: https://codereview.chromium.org/2545923002 .
 2016-12-01 13:41:08 -08:00
Vijay Menon 588f10ee8e Skip queryall_test on canary. See #27794 
R=alanknight@google.com

Review URL: https://codereview.chromium.org/2492903002 .
 2016-11-15 09:49:05 -08:00
Vijay Menon 9da150f2fb Mark two more tests as passing on DDC / FF 
TBR=alanknight@google.com

Review URL: https://codereview.chromium.org/2498423002 .
 2016-11-15 08:42:41 -08:00
Vijay Menon 5716000c23 Mark test as passing on FF 
Now passing on FF 50.

TBR=alanknight@google.com

Review URL: https://codereview.chromium.org/2506663002 .
 2016-11-15 08:18:09 -08:00
Bob Nystrom 8daf4cfb73 Get the basics of deferred libraries working. 
References to loadLibrary on a library prefix are compiled to a
helper function that returns a Future that always completes
successfully.

The deferred libraries aren't actually deferred, but code that uses
loadLibrary() now doesn't barf.

BUG=#27343
R=vsm@google.com

Review URL: https://codereview.chromium.org/2477673006 .
 2016-11-07 10:41:23 -08:00
Vijay Menon 4874480d55 Move FF and Canary to green on travis 
Try run is here:
https://travis-ci.org/dart-lang/sdk/builds/172400947

R=rnystrom@google.com

Review URL: https://codereview.chromium.org/2467063002 .
 2016-11-03 07:44:27 -07:00
Vijay Menon 2d15b4ae74 Type-related fixes 
R=jmesserly@google.com

Review URL: https://codereview.chromium.org/2468493003 .
 2016-10-31 15:01:29 -07:00
Vijay Menon e8fbfc4f0d Mark test as runtime failure 
pkg collection is now clean.

TBR=jmesserly@google.com

Review URL: https://codereview.chromium.org/2466533002 .
 2016-10-31 06:00:59 -07:00
Jennifer Messerly 644c1dca75 fix #27429, html wrapper methods pass incorrect number of arguments 
R=vsm@google.com

Review URL: https://codereview.chromium.org/2454173003 .
 2016-10-27 13:16:00 -07:00
Jennifer Messerly 982f9f46ed fix #27642, static members should now work 
R=vsm@google.com

Review URL: https://codereview.chromium.org/2440863002 .
 2016-10-21 11:25:47 -07:00
Jennifer Messerly cc1ad8cdde fix #27532, implementing a native type with fields 
R=vsm@google.com

Review URL: https://codereview.chromium.org/2430953006 .
 2016-10-20 15:59:18 -07:00
Bob Nystrom 60a966605d Remove uses of unittest in the HTML tests where possible. 
This finishes going through the dev_compiler HTML tests and switches
out unittest for minitest wherever possible.

In the process, it gets another 10 tests strong mode clean, and gets
several more passing, and more not skipped. With this CL, we're running
another 50 more HTML tests (though some are expected to fail, mostly
because of #27578).

R=jacobr@google.com, vsm@google.com

Review URL: https://codereview.chromium.org/2419863002 .
 2016-10-14 13:44:19 -07:00
Bob Nystrom ae5a566f98 Move minitest.dart into the expect package. 
R=vsm@google.com

Review URL: https://codereview.chromium.org/2416853003 .
 2016-10-13 14:15:21 -07:00
Bob Nystrom 2305865365 Start cleaning up the HTML tests. 
My initial goal was just to move some of the HTML tests off unittest,
but that ended up slurping in some other changes as well. I haven't
finished going through all of the tests, but this puts the
infrastructure in place and fixes a batch of them. I'll do more next.

Changes:

- Add a "minitest" package. This shims just enough of the unittest/test
  API to make it easy to swap it out for unittest without having to
  rework the entire test.

- Go through the HTML tests from A-J and change them to use minitest
  when possible. The ones that aren't possible use asynchrony.
  Minitest doesn't support async tests (yet, maybe).

- Triage those tests and enable ones that are passing. Mark them failing
  if failing. Filed a couple of tracking bugs for the common issues,
  but for other cases, I just left a comment.

- In the process of this, I went ahead and make some of the affected
  tests strong mode clean if they weren't already and it was easy.

- Synchronize changes between dev_compiler's fork of expect and
  pkg/expect. We'll want to unfork those at some point. D-:

This gets dev_compiler from 1985 tests to 2042.

R=jacobr@google.com, vsm@google.com

Review URL: https://codereview.chromium.org/2413073002 .
 2016-10-13 08:47:27 -07:00
Vijay Menon 2495f6a060 Handle private members in dart:mirrors 
R=rnystrom@google.com

Review URL: https://codereview.chromium.org/2410453002 .
 2016-10-10 15:55:20 -07:00
Bob Nystrom 9b6317d571 Stop using unittest in point_test and rectangle_test. 
This also makes rectangle_test strong mode clean. Alas, the test isn't
passing because of another bug, but once that bug is fixed, it should.

R=vsm@google.com

Review URL: https://codereview.chromium.org/2407913002 .
 2016-10-10 11:02:37 -07:00
Bob Nystrom b30571884f Use expect instead of unittest for json_lib_test. 
One step closer to removing the deprecated unittest.

R=vsm@google.com

Review URL: https://codereview.chromium.org/2402123002 .
 2016-10-10 09:42:40 -07:00
nshahan 0132d6114a Fix for the missing new keyword on an external factory call. 
Added a test for calling an external factory and updated expected test failures/errors from turning on the tests: js_typed_interop_test

Fixes #27443

R=jacob314@gmail.com, vsm@google.com

Review URL: https://codereview.chromium.org/2394103002 .
 2016-10-06 10:24:38 -07:00
Vijay Menon ef973f7d56 Restore unittests 
Fixes #27261

R=jmesserly@google.com, rnystrom@google.com

Review URL: https://codereview.chromium.org/2345853002 .
 2016-10-05 16:58:53 -07:00
Vijay Menon 68d2121fd0 Use .packages instead of pubspec.yaml 
This runs tests against sdk versions of packages instead of whatever
random version we have in pubspec.yaml.

Travis may be unhappy with the lack of a pubspec.yaml.  Here's the try:

https://travis-ci.org/dart-lang/sdk/builds/163270204

R=jmesserly@google.com, rnystrom@google.com

Review URL: https://codereview.chromium.org/2371113004 .
 2016-09-28 09:49:31 -07:00
Vijay Menon df832444ed Skip flaky (timeout) test 
TBR=jmesserly@google.com

Review URL: https://codereview.chromium.org/2298883005 .
 2016-09-01 16:02:51 -07:00
Vijay Menon 9af2fb0115 More DDC mirrors support 
(Note, this is a straight migration of the old DDC repo CL. :-))

R=jmesserly@google.com

Review URL: https://codereview.chromium.org/2301973002 .
 2016-09-01 10:13:31 -07:00
Vijay Menon b220f63954 Travis config 
See try-run here: https://travis-ci.org/dart-lang/sdk/builds/156699868

R=kevmoo@google.com

Review URL: https://codereview.chromium.org/2301833002 .
 2016-09-01 08:33:50 -07:00