dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
44,449 Commits 2 Branches 0 Tags
5e09ca8d97c2b433c8ae45fcdcdcd11bd58ef3e3
Commit Graph

13542 Commits

Author SHA1 Message Date
Vyacheslav Egorov 5e09ca8d97 Fasta: Change BodyBuilder.buildCompileTimeError to throw an instance of _CompileTimeError. 
This is a VM specific class that is recognized by exception handling code in VM.

Using this class instead of string guarantees that VM terminates with the correct exit code: kCompilationErrorExitCode (254) and not kErrorExitCode (255).

BUG=
R=ahe@google.com

Review-Url: https://codereview.chromium.org/2689543002 .
 2017-02-09 17:13:47 +01:00
Brian Wilkerson a191011c03 Update ChangeBuilder to the new driver 
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2688513003 .
 2017-02-09 07:51:42 -08:00
Peter von der Ahé b0c9753106 Use correct name of compile_test. 
R=dmitryas@google.com

Review-Url: https://codereview.chromium.org/2686073002 .
 2017-02-09 13:23:42 +01:00
Peter von der Ahé c13730e8ea Pay some naming debt. 
R=johnniwinther@google.com

Review-Url: https://codereview.chromium.org/2682993002 .
 2017-02-09 13:10:24 +01:00
Peter von der Ahé 616640d28b Handle operators correctly. 
R=johnniwinther@google.com

Review-Url: https://codereview.chromium.org/2680323002 .
 2017-02-09 13:04:31 +01:00
Peter von der Ahé f32f48bcd5 Mark fasta/compile test slow. 
Fixes https://github.com/dart-lang/sdk/issues/28701

R=dmitryas@google.com

Review-Url: https://codereview.chromium.org/2685103002 .
 2017-02-09 12:40:00 +01:00
Johnni Winther a2837b78d5 Refactor computation of NativeBehavior. 
- to prepare for kernel based implementation.

R=sigmund@google.com

Review-Url: https://codereview.chromium.org/2686533002 .
 2017-02-09 11:20:36 +01:00
Konstantin Shcheglov 832f10e589 Don't re-read files when compute their analysis results. 
We don't really need this.
The client must notify us that the file was changed.
Then we will re-read it.

R=brianwilkerson@google.com, paulberry@google.com
BUG=

Review-Url: https://codereview.chromium.org/2686843003 .
 2017-02-08 19:21:12 -08:00
William Hesse f7e08cc102 Update status for front-end unit tests 
BUG=https://github.com/dart-lang/sdk/issues/28698
TBR=ahe@google.com

Review-Url: https://codereview.chromium.org/2681033008 .
 2017-02-09 03:03:34 +01:00
Paul Berry 45fef2c266 Eliminate commentAndMetadata() from parser tests. 
This allows the parser tests to be rewritten in a way that will make
them easier to adapt to testing Fasta, because they no longer make
assumptions about data structures passed around inside the parser.

R=brianwilkerson@google.com

Review-Url: https://codereview.chromium.org/2684833004 .
 2017-02-08 16:49:25 -08:00
Paul Berry 9a82ada085 Remove hardcoded paths from perf.dart. 
This lets perf.dart find the SDK and the .packages file regardless of
the architecture that's being tested and the working directory in
which the script is started.

Fixes #28676.

R=sigmund@google.com

Review-Url: https://codereview.chromium.org/2687723002 .
 2017-02-08 16:48:20 -08:00
Paul Berry aa64ca9554 Eliminate emptyCommentAndMetadata() from parser tests. 
This allows the parser tests to be rewritten in a way that will make
them easier to adapt to testing Fasta, because they no longer make
assumptions about data structures passed around inside the parser.

R=brianwilkerson@google.com

Review-Url: https://codereview.chromium.org/2684703007 .
 2017-02-08 14:16:17 -08:00
William Hesse 72b58ee3b6 Fix corelib_strong/sort_test on dev_compiler 
BUG=
R=jacobr@google.com, vsm@google.com

Review-Url: https://codereview.chromium.org/2683583009 .
 2017-02-08 23:06:52 +01:00
Brian Wilkerson 5d0fa7dc21 Finish file rename operation (TBR) 
Review-Url: https://codereview.chromium.org/2685783005 .
 2017-02-08 13:56:56 -08:00
Konstantin Shcheglov c97317cee9 Ensure that returned cached source have the same actual URI. 
R=brianwilkerson@google.com
BUG=

Review-Url: https://codereview.chromium.org/2683043002 .
 2017-02-08 13:45:50 -08:00
Brian Wilkerson 6ca3a29f2f Rename generated file 
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2686933002 .
 2017-02-08 13:26:02 -08:00
Konstantin Shcheglov fa03f80b22 Compute pending errors for @Required named parameters. 
R=brianwilkerson@google.com
BUG=

Review-Url: https://codereview.chromium.org/2685043002 .
 2017-02-08 11:53:44 -08:00
Konstantin Shcheglov b6f6738b77 Extract hints generation into a separte method and make is optional. 
R=brianwilkerson@google.com
BUG=

Review-Url: https://codereview.chromium.org/2680373002 .
 2017-02-08 11:44:20 -08:00
Konstantin Shcheglov a980fc4790 Parse using FileState, so use all analysis options. 
R=brianwilkerson@google.com
BUG=

Review-Url: https://codereview.chromium.org/2681143002 .
 2017-02-08 10:06:15 -08:00
Konstantin Shcheglov 09556fa1f4 Resolve import/export directives in analyzer itself, report non-libraries. 
R=brianwilkerson@google.com
BUG=

Review-Url: https://codereview.chromium.org/2684793003 .
 2017-02-08 09:33:45 -08:00
Peter von der Ahé bc0fb7668c Include stack in error about unhandled event. 
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2685903002 .
 2017-02-08 17:51:50 +01:00
Konstantin Shcheglov ab108234af Filter out ignored errors without tasks. 
R=brianwilkerson@google.com
BUG=

Review-Url: https://codereview.chromium.org/2682013003 .
 2017-02-08 08:44:38 -08:00
Konstantin Shcheglov 2f741af001 Fix for 'execution.mapUri' with the new analysis driver. 
R=brianwilkerson@google.com
BUG=

Review-Url: https://codereview.chromium.org/2682983002 .
 2017-02-08 08:40:59 -08:00
Konstantin Shcheglov 8bc597f04b Compute also constant dependencies reference in method bodies. 
R=brianwilkerson@google.com
BUG=

Review-Url: https://codereview.chromium.org/2679373003 .
 2017-02-08 08:38:23 -08:00
Devon Carew eb655b6d32 Fix a few typos in the front_end package. 
BUG=
R=paulberry@google.com

Review-Url: https://codereview.chromium.org/2680013006 .
 2017-02-08 08:35:05 -08:00
Paul Berry 67463b0f7d Make some parser test helper methods non-static. 
This paves the way for allowing more of analyzer's parser tests to be
run on both Fasta's parser and the analyzer parser.

R=brianwilkerson@google.com, scheglov@google.com

Review-Url: https://codereview.chromium.org/2683543006 .
 2017-02-08 08:24:55 -08:00
Brian Wilkerson a69189972c Add failing test 
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2683793003 .
 2017-02-08 08:13:37 -08:00
Devon Carew 5f8341a388 Update the contributing file for the analysis server. 
BUG=
R=brianwilkerson@google.com

Review-Url: https://codereview.chromium.org/2685913002 .
 2017-02-08 08:13:20 -08:00
Brian Wilkerson f70f023261 Add an interface for request parameters 
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2679093004 .
 2017-02-08 07:44:09 -08:00
Peter von der Ahé a881e826dc Resolve type variables of generic methods. 
R=sigmund@google.com

Review-Url: https://codereview.chromium.org/2672993003 .
 2017-02-08 16:11:20 +01:00
Peter von der Ahé 98c93c3c92 Revert "Use ProcedureKind.Operator for operators." 
This reverts commit 025ad56fcc.

Revert "Add enum for user-definable operators."

This reverts commit 91bea04dcb.

Review-Url: https://codereview.chromium.org/2682113003 .
 2017-02-08 15:44:23 +01:00
Peter von der Ahé 025ad56fcc Use ProcedureKind.Operator for operators. 
R=johnniwinther@google.com

Review-Url: https://codereview.chromium.org/2684763004 .
 2017-02-08 15:38:01 +01:00
Peter von der Ahé 9a5f9aa9d7 Correctly resolve package parts. 
R=vegorov@google.com

Review-Url: https://codereview.chromium.org/2682103002 .
 2017-02-08 15:15:01 +01:00
Peter von der Ahé 91bea04dcb Add enum for user-definable operators. 
R=lrn@google.com

Review-Url: https://codereview.chromium.org/2684933002 .
 2017-02-08 15:04:05 +01:00
Paul Berry 5a714dd192 Update fasta scanner tests to refer to #28665. 
R=sigmund@google.com

Review-Url: https://codereview.chromium.org/2682753003 .
 2017-02-08 05:14:56 -08:00
Johnni Winther 1498e533e0 Remove LibraryEntity.libraryName 
- use libraryName for LibraryElement.name if available.

R=sigmund@google.com

Review-Url: https://codereview.chromium.org/2632643002 .
 2017-02-08 11:37:01 +01:00
Johnni Winther af4b2b8e30 Extract InterceptorData from JavaScriptBackend. 
R=sigmund@google.com

Review-Url: https://codereview.chromium.org/2680823002 .
 2017-02-08 11:04:53 +01:00
Johnni Winther 52efadefc2 Replace Backend with JavaScriptBackend. 
R=sigmund@google.com

Review-Url: https://codereview.chromium.org/2685573002 .
 2017-02-08 10:50:55 +01:00
Johnni Winther 20e2aa4f0e Fix access to returnTypeOf 
- a field does not have a return type.

Review-Url: https://codereview.chromium.org/2685783003 .
 2017-02-08 10:08:23 +01:00
Konstantin Shcheglov fe3286ad4b Resolve Library/Part/PartOf/Directive(s) in AST without tasks. 
R=brianwilkerson@google.com
BUG=

Review-Url: https://codereview.chromium.org/2680883004 .
 2017-02-07 18:20:39 -08:00
Paul Berry 6c86822bf5 Separate fasta and analyzer scanner tests. 
This makes it easier to run one set of tests or the other.

R=sigmund@google.com

Review-Url: https://codereview.chromium.org/2680903002 .
 2017-02-07 17:36:52 -08:00
Sigmund Cherem b14963b443 Adjust status file for perf_test on windows and mac. 
Review-Url: https://codereview.chromium.org/2686743002 .
 2017-02-07 16:01:08 -08:00
Sigmund Cherem 25e94e2e0b Small fix to perf.dart. 
This also makes perf_test.dart do something useful. It now executes perf.dart on
a small file from pkg/front_end. This may help to detect early when the
peformance bots will see a failure. I've only tested this in linux, but given
that's the OS of the perf bots, I'm ok skipping this in other OSs.

R=paulberry@google.com

Review-Url: https://codereview.chromium.org/2677423002 .
 2017-02-07 15:07:57 -08:00
Emily Fortuna f8f60f1ec4 Fix the loops break label test with Kernel. 
BUG=https://github.com/dart-lang/sdk/issues/28670
R=sigmund@google.com

Review-Url: https://codereview.chromium.org/2682823002 .
 2017-02-07 14:49:29 -08:00
Sigmund Cherem ac6bf5926f Temporarily allow to import dart:io in client apps. 
Disclaimer: I am not in favor of this approach, but it appears to be the least
worst option at the time.

Reach out to kevmoo@ or dgrove@ for details.

R=lrn@google.com, sra@google.com, dgrove@google.com, kevmoo@google.com

Review-Url: https://codereview.chromium.org/2675023002 .
 2017-02-07 14:02:04 -08:00
Brian Wilkerson 82d0383566 Revert "Add an interface for request parameters" 
Review-Url: https://codereview.chromium.org/2683583004 .
 2017-02-07 13:34:58 -08:00
Brian Wilkerson 41685ccf9a Add an interface for request parameters 
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2680053002 .
 2017-02-07 12:54:02 -08:00
Konstantin Shcheglov e5776b3311 Always add the target library to the store. 
So, we can remove the workaround in analyzer.

R=brianwilkerson@google.com
BUG=

Review-Url: https://codereview.chromium.org/2682783002 .
 2017-02-07 11:24:35 -08:00
Konstantin Shcheglov be37e10b72 Make fields private, add DeclaredVariables, put library into a field. 
progress

R=brianwilkerson@google.com
BUG=

Review-Url: https://codereview.chromium.org/2679243002 .
 2017-02-07 11:18:18 -08:00
Paul Berry 5c3ad68f13 Rename parser_test_fasta.dart to parser_fasta_test.dart. 
Tests must be named "..._test.dart" in order to be run by the build
bots.

R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2682753002 .
 2017-02-07 11:12:49 -08:00