Commit Graph

8 Commits

Author SHA1 Message Date
Ryan Macnak c1f11fed3f [tools] Fix binary_size to work with Dart AOT snapshots.
- Make the size tools less dependent on quirks mode.
 - Add explicit language attribute so Chrome stops offering to translate.
 - Add zip_size to look at the Dart SDK and Flutter APKs.

Change-Id: I0017bd68145344e2427644fcccd13f9b9f307218
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/428064
Reviewed-by: Brian Quinlan <bquinlan@google.com>
Commit-Queue: Ryan Macnak <rmacnak@google.com>
2025-05-12 15:29:08 -07:00
Ryan Macnak cfd0ae327e [tools] Remember the current view in the URL fragment.
Change-Id: I516914b3b64269571c0932a8bcada3891b266c15
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/425361
Reviewed-by: Brian Quinlan <bquinlan@google.com>
Commit-Queue: Ryan Macnak <rmacnak@google.com>
2025-04-29 13:01:59 -07:00
Ryan Macnak b86d7de6f0 [tools] Tweaks to binary_size.
- Group symbols with no path by C++ namespace.
 - Fix layout in Firefox.
 - Don't remove paths containing only one symbol.

Change-Id: I951e2df0b46919bc40ae0e1db641f7422310e45d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/425153
Reviewed-by: Brian Quinlan <bquinlan@google.com>
Commit-Queue: Ryan Macnak <rmacnak@google.com>
2025-04-28 17:05:58 -07:00
Ryan Macnak 2118f18f50 [tools] Consume bloaty's output instead of nm for binary size analysis.
This makes the attribution of file bytes much more exhaustive.

Change-Id: Ie582b30cc0fb72f84ace447e88581b5759134d82
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/423764
Reviewed-by: Brian Quinlan <bquinlan@google.com>
2025-04-23 09:45:39 -07:00
Ryan Macnak 7d5d3ae6a5 [tools] Add sections without symbols into binary_size's treemap.
This makes the cost of especially unwind tables and relocation visible and gets the treemap's total much closer the stripped binary size.

Change-Id: I1123e294b79b83cd709e7dc6e8e89c7a9545ef2c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/423605
Commit-Queue: Ryan Macnak <rmacnak@google.com>
Reviewed-by: Brian Quinlan <bquinlan@google.com>
2025-04-22 09:53:50 -07:00
Ryan Macnak 26ce00d68c [tools] Add binary size tool.
Compared to (Chromium's) third_party/binary_size, this tool better simplifies paths and can handle `dart:` and `package:` "paths".

Cf. e32d98cd06.

Change-Id: I9e757d9ba8422024584586899481279f7fd6542d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/387840
Reviewed-by: Brian Quinlan <bquinlan@google.com>
Commit-Queue: Ryan Macnak <rmacnak@google.com>
2024-10-07 22:32:26 +00:00
Siva Annamalai 2e731c540a Revert "[tools] Replace the Chromium binary size tool, which no longer works."
This reverts commit e32d98cd06.

Reason for revert: Dart rolls into the engine are failing because there are references to run_binary_size_analysis in the "Upload artifacts android-arm64-release" step of the build

Original change's description:
> [tools] Replace the Chromium binary size tool, which no longer works.
>
> Change-Id: Id84717e21a129a392d3bc4e9b4cce84dfb4771e1
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/231066
> Reviewed-by: Ben Konyi <bkonyi@google.com>

# Not skipping CQ checks because original CL landed > 1 day ago.

Change-Id: Ibfbdf1e0a970ad7fae9ec1d39d24722647b38730
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/231600
Reviewed-by: Siva Annamalai <asiva@google.com>
Reviewed-by: Ben Konyi <bkonyi@google.com>
Commit-Queue: Siva Annamalai <asiva@google.com>
2022-02-04 02:11:06 +00:00
Ryan Macnak e32d98cd06 [tools] Replace the Chromium binary size tool, which no longer works.
Change-Id: Id84717e21a129a392d3bc4e9b4cce84dfb4771e1
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/231066
Reviewed-by: Ben Konyi <bkonyi@google.com>
2022-02-02 17:22:38 +00:00