dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
83,955 Commits 2 Branches 0 Tags
5933e2dfbcebc021fdeea1bbcf9830f1e47f7321
Commit Graph

340 Commits

Author SHA1 Message Date
Ben Konyi f9147d933e [ Service ] Update VM service message to not reference Observatory 
See https://github.com/dart-lang/sdk/issues/46756

TEST=Existing

Change-Id: Ib71bf00d667369d7438a4547ae444951ec0979df
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/233504
Reviewed-by: Siva Annamalai <asiva@google.com>
Commit-Queue: Ben Konyi <bkonyi@google.com>
 2022-02-18 20:53:52 +00:00
Devon Carew bd5da72538 [dartdev] tweak the pubspec file generation for 'dart create' 
Change-Id: I769ef258b9875aeeb23bc9aeca396bc9594197d4
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/232980
Auto-Submit: Devon Carew <devoncarew@google.com>
Reviewed-by: Ben Konyi <bkonyi@google.com>
Commit-Queue: Ben Konyi <bkonyi@google.com>
 2022-02-14 21:23:59 +00:00
Alexander Thomas 30beab0f43 [infra] Add OWNERS to the Dart SDK 
* Add team "groups" in tools/OWNERS_<group name>.
* Add top-level OWNERS as a fallback.
* Add OWNERS for all top-level directories.
* Add OWNERS to all packages.

For additional background information see go/dart-sdk-owners.

TEST=No op until code-owners is enabled.
Bug: b/200915407
Change-Id: I7fe6116cc599c749cd50ca16151d6d6a801d99d7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/229147
Reviewed-by: Jonas Termansen <sortie@google.com>
 2022-02-14 14:06:34 +00:00
Devon Carew 554b001ad9 [dartdev] adjust the behavior of several 'dart doc' cli flags 
Change-Id: I9efdd71da948b87b0fcbcd2b3e242647131462b9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/232120
Reviewed-by: Ben Konyi <bkonyi@google.com>
Commit-Queue: Devon Carew <devoncarew@google.com>
 2022-02-10 18:55:41 +00:00
Kenzie Schmoll deb9cd31e7 Add missing 'help' option to DevTools server arg parser. 
This option existed in the previous impl of devtools server: https://github.com/flutter/devtools/blob/v2.10.0/packages/devtools_server/lib/src/server.dart#L507-L516

Change-Id: Icdc2f1b29e9128531a51fbc471c7b52e761e8f31
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/232122
Reviewed-by: Ben Konyi <bkonyi@google.com>
Commit-Queue: Ben Konyi <bkonyi@google.com>
Commit-Queue: Kenzie Davisson <kenzieschmoll@google.com>
 2022-02-08 19:15:56 +00:00
Ben Konyi 250173e60c [ CLI ] dartdev null-safety migration cleanup 
Follow-up to https://dart-review.googlesource.com/c/sdk/+/229948

Change-Id: If5624638eeb629ea025ec04b6a11d23144ea43ae
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/231741
Auto-Submit: Ben Konyi <bkonyi@google.com>
Commit-Queue: Ben Konyi <bkonyi@google.com>
Reviewed-by: Siva Annamalai <asiva@google.com>
Commit-Queue: Siva Annamalai <asiva@google.com>
 2022-02-04 19:23:40 +00:00
Devon Carew cc019ea118 [dartdev] have the 'doc' command default to documenting the cwd 
Change-Id: Id1d0394f6ecc300d100d0269a8df4d1a519422cf
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/230820
Reviewed-by: Ben Konyi <bkonyi@google.com>
Reviewed-by: Michael Thomsen <mit@google.com>
Commit-Queue: Devon Carew <devoncarew@google.com>
 2022-02-02 23:55:46 +00:00
Devon Carew 0571cfe655 [dartdev] turn on the prefer_single_quotes lint 
Change-Id: I43c964c769a98ca4796e7172254835088adbc088
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/230800
Auto-Submit: Devon Carew <devoncarew@google.com>
Commit-Queue: Devon Carew <devoncarew@google.com>
Reviewed-by: Ben Konyi <bkonyi@google.com>
Commit-Queue: Ben Konyi <bkonyi@google.com>
 2022-01-28 19:21:15 +00:00
Ben Konyi d1baf327a1 [ DDS / CLI ] Add serveDevToolsWithArgs to devtools_server library 
Also moves ArgParser creation for `dart devtools` from dartdev to
devtools_server

Change-Id: I26e0c1a14eeccda163c9e62a240c4bd57a13f382
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/230541
Reviewed-by: Kenzie (Schmoll) Davisson <kenzieschmoll@google.com>
Commit-Queue: Ben Konyi <bkonyi@google.com>
 2022-01-28 00:02:01 +00:00
Sigurd Meldgaard bc7554107b Bump pub to 8f5ab7b1aba3b9f66b56246d77e167990339d317 
Changes:
```
> git log --format="%C(auto) %h %s" dcb6aba..8f5ab7b
 https://dart.googlesource.com/pub.git/+/8f5ab7b1 Avoid raceconditions in `global activate`, `run` and `global run` (#3285)
 https://dart.googlesource.com/pub.git/+/6e03ec02 Support multiple packages in 'dart pub add' (#3283)
 https://dart.googlesource.com/pub.git/+/1a298f4d Fix --verbose doc, and accept verboseness setting from embedder (#3279)
 https://dart.googlesource.com/pub.git/+/5bda798c Avoid race condition for hosted source on package extraction (#3277)
 https://dart.googlesource.com/pub.git/+/17c5addb Error on acquireDependencies when the root pubspec has an unknown sdk in the environment. (#3271)
 https://dart.googlesource.com/pub.git/+/0a32ae4a folder/* should not ignore the folder itself, only the contents (#3267)
 https://dart.googlesource.com/pub.git/+/44b785aa Normalize file names for tar.gz (#3268)
 https://dart.googlesource.com/pub.git/+/2fd6b5f0 Fix repository specification: isRetracted -> retracted (#3249)
 https://dart.googlesource.com/pub.git/+/0fc71db4 Write log trace to $PUB_CACHE/log/pub_log.txt when crashing (#3240)

```

Diff: https://dart.googlesource.com/pub.git/+/dcb6abac2d7d43258c03b348be42bf4aab9529b1~..8f5ab7b1aba3b9f66b56246d77e167990339d317/
Change-Id: I54f1fde0f50ca19ca036bb1e6d9b166455031183
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/229542
Reviewed-by: Jonas Jensen <jonasfj@google.com>
Commit-Queue: Sigurd Meldgaard <sigurdm@google.com>
 2022-01-27 11:17:00 +00:00
Ben Konyi 1c571a12fa [ CLI ] Migrate package:dartdev to null safety 
Fixes https://github.com/dart-lang/sdk/issues/47964

TEST=CQ

Change-Id: I4ee57bc5739835824b0052bd9470a0d52ccf161b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/229948
Reviewed-by: Devon Carew <devoncarew@google.com>
Commit-Queue: Ben Konyi <bkonyi@google.com>
 2022-01-26 21:16:49 +00:00
Michael Thomsen a0475234aa Adding a few more dartdoc flags, 
needed to convert the bots to call "dart doc" rather than "dartdoc"

Change-Id: Id2cda151079dc4b279b0df8cf7ada364297adcb9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/228920
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Commit-Queue: Michael Thomsen <mit@google.com>
 2022-01-23 18:42:06 +00:00
Sigmund Cherem 8415b70e75 [dart2js] recommend using 'dart compile js'. 
This is the first deprecation step, moving towards having dart2js
under the more general dart command line interface.

Going forward 'dart compile js' is the recommended way to invoke
dart2js.

This CL adds:
* an internal flag used to detect how was dart2js invoked and
  provide a warning when invoked in an unsupported way.
* ensures the flag is provided in the dart cli, as well as our
  (developer's only) scripts. These scripts will likely move to a
  different location in the future. Note that the `dart2js_sdk*`
  scripts are not providing this flag (these are the script that get
  eventually shipped with our built SDK), as such, invokations of the
  dart2js binary will show the new warning.

Change-Id: I96e40ecf01598eadab20dfc59114f5fff7438084
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/229062
Reviewed-by: Joshua Litt <joshualitt@google.com>
Commit-Queue: Sigmund Cherem <sigmund@google.com>
 2022-01-21 16:42:40 +00:00
Ben Konyi e557fef27d [ CLI ] Fix incorrect string in smoke_test.dart 
Change-Id: Ic60b0010d97b138c6afaa2d3606f4e41598fc41b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/229120
Reviewed-by: Ben Konyi <bkonyi@google.com>
Commit-Queue: Ben Konyi <bkonyi@google.com>
 2022-01-20 04:33:26 +00:00
Konstantin Shcheglov 6d5543e01b [analyzer] Update generated experiments 
experimental_features.yaml was updated in
https://dart-review.googlesource.com/c/sdk/+/219789
but unfortunately the analyzer code wasn't regenerated.

This CL updates the generated files and adds capability of checking
consistency to the generator. A check of consistency is add next to
the check for consistency used in presubmit for the CFE counterpart.

Was: https://dart-review.googlesource.com/c/sdk/+/224520
Change-Id: I59be4335ee81743aca5dc48eaa0df278d64d3692
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/229020
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2022-01-20 00:07:36 +00:00
Ben Konyi 0c2079561b [ DDS ] Handle case where requested DDS port is already in use 
Instead of hanging with no output to the console, a useful error message
is output to the console before shutting down the VM process.

Fixes https://github.com/dart-lang/sdk/issues/48160

Change-Id: Ib37c0cdf8b1bae6f164abff4a3b3100e944d8a3c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/228961
Reviewed-by: Ryan Macnak <rmacnak@google.com>
Commit-Queue: Ben Konyi <bkonyi@google.com>
 2022-01-19 22:43:37 +00:00
Ben Konyi 3b736b8460 [ package:dds ] Migrate package:devtools_server functionality under package:dds/devtools_server.dart 
Will allow for us to remove dependencies on package:devtools_server in
various packages.

Change-Id: I055cc7bb05d5b4ce0071e3f88a71cb9596e76c74
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/228022
Reviewed-by: Kenzie (Schmoll) Davisson <kenzieschmoll@google.com>
Commit-Queue: Ben Konyi <bkonyi@google.com>
 2022-01-18 22:42:05 +00:00
Devon Carew 27d9a24e53 [dartdev] rename the 'dart doc' output directory option 
Change-Id: I9b6a9ebf47e947072a104da76ec20a5f9608c9a0
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/227941
Reviewed-by: Ben Konyi <bkonyi@google.com>
Commit-Queue: Devon Carew <devoncarew@google.com>
 2022-01-18 21:54:58 +00:00
Danny Tuppeny 650b9627b7 [analysis_server] Rebuild analysis contexts if changes occur between creation and watchers being ready 
See https://github.com/Dart-Code/Dart-Code/issues/3438.

Change-Id: I3ca038d8c878b118a465b6f230c62912d63990eb
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/222763
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2022-01-15 00:18:41 +00:00
Devon Carew 0a9fb1723e [dartdev] update help text for 'dart doc' 
Change-Id: Iac786b3dd471c4650e42aefacdddb177370f38f5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/227921
Reviewed-by: Ben Konyi <bkonyi@google.com>
Commit-Queue: Devon Carew <devoncarew@google.com>
 2022-01-12 23:46:42 +00:00
Alexander Aprelev f40b06a8ac [dartdev] Make directory cleanup more resilient on Windows. 
Processes on Windows can take longer to exit, taking longer for directories they use to become available for deletion. Accommodate this potentially lengthy by trying several times to delete temp directories before failing the test.

Fixes https://github.com/dart-lang/sdk/issues/47700
TEST=run_test on Windows

Change-Id: Id73d6ba3ff981ed59c89ab833f5775eff5375ae6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/226980
Reviewed-by: Ben Konyi <bkonyi@google.com>
Commit-Queue: Alexander Aprelev <aam@google.com>
 2022-01-07 19:12:56 +00:00
Alexander Aprelev eb4eade02a [vm/gen_snapshot] Avoid redundant compilation when generating kernel snapshot. 
Fixes https://github.com/dart-lang/sdk/issues/39580
TEST=ci

Change-Id: I98e7201350433754c9ff1746e1d6e24b7107099e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/225740
Reviewed-by: Slava Egorov <vegorov@google.com>
Commit-Queue: Alexander Aprelev <aam@google.com>
 2022-01-05 17:51:26 +00:00
Ben Konyi 7a7c36ab2f Revert "[ CLI ] Attempt to execute samples generated by 'dart create' templates" 
This reverts commit e59f59d49a.

Reason for revert: Causing timeout failures on pkg-{mac,win}-release

Original change's description:
> [ CLI ] Attempt to execute samples generated by 'dart create' templates
>
> Fixes https://github.com/dart-lang/sdk/issues/47458
>
> Change-Id: Icf3c03c6d1f33ef9be30e4bf826813674e9e9fb7
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/220883
> Reviewed-by: Devon Carew <devoncarew@google.com>
> Commit-Queue: Ben Konyi <bkonyi@google.com>

TBR=mit@google.com,devoncarew@google.com,bkonyi@google.com

Change-Id: Id27c1f9ec124dad8556e1733220284180302b30e
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/226561
Reviewed-by: Ben Konyi <bkonyi@google.com>
Commit-Queue: Ben Konyi <bkonyi@google.com>
 2022-01-05 17:43:15 +00:00
Ben Konyi dc0b571335 [ VM / CLI ] Remove service flags from VM and the CLI when building in 
PRODUCT mode

Fixes https://github.com/dart-lang/sdk/issues/47813

TEST=Manual testing, CQ

Change-Id: I50e57fa653c45c892e748d4e283617200cee0c0a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/224860
Reviewed-by: Siva Annamalai <asiva@google.com>
Commit-Queue: Ben Konyi <bkonyi@google.com>
 2022-01-04 19:53:11 +00:00
Ben Konyi e59f59d49a [ CLI ] Attempt to execute samples generated by 'dart create' templates 
Fixes https://github.com/dart-lang/sdk/issues/47458

Change-Id: Icf3c03c6d1f33ef9be30e4bf826813674e9e9fb7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/220883
Reviewed-by: Devon Carew <devoncarew@google.com>
Commit-Queue: Ben Konyi <bkonyi@google.com>
 2022-01-04 17:48:56 +00:00
Konstantin Shcheglov 8d8da75060 Stop using package:intl, but keep in DEPS. 
Initial: https://dart-review.googlesource.com/c/sdk/+/224660
Reverted: https://dart-review.googlesource.com/c/sdk/+/225260
Change-Id: I66ef3126997c4f564e4181bbe185a1f64abf43e8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/225324
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2021-12-22 01:17:04 +00:00
Konstantin Shcheglov 73cfe523e0 Revert "Stop using package:intl, remove it from DEPS." 
This reverts commit b0d7c56e84.

Reason for revert: breaks Golem, we need these benchmarks.

Original change's description:
> Stop using package:intl, remove it from DEPS.
>
> Change-Id: I7a6c036f7cd2c5ac64b0ab5a8b87bed1b9f34034
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/224660
> Reviewed-by: Samuel Rawlins <srawlins@google.com>
> Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
> Commit-Queue: Konstantin Shcheglov <scheglov@google.com>

TBR=scheglov@google.com,brianwilkerson@google.com,srawlins@google.com

Change-Id: I39d4a2c773063da4dfa75404b64987f85dbcf764
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/225260
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2021-12-21 19:08:24 +00:00
Konstantin Shcheglov b0d7c56e84 Stop using package:intl, remove it from DEPS. 
Change-Id: I7a6c036f7cd2c5ac64b0ab5a8b87bed1b9f34034
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/224660
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2021-12-21 17:19:53 +00:00
Ben Konyi 78b7fc5ac1 [ CLI / Gardening ] Wait for process to exit before cleaning up test 
directory

Fixes https://github.com/dart-lang/sdk/issues/47700

Change-Id: Ifc0783409bdea308ba861f8021489ea8e58022c3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/224080
Reviewed-by: Siva Annamalai <asiva@google.com>
Commit-Queue: Ben Konyi <bkonyi@google.com>
 2021-12-15 01:13:15 +00:00
Michael Thomsen 7da2117892 Initial 'dart doc' developer command 
Initial 'dart doc' command for the unified 'dart' developer tool,
over time replacing the exiting 'bin/dartdoc' tool.

This is a second attempt after the previous got reverted:
https://dart-review.googlesource.com/c/sdk/+/217980

The first attempt, which was already reviewed, is
in patchset 1.

Change-Id: Id9e0e572944ba032c32f3cebec579ab23d0df036
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/220744
Commit-Queue: Michael Thomsen <mit@google.com>
Reviewed-by: Ben Konyi <bkonyi@google.com>
Reviewed-by: Samuel Rawlins <srawlins@google.com>
 2021-12-06 10:26:09 +00:00
Sam Rawlins ed086ad778 dart fix: report when --compare-to-golden has unchanged files 
I was pretty confused about what was being compared until this change
was able to highlight that no edits were made.

Bug: https://github.com/dart-lang/sdk/issues/47678
Change-Id: I1d37070437658063d4b84f2fb5f4a33923bf5d92
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/221840
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
 2021-12-01 20:44:06 +00:00
Ben Konyi c39b243435 [ CLI ] Avoid awaiting on join() calls in test harness 
Fixes #47750

Change-Id: I179a9e987cea157257d40d6e840e9f4ff5539877
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/221543
Commit-Queue: Ben Konyi <bkonyi@google.com>
Reviewed-by: William Hesse <whesse@google.com>
 2021-11-30 16:39:25 +00:00
Vyacheslav Egorov 71c9c2cd83 [vm] Remove support for non-bare AOT snapshots 
Every AOT user out there has been using bare instructions mode
and continuing to maintaining non-bare instructions mode simply
adds costs (both in terms of time spent making changes to work
in a mode that is not used and CI resources spent on testing it).

This change removes FLAG_use_bare_instructions and changes the code
to assume that FLAG_precompiled_mode implies bare instructions.

TEST=ci

Cq-Include-Trybots: luci.dart.try:vm-kernel-precomp-linux-debug-x64-try,vm-kernel-precomp-linux-debug-x64c-try,vm-kernel-precomp-linux-product-x64-try,vm-kernel-precomp-dwarf-linux-product-x64-try,vm-kernel-precomp-obfuscate-linux-release-x64-try,app-kernel-linux-release-x64-try,app-kernel-linux-debug-x64-try
Change-Id: I5032b13bfcb613f79865f2cfa139cca8d1b42556
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/220964
Commit-Queue: Slava Egorov <vegorov@google.com>
Reviewed-by: Martin Kustermann <kustermann@google.com>
 2021-11-24 13:03:52 +00:00
Brian Wilkerson 8fd4647032 Iterate until all fixable diagnostics have been fixed 
Change-Id: Ibd8bcf36f7813fd39a2c3733ac2a933971a8cce9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/221140
Reviewed-by: Phil Quitslund <pquitslund@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2021-11-23 18:23:01 +00:00
Ben Konyi 2408d38878 [ CLI / Gardening ] Kill test subprocesses before deleting directories 
Previously, if a test timed out and the `tearDown` callback was invoked
to cleanup the temporary project, we would try and cleanup the temporary
directory even if the subprocess hadn't exited. This works fine on most
platforms, but causes an exception to be thrown on Windows as the
subprocess still holds a handle to the temporary directory. Ensuring the
subprocess is killed before deleting the temporary directory will
prevent us from encountering errors on cleanup on Windows.

Fixes https://github.com/dart-lang/sdk/issues/47700

Change-Id: I71599908c31a1b32afed15c1388d228618462506
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/220641
Commit-Queue: Ben Konyi <bkonyi@google.com>
Reviewed-by: Siva Annamalai <asiva@google.com>
 2021-11-19 21:14:28 +00:00
Clement Skau 70488fc8f6 [vm] Elaborate on DartDev server error. 
This change makes the error message consistent with a similar
message in sdk/lib/_internal/vm/bin/vmservice_server.dart.

Before:
  Could not start Observatory HTTP server

After:
  Could not start Observatory HTTP server:
  Invalid argument(s): A directory corresponding to fileSystemPath "/.../out/DebugX64/devtools" could not be found
  #0      createStaticHandler (package:shelf_static/src/static_handler.dart:50:5)
  [...]

Change-Id: Ie42d39d8c009b4ea403e1584a524567b3da20a45
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/220742
Reviewed-by: Ben Konyi <bkonyi@google.com>
Commit-Queue: Clement Skau <cskau@google.com>
 2021-11-19 13:45:38 +00:00
Michael Thomsen 5075cb7a50 Revert "Initial 'dart doc' developer command" 
This reverts commit 916a43a1c8.

Reason for revert: command fails in built SDK, see https://github.com/dart-lang/sdk/issues/47677

Original change's description:
> Initial 'dart doc' developer command
>
> Initial 'dart doc' command for the unified 'dart' developer tool,
> over time replacing the exiting 'bin/dartdoc' tool.
>
> Change-Id: Ib5639f9329bf5ed86375c97c5e485471934c56ff
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/217980
> Commit-Queue: Michael Thomsen <mit@google.com>
> Reviewed-by: Ben Konyi <bkonyi@google.com>

# Not skipping CQ checks because original CL landed > 1 day ago.

Change-Id: I5eb04c68cb80b1e2b95642e9e7904ad86c603315
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/220006
Reviewed-by: Michael Thomsen <mit@google.com>
Reviewed-by: Ben Konyi <bkonyi@google.com>
Commit-Queue: Michael Thomsen <mit@google.com>
 2021-11-11 15:39:43 +00:00
Michael Thomsen 916a43a1c8 Initial 'dart doc' developer command 
Initial 'dart doc' command for the unified 'dart' developer tool,
over time replacing the exiting 'bin/dartdoc' tool.

Change-Id: Ib5639f9329bf5ed86375c97c5e485471934c56ff
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/217980
Commit-Queue: Michael Thomsen <mit@google.com>
Reviewed-by: Ben Konyi <bkonyi@google.com>
 2021-11-09 21:27:53 +00:00
Sigurd Meldgaard 86b7480b8c Start a new analytics session for each dartdev run 
Change-Id: I0deb0ed7834361506ca6f67d5a8a77d40ea286a6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/218643
Reviewed-by: Ben Konyi <bkonyi@google.com>
Reviewed-by: Jonas Jensen <jonasfj@google.com>
Commit-Queue: Ben Konyi <bkonyi@google.com>
Auto-Submit: Sigurd Meldgaard <sigurdm@google.com>
 2021-11-01 20:46:11 +00:00
Sigurd Meldgaard 3c5e2a0d7b Bump pub to 0035a40f25d027130c0314571da53ffafc6d973b 
Changes:
```
> git log --format="%C(auto) %h %s" 78bc50c..0035a40
 https://dart.googlesource.com/pub.git/+/0035a40f Fix echo mode crash on `token add` (#3194)
 https://dart.googlesource.com/pub.git/+/a75a8c17 Don't warn against discontinued transitive dependencies (#3195)
 https://dart.googlesource.com/pub.git/+/cf2ed105 Fix analytics code (#3197)
 https://dart.googlesource.com/pub.git/+/08e13f7b Remove unused golden files (#3189)
 https://dart.googlesource.com/pub.git/+/b6293b80 Fix log message related to `pub global activate`  (#3187)
 https://dart.googlesource.com/pub.git/+/94f6b477 Introducing command-line interface tests (#3161)
 https://dart.googlesource.com/pub.git/+/3ba8134f More details from getExecutableForCommand (#3186)
 https://dart.googlesource.com/pub.git/+/a2dbcfff Shorthand syntax for hosted dependencies (#3133)
 https://dart.googlesource.com/pub.git/+/435e4e3f Shuffle analytics (#3185)

```

Diff: https://dart.googlesource.com/pub.git/+/78bc50c7833451c24e531713362e46fd50621ff0~..0035a40f25d027130c0314571da53ffafc6d973b/
Change-Id: Idfd7c382985d1ad3e3ad87a621dc79d3b74e898e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/218620
Reviewed-by: Jonas Jensen <jonasfj@google.com>
Commit-Queue: Sigurd Meldgaard <sigurdm@google.com>
 2021-10-29 13:05:39 +00:00
Ben Konyi 4de9e805ed [ CLI ] Don't resolve paths as URIs for known SDK artifacts 
Handles cases where the SDK is installed on a path which includes
percent encoded characters. The OS doesn't decode these characters, so
decoding them before trying to load a snapshot with said characters in
their path will result in files not being found.

Fixes https://github.com/dart-lang/sdk/issues/46364

TEST=pkg/dartdev/test/regress_46364_test.dart

Change-Id: I5f78e8a2049cc0c83555528fcc8f41be946141f5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/218082
Reviewed-by: Ryan Macnak <rmacnak@google.com>
 2021-10-27 16:34:00 +00:00
Michael Thomsen 800366738c Clarify how to to run compiled files 
Bug: 47518
Change-Id: Ia0d69e9ab34d41df9da943acc9433b7c5d02afca
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/217921
Reviewed-by: Ben Konyi <bkonyi@google.com>
Commit-Queue: Michael Thomsen <mit@google.com>
 2021-10-26 13:11:41 +00:00
Sigurd Meldgaard ecc6ed1b32 Send resolution analytics from dart pub get/upgrade/... 
Also enables batched analytics (up to 20 events will be sent together in
one request if they are all issued before control is returned to the
async queue).

Change-Id: Ic23429d4981bc33a34cb19ffc00affdd09dfe511
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/217014
Reviewed-by: Jonas Jensen <jonasfj@google.com>
Commit-Queue: Sigurd Meldgaard <sigurdm@google.com>
 2021-10-25 12:35:30 +00:00
Kenzie Schmoll 6a39b26d07 Unhide the devtools command from dart --help 
Change-Id: I853cdcd6cb968fa4c5c7b56a5ad69a27c60e4524
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/217743
Reviewed-by: Ben Konyi <bkonyi@google.com>
Commit-Queue: Ben Konyi <bkonyi@google.com>
Commit-Queue: Kenzie Schmoll <kenzieschmoll@google.com>
 2021-10-21 21:43:05 +00:00
Brian Wilkerson 1ac19c47ba Remove unnecessary ignore comment 
Change-Id: I40bdf75ccfc0d22c93dfbb7bbea5c860198b065b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/217022
Auto-Submit: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Ben Konyi <bkonyi@google.com>
Reviewed-by: Ben Konyi <bkonyi@google.com>
 2021-10-20 17:07:31 +00:00
Michael Thomsen 3f931429c3 Roll deps of web template 
Bug: https://github.com/dart-lang/sdk/issues/47450
Change-Id: I49c27714fd36ea60dd6e6f40928526ccf2554c99
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/216621
Reviewed-by: Kevin Moore <kevmoo@google.com>
Commit-Queue: Michael Thomsen <mit@google.com>
 2021-10-14 08:50:52 +00:00
pq 8db81bbc44 migrate to package:async unawaited 
Change-Id: I48cc9c0b2d16ecc50b3b7d1ea68006388e041a08
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/214684
Reviewed-by: Ben Konyi <bkonyi@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
 2021-09-27 19:35:43 +00:00
Ben Konyi bd067153d5 [ CLI ] Hide exe and aot-snapshot subcommands from dart compile on IA32 
The AOT runtime is not supported on IA32, so generating snapshots and
executables requiring the AOT runtime is not possible on IA32.

Fixes https://github.com/dart-lang/sdk/issues/47177

TEST=pkg/dartdev/test/commands/compile_test.dart

Change-Id: I99e9a16f6a93b3b63b8ed15acc1472f9ca619c08
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/213680
Commit-Queue: Ben Konyi <bkonyi@google.com>
Reviewed-by: Alexander Markov <alexmarkov@google.com>
Reviewed-by: Ryan Macnak <rmacnak@google.com>
 2021-09-24 01:21:08 +00:00
Danny Tuppeny b68ccc9a39 [dartdev] Add a "dart debug_adapter" command to run the DAP server from DDS 
Change-Id: Icf4442929f848f7f927e84c999f09206e3fd0704
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/213640
Reviewed-by: Ben Konyi <bkonyi@google.com>
Commit-Queue: Ben Konyi <bkonyi@google.com>
 2021-09-17 16:09:49 +00:00
Ben Konyi 123950ffa9 [ CLI / VM ] Add support for disabling DDS 
Allows for tooling (e.g., DAP) to spawn their own DDS instance without
having to disable the CLI.

Fixes https://github.com/dart-lang/sdk/issues/47059

TEST=pkg/dartdev/test/commands/run_test.dart

Change-Id: Ie9a4832d424edae67f32560399d3b0a6ca9f1dc0
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/213660
Reviewed-by: Siva Annamalai <asiva@google.com>
Commit-Queue: Ben Konyi <bkonyi@google.com>
 2021-09-16 20:31:45 +00:00