Konstantin Shcheglov
8ba6128378
Remove deprecated AnalysisDriver constructor.
...
Change-Id: Ida5366d5d6419944c0b654f67375bccd8ca507e5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/226804
Reviewed-by: Samuel Rawlins <srawlins@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2022-01-07 18:44:36 +00:00
Konstantin Shcheglov
9d7df725f6
Deprecated restoreAbsolute(), use pathToUri().
...
Change-Id: Id705e4f0eda7beba4c3d2dd2f6ba4b82691ef1f8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/220480
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Samuel Rawlins <srawlins@google.com >
2021-11-18 21:17:17 +00:00
Konstantin Shcheglov
48b45db358
Remove clearCache() from SourceFactory and UriResolver.
...
We don't use them anymore, the whole context collection is recreated.
Change-Id: Ie07d330a4928c3f85663a86d1dc83d8e3e28ab95
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/220460
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2021-11-17 08:13:52 +00:00
Konstantin Shcheglov
635bd112a3
Use single FileState for a path.
...
For some time now we decided to use canonical URIs for files in lib/.
Change-Id: I416ef87e7c4e6b27be9e1bc274deee67286a9d05
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/220223
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Samuel Rawlins <srawlins@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2021-11-16 17:44:42 +00:00
Kevin Moore
cb7c932f7b
analyzer: use Object.hash functions, deprecate JenkinsSmiHash
...
Also bump min SDK for pkg:analyzer
Towards https://github.com/dart-lang/sdk/issues/27698
Change-Id: Ic32c839c02f18afd99fdb98eb382540aae7da88a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/214126
Auto-Submit: Kevin Moore <kevmoo@google.com >
Commit-Queue: Kevin Moore <kevmoo@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
2021-09-22 19:11:24 +00:00
Ahmed Ashour
f1ded6af56
Remove import dart:core
...
Fixes #47092
TEST=existing
Change-Id: I3c5c0a1ec5e0426642a5dc70aa9a0391a143ed93
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/212298
Reviewed-by: Johnni Winther <johnniwinther@google.com >
Commit-Queue: Johnni Winther <johnniwinther@google.com >
2021-09-06 11:57:40 +00:00
Konstantin Shcheglov
dabdade731
Inline ContextBuilderOptions into analyzer_cli CommandLineOptions.
...
Change-Id: I2a386c1f9412ebcfaeb509715da616ff078591fd
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/206673
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2021-07-14 22:47:21 +00:00
Konstantin Shcheglov
109ba28c6e
Move Workspace creation into ContextLocatorImpl.
...
Change-Id: I98f85e4365cd3190781827c79c9b1dedf0702a2d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/206671
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2021-07-14 00:48:29 +00:00
Konstantin Shcheglov
df3339b1de
Remove unused code from ContextBuilder.
...
Change-Id: I66ecb375c938e868a00422c3ddb4887ee8c11770
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/206680
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2021-07-13 22:40:50 +00:00
Brian Wilkerson
adcef136a6
The dart fix command should not modify generated files
...
Change-Id: I485b0b0d1b99e5105402f12ad19d707f169df71a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/205900
Reviewed-by: Phil Quitslund <pquitslund@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2021-07-03 05:25:35 +00:00
Devon Carew
1acb443145
[analyzer] cleanup references to the .analysis_options file
...
Change-Id: I08f491b06925a420069019b77177839e8310843c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/202868
Commit-Queue: Devon Carew <devoncarew@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
2021-06-09 15:52:31 +00:00
Konstantin Shcheglov
d2682070f4
Use explicit FileContentCache instance for AnalysisContextCollectionImpl.
...
Previously we cached file contents implicitly, using Expando on top
of ResourceProvider. This is somewhat dangerous, and does not allow
us to decide when to cache, and when to invalidate.
Change-Id: I5c93ac22f217bb2baba6b7f6e73fc05f1c674e75
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/201233
Reviewed-by: Samuel Rawlins <srawlins@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2021-05-26 00:54:01 +00:00
Konstantin Shcheglov
62d0d5ff4d
Deprecate AnalysisDriver default constructor.
...
Change-Id: I9b87cc720b5e3731499302737fcaedcb229f6199
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/199371
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2021-05-12 05:35:58 +00:00
Konstantin Shcheglov
3a3b3e480b
Remove support for FileContentOverlay from ContextBuilder.
...
Change-Id: I23b9481ac6a841675e401579ff60bfb383865f8b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/199361
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2021-05-11 23:17:08 +00:00
Konstantin Shcheglov
12b68d6c87
Remove ContentCache.
...
Change-Id: I2cec74046d3257a7b9fa6fa01b97b3d22fc2e4d8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/199162
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2021-05-11 20:14:24 +00:00
Brian Wilkerson
5be0438e47
Make local variables that hide fields be final (analyzer)
...
Change-Id: I4cb41aec1757e133751979d3c0cdc697ccafc4a6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/196780
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2021-04-24 18:04:04 +00:00
Brian Wilkerson
ec04c1f335
Remove some unnecessary ignore comments
...
Change-Id: Iafa4b9c8aa5dc696c5746248a8701b4f6e875979
TEST=Existing tests.
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/191980
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Nicholas Shahan <nshahan@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Ben Konyi <bkonyi@google.com >
2021-03-18 19:58:43 +00:00
Konstantin Shcheglov
6550317955
Move updateAnalysisOptions() to CommandLineOptions.
...
Change-Id: I96e63478f2e3ea65d58a56a1b12dc2726a3d55ef
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/189860
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2021-03-10 00:34:32 +00:00
Konstantin Shcheglov
10a0c238ce
Discover default analysis options files in ContextLocatorImpl.
...
Change-Id: Idbcb43ab53878b677c3195d3003eb9da6eda5bab
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/189260
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2021-03-05 06:30:17 +00:00
Konstantin Shcheglov
4cb71ce5cb
Update analysis options before creating AnalysisDriver.
...
Change-Id: If9c337fc69ac11a570da5165edb17a3c4c75f418
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/188920
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2021-03-04 19:18:19 +00:00
Konstantin Shcheglov
d7dc1bfc45
Don't (re)discover analysis contexts in ContextBuilder.
...
Change-Id: I4079ec180f759c29ac51af989de30751673f6432
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/188584
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2021-03-02 22:35:17 +00:00
Konstantin Shcheglov
721ecfd63a
We don't have any language features with the version before 2.6, so 2.2.2 is not important anymore.
...
Change-Id: I01cd35e5eccd47ae0e1638e881fa3b84d5f0a102
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/187660
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2021-02-25 23:18:54 +00:00
Konstantin Shcheglov
a629b48fdc
Remove file name constants from AnalysisEngine.
...
Change-Id: I3457973212e704a0fedee20db17956c017ec91ac
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/187260
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2021-02-25 05:52:56 +00:00
Konstantin Shcheglov
1b1e853be4
Remove ContextBuilder.onCreateAnalysisDriver.
...
It was supposed to be 'temporary plugin support', and I believe we
have a replacement.
Change-Id: I7c6482fa257bee7a7c5c41c47d537b00e8f3ac69
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/186840
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2021-02-24 06:56:32 +00:00
Konstantin Shcheglov
9bfd416c45
Add ContextRoot.workspace, deprecated AnalysisContext.workspace, support included excludes in ContextLocatorImpl
...
Change-Id: Iecd324ad45b926ca6b0626f8bea4f479409154e8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/185499
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2021-02-19 02:15:40 +00:00
Konstantin Shcheglov
9a30392588
Require Workspace for ContextBuilder.getAnalysisOption() and createSourceFactory()
...
Ideally we want to create Workspace only once, and pass it around.
I was not able to do this yet, because DAS ContextManager kind of
dynamically updates contexts and drivers. I expect to avoid this issue
by switching DAS soon to AnalysisContextCollection.
I will follow with a bigger CL that keeps Workspace in ContextRoot.
Change-Id: I3050ba65400e0e5aa73e6d5f8beae821db10a6ee
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/185498
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2021-02-19 00:54:30 +00:00
Konstantin Shcheglov
51950ab881
Add Resource.parent2 that returns non-null Folder, add Folder.isRoot
...
A bigger version of than https://dart-review.googlesource.com/c/sdk/+/184381
This is breaking change, so we do this in steps.
Change-Id: I0c7212a073b605ade56657036543c604651810c7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/184581
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2021-02-12 19:09:20 +00:00
Konstantin Shcheglov
244964d893
Refactor ContextBuilder.createPackageMap() and createWorkspace() into static methods.
...
There are places when we need to call createWorkspace(), but we don't
have enough data to create full ContextBuilder, because we don't
know SdkManager.
Change-Id: I12ec5701ecab897bf1c49c478e8487c7ca348a29
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/184380
Reviewed-by: Samuel Rawlins <srawlins@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2021-02-11 17:52:53 +00:00
Konstantin Shcheglov
0fb52e9f78
Fix some null checks.
...
Change-Id: Idd3d88d1f7dd6e2250088498734396b98f8c5375
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/184383
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2021-02-11 17:44:49 +00:00
Konstantin Shcheglov
4765ef5037
Remove 'actualUri' from UriResolver.resolveAbsolute()
...
Change-Id: I87edfa780e891a5e1ecdd1a9a548509e4cfa641a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/183440
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2021-02-09 22:17:08 +00:00
Konstantin Shcheglov
74583b31ed
Make looking for BUILD file substitutes in BazelWorkspace optional.
...
Disable it for DAS, we always have BUILD files when interactive analysis.
Change-Id: I095f74ad25698e7ec07ea94252ee287d29e6a52f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/182122
Reviewed-by: Samuel Rawlins <srawlins@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2021-02-02 17:03:14 +00:00
Konstantin Shcheglov
9f986d2501
Migrate package:analyzer to null safety.
...
Change-Id: Iffe4370431587e46a141ddc72a86ceec29c163b2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/176486
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Samuel Rawlins <srawlins@google.com >
2021-02-01 18:56:04 +00:00
Michal Terepeta
97093b2594
Watch Bazel generated files for changes
...
This introduces a way to see what paths have been searched for by
the `BazelWorkspace` and adds a polling-based watcher to detect
when files generated by Bazel appear (or have changed). This allows
us to re-analyze things automatically instead of, e.g., restarting
the server.
Change-Id: I60eae29b0e4fcc3a91d8d2275c6898e45548ea03
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/168649
Commit-Queue: Michal Terepeta <michalt@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
2020-12-09 09:39:19 +00:00
Sam Rawlins
6f77ac032b
Remove use of deprecated package_config libraries.
...
Fixes https://github.com/dart-lang/sdk/issues/44116
Change-Id: I6d429fd31955aecefda01dab55dace922e4e46af
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/171880
Commit-Queue: Samuel Rawlins <srawlins@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2020-11-14 01:11:16 +00:00
Konstantin Shcheglov
779a3219f3
Ignore names _$foo when there is a missing .g.dart part.
...
Change-Id: I5a103cd362318b4db292b5f41da9e56a60f6431d
Bug: https://github.com/dart-lang/sdk/issues/42832
Bug: https://github.com/dart-lang/sdk/issues/42977
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/166820
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2020-10-14 19:28:38 +00:00
Konstantin Shcheglov
ba78db411a
Remove DartSdk.analysisContext
...
Change-Id: I6a67344d928e6182a851741bbbc862284af710c0
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/162623
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2020-09-13 00:56:36 +00:00
Konstantin Shcheglov
c71ce5234d
Remove DartSdk.analysisOptions getter/setter.
...
Change-Id: I6bdcd1d8c2e998bf4adbf26ddf533f5d649c73c3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/162620
Reviewed-by: Samuel Rawlins <srawlins@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2020-09-12 21:33:26 +00:00
Konstantin Shcheglov
25edea3d8d
Issue 43100. Verify local variable reads for null safety.
...
Bug: https://github.com/dart-lang/sdk/issues/43100
Change-Id: Ia8ece4de32f65d7912e534ce61936a45f2c768c0
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/159382
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2020-08-20 15:50:50 +00:00
Konstantin Shcheglov
a51f1747e0
Prepare to publish analyzer 0.40.0 and _fe_analyzer_shared 8.0.0.
...
Change-Id: I126207dcc47885565a3a6d7002ff15ad3cc493c5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/122483
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2020-08-18 15:12:10 +00:00
Konstantin Shcheglov
5e3f13494c
Create new context roots for folders with .dart_tool/package_config.json files.
...
R=brianwilkerson@google.com
Change-Id: If1ad72a1debb7c16737df9ea2507a020fabdfcf2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/158221
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2020-08-12 16:38:15 +00:00
Konstantin Shcheglov
ebd5b622ba
Add DartSdk.languageVersion
...
Bug: https://github.com/dart-lang/build/issues/2763#issuecomment-666707445
Change-Id: I8232bd395abc9efea0e5c27716450d6a5442b3bb
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/156489
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: William Hesse <whesse@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2020-08-04 21:01:09 +00:00
Sam Rawlins
041e0dd618
Analyzer: Enforce strict-inference
...
Change-Id: Iba49bfa7cf10f8a3b1d3be03e73fdca280f0940a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/155062
Commit-Queue: Samuel Rawlins <srawlins@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
2020-07-22 00:44:55 +00:00
Konstantin Shcheglov
c76fc431c7
Add WorkspacePackage to each FileState.
...
We need this so that we can look if the file is NullSafe by asking
the package that contains it.
Bug: https://github.com/dart-lang/sdk/issues/42594
Change-Id: I11c71faf7bddd53b458a66f0786454ecd7453b5e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/153521
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2020-07-08 23:54:47 +00:00
Konstantin Shcheglov
69aba23371
Move TypeSystemImpl to src/dart/element/type_system.dart
...
R=brianwilkerson@google.com
Change-Id: I0d9acad041c1038f6f2be6c09855488287ba5e97
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/153320
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2020-07-05 16:44:59 +00:00
Konstantin Shcheglov
326f7b4a8f
Remove DartSdk.useSummary.
...
Initial: https://dart-review.googlesource.com/c/sdk/+/149495
Reverted: https://dart-review.googlesource.com/c/sdk/+/149687
Change-Id: Ibd3f1af1aef83adc35f77cfbda66e07c5ae99922
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/153241
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2020-07-03 15:56:41 +00:00
Konstantin Shcheglov
6e9aa86d6f
Stop using AnalysisOptions.signature and multiple paths in SdkDescription.
...
Basically reduce it to a single path.
R=brianwilkerson@google.com
Change-Id: Ia532a5c7f6ae1464b77c5e9d23b3aaa7e85a6bf0
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/152710
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2020-06-29 17:50:14 +00:00
Sam Rawlins
648b5e9c68
Use ///-style doc comments in analyzer/lib
...
Bug: https://github.com/dart-lang/sdk/issues/33892
Change-Id: I573cb81dca6462c571bd6bf7bf309a46fd628967
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/152610
Reviewed-by: Paul Berry <paulberry@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Samuel Rawlins <srawlins@google.com >
2020-06-26 17:58:50 +00:00
Konstantin Shcheglov
16a64f0bde
Check for PackageBuildPackageUriResolver in SourceFactory.packageMap
...
Bug: https://github.com/Dart-Code/Dart-Code/issues/2558
Change-Id: I3270918320a9a15ca3175101da0337145179f6ed
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/152203
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2020-06-23 21:48:13 +00:00
Paul Berry
930cae0f13
Revert "Remove DartSdk.useSummary."
...
This reverts commit a2c3ecabce .
Reason for revert: Breaking change to de facto API
Original change's description:
> Remove DartSdk.useSummary.
>
> R=brianwilkerson@google.com
>
> Change-Id: Ifa851f4af47a973d65c528c6d07fcac0a515134b
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/149495
> Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
> Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
TBR=scheglov@google.com ,brianwilkerson@google.com
# Not skipping CQ checks because original CL landed > 1 day ago.
Change-Id: I9998bedb74ea940371f18ac7dce42b2f5dcc3b98
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/149687
Reviewed-by: Paul Berry <paulberry@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Paul Berry <paulberry@google.com >
2020-06-02 15:20:32 +00:00
Konstantin Shcheglov
a2c3ecabce
Remove DartSdk.useSummary.
...
R=brianwilkerson@google.com
Change-Id: Ifa851f4af47a973d65c528c6d07fcac0a515134b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/149495
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2020-05-30 19:07:32 +00:00