dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
83,955 Commits 2 Branches 0 Tags
5933e2dfbcebc021fdeea1bbcf9830f1e47f7321
Commit Graph

9116 Commits

Author SHA1 Message Date
Konstantin Shcheglov 1751ae0db0 Update ResolvedAstPrinter to use namedChildEntities. 
Change-Id: I621f3f7c309b2a1a17c68ae95e2a609121a113e1
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/233649
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2022-02-19 01:56:26 +00:00
Konstantin Shcheglov 8b6280b8fd Collect ChildEntity instances, add AstNodeImpl.namedChildEntities 
The new getter is not used yet, will be used to update ResolvedAstPrinter.

Change-Id: I5c3509ad2339d9f4b2ef398443012b980be66fea
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/233541
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2022-02-18 18:40:32 +00:00
Konstantin Shcheglov f784130fea Fix MISSING_REQUIRED_ARGUMENT for super-formal parameters. 
Change-Id: I0ee3114e5d618fa16da42072c8bc15d7b86001c3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/233525
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2022-02-18 17:33:53 +00:00
Johnni Winther 2435848b13 [parser] Support 'augment' modifier on class declarations 
This adds support for the 'augment' modifier on class declarations
needed for the static meta-programming prototype.

Change-Id: Iadd11f766a195076405f2803b2092199caf1ea8c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/233180
Reviewed-by: Jens Johansen <jensj@google.com>
Commit-Queue: Johnni Winther <johnniwinther@google.com>
 2022-02-18 09:39:23 +00:00
Konstantin Shcheglov 7cd6b3ed3e Issue 48396. Set 'dynamic' if invalid function reference resolution. 
Bug: https://github.com/dart-lang/sdk/issues/48396
Change-Id: I9d7f617fd716b6a1eb8c2d38e64f1f5800a99f54
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/233529
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2022-02-18 02:31:11 +00:00
Konstantin Shcheglov beddd6f2cd Rename refactoring for enum constructors. 
Change-Id: I35fd6ba07b911862c76d58aa7a58d226d2ff050f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/232820
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2022-02-17 02:21:23 +00:00
Konstantin Shcheglov 60b428e2b1 Deprecate superclass2, mixinTypes2, etc. 
Change-Id: Ieaaeab57930cb93f5b6b1323efe63c3395b79993
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/232742
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2022-02-17 02:20:42 +00:00
Konstantin Shcheglov 85cdbe31ca Report all available libraries in exceptions. 
There are two kinds: which we just built, and from readers.
With this change we will cover also just built libraries.

Change-Id: I67fa8ec5eeb00e539b4bd648d35b547dea8b4a7e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/232686
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2022-02-12 01:49:21 +00:00
Konstantin Shcheglov 582bf2f230 Completion for constructors in enum constants. 
Change-Id: I3a68db8045d249f7459ec0dbf0fbd9c203fccade
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/232683
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2022-02-11 21:41:37 +00:00
Konstantin Shcheglov d5269652d8 Remove 'index' from enum classes. 
Change-Id: I7632aced8cde06c449e694c028d0e7fb2d3312df
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/232426
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2022-02-11 17:35:17 +00:00
Paul Berry 8652944f72 Clean up how negated integer literals are type inferred. 
Previously, when upon reaching the integer literal, we would check if
the parent was a PrefixExpression with an operator of `-`, and if so,
use the context type of the PrefixExpression to decide whether to do
an int->double conversion.  This CL moves the logic to the
PrefixExpressionResolver; we now pass down the appropriate context
when visiting the integer literal.

This makes the context handling for negated integer literals less of
an odd exception.

This is part of a larger effort to elimiate the use of
InferenceContext.getContext and InferenceContext.setType entirely.

Change-Id: I6ca63df1adcb706011c146c80c2576814a73926d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/231326
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
 2022-02-10 18:36:51 +00:00
Konstantin Shcheglov 9098b5d12e Increment DATA_VERSION. 
Change-Id: Id84b42f083a581a2d391b400ff6868c782a73d4a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/232420
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2022-02-10 16:57:11 +00:00
Konstantin Shcheglov 1150b1c2dc Don't build synthetic toString() for enums. 
The specification now says that `class Enum` is extended, and
has `external` impelementations of `index` and `toString()`.

Change-Id: I6cb138013722006d570766b87c46ac1c12273dee
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/232233
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2022-02-10 16:35:31 +00:00
Konstantin Shcheglov 3e4c396b6b Add EnumDeclaration.semicolon 
Change-Id: Ib502217f31090c49d1561538b72ef5d98087d569
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/232323
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2022-02-10 16:35:21 +00:00
Konstantin Shcheglov 6c494313d7 Remove duplicate of toLegacyTypeIfOptOut() in TypeSystemImpl. 
Change-Id: I2d58f82a1cf9fa754713288665587e8ee2e296a5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/232235
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2022-02-10 04:29:17 +00:00
Konstantin Shcheglov 119eed6f93 Make top-level accessors static. 
Change-Id: I28449a218b7613e920c38de57d7eb6d18f8c6176
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/232231
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2022-02-10 04:21:11 +00:00
Konstantin Shcheglov b66ea5276f Use elements in GetterSetterTypesVerifier, support fields. 
Change-Id: I92376ace55845385e69742e0eaadcae407a71a53
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/232228
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2022-02-09 22:36:48 +00:00
Konstantin Shcheglov e8c25a56b7 Include enum type parameters into the namespace when resolving identifiers. 
Change-Id: I2804e3ace95313b5e2a99bcc679d8965dfff26c3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/232224
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2022-02-09 21:48:31 +00:00
Konstantin Shcheglov 9d11380582 Skip 'values' when checking for CONST_CONSTRUCTOR_WITH_FIELD_INITIALIZED_BY_NON_CONST in enum. 
Change-Id: Ie528eff182a7ff176ec339da78de5d47cd0c24aa
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/232226
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2022-02-09 21:40:28 +00:00
Konstantin Shcheglov be0c8560b4 Search for enum children. 
Change-Id: Id6ab2860f6a88b3b1f747ad8a63045e91e3a0309
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/232220
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2022-02-09 17:59:56 +00:00
Konstantin Shcheglov f481cbf2fa Use IS_INVOKED_BY_ENUM_CONSTANT_WITHOUT_ARGUMENTS 
Change-Id: I870ece21708c1e96bf8b3bd4d4373ca6bdade9cf
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/232133
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2022-02-09 16:16:56 +00:00
Konstantin Shcheglov 1acf0dce85 Report ENUM_INSTANTIATED_TO_BOUNDS_IS_NOT_WELL_BOUNDED 
Change-Id: I4cef975da984b9bf1da64008292864b716b13e8f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/232128
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2022-02-09 16:13:06 +00:00
Konstantin Shcheglov 29d364dfd4 Report VALUES_DECLARATION_IN_ENUM 
Change-Id: I8efc240b5bd2740a457eb373bece31afab3c7525
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/232130
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2022-02-09 15:53:36 +00:00
Konstantin Shcheglov 4e2dc38e0e Report CONST_WITH_NON_CONSTANT_ARGUMENT for enums. 
Bug: https://github.com/dart-lang/sdk/issues/48237

Change-Id: Iffde67714dcea7b022b22a149b573dd3e26668b0
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/232132
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2022-02-09 15:53:27 +00:00
Nate Bosch 33e174084a Replace Uri.scheme == with Uri.isScheme 
Use `hasScheme` in place of comparing against the empty string, and
`isScheme` to compare against all other schemes.

TEST=No behavior changes.

Change-Id: Ifc9fd13c6cf37933ebd4a754c4b500dedbcb291b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/231185
Reviewed-by: Kevin Moore <kevmoo@google.com>
Commit-Queue: Nate Bosch <nbosch@google.com>
 2022-02-08 21:38:57 +00:00
Konstantin Shcheglov 7282a40c49 Report ILLEGAL_LANGUAGE_VERSION_OVERRIDE even when the package language version causes it. 
Change-Id: I617d67ba06758e3f57d9ff0048a080d0a699fc96
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/232126
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2022-02-08 21:23:46 +00:00
Konstantin Shcheglov d8e2cdaeec Report WRONG_NUMBER_OF_TYPE_ARGUMENTS_ENUM and TYPE_ARGUMENT_NOT_MATCHING_BOUNDS for enums. 
Change-Id: Icac828fa09d7565974727521c27b5cd4daa7e0f4
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/232089
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2022-02-08 19:50:36 +00:00
Konstantin Shcheglov f6ebb50359 Report ENUM_CONSTANT_WITH_NON_CONST_CONSTRUCTOR 
Change-Id: I3962553ccaa881db761e87fdd97ce47a65db4b2e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/232124
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2022-02-08 19:15:28 +00:00
Konstantin Shcheglov 62488444c9 Report INVALID_REFERENCE_TO_GENERATIVE_ENUM_CONSTRUCTOR for factory redirections. 
Change-Id: I02f6f3f374cd00b24722b8eb5498aaab33b1a7fd
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/232121
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2022-02-08 17:25:06 +00:00
Konstantin Shcheglov ed2ae85bfe Remove deprecated AnalysisDriver.tmp1() 
Change-Id: Ie05f71eabfdc81ce80264581d751c1ae9391bce7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/232035
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2022-02-08 17:21:36 +00:00
Konstantin Shcheglov 1d7d5a6dcf Verify the number and types of enum constant arguments. 
Change-Id: Id51ca6081bb9a1ab85217457bca67cae8adce710
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/232033
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2022-02-08 16:16:06 +00:00
Konstantin Shcheglov 6bcc451e59 Report DUPLICATE_DEFINITION for 'values' in enums. 
Change-Id: I0df2f7286e8913b3a323fd19bb18a8d77f27bbe6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/232025
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2022-02-08 01:49:35 +00:00
Konstantin Shcheglov cc93c8815b Tests for indexing enum children. 
Change-Id: I76b7369a5ba2e7c3cb799694f21dee95eebf125f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/232028
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2022-02-08 00:24:45 +00:00
Konstantin Shcheglov 63f34ab810 Report UNDEFINED_ENUM_CONSTRUCTOR_NAMED/UNNAMED 
Change-Id: I02b8a2d9d3988cc0c281a8d251b9670e378b3561
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/232023
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2022-02-07 23:27:14 +00:00
Brian Wilkerson 867e155ff6 Merge two error codes 
I was thinking about unifying these two codes for documentation purposes,
but then I wondered whether we might not want to unify them for reporting
purposes too. The reason I think it might be better to unify them is
because (a) they really represent a single problem (missing required
arguments) and (b) we were previously reporting the same problem multiple
times.

Change-Id: Iecf2865e67d61b03a1e1f56781e94e283d2a08e2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/232022
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2022-02-07 23:10:06 +00:00
Konstantin Shcheglov f15518dffc Report ILLEGAL_ENUM_VALUES_DECLARATION/INHERITANCE 
Change-Id: I31a02b7c0fe50362ed6d9cb66159db3386f3b56e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/232020
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2022-02-07 21:47:45 +00:00
Konstantin Shcheglov ef66f47631 Fix an enum rebase issue. 
Change-Id: Idd09905a99193127954952ca91284a061ae60ab8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/232000
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2022-02-07 20:00:11 +00:00
Konstantin Shcheglov 2c84f13edb Report ILLEGAL_NON_ABSTRACT_ENUM_INDEX 
Change-Id: I028ce008c11a0e4b9e0bebef4e6b62c855a07e82
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/231880
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2022-02-07 19:42:20 +00:00
Ilya Yanok 3c16fdd3b0 Fix type inference for yield* inside method w/o declared return type 
This was broken after
https://dart-review.googlesource.com/c/sdk/+/230948, the example would
be

```dart
class A {
   m() sync* {
     yield* [1];
   }
 }
```

Inferred type for expression in `yield*` statement is
`List<FutureOr<dynamic>>` after the above CL, while I'd expect it
to be `List<int>`.

The change modified the behaivor while passing the imposed
return type a bit: `InferenceContext.setType` resets the type to `null`
if it's `dynamic`, while the logic that passes the type down explicitly
doesn't do that. My change restores the behavior of resetting the
imposed type to `null` if it's `dynamic`.

Interestingly enough, this is not a problem for function declarations:
`FunctionExpressionResolver.resolve(FunctionExpressionImpl)`
has special clause that resets the imposed type to null. But
for reasons I don't understand `FunctionExpressionResolver` is
used for function declarations but not for method declaration.

Change-Id: I63cfde01f067c25442afed64843861d09c7474a1
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/231702
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
Commit-Queue: Ilya Yanok <yanok@google.com>
 2022-02-07 19:34:18 +00:00
Konstantin Shcheglov d7bb928f64 Report ENUM_WITH_ABSTRACT_MEMBER and NON_ABSTRACT_CLASS_INHERITS_ABSTRACT_MEMBER. 
Change-Id: I3da69337edc299fee847ba7984b16ca7be65c1e8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/231860
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2022-02-07 19:26:18 +00:00
Konstantin Shcheglov 2ad4e8258c Report ENUM_CONSTANT_WITH_TYPE_ARGUMENTS_WITHOUT_ARGUMENTS 
Change-Id: I41fa9cb8497671363878d2140dfec2ec3fc0f6ba
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/231844
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2022-02-07 19:26:15 +00:00
Konstantin Shcheglov 2d14e064f5 Report more enum member conflicts. 
Change-Id: I39a59fdd96e91c8172db0d747b05f8eef810a36c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/231841
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2022-02-07 18:13:05 +00:00
Konstantin Shcheglov 3e8114261a Add HasCompletionData to a few more elements. 
Change-Id: I7ea2f0b70cbc5a65584725d2ca662db37651ed1b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/231840
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2022-02-07 17:59:55 +00:00
Devon Carew 150df0637f [analyzer] remove the dep on package:cli_util 
Change-Id: Ie5b0c29ae443588c501dd2012e645618aff17ca4
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/231846
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Devon Carew <devoncarew@google.com>
 2022-02-06 05:26:40 +00:00
Konstantin Shcheglov c99e3af906 Report duplicate declarations for enums. 
Change-Id: I2bda7ea3116a4ea8c65024c8ec4b5981e7d93c19
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/231746
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2022-02-05 02:07:30 +00:00
Konstantin Shcheglov 0962b173d6 Replace 'enumeration' with 'enum' in messages.yaml 
Change-Id: I62d389bb9462a15f2b08d2fb313fc1a3fca74379
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/231742
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2022-02-04 22:00:41 +00:00
Konstantin Shcheglov 14bead484c Report more enum hierarchy errors for enums. 
Change-Id: I9ffc41ce9cbc9a51b059dc8a891e59420232d047
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/231536
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2022-02-04 18:51:39 +00:00
Konstantin Shcheglov f69d1f887f Use CompletionSuggestionBuilder, and HasCompletionData to store location independent data. 
Change-Id: I767bfc1c31b5aebc8f4e27267520f705701e7724
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/231044
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2022-02-04 17:33:19 +00:00
Konstantin Shcheglov 1e66a8a079 Report more hierarchy diagnostics for enums. 
Change-Id: If2c4ef3604fadfaa6d3d5af992f61a6a819a5b01
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/231528
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2022-02-03 23:39:26 +00:00
Brian Wilkerson 17422f82b2 Remove an unnecessary shared name from a message 
Change-Id: I0569bd99620f2b276f9cc1510a4641bbe0cb7182
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/231522
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2022-02-03 21:18:48 +00:00