Commit Graph

6662 Commits

Author SHA1 Message Date
Brian Wilkerson 5933e2dfbc Replace a hard-coded path with a computed path
Fixes https://github.com/dart-lang/sdk/issues/48355

Change-Id: Ib6b46ab73f7264f6f7f23a603b57d1fbbedc0752
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/233656
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
2022-02-19 16:51:22 +00:00
Brian Wilkerson ab6d76844a Attempt to fix the windows bot
Change-Id: Ifbe570282c99441c3b80926ae4d615e142b27480
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/233657
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
2022-02-19 05:20:32 +00:00
Brian Wilkerson 0b12b2c5a4 Unify the two copies of IndexRange
Change-Id: I3836c680b71404c157814eb5c3c234b026587be9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/233654
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
2022-02-19 02:20:32 +00:00
Konstantin Shcheglov 96464ceb3a Test for navigation when named arguments anywhere.
Change-Id: I0ad0e8501b7f8297750b0767a61ba9039859b2a1
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/233643
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
2022-02-19 02:12:33 +00:00
Konstantin Shcheglov 24839d6123 Test for occurrences with named arguments anywhere.
Change-Id: I5f93602d7286d0437b7c27ee8c0145fe80b2901f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/233645
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
2022-02-19 02:12:30 +00:00
Konstantin Shcheglov 627eb64320 Test for Flutter outline with named arguments anywhere.
Change-Id: I9e2df45ba04c0e02b2388029c2c3c56213ef9dc5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/233644
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
2022-02-19 02:04:31 +00:00
Konstantin Shcheglov f0ae696ee2 Tests for search with named arguments anywhere.
Change-Id: I423a92f49981514074a26e1b893dfff06b0e3389
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/233646
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
2022-02-19 02:04:28 +00:00
Konstantin Shcheglov d637f3591d Test for semantic highlighting with named arguments anywhere.
Change-Id: I44badd1284cc512615dfae727b9d674fee193812
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/233647
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
2022-02-19 01:56:29 +00:00
Ben Konyi f9147d933e [ Service ] Update VM service message to not reference Observatory
See https://github.com/dart-lang/sdk/issues/46756

TEST=Existing

Change-Id: Ib71bf00d667369d7438a4547ae444951ec0979df
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/233504
Reviewed-by: Siva Annamalai <asiva@google.com>
Commit-Queue: Ben Konyi <bkonyi@google.com>
2022-02-18 20:53:52 +00:00
Brian Wilkerson 0921dceaef Add a quick assist to convert a class to an enum
Change-Id: Iebd83940c85e778132132bfe483df08193f574ff
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/233002
Reviewed-by: Phil Quitslund <pquitslund@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
2022-02-18 20:00:21 +00:00
Danny Tuppeny 2bbd3bc67e [analysis_server] Fix code_actions_fixes test on Windows
Fixes https://github.com/dart-lang/sdk/issues/48431.

Change-Id: Ifb15a2fbd1949ba6e825f6fb2769eb790588a60f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/233567
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
2022-02-18 19:56:12 +00:00
Danny Tuppeny bf491f87cd [analysis_server] Add support for snippets in LSP completion
Change-Id: Ife64add884c310e4d0b5413ef91665aef2375648
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/233361
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
2022-02-18 19:43:21 +00:00
Konstantin Shcheglov aec9bccdd9 Update 'mightBeTypeIdentifier' to return the type name, or null.
This way, instead of implicit result that the given node is a
SimpleIdentifier and requiring a cast in the client, or a
PrefixedIdentifier - so we have to check whether it is one or another
again; we now prove the result by returning the actual value, not
just a flag.

Change-Id: I65f0a21e5d3c1e7be06e621a0f7fb6a5e6b2db2d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/232780
Reviewed-by: Phil Quitslund <pquitslund@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
2022-02-17 17:04:30 +00:00
Konstantin Shcheglov beddd6f2cd Rename refactoring for enum constructors.
Change-Id: I35fd6ba07b911862c76d58aa7a58d226d2ff050f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/232820
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
2022-02-17 02:21:23 +00:00
Konstantin Shcheglov 60b428e2b1 Deprecate superclass2, mixinTypes2, etc.
Change-Id: Ieaaeab57930cb93f5b6b1323efe63c3395b79993
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/232742
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
2022-02-17 02:20:42 +00:00
Konstantin Shcheglov 1a1d3714f5 Remove supportsAvailableSuggestions from AbstractCompletionDriverTest.
We always use it for the protocol version 1.

Change-Id: I18558bb76e82bc5c8be7ccb2fca886dc0139b7a0
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/232741
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
2022-02-17 02:13:21 +00:00
Konstantin Shcheglov fe5a580f8e Pass the context as a single object in class body completion tests.
Change-Id: Iec7bc93a150a1dfe4d96ef6c1c87d334db28146a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/232760
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
2022-02-17 02:12:40 +00:00
Danny Tuppeny 55fd24e6a6 [analysis_server] Refactor LSP snippet building in preparation for Snippet completions
Change-Id: Ie39e2e803d17435b31246da07ed69eba7d7aba21
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/233360
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
2022-02-16 20:01:00 +00:00
Jaime Wren a2f887ea59 New optional enum input, CompletionCaseMatchingMode, in DAS getSuggestions2 request.
Change-Id: Ibddcd7db4f51266c29a104d2b46e93c29ddf5465
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/232422
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Jaime Wren <jwren@google.com>
2022-02-15 00:15:00 +00:00
Danny Tuppeny 4bd312d1e6 [analysis_server] Improve LSP server error messages for invalid paths/parse failures
Change-Id: I1a72ee62e282991b0071d0135c9a658bc5f7e14e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/232861
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
2022-02-14 17:07:48 +00:00
Alexander Thomas 30beab0f43 [infra] Add OWNERS to the Dart SDK
* Add team "groups" in tools/OWNERS_<group name>.
* Add top-level OWNERS as a fallback.
* Add OWNERS for all top-level directories.
* Add OWNERS to all packages.

For additional background information see go/dart-sdk-owners.

TEST=No op until code-owners is enabled.
Bug: b/200915407
Change-Id: I7fe6116cc599c749cd50ca16151d6d6a801d99d7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/229147
Reviewed-by: Jonas Termansen <sortie@google.com>
2022-02-14 14:06:34 +00:00
Konstantin Shcheglov ea4f04f56d Support completion in enum constant argument list.
Change-Id: Id483d6ea3715e567f1d2cc9a2051f615b750a8a9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/232684
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
2022-02-11 23:07:25 +00:00
Konstantin Shcheglov 582bf2f230 Completion for constructors in enum constants.
Change-Id: I3a68db8045d249f7459ec0dbf0fbd9c203fccade
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/232683
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
2022-02-11 21:41:37 +00:00
Konstantin Shcheglov b62949ea1d Semantic highlighting for enums.
Change-Id: Ib3e4aceec56b6bdd28b38a317c4c3981db87b7d1
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/232680
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
2022-02-11 18:50:57 +00:00
Konstantin Shcheglov 8b67b90016 A few tests for completion in class body and similar.
Change-Id: Id8749e4c45d26a5e56de31ce0d8b117db60150a1
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/232486
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
2022-02-11 18:04:57 +00:00
Konstantin Shcheglov d5269652d8 Remove 'index' from enum classes.
Change-Id: I7632aced8cde06c449e694c028d0e7fb2d3312df
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/232426
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
2022-02-11 17:35:17 +00:00
Devon Carew 1a72a4ca8f [analysis server] remove the dep on package:cli_util
Change-Id: I9a3b7b8c23dc324ad62f0d9b456e608d365133c0
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/232423
Auto-Submit: Devon Carew <devoncarew@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
2022-02-10 21:27:34 +00:00
Konstantin Shcheglov 4a122c0b5a Add completion tests inside enum declaration.
As we discussed some time ago, it is not clear to me where some
tests should go. Here, I put it into "location" tests, and checked
locations that seem strongly associated with the enum - its header,
its body; including the `WithClause` on the enum.

It is less clear where tests for completion inside the header or
the body of a method inside of an enum should go. I initially
planned to put them into `declaration/enum_test.dart`, but now
starting to doubt. The tests there are currently for using an
enum from outside.

Change-Id: Ife091f82bbb0ad1f26df984be42aa93a78595816
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/232421
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
2022-02-10 20:26:01 +00:00
Danny Tuppeny 70d25c7ce7 [analysis_server] Make docs more explicit about positions in LinkedEditGroups
Change-Id: Ifcc8935ac7c72d42fcc0462fd2f6ad3eb8ecd3b9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/232460
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
2022-02-10 19:51:13 +00:00
Danny Tuppeny 74248dc6db [analysis_server] Use ConvertToPackageImport fix for always_use_package_imports lint
Fixes https://github.com/Dart-Code/Dart-Code/issues/3823.

Change-Id: I33d1448b36de1927e3e3cc5628d0d822d4f21786
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/232265
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
2022-02-10 19:45:31 +00:00
Sai Sandeep Mutyala 7605a36ab3 Add fix for sort_constructors_first lint.
Bug: https://github.com/dart-lang/sdk/issues/47953
Change-Id: I0c927714f55eddd30d0c3770a3315118f64a160b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/232141
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
2022-02-10 06:03:59 +00:00
Sam Rawlins efe0af4cae Add functionality and tests for super-parameters in fixes for Hints and Errors
Change-Id: I8e2c9754f65368ee5d1a243160e844b742506509
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/232229
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
2022-02-10 02:53:19 +00:00
Konstantin Shcheglov f204bf5ead Navigation for enum constants.
Change-Id: I47c420d29b857dc57d14854255c62e4db5458179
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/232223
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
2022-02-09 21:40:19 +00:00
Konstantin Shcheglov 96f5385295 Tests for searching enum children in analysis_server.
Change-Id: I52b43a606cdac5165aa5ddd6c97741f276c1ebf7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/232221
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
2022-02-09 19:12:56 +00:00
Sai Sandeep Mutyala 3de72ec6b0 Add fix for sort_unnamed_constructors_first lint.
Change-Id: I08decb3d05612d0899c570597ce0a3b8e1eb1c02
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/231900
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
2022-02-09 06:51:07 +00:00
Nate Bosch 33e174084a Replace Uri.scheme == with Uri.isScheme
Use `hasScheme` in place of comparing against the empty string, and
`isScheme` to compare against all other schemes.

TEST=No behavior changes.

Change-Id: Ifc9fd13c6cf37933ebd4a754c4b500dedbcb291b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/231185
Reviewed-by: Kevin Moore <kevmoo@google.com>
Commit-Queue: Nate Bosch <nbosch@google.com>
2022-02-08 21:38:57 +00:00
Danny Tuppeny afe70b7432 [analysis_server] Reduce the scope of a non-null-assertion to prevent errors during large renames
This assertion is not sound and needs removing, but that requires additional changes to ensure callers (including plugins) provide line/col information. This change reduces the chance of it triggering (by avoiding it being used for context messages) in the meantime.

Change-Id: I73c861b69a795212ae0d59e30da6aa6bdd1bb3af
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/232082
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
2022-02-08 16:47:56 +00:00
Brian Wilkerson 867e155ff6 Merge two error codes
I was thinking about unifying these two codes for documentation purposes,
but then I wondered whether we might not want to unify them for reporting
purposes too. The reason I think it might be better to unify them is
because (a) they really represent a single problem (missing required
arguments) and (b) we were previously reporting the same problem multiple
times.

Change-Id: Iecf2865e67d61b03a1e1f56781e94e283d2a08e2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/232022
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
2022-02-07 23:10:06 +00:00
fredbroz da97de73cb [analyzer] Add fix for avoid_void_async lint
Closes https://github.com/dart-lang/sdk/issues/47959

Change-Id: I32838d7889cbaf9491d24672f19995cd6f75c2fa
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/231940
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
2022-02-07 19:57:35 +00:00
Konstantin Shcheglov 5198169e1a Suggest the exception and stack trace as local variables.
Change-Id: Icffb93295db3be2e0b83c1ff2dd5dc01f1ce901d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/231881
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
2022-02-07 19:49:45 +00:00
Konstantin Shcheglov 52290eba28 Add CompletionSuggestion.libraryUri, keep isNotImported.
Change-Id: I1bce246c2d8eaa968a47ae6ba82114592b991a47
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/231040
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
2022-02-04 22:49:10 +00:00
Konstantin Shcheglov f69d1f887f Use CompletionSuggestionBuilder, and HasCompletionData to store location independent data.
Change-Id: I767bfc1c31b5aebc8f4e27267520f705701e7724
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/231044
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
2022-02-04 17:33:19 +00:00
Brian Wilkerson a4b3b8edec Add an assist to convert a normal parameter to a super initializing parameter
Change-Id: Icf5d44a3a155e67f76165eca711094d368cdca64
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/231520
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
2022-02-04 01:03:36 +00:00
Konstantin Shcheglov ddff5ac88c Tests for completion in NamedExpression.
Change-Id: I5a7ba57a1279797f7e625890a64c42091708f60e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/231380
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
2022-02-03 22:24:16 +00:00
fredbroz d48a637bf5 [Analyzer] Add fix for use_raw_strings lint
Closes https://github.com/dart-lang/sdk/issues/47955

Bug: https://github.com/dart-lang/sdk/issues/47955
Change-Id: If321097598fcdcd79c246032f64332e91ee7f57c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/231302
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
2022-02-03 15:55:56 +00:00
Konstantin Shcheglov f5acc570e8 Fix CompletionDriver tests on Windows.
Change-Id: I43bf2c80b244906c2568e05fd24d4dd49953feb5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/231321
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
2022-02-02 18:28:25 +00:00
Sam Rawlins b9b1252752 For existing fixes, add super-parameter and named-args-anywhere tests
Bug: https://github.com/dart-lang/sdk/issues/48067, https://github.com/dart-lang/sdk/issues/47578
Change-Id: Iaef317459c7e6901296475163959ad92a6c880b2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/231070
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
2022-02-02 17:47:49 +00:00
Danny Tuppeny 4a5b0b3030 [analysis_server] Fix slash direction in auto-import details for LSP completions
Fixes some failing tests on the Windows bots that were getting backslashes but expecting forward.

Change-Id: Idd89a45d7be87385d497e221a1941e4c48d597af
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/231300
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
2022-02-02 17:26:09 +00:00
Keerti Parthasarathy eb4f5077ab Check for private elements while rename
Change-Id: I3423cd746e675315a3abd1b728bc6cd978384beb
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/230954
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Keerti Parthasarathy <keertip@google.com>
2022-02-02 03:08:46 +00:00
Konstantin Shcheglov 1b16157413 Switch AbstractCompletionDriverTest to PubPackageAnalysisServerTest.
Change-Id: I39e14c746b1b50af12508e6b30785cdd97920c2d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/230943
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Phil Quitslund <pquitslund@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
2022-01-31 18:25:54 +00:00