dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
85,572 Commits 2 Branches 0 Tags
58ae85642293fce2e609883aeaf0688baa961966
Commit Graph

896 Commits

Author SHA1 Message Date
Brian Wilkerson 264f5255db Add new diagnostic documentation 
Change-Id: I1f8b96e7f7904cc4d1ec51938ee6099a2ed53c05
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/246400
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2022-05-28 22:51:30 +00:00
Arseny Uskov 495526c999 Reland "[Analyzer] Handle parameters that are both deprecated and required" 
as per discussion in https://github.com/dart-lang/sdk/issues/48206

This is a reland of commit 992618988b

Original change's description:
> [Analyzer] Handle parameters that are both deprecated and required
>
> Do not produce a diagnostic at the call-site in this case.
>
> Change-Id: I994704f77261b8e801a242c963236385f519eaa8
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/241008
> Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
> Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>

Change-Id: Ife7eb4699d8c4f0c3325f6d2526fdcdfbcb0d1f6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/245703
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2022-05-26 23:49:00 +00:00
Konstantin Shcheglov 662aaa387c Issue 48987. Report DUPLICATE_IMPORT even when URIs are not syntactically identical. 
Bug: https://github.com/dart-lang/sdk/issues/48987
Change-Id: I88dfcd7ce4901933998ddd11724c3a47bec9a784
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/244183
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2022-05-24 18:22:25 +00:00
pq 5e400bdccc remove temporary map iterables from method lookups 
Removes some unnecessary maps and scoots the (fast) supertype check to first.

I don't expect these temporary map iterables to have significant impact (though we should measure) but removing them doesn't hurt readability IMO so I think is a win.  Happy for push back though!


Change-Id: I1641da3b34605e255c9d95ef7b490f7182e84e21
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/245560
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
 2022-05-20 21:37:16 +00:00
Konstantin Shcheglov f0a07ac120 Enforce use_super_parameters in analyzer/. 
Change-Id: I92a002d69a10b83b9600455156a43c1592439477
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/245420
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2022-05-19 19:36:41 +00:00
Brian Wilkerson e5cd0bf0fd Remove published diagnostic documentation from the generated declarations of error codes 
Change-Id: I49619c4b968035c352bc50bf626773034fce1579
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/245083
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2022-05-18 04:19:31 +00:00
Ahmed Ashour 1cf5c7849f [analyzer] fix @useResult in a NamedExpression 
Fixes #49023

Change-Id: I9fec67740ed1d85b38aa0bc0946f028c7c69ca9d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/244923
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2022-05-16 16:56:28 +00:00
Ahmed Ashour 2aa31c9046 Hint.UNUSED_RESULT to handle callable instances. 
Fixes #48913

Change-Id: I55e6572946b7418a4de0f0778c298bc0b2df4cfb
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/242868
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2022-05-09 15:54:22 +00:00
Konstantin Shcheglov 401506c09c Issue 48969. Check Annotation for required named parameters. 
Bug: https://github.com/dart-lang/sdk/issues/48969
Change-Id: I8fd8a13fc7174d936d27062e2d41787f241b2b07
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/243925
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2022-05-06 23:11:50 +00:00
Ahmed Ashour 7352712902 Fix UseResult in AsExpression 
Fixes #48879

Change-Id: Ib43b72f96d05a119f37e18ca47bf71d2d0ebc52c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/242287
Reviewed-by: Ömer Ağacan <omersa@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2022-04-27 03:36:44 +00:00
Konstantin Shcheglov 73935c1d83 Report MACRO_EXECUTION_EXCEPTION. 
Change-Id: Ia4c9b897467ce276c2030cbf242146aa95410189
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/241988
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2022-04-22 01:10:28 +00:00
Konstantin Shcheglov 6af3297fea Issue 48811. Don't report an error for 'index' in '_Enum' from dart:core 
Analyze a few dart:xyz libraries from MockSdk.

Bug: https://github.com/dart-lang/sdk/issues/48811
Change-Id: Ifd8d332dd76cc9bab916ec497a7ca918919cdf71
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/241466
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2022-04-18 17:57:56 +00:00
Brian Wilkerson a9d162e25a Revert "[Analyzer] Handle parameters that are both deprecated and required" 
This reverts commit 992618988b.

Reason for revert: Breaks the flutter build

Original change's description:
> [Analyzer] Handle parameters that are both deprecated and required
>
> Do not produce a diagnostic at the call-site in this case.
>
> Change-Id: I994704f77261b8e801a242c963236385f519eaa8
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/241008
> Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
> Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>

# Not skipping CQ checks because original CL landed > 1 day ago.

Change-Id: I2c6cbdcf8a08a178d77c6f875488f54f95788063
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/241441
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2022-04-18 04:55:16 +00:00
Brian Wilkerson 909dbe509d Merge two diagnostic codes for documentation purposes 
Change-Id: Ib1f75add55f2638d8031723b9bf225cb02acf1ef
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/241400
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2022-04-17 20:00:16 +00:00
Arseny Uskov 992618988b [Analyzer] Handle parameters that are both deprecated and required 
Do not produce a diagnostic at the call-site in this case.

Change-Id: I994704f77261b8e801a242c963236385f519eaa8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/241008
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2022-04-15 22:10:04 +00:00
Ahmed Ashour f2b5ba82ab Add a hint for final FieldFormalParameter and SuperFormalParameter 
Fixes #48699

Change-Id: Ieb16648a52884588e406931f830e4655b120cb0c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/239640
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2022-04-10 18:11:00 +00:00
Konstantin Shcheglov 531cb9784a Add ExecutableElementImpl.invokesSuperSelf, fix getter / setter matching. 
Bug: https://github.com/dart-lang/sdk/issues/48352
Change-Id: I443df48885eebadbe85d82ff06474aef4db6e422
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/240652
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Phil Quitslund <pquitslund@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2022-04-09 19:12:39 +00:00
Sam Rawlins a1257544e0 analyzer: skip CodeChecker for null safe libraries 
In some profiling, I saw that CodeChecker accounted for ~10% of the time
spent in `LibraryAnalyzer._computeVerifyErrors`.

The only errors which are reported any longer in CodeChecker are
pre-null safe errors, and the TOP_LEVEL_CYCLE error, which is moved to
resolution.

Change-Id: I9ad38a1c76490a95cbb8464465e37a07622b4f97
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/240643
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
 2022-04-08 14:27:48 +00:00
Konstantin Shcheglov 6b6e6da943 Include 'invokesSuperSelf' flag into unlinked API signature. 
We will add this flag as a property of MethodElement. So, it will
affect the semantics, and should be a part of unlinked signature.

Change-Id: If24b09fcd000364a2ddb3737baa69af3d1c6fbd5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/240641
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2022-04-08 05:28:58 +00:00
Ahmed Ashour 452293de33 Hint INVALID_USE_OF_VISIBLE_FOR_OVERRIDING_MEMBER with operators 
Fixes #48729

Change-Id: I6402a8a24419073b0659c7db89d2f1da1d740c87
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/239671
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2022-04-04 16:26:21 +00:00
Ahmed Ashour 28d77be0eb @visibleForOverriding should not hint on calling super. 
Fixes #48626

Change-Id: Ie0b7d1e8f92ab5ecfc03e60635ab89ea4b99f0d3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/239432
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2022-04-01 17:27:55 +00:00
Brian Wilkerson 5a542ce2b1 Enable links to newly published documentation 
Change-Id: Iace45474f783b833d7095d55259a9e285bf554b8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/238460
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2022-03-25 18:18:00 +00:00
Ahmed Ashour 539e14296d FINAL_NOT_INITIALIZED_CONSTRUCTOR not to be reported for static fields. 
Fixes #48180

Change-Id: I3c296fb6e307b5dd6cf0dd53cbc7297a88146e81
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/238358
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2022-03-24 19:12:21 +00:00
Sam Rawlins 434e1b70e8 Add many cases for valid @useResult uses 
All of the changes here should be non-breaking; they should only result
in _fewer_ diagnostics.

New cases of "check the parent": parent is
* BinaryExpression
* ForElement
* IfElement
* IndexedExpression
* PostfixExpression
* SpreadElement

New cases of a "real use": parent is
* AssertInitializer
* AssertStatement
* ConstructorFieldInitializer
* ForEachParts
* ForEachPartsWithDeclaration
* ForLoopParts
* IfStatement
* ThrowExpression
* WhileStatement
* YieldStatement

Bug: https://github.com/dart-lang/sdk/issues/47685
Change-Id: Ib3fa216d45d01a728f73795b32b52f204eb140e5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/238264
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
 2022-03-23 22:54:01 +00:00
Brian Wilkerson a5ca4b57fe Add documentation for the newest diagnostics 
Change-Id: Ia649012c061f5d155d0a045ddb4bf72e61ac0f46
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/238164
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2022-03-23 13:42:20 +00:00
Sam Rawlins ab22a8dd8c Avoid single cascades, unnecessary interpolations, and exposing private types 
* Make `MicroContextObjects` constructor private, which is not used
  outside the library.
* Remove unused `analysisContext2` constructor parameter.
* Make `tryMatchSubtypeOf` private, which requires a parameter of
  private type.
* Make `_FileStateFiles` public, as it is used outside the library.
* Return empty for void-typed functions.

Change-Id: If67a69effdbbaed2eb364788e52eeb60270a0c19
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/237855
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
 2022-03-21 18:12:47 +00:00
Sam Rawlins 843a31fe45 Prefer string interpolations; other small fixes for lints 2.0.0 
Change-Id: Ie66c42ac738adbcf07d0b7c5ccc77e34975008c2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/237801
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Phil Quitslund <pquitslund@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
 2022-03-18 22:13:21 +00:00
Konstantin Shcheglov e253d467ae Fix for reporting UNUSED_ELEMENT_PARAMETER when used via super-formal. 
Change-Id: I334b2b30dd29ae61fb7fbf3bf2af8e68cf969a3b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/237767
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2022-03-18 02:14:38 +00:00
Paul Berry 1ffba32609 Rework type inference logic to avoid redundant constraint gathering. 
Previously, the analyzer would perform downwards and upwards inference
using separate GenericInferrer objects.  This meant that any
constraint gathering work performed during downwards inference had to
be repeated during upwards inference.

This change avoids the extra work by using a single GenericInferrer
object for both downwards and upwards inference.  It also cleans up
the API for GenericInferrer a bit.

Change-Id: Idc5deed96c18ffc89aeb8ba4e5e95942843dae11
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/236660
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
 2022-03-14 15:05:18 +00:00
Konstantin Shcheglov 44806b2e47 Don't report VALUES_DECLARATION_IN_ENUM for static setter. 
See https://github.com/dart-lang/co19/pull/1312

Change-Id: Ie535a826a2997c45344486febbb8cc35a748496c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/236300
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2022-03-09 19:13:34 +00:00
Konstantin Shcheglov ba987d76eb Don't report an error when enum implements Enum. 
Change-Id: I90a872d80d06262bc5f37b872d4eee3b34fed6fc
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/235171
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2022-03-03 21:49:50 +00:00
Danny Tuppeny 1e9fb81697 [analysis_server] Make CompilationUnit.lineInfo non-nullable 
Change-Id: Ib628751a14dc3257cf7325432ab20f2bdb9d6f3b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/234290
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2022-03-03 06:59:00 +00:00
Konstantin Shcheglov 366ad77ee2 Report NON_FINAL_FIELD_IN_ENUM. 
Change-Id: I6b481cd5cd02d4dbfdb213fe25aae0423c1b06ec
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/234913
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2022-03-02 23:52:30 +00:00
Brian Wilkerson b55a29f59c Mark newly published docs as having been published 
Change-Id: I7d51ac0856df22b8c8f5b892118a8804226fedbf
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/234541
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2022-02-28 19:15:47 +00:00
Parker Lougheed edc352030c [pkg/analyzer] Fix some minor diagnostic message issues 
Change-Id: I7eb437eda9eb1683274ba302148759553c68af5d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/234580
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2022-02-27 18:41:33 +00:00
Brian Wilkerson 2f9d45b8bf Add new diagnostic documentation 
This also adds links for some annotation in `meta` that were in existing
tests.

Change-Id: I8260e0d4f40f88228c953ead19b77680c2f69ef4
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/234449
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2022-02-26 21:20:24 +00:00
Konstantin Shcheglov d281ced782 Report FINAL_NOT_INITIALIZED_CONSTRUCTOR errors. 
Change-Id: I1e0d0f503615a9b0fec8f66468e26aaa611c5cca
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/234326
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2022-02-24 21:30:46 +00:00
Konstantin Shcheglov fa3e03c830 Report HintCode.OVERRIDE_ON_NON_OVERRIDING_xyz on enum. 
Bug: https://github.com/dart-lang/linter/issues/3093
Change-Id: Ie59b366250db069f40236491eb705e291b7bb3fe
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/234221
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Phil Quitslund <pquitslund@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2022-02-24 16:21:53 +00:00
Konstantin Shcheglov f21a6d694f Report ENUM_WITH_NAME_VALUES. 
Change-Id: Ie8dabdb7874c9e03ed7d48b7b35bdbc7b93d10c6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/234105
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2022-02-23 19:37:02 +00:00
Konstantin Shcheglov 139c4f83b9 Mark optional enum constructor parameters used when arguments provided. 
Change-Id: Ie771d639e8a0fe199ef4b353cac67be738c714c4
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/234103
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2022-02-23 18:54:23 +00:00
Konstantin Shcheglov be2493449b Report ILLEGAL_CONCRETE_ENUM_MEMBER_INHERITANCE for 'index'. 
Change-Id: I6c7347fcfcac533132030568491c8dfa49f7a18e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/233967
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2022-02-23 17:03:12 +00:00
Konstantin Shcheglov 774cafe41d Don't report unimplemented abstract for 'index' in enum. 
Bug: https://github.com/dart-lang/sdk/issues/48438
Change-Id: I5d6357ce0dcff872a2f4b356359a19554833bf97
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/233968
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2022-02-23 16:42:42 +00:00
Konstantin Shcheglov 15efed584e Tests and fixes for HintCode.UNUSED_ELEMENT and enums. 
Change-Id: I4a516e2fc9c42444e6f85949f1992f9127c95a4c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/233940
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2022-02-23 00:16:42 +00:00
Konstantin Shcheglov 0caead5485 Report ILLEGAL_CONCRETE_ENUM_MEMBER_DECLARATION/INHERITANCE 
Change-Id: I6e0815ddbd3f161fc07c83d6a0c9b7c61b2f9fc2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/233702
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2022-02-22 18:12:31 +00:00
Konstantin Shcheglov 567834e499 Report CONFLICTING_CONSTRUCTOR_AND_STATIC_xyz for enums. 
Change-Id: Iebd399e6cf0de8e8e50b468815557e683086c6ba
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/233762
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2022-02-22 17:15:51 +00:00
Konstantin Shcheglov 0d9f02bf27 Rename to CONCRETE_CLASS_HAS_ENUM_SUPERINTERFACE, report for concrete classes. 
Bug: https://github.com/dart-lang/sdk/issues/48437
Change-Id: Ib5b3ac90c030ea47e33987f7a961432a954807b3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/233701
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2022-02-19 23:01:24 +00:00
Brian Wilkerson 992b9c36b8 Unify two error codes for documentation purposes 
Change-Id: I15919ebfa4f8c79ac9ab846eba708aceb58033ed
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/233683
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2022-02-19 22:27:43 +00:00
Konstantin Shcheglov f784130fea Fix MISSING_REQUIRED_ARGUMENT for super-formal parameters. 
Change-Id: I0ee3114e5d618fa16da42072c8bc15d7b86001c3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/233525
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2022-02-18 17:33:53 +00:00
Konstantin Shcheglov 60b428e2b1 Deprecate superclass2, mixinTypes2, etc. 
Change-Id: Ieaaeab57930cb93f5b6b1323efe63c3395b79993
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/232742
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2022-02-17 02:20:42 +00:00
Konstantin Shcheglov 119eed6f93 Make top-level accessors static. 
Change-Id: I28449a218b7613e920c38de57d7eb6d18f8c6176
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/232231
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2022-02-10 04:21:11 +00:00