577bb2dc7e
Extract shorten() into string utils.
...
R=brianwilkerson@google.com
Bug:
Change-Id: I68d17461b4b5b478df5713cadb120a130f492406
Reviewed-on: https://dart-review.googlesource.com/16602
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2017-10-25 18:54:34 +00:00
4c86f98d7a
Drop the 'Flutter' word from names, expect that clients will use the 'flutter' import prefix.
...
R=brianwilkerson@google.com
Bug:
Change-Id: I0275557bad66f03ed0d1b8388119b168d70bfad4
Reviewed-on: https://dart-review.googlesource.com/16600
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2017-10-25 17:14:01 +00:00
c2f1af6378
First steps for computing Flutter outlines.
...
R=brianwilkerson@google.com , devoncarew@google.com
Bug:
Change-Id: Ib8151df40439a28da536d467a5c0e7354fcfba51
Reviewed-on: https://dart-review.googlesource.com/16338
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2017-10-25 17:00:56 +00:00
82d90f6773
Add tests for isFlutterWidget() and isFlutterWidgetCreation().
...
R=brianwilkerson@google.com , devoncarew@google.com
Bug:
Change-Id: I7946941e458e1ba538921b0e8552dbe555fb0aab
Reviewed-on: https://dart-review.googlesource.com/16303
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2017-10-24 21:26:48 +00:00
a5c2256455
Send test element kinds for test outline items.
...
Bug:
Change-Id: Iebea8d4b9705c726e297722ef1678e1a2cd1ea96
Reviewed-on: https://dart-review.googlesource.com/12841
Commit-Queue: Devon Carew <devoncarew@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2017-10-11 17:00:41 +00:00
e6a34d78f1
Improve the extract method refactoring for flutter build() methods.
...
Bug:
Change-Id: Ic957eede0989b9cd171212425d5da0aad83bc941
Reviewed-on: https://dart-review.googlesource.com/11740
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
2017-10-08 01:41:41 +00:00
fcecf07f92
Make names suggestions for index operator to use only 's' suffix.
...
R=brianwilkerson@google.com
Bug:
Change-Id: I69d60eb23a1100e8776199dfb3082314062e231a
Reviewed-on: https://dart-review.googlesource.com/12220
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2017-10-07 01:40:16 +00:00
31cf7dda06
Do not create parameters for non-final fields
...
Change-Id: Id7d213d3408739301217c1638d050d0b3946fc76
Reviewed-on: https://dart-review.googlesource.com/12100
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
2017-10-06 18:39:11 +00:00
6a19e794b1
Don't create single line closing labels.
...
Bug:
Change-Id: I1ced51a7b5e5aee6db03a77a788c0eeaef101469
Reviewed-on: https://dart-review.googlesource.com/10820
Commit-Queue: Devon Carew <devoncarew@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
2017-10-05 05:23:20 +00:00
082bbdb6a7
Remove flag and enable asserts in initializers by default
...
Change-Id: Ia81f5ec936981dc08ff4c740f3511c6b7c9e6eb6
Reviewed-on: https://dart-review.googlesource.com/10740
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
2017-10-04 18:45:09 +00:00
8ce5c45fff
Fix for copying constructor return types.
...
R=brianwilkerson@google.com
Bug:
Change-Id: Iaa1039b85549fb2daa3d90ea11f4756363c6c358
Reviewed-on: https://dart-review.googlesource.com/10163
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2017-10-02 21:37:47 +00:00
e925eb125c
Fix type code for typedefs after switching to GenericTypeAliasElement.
...
https://dart-review.googlesource.com/c/sdk/+/9421
R=brianwilkerson@google.com , paulberry@google.com
Bug:
Change-Id: I25d60ff904f15e6eeefff97b08ba9870d69733db
Reviewed-on: https://dart-review.googlesource.com/9460
Reviewed-by: Paul Berry <paulberry@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2017-09-29 04:27:53 +00:00
fd4528fffb
Make closing labels slightly less noisy.
...
Bug:
Change-Id: If916adb1cceab14c9260f288bf59878c6955f3ce
Reviewed-on: https://dart-review.googlesource.com/9000
Commit-Queue: Devon Carew <devoncarew@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2017-09-27 18:52:25 +00:00
472f64b005
Check for _serverFuture is null in HttpAnalysisServer.
...
R=brianwilkerson@google.com
Bug:
Change-Id: I54dc00d5a0b29e60a0825e6dcc46daae382ad302
Reviewed-on: https://dart-review.googlesource.com/8243
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2017-09-25 21:08:59 +00:00
bb026e5d29
Fix typing error.
...
Change-Id: Ib10a42863316ce6f15648345cf980236871c2f01
Reviewed-on: https://dart-review.googlesource.com/7361
Reviewed-by: Florian Loitsch <floitsch@google.com >
2017-09-20 16:16:27 +00:00
f6e3e1f549
Add outline support for the test package
...
Change-Id: Iff938d55082b3b222cf801ea53d4eaf5feb1e094
Reviewed-on: https://dart-review.googlesource.com/6980
Reviewed-by: Devon Carew <devoncarew@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2017-09-19 18:59:54 +00:00
c0bf4ab395
Handle recursive import/export graph in completions
...
Change-Id: Ia164c13f3119f569d781292353acc17243c8a464
Reviewed-on: https://dart-review.googlesource.com/7000
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
2017-09-19 18:01:04 +00:00
a715f60d51
Guard against race condition
...
Change-Id: Ie689e8e47559760c5955987005def7aef67e8e09
Reviewed-on: https://dart-review.googlesource.com/6262
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2017-09-15 21:27:40 +00:00
8db9995c65
Fix an exception when a package is not defined
...
Change-Id: Id2469b4e0c4aaa8acb63c0186e7b53ec4acea95d
Reviewed-on: https://dart-review.googlesource.com/5885
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
2017-09-14 19:42:50 +00:00
1b4239d2e4
Export ByteStore and its implementations from front_end.
...
R=ahe@google.com , paulberry@google.com , sigmund@google.com
Bug:
Change-Id: Ie2e3413a7f143e270cec2bd3ae4564ad7cc315b1
Reviewed-on: https://dart-review.googlesource.com/3840
Reviewed-by: Sigmund Cherem <sigmund@google.com >
Reviewed-by: Paul Berry <paulberry@google.com >
2017-09-07 19:23:21 +00:00
455984bbf9
Fix fuzzy arrow warnings in analyzer and analysis_server.
...
There is one warning which I'd like to fix in a separate CL.
The rest is because of package:test predicate().
I think Leaf fixed it in https://github.com/dart-lang/matcher/commit/3625f13698346576da0f5baf44e95abc9c56fb49
R=brianwilkerson@google.com
Bug:
Change-Id: I060f7ced55dbcc460185916251c47ebbd5c838d3
Reviewed-on: https://dart-review.googlesource.com/3404
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2017-09-06 00:26:18 +00:00
28381b8f06
Add completion of keywords in partial field declarations
...
R=danrubel@google.com
Review-Url: https://codereview.chromium.org/3006033002 .
2017-09-03 13:04:06 -07:00
0db33f7053
Add fixes for more lints
...
R=scheglov@google.com
Review-Url: https://codereview.chromium.org/3009063002 .
2017-09-02 15:11:29 -07:00
aab7af12e9
Add fixes for two more lint rules
...
R=scheglov@google.com
Review-Url: https://codereview.chromium.org/3004293002 .
2017-09-02 15:10:56 -07:00
8f1b6d0aab
Dart Kythe indexer refactoring to gather all variable declaration logic into one method
...
R=brianwilkerson@google.com
Review-Url: https://codereview.chromium.org/3004273002 .
2017-09-01 12:12:37 -07:00
59516d9794
Added an analysis server argument to set the location of the session cache. ( #30583 )
2017-08-31 10:25:50 -07:00
170c562ffe
Add fixes for two additional lints
...
R=scheglov@google.com
Review-Url: https://codereview.chromium.org/3007783002 .
2017-08-29 10:18:17 -07:00
96ee1d846d
Add variable declaration support to the DeclaredIdentifier AST node in the Kythe Dart indexer.
...
R=brianwilkerson@google.com
Review-Url: https://codereview.chromium.org/3004763002 .
2017-08-28 10:25:26 -07:00
37042bb59b
Add an integration test for kythe support with bug fixes
...
R=jwren@google.com
Review-Url: https://codereview.chromium.org/3006693002 .
2017-08-28 10:07:04 -07:00
bf259dce6b
Remove unused imports missed in earlier CL
...
R=scheglov@google.com
Review-Url: https://codereview.chromium.org/3010443002 .
2017-08-25 09:22:13 -07:00
c38c97def3
Reduce duplicated code
...
R=scheglov@google.com
Review-Url: https://codereview.chromium.org/3002303002 .
2017-08-25 08:18:39 -07:00
23bcc17a61
Use the NavigationCollector from analyzer_plugin to avoid duplication
...
R=scheglov@google.com
Review-Url: https://codereview.chromium.org/3002253002 .
2017-08-25 07:25:16 -07:00
13346cab3d
Put the analytics UI behind a flag.
...
BUG=
R=brianwilkerson@google.com
Review-Url: https://codereview.chromium.org/3003783002 .
2017-08-24 11:17:37 -07:00
e8b617217f
Remove most of the remaining references to AnalysisContext
...
R=scheglov@google.com
Review-Url: https://codereview.chromium.org/3007493002 .
2017-08-23 12:57:09 -07:00
84a36f1b77
flag to limit file and package URI completion suggestions
...
R=brianwilkerson@google.com
Review-Url: https://codereview.chromium.org/3003233002 .
2017-08-23 13:39:32 -04:00
e4d44b2dcd
Remove more references to the old plugin system
...
R=scheglov@google.com
Review-Url: https://codereview.chromium.org/3004523003 .
2017-08-23 09:25:07 -07:00
b999edf5ee
Remove more references to AnalysisContext
...
R=scheglov@google.com
Review-Url: https://codereview.chromium.org/3003173002 .
2017-08-23 07:53:14 -07:00
b941f148a7
Remove uses of the old plugin model from the analysis server
...
R=scheglov@google.com
Review-Url: https://codereview.chromium.org/3001413002 .
2017-08-23 07:42:13 -07:00
4aeedec64e
Remove the auto-discovery of plugins
...
R=scheglov@google.com
Review-Url: https://codereview.chromium.org/3003663002 .
2017-08-22 09:04:23 -07:00
4076ef910f
Guard the fix code against file system exceptions
...
R=devoncarew@google.com
Review-Url: https://codereview.chromium.org/2997153002 .
2017-08-17 10:41:22 -07:00
8b96449718
Handle watch events that arrive before plugin start-up
...
R=devoncarew@google.com
Review-Url: https://codereview.chromium.org/3001133002 .
2017-08-17 09:57:22 -07:00
6f96d88e1e
Avoid closing an already closed channel
...
R=devoncarew@google.com
Review-Url: https://codereview.chromium.org/2999153002 .
2017-08-17 09:47:33 -07:00
bd8f5ad79f
Guard against getting a watch event before the driver is created
...
R=devoncarew@google.com
Review-Url: https://codereview.chromium.org/3001023002 .
2017-08-16 14:08:44 -07:00
35f6d5da1b
Correctly handle adding imports when pasting into part files
...
R=devoncarew@google.com
Review-Url: https://codereview.chromium.org/3001733002 .
2017-08-16 07:43:36 -07:00
44b5341de8
Update edit.importElements response data to support part files
...
R=devoncarew@google.com
Review-Url: https://codereview.chromium.org/3001723002 .
2017-08-15 08:51:51 -07:00
eaf779ba1e
Fix insertion of imports when there are no existing directives (issue 30430)
...
R=scheglov@google.com
Review-Url: https://codereview.chromium.org/3002643002 .
2017-08-14 13:32:57 -07:00
e42abf621e
Update the version of the server API spec for analysis.closingLabels
...
R=devoncarew@google.com
Review-Url: https://codereview.chromium.org/3002513002 .
2017-08-12 14:44:41 -07:00
8c8969db4c
Forward Kythe requests to plugins and merge in the results
...
R=jwren@google.com
Review-Url: https://codereview.chromium.org/3000823002 .
2017-08-12 08:16:34 -07:00
0647d9a228
Improvements to analysis server closing labels ( #30411 )
...
* Tweak comment that was based on integration test verison.
See #30285
* Include additional 1/2-line spans that end on same lines as >2 line spans.
See #30285
* Add tests to ensure no unwanted closing labels from multiline expressions.
See #30285
* Don't show closing labels for code inside interpolated strings.
See #30285
* Remove unwanted @soloTest.
See #30285
* Make casing of test names consistent.
See #30285
* Add a constructor and make fields final.
See #30285
* Use putIfAbsent for adding to map.
See #30285
* Shorten closing labels constructor.
See #30285
* Run "Sort members" on closing labels files.
See #30285
* Remove unnecessary type annotations.
See #30285
2017-08-11 11:04:34 -07:00
ecc72d6be5
Initial implementation of the kythe domain
...
R=jwren@google.com
Review-Url: https://codereview.chromium.org/2999783002 .
2017-08-10 11:49:22 -07:00
Konstantin Shcheglov