6a4f1b76ac
Remove the --preview-dart-2 option from dartanalyzer and the analysis server.
...
Change-Id: I268b9d5f79b30d0e4a0f8e6bb81a7738c98e5eea
Reviewed-on: https://dart-review.googlesource.com/69802
Commit-Queue: Devon Carew <devoncarew@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2018-08-14 04:24:47 +00:00
4c659e9f83
Have --use-cfe contribute to the driver signature.
...
Change-Id: Ica21f166bde60e41e19c3e6ab49e05a29540b0b0
Reviewed-on: https://dart-review.googlesource.com/69320
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Devon Carew <devoncarew@google.com >
2018-08-10 18:11:41 +00:00
a0b335ac6c
Try no implicit casts in pkg/analyzer_cli.
...
Change-Id: Ied093d1d988e944b497121e654956e93e61ee52d
Reviewed-on: https://dart-review.googlesource.com/69002
Commit-Queue: Devon Carew <devoncarew@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Mike Fairhurst <mfairhurst@google.com >
2018-08-08 22:14:12 +00:00
80e08e0913
Use 'useCFE' flag to turn on CFE in AnalysisDriver.
...
R=brianwilkerson@google.com
Change-Id: If0aa7d10bc46f1dd408d0be8128fc25538758359
Reviewed-on: https://dart-review.googlesource.com/68720
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2018-08-07 16:12:47 +00:00
6e322f794c
No longer run pub list-package-dirs from the analysis server.
...
Change-Id: Id02bdfc25cb8827873ff607f7c4d4a3401c9a199
Reviewed-on: https://dart-review.googlesource.com/67205
Commit-Queue: Devon Carew <devoncarew@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2018-07-27 23:05:41 +00:00
34fea8710c
More cleanup related to strong mode, mostly in the SDK support
...
Change-Id: I1aa0f5169774d53d8ba0902df7880a6462a600bd
Reviewed-on: https://dart-review.googlesource.com/66941
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2018-07-26 16:33:11 +00:00
a456edcb8f
Remove analyzer Dart files from AnalysisDriver.
...
This caused language_2/malformed2_test being flaky.
R=brianwilkerson@google.com
Change-Id: I8bf813e3244e9a76ea2ff72cd9c10b9516596a79
Reviewed-on: https://dart-review.googlesource.com/65980
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2018-07-20 18:47:25 +00:00
64a1f8f69c
Prepare for upcoming void usage semantics
...
Change-Id: I30d92ffb88338036aebed4e6891ce8e5737bf81f
Reviewed-on: https://dart-review.googlesource.com/65322
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Peter von der Ahé <ahe@google.com >
2018-07-17 15:36:38 +00:00
ab1c1582b1
Remove deprecation hints in analyzer packages
...
Change-Id: I001e57239a87f2806be74052a5e7686245fea812
Reviewed-on: https://dart-review.googlesource.com/65000
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Devon Carew <devoncarew@google.com >
2018-07-17 15:22:07 +00:00
3ad109038e
Fix a runtime type issue in the dartanalyzer cli.
...
Change-Id: I5457ac82bb836fe36b3e8765e9fde690e2b324a2
Reviewed-on: https://dart-review.googlesource.com/64648
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Devon Carew <devoncarew@google.com >
2018-07-11 22:57:03 +00:00
96b840dcd2
Fix an npe in the analyzer cli when used with --no-hints.
...
Bug: https://github.com/dart-lang/sdk/issues/33821
Change-Id: I4fd08134a86ed3d6eb599bd17e5e4bfa19cc900d
Reviewed-on: https://dart-review.googlesource.com/64642
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Devon Carew <devoncarew@google.com >
2018-07-11 19:52:53 +00:00
2dd33c2a6c
Have the package:analyzer strong mode option hard coded to on. Delete several spec mode only tests.
...
Change-Id: I5dffec68d9845fe75936d55100c03306b6eda363
Reviewed-on: https://dart-review.googlesource.com/64060
Commit-Queue: Devon Carew <devoncarew@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
2018-07-10 05:30:10 +00:00
d6cf9b471e
Deprecate and remove the implementation of an older flag.
...
Change-Id: I650f5c7cc14c53b1109b8555a7e68544266ad65a
Reviewed-on: https://dart-review.googlesource.com/63860
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: William Hesse <whesse@google.com >
Commit-Queue: Devon Carew <devoncarew@google.com >
2018-07-05 18:30:18 +00:00
e8ff3d596f
Deprecate and ignore the --strong flag on dartanalyzer.
...
Change-Id: Icb5adae9a628b96394a4249d6326c24acc40a8fc
Reviewed-on: https://dart-review.googlesource.com/63700
Commit-Queue: Devon Carew <devoncarew@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
2018-07-05 06:20:48 +00:00
c19233dcce
Plumb in more of the analytics impl into the analysis server; allow clients to enble analytics.
...
Change-Id: Id546ce60e3ec49d37d6c5545f98a46bff009e6c1
Reviewed-on: https://dart-review.googlesource.com/62701
Commit-Queue: Devon Carew <devoncarew@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2018-06-28 16:28:25 +00:00
de5f9ea95f
Add --use-fasta-parser flags to dartanalyzer and the analysis server.
...
Change-Id: Id7272c0d86806f2cbdfc982ee90923b018e08866
Reviewed-on: https://dart-review.googlesource.com/60453
Commit-Queue: Devon Carew <devoncarew@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Dan Rubel <danrubel@google.com >
2018-06-16 13:21:24 +00:00
f6d2c2378a
Add awaits in async methods to restore previous semantics
...
Change-Id: I7711cd878a31df0fb0c92572e2256c0a26923640
Reviewed-on: https://dart-review.googlesource.com/59480
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Paul Berry <paulberry@google.com >
2018-06-08 19:58:07 +00:00
8e59876cca
Issue 33381. Make input paths in analyzer_cli absolute and normalized.
...
R=brianwilkerson@google.com
Bug: https://github.com/dart-lang/sdk/issues/33381
Change-Id: I27e710859fdf2ab8e9380b232739def5acdf561d
Reviewed-on: https://dart-review.googlesource.com/59101
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2018-06-07 18:48:18 +00:00
36e73371fb
Switch analyzer_cli to using AnalysisDriver only.
...
R=brianwilkerson@google.com , devoncarew@google.com
Change-Id: Ibb97bf4843636655e646ee994532ec7e74c43b62
Reviewed-on: https://dart-review.googlesource.com/58622
Reviewed-by: Devon Carew <devoncarew@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2018-06-06 15:47:03 +00:00
a6ad152315
Fix constant-related deprecation warnings in analyzer packages
...
Change-Id: I6e4186d2a877275db2f04881a6aa6d154d4f8693
Reviewed-on: https://dart-review.googlesource.com/55820
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2018-05-17 21:24:38 +00:00
1afe71c08a
Enable preview-dart-2 as default for analyzer.
...
Based on https://dart-review.googlesource.com/c/sdk/+/52340 , but adds
the necessary plumbing through the test system to pass through
negations to strong and preview-dart-2. Also adds support for those
negations to the analyzer.
Change-Id: I9793ff28bb593d25bbb0a2ed8736b5b53e0a62d8
Reviewed-on: https://dart-review.googlesource.com/52461
Commit-Queue: Janice Collins <jcollins@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2018-04-26 17:01:12 +00:00
7054d92a02
Remove some classes from the analyzer public API
...
Change-Id: Ic53a8426818b06f44c2876abd16c789589bf78b5
Reviewed-on: https://dart-review.googlesource.com/52421
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2018-04-24 15:28:15 +00:00
b936ffb329
Move several libraries out of the public API
...
Change-Id: I8259de00134310f25b1c6168940aea5190488999
Reviewed-on: https://dart-review.googlesource.com/51443
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
2018-04-17 17:35:27 +00:00
dd897d35a2
Move the task API out of the public API
...
Change-Id: I0fbafb4965ced89fb9a063edb773c3f1cb3a39fa
Reviewed-on: https://dart-review.googlesource.com/51242
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
2018-04-16 18:18:08 +00:00
c214c43758
Make LineInfo a public class
...
Change-Id: I1bc7f5302797374609752ea5293b96c30719b41f
Reviewed-on: https://dart-review.googlesource.com/51101
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2018-04-13 16:23:47 +00:00
98671b2659
Make DeclaredVariables immutable
...
Change-Id: I3d0233cfb4002140af7cf0166cd98466d73d630c
Reviewed-on: https://dart-review.googlesource.com/50580
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2018-04-11 01:58:51 +00:00
07a05906c5
Remove an unused flag from dartanalyzer.
...
Change-Id: I4250f4accd98fe83a81d9845f09653bf860024a7
Reviewed-on: https://dart-review.googlesource.com/49980
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
2018-04-07 02:51:14 +00:00
7470f410dd
Clean up documentation of command-line analyzer options
...
Change-Id: If37cfbd7f1187229ab90205e59a7eb60d3b884cf
Reviewed-on: https://dart-review.googlesource.com/48701
Reviewed-by: Devon Carew <devoncarew@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2018-03-28 21:15:58 +00:00
26c06cdd82
Clean up Dart 2 type issues related to YAML support
...
Change-Id: Ic29054afca9773286aa899eecede287f7ecbca9a
Reviewed-on: https://dart-review.googlesource.com/47680
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2018-03-22 17:06:40 +00:00
1d184ace7b
Fixes for packages:args deprecated uses.
...
Mostly addOption() -> addMultiOption().
Change-Id: Iab40059aab45a371e0def89fbdfcd08bd1487d47
Reviewed-on: https://dart-review.googlesource.com/47121
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2018-03-19 20:15:37 +00:00
5bc6d66bd9
fix a few --preview-dart-2 issues
...
Change-Id: Ib4bd63b826d8957cdd2db97e1d5311f52bcdf921
Reviewed-on: https://dart-review.googlesource.com/46304
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Devon Carew <devoncarew@google.com >
2018-03-13 17:46:09 +00:00
80a571d546
Take the --preview-dart-2 defaults from the context and options classes, not the cli tool defaults.
...
Also, allow --no-preview-dart-2 from dartanalyzer.
Change-Id: Ic304a29e640bbddb50892c28712a131a2b306930
Reviewed-on: https://dart-review.googlesource.com/45881
Commit-Queue: Devon Carew <devoncarew@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2018-03-09 22:30:24 +00:00
602a8c2a7b
Clean up usage of deprecated constants
...
Change-Id: I9005ba6e94529e15d8f7b21322591f4a9dabec47
Reviewed-on: https://dart-review.googlesource.com/45763
Commit-Queue: William Hesse <whesse@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
2018-03-09 01:02:49 +00:00
748cfdff7e
Refactor to efficiently find analysis roots correctly fix #31343 & #31344 .
...
Move logic out into a ContextCache since we're not interested in caching
at least two if not three things (the options, the options path, and
optionally the builder).
Move some convenience methods around accessing contexts into a mixin.
Regarding some semantic decisions for finding analysis roots:
* treat the analysis_options.yaml file as the analysis root if it exists
* if it doesn't exist, assume the directory passed in is the root
* if custom options are provided, assume they "overwrite" the others
_in-place_.
Tests to confirm this logic via excludes configurations with & without
the yaml file specified, passing in the root in some cases and
subdirectories in others.
Also change to use PathFinder for handling wildcards in excludes.
Bug: 31343,31344
Change-Id: I400fe30a1ec379f9040f812fc0bd9481d42a13cf
Reviewed-on: https://dart-review.googlesource.com/41570
Commit-Queue: Mike Fairhurst <mfairhurst@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2018-03-05 23:51:00 +00:00
13ccc0d49e
Reland https://dart-review.googlesource.com/c/sdk/+/42540
...
In CLI no batch, support analyzing multiple files in multiple contexts
Support `dartanalyzer pkg/a/foo pkg/b/foo` and use a different context
for each.
Requires knowing the source being analyzed while creating a context,
which gets a bit hacky with build mode, but seems to work as is.
Suggestions on a cleaner integration there are welcome!
Change-Id: I2648fdb80c0a36a05580ef7267350ffb847c43e9
Reviewed-on: https://dart-review.googlesource.com/42582
Commit-Queue: Mike Fairhurst <mfairhurst@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2018-02-22 17:29:06 +00:00
4d88a243bd
Revert "In CLI no batch, support analyzing multiple files in multiple contexts"
...
This reverts commit 126bfebb4ehttps://dart-review.googlesource.com/41900
> Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
> Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
TBR=scheglov@google.com ,brianwilkerson@google.com ,mfairhurst@google.com
Change-Id: I0e90d8d4e2256b7087daeeb934ed14da57fd20df
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://dart-review.googlesource.com/42540
Reviewed-by: Mike Fairhurst <mfairhurst@google.com >
Commit-Queue: Mike Fairhurst <mfairhurst@google.com >
2018-02-20 23:08:41 +00:00
126bfebb4e
In CLI no batch, support analyzing multiple files in multiple contexts
...
Support `dartanalyzer pkg/a/foo pkg/b/foo` and use a different context
for each.
Requires knowing the source being analyzed while creating a context,
which gets a bit hacky with build mode, but seems to work as is.
Suggestions on a cleaner integration there are welcome!
Change-Id: Ia4e63fe01342f2299c96ca8d34ca983a9280a911
Reviewed-on: https://dart-review.googlesource.com/41900
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2018-02-20 22:37:45 +00:00
f5942a5ce0
Add support for analyzing analysis options and pubspec files
...
Change-Id: I2aa05e5822b2993d0f1e903396c816b52e2292b4
Reviewed-on: https://dart-review.googlesource.com/41566
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2018-02-14 22:50:05 +00:00
421db9c69c
Re-land "Implement proper checking for callability of Function class."
...
(was reverted in https://dart-review.googlesource.com/c/sdk/+/40980
due to an analyzer bot breakage)
Original commit message:
Implement proper checking for callability of Function class.
There was some old (incorrect) logic for doing this, behind the flag
enableStrictCallChecks. This flag has been removed, since the new
behavior is now standard in Dart 2.0.
Fixes #31509
Change-Id: Ice5cf38bbc648badf7f2563ff930b69f9a799635
Reviewed-on: https://dart-review.googlesource.com/41120
Reviewed-by: Jonas Termansen <sortie@google.com >
Commit-Queue: Paul Berry <paulberry@google.com >
2018-02-14 11:30:23 +00:00
35aea15097
Revert "Implement proper checking for callability of Function class."
...
This reverts commit 6837dafcc3Fixes #31509
>
> Change-Id: I4a6da34a4b85ea8409f6e0d14c377a586546056a
> Reviewed-on: https://dart-review.googlesource.com/40509
> Commit-Queue: Paul Berry <paulberry@google.com >
> Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
> Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
> Reviewed-by: Mike Fairhurst <mfairhurst@google.com >
TBR=paulberry@google.com ,scheglov@google.com ,brianwilkerson@google.com ,mfairhurst@google.com
Change-Id: Ib631ad16bc5e937ff914127d1c5330f3fcaff2c9
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://dart-review.googlesource.com/40980
Reviewed-by: Paul Berry <paulberry@google.com >
Commit-Queue: Paul Berry <paulberry@google.com >
2018-02-13 19:56:35 +00:00
6837dafcc3
Implement proper checking for callability of Function class.
...
There was some old (incorrect) logic for doing this, behind the flag
enableStrictCallChecks. This flag has been removed, since the new
behavior is now standard in Dart 2.0.
Fixes #31509
Change-Id: I4a6da34a4b85ea8409f6e0d14c377a586546056a
Reviewed-on: https://dart-review.googlesource.com/40509
Commit-Queue: Paul Berry <paulberry@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Mike Fairhurst <mfairhurst@google.com >
2018-02-13 14:19:08 +00:00
95c2bb7c2c
Fix parts analysis in build mode without building summaries.
...
R=brianwilkerson@google.com
Change-Id: I67e33b0d5d403402ce7954106081e57fee3ef9ce
Reviewed-on: https://dart-review.googlesource.com/38781
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2018-02-05 18:50:26 +00:00
8b9e1bda84
Copy the CLI flag into the AnalysisOptions file
...
Change-Id: I0c5da5f884ed1343f2dbb999fed136f49bd55103
Reviewed-on: https://dart-review.googlesource.com/37649
Reviewed-by: Jaime Wren <jwren@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Jaime Wren <jwren@google.com >
2018-01-31 17:26:55 +00:00
cd878bc433
Create the new flag --use-cfe in the analyzer, analysis server and analyzer_cli and migrate the old behavior of --preview-dart-2 to --use-cfe. The --preview-dart-2 flag is now a no-op, with functionality coming soon.
...
See https://github.com/dart-lang/sdk/issues/31640
Change-Id: I2db2e7ef6a324cbd5d369b807e331495fed167df
Reviewed-on: https://dart-review.googlesource.com/33121
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Jaime Wren <jwren@google.com >
2018-01-08 22:37:05 +00:00
3bca5b6a1d
Duplicate some analyzer cli tests to also run in --preview-dart-2.
...
Bug:
Change-Id: Ic2b96434e58a7d3eff3ff9aef1bcb540d8f4f0ce
Reviewed-on: https://dart-review.googlesource.com/29623
Reviewed-by: Phil Quitslund <pquitslund@google.com >
Commit-Queue: Devon Carew <devoncarew@google.com >
2017-12-14 22:18:35 +00:00
22d0696d91
[CFE] Move front-end API under src/
...
This CL deprecates the front-end API and moves it into src/api_prototype.
For now all usages have been updated to point to the new location,
but they should be updated to use custom-client invocations instead (e.g.
one specific way for DDC, another for dart2js etc.)
Bug:
Change-Id: I9b4f41f6ebf55d42510fd35240d942d1dc7292d6
Reviewed-on: https://dart-review.googlesource.com/24822
Commit-Queue: Jens Johansen <jensj@google.com >
Reviewed-by: Kevin Millikin <kmillikin@google.com >
2017-12-01 08:42:16 +00:00
5ea30b4e3d
Rename performace_logger.dart to performance_logger.dart
...
R=paulberry@google.com , sigmund@google.com
Bug:
Change-Id: Ib7b6d122dff3ddabde3db2270daa777a269e04ed
Reviewed-on: https://dart-review.googlesource.com/18512
Reviewed-by: Sigmund Cherem <sigmund@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2017-11-03 20:24:00 +00:00
ffadd1ed3d
When running analyzer_cli with --preview-dart-2, load SDK from vm_outline.dill.
...
We need this to be able to access classes that are required by Fasta,
but come from VM patches.
R=brianwilkerson@google.com , paulberry@google.com
Bug:
Change-Id: I4d29e1dca42e016446516a2dab0fae138cb74548
Reviewed-on: https://dart-review.googlesource.com/16863
Reviewed-by: Paul Berry <paulberry@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2017-10-26 23:34:18 +00:00
aab22a8f9b
When analyzer_cli is given --preview-dart-2, use KernelDriver.
...
R=brianwilkerson@google.com , paulberry@google.com
Bug:
Change-Id: Ibde08b9732c3e750cf78bd0af48cfa3ef17fa4a4
Reviewed-on: https://dart-review.googlesource.com/14881
Reviewed-by: Paul Berry <paulberry@google.com >
2017-10-18 19:35:41 +00:00
0dbc39cb5f
Revert "When analyzer_cli is given --preview-dart-2, use KernelDriver."
...
This reverts commit 7d28e6fc21brianwilkerson@google.com , paulberry@google.com
>
> Bug:
> Change-Id: I91484f906a691fba80917f8fd8ec1c0628c0815f
> Reviewed-on: https://dart-review.googlesource.com/14505
> Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
> Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
TBR=paulberry@google.com ,scheglov@google.com ,brianwilkerson@google.com
Change-Id: Ib440303cd82d6ebb14ef7d14efdb6b535cc0bf88
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://dart-review.googlesource.com/14580
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2017-10-17 19:06:11 +00:00
Devon Carew